141307 2015-02-05 14:46:45 -0800 [iOS] Remove False Positive dispatch_source Leak in WebMemoryPressureHandler singleton 2015-02-05 15:47:45 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck andersca commit-queue thorton oldest_to_newest 1067224 0 joepeck 2015-02-05 14:46:45 -0800 * SUMMARY Remove False Positive OS_dispatch_source Leak in WebMemoryPressureHandler singleton. I think we actually want to always keep this dispatch_source around. So we should just add a reference to it in WebMemoryPressureHandler. * LEAK OUTPUT Leak: 0x1657a1f0 size=112 zone: DefaultMallocZone_0x197e000 OS_dispatch_source ObjC libdispatch.dylib Call stack: [thread 0x3676a9d0]: | start | 0x4c0e1 | UIApplicationMain | -[UIApplication _run] ... | -[WKProcessPool(WKPrivate) _initWithConfiguration:] | WebKit::WebProcessPool::WebProcessPool(API::ProcessPoolConfiguration&) | WebKit::WebMemoryPressureHandler::shared() | WebKit::WebMemoryPressureHandler::WebMemoryPressureHandler() | dispatch_source_create | _os_object_alloc_realized | class_createInstance | calloc | malloc_zone_calloc 1067225 1 246132 joepeck 2015-02-05 14:47:38 -0800 Created attachment 246132 [PATCH] Proposed Fix 1067238 2 246132 commit-queue 2015-02-05 15:47:41 -0800 Comment on attachment 246132 [PATCH] Proposed Fix Clearing flags on attachment: 246132 Committed r179720: <http://trac.webkit.org/changeset/179720> 1067239 3 commit-queue 2015-02-05 15:47:45 -0800 All reviewed patches have been landed. Closing bug. 246132 2015-02-05 14:47:38 -0800 2015-02-05 15:47:41 -0800 [PATCH] Proposed Fix leak.patch text/plain 2666 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhNDkzNjRkLi5jZDlkOWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTUtMDItMDUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbaU9TXSBSZW1vdmUgRmFsc2UgUG9zaXRpdmUgZGlzcGF0Y2hfc291cmNlIExlYWsg aW4gV2ViTWVtb3J5UHJlc3N1cmVIYW5kbGVyIHNpbmdsZXRvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMzA3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dlYk1lbW9yeVBy ZXNzdXJlSGFuZGxlcklPUy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV2ViTWVtb3J5UHJl c3N1cmVIYW5kbGVySU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJNZW1vcnlQcmVzc3VyZUhh bmRsZXI6OldlYk1lbW9yeVByZXNzdXJlSGFuZGxlcik6CisgICAgICAgIFdlIHdhbnQgdG8ga2Vl cCB0aGUgZGlzcGF0Y2hfc291cmNlIGFyb3VuZCwgc28ganVzdCB0aWUgaXQgdG8gdGhlCisgICAg ICAgIHNpbmdsZXRvbiBzbyB0aGF0IGl0IGlzIG5vdCByZXBvcnRlZCBhcyBhIGxlYWsuCisKIDIw MTUtMDItMDQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgW2lPUyBXSzJdIExheWVycyB0aGF0IGFyZSBjcmVhdGVkIGFuZCBkZXN0cm95ZWQgaW4gdGhl IHNhbWUgdHJhbnNhY3Rpb24gc2hvdWxkbid0IGJlIGVuY29kZWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViTWVtb3J5UHJlc3N1cmVIYW5kbGVySU9TLmggYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYk1lbW9yeVByZXNzdXJlSGFuZGxlcklPUy5o CmluZGV4IDdjMzRjMzEuLjdmMGUyODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9pb3MvV2ViTWVtb3J5UHJlc3N1cmVIYW5kbGVySU9TLmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XZWJNZW1vcnlQcmVzc3VyZUhhbmRsZXJJT1MuaApAQCAtMjgsNyAr MjgsOCBAQAogCiAjaWYgUExBVEZPUk0oSU9TKQogCi0jaW5jbHVkZSA8d3RmL05ldmVyRGVzdHJv eWVkLmg+CisjaW1wb3J0IDxkaXNwYXRjaC9kaXNwYXRjaC5oPgorI2ltcG9ydCA8d3RmL05ldmVy RGVzdHJveWVkLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCkBAIC0zOSw2ICs0MCw3IEBAIHB1 YmxpYzoKIAogcHJpdmF0ZToKICAgICBXZWJNZW1vcnlQcmVzc3VyZUhhbmRsZXIoKTsKKyAgICBk aXNwYXRjaF9zb3VyY2VfdCBfc291cmNlOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYk1lbW9yeVByZXNzdXJl SGFuZGxlcklPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViTWVtb3J5UHJl c3N1cmVIYW5kbGVySU9TLm1tCmluZGV4IDFiYjVkM2EuLmQwMzllYTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViTWVtb3J5UHJlc3N1cmVIYW5kbGVySU9TLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViTWVtb3J5UHJlc3N1cmVIYW5k bGVySU9TLm1tCkBAIC00NSwxMiArNDUsMTIgQEAgV2ViTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpX ZWJNZW1vcnlQcmVzc3VyZUhhbmRsZXIoKQogICAgIC8vIFJpZ2h0IG5vdyBpdCBjYW5ub3QgYmVj YXVzZSBXZWJLaXQxIGFuZCBXZWJLaXQyIG5lZWQgdG8gYmUgYWJsZSB0byBjb2V4aXN0IGluIHRo ZSBVSSBwcm9jZXNzLAogICAgIC8vIGFuZCB5b3UgY2FuIG9ubHkgaGF2ZSBvbmUgV2ViQ29yZTo6 TWVtb3J5UHJlc3N1cmVIYW5kbGVyLgogCi0gICAgZGlzcGF0Y2hfc291cmNlX3Qgc291cmNlID0g ZGlzcGF0Y2hfc291cmNlX2NyZWF0ZShESVNQQVRDSF9TT1VSQ0VfVFlQRV9NRU1PUllTVEFUVVMs IDAsIERJU1BBVENIX01FTU9SWVNUQVRVU19QUkVTU1VSRV9XQVJOLCBkaXNwYXRjaF9nZXRfbWFp bl9xdWV1ZSgpKTsKLSAgICBkaXNwYXRjaF9zZXRfY29udGV4dChzb3VyY2UsIHRoaXMpOwotICAg IGRpc3BhdGNoX3NvdXJjZV9zZXRfZXZlbnRfaGFuZGxlcihzb3VyY2UsIF57CisgICAgX3NvdXJj ZSA9IGRpc3BhdGNoX3NvdXJjZV9jcmVhdGUoRElTUEFUQ0hfU09VUkNFX1RZUEVfTUVNT1JZU1RB VFVTLCAwLCBESVNQQVRDSF9NRU1PUllTVEFUVVNfUFJFU1NVUkVfV0FSTiwgZGlzcGF0Y2hfZ2V0 X21haW5fcXVldWUoKSk7CisgICAgZGlzcGF0Y2hfc2V0X2NvbnRleHQoX3NvdXJjZSwgdGhpcyk7 CisgICAgZGlzcGF0Y2hfc291cmNlX3NldF9ldmVudF9oYW5kbGVyKF9zb3VyY2UsIF57CiAgICAg ICAgIFZpZXdTbmFwc2hvdFN0b3JlOjpzaW5nbGV0b24oKS5kaXNjYXJkU25hcHNob3RJbWFnZXMo KTsKICAgICB9KTsKLSAgICBkaXNwYXRjaF9yZXN1bWUoc291cmNlKTsKKyAgICBkaXNwYXRjaF9y ZXN1bWUoX3NvdXJjZSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=