141304 2015-02-05 13:58:17 -0800 [WK2] Properly check for mmap() error case 2015-02-05 14:13:14 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez andersca benjamin kling koivisto sam oldest_to_newest 1067208 0 cdumez 2015-02-05 13:58:17 -0800 mmap() returns MAP_FAILED, which is (void*)-1, not a null pointer in case of failure. 1067209 1 246128 cdumez 2015-02-05 14:03:18 -0800 Created attachment 246128 Patch 1067210 2 cdumez 2015-02-05 14:13:14 -0800 Committed r179707: <http://trac.webkit.org/changeset/179707> 246128 2015-02-05 14:03:18 -0800 2015-02-05 14:10:18 -0800 Patch bug-141304-20150205140317.patch text/plain 3881 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzFkNmViN2UxZGM0MGE0 ZTg0YjJkN2U2MjcwMDFlNjkyZjQzODFkMS4uMDBkZTkxNjA0NGNhNGIwZmI2NmQ4YjcyOGE3YmFm NDJlZmU3NTZiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTAyLTA1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gUHJvcGVybHkgY2hl Y2sgZm9yIG1tYXAoKSBlcnJvciBjYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDEzMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBtbWFwKCkgcmV0dXJucyBNQVBfRkFJTEVELCB3aGljaCBpcyAodm9p ZCopLTEsIG5vdCBhIG51bGwgcG9pbnRlciBpbgorICAgICAgICBjYXNlIG9mIGZhaWx1cmUuIFRo aXMgcGF0Y2ggdXBkYXRlcyBzZXZlcmFsIHdyb25nIGVycm9yIGNoZWNrcyBpbgorICAgICAgICBX ZWJLaXQyLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3Rv cmFnZUNvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpkZWNvZGVFbnRyeSk6CisgICAgICAgICog UGxhdGZvcm0vSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHA6CisgICAgICAgIChJUEM6OmFsbG9jQnVm ZmVyKToKKyAgICAgICAgKElQQzo6QXJndW1lbnRFbmNvZGVyOjpyZXNlcnZlKToKKyAgICAgICAg KiBQbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW06CisgICAgICAgIChJUEM6OkNvbm5l Y3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2UpOgorCiAyMDE1LTAyLTA0ICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBBdm9pZCBjb3B5aW5nIHN0ZDo6ZnVuY3Rp b25zIGFjcm9zcyB0aHJlYWRzIGluIE5ldHdvcmtDYWNoZVN0b3JhZ2UKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2VDb2Nv YS5tbSBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0 b3JhZ2VDb2NvYS5tbQppbmRleCAyZTQ0NDYxNmQyYzZkOThmN2VjNWU2NDFlNTM2OTQxMTY0MTMw YjQ0Li40NGE0MjEwODQ1NzBhMDFjNGUwZmI5YjBmMDVmYzE0Yjg2NjVmNDYwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdl Q29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29y a0NhY2hlU3RvcmFnZUNvY29hLm1tCkBAIC0yNzEsNyArMjcxLDcgQEAgc3RhdGljIHN0ZDo6dW5p cXVlX3B0cjxOZXR3b3JrQ2FjaGVTdG9yYWdlOjpFbnRyeT4gZGVjb2RlRW50cnkoZGlzcGF0Y2hf ZGF0YV90IGYKICAgICB9CiAgICAgc2l6ZV90IG1hcFNpemUgPSBtZXRhRGF0YS5ib2R5U2l6ZTsK ICAgICB2b2lkKiBtYXAgPSBtbWFwKG51bGxwdHIsIG1hcFNpemUsIFBST1RfUkVBRCwgTUFQX1BS SVZBVEUsIGZkLCBtZXRhRGF0YS5ib2R5T2Zmc2V0KTsKLSAgICBpZiAoIW1hcCkgeworICAgIGlm IChtYXAgPT0gTUFQX0ZBSUxFRCkgewogICAgICAgICBMT0coTmV0d29ya0NhY2hlU3RvcmFnZSwg IihOZXR3b3JrUHJvY2VzcykgbWFwIGZhaWxlZCIpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsK ICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQXJndW1lbnRF bmNvZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Bcmd1bWVudEVuY29kZXIu Y3BwCmluZGV4IGM3MWUxYTE0YjRmMTcxOWY2NDQ5OWNjMjgwMTZmYjVjZGUyMzE1YzEuLmQ1NWY3 NDJiOTVkMmExZmUyN2I5MDNjMjRjMTc3NzgwYTQwZjQxNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL0lQQy9Bcmd1bWVudEVuY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtL0lQQy9Bcmd1bWVudEVuY29kZXIuY3BwCkBAIC0zNiwxMiArMzYsMTUgQEAK IAogbmFtZXNwYWNlIElQQyB7CiAKLXN0YXRpYyBpbmxpbmUgdm9pZCogYWxsb2NCdWZmZXIoc2l6 ZV90IHNpemUpCit0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KK3N0YXRpYyBpbmxpbmUgYm9vbCBhbGxv Y0J1ZmZlcihUKiYgYnVmZmVyLCBzaXplX3Qgc2l6ZSkKIHsKICNpZiBPUyhEQVJXSU4pCi0gICAg cmV0dXJuIG1tYXAoMCwgc2l6ZSwgUFJPVF9SRUFEIHwgUFJPVF9XUklURSwgTUFQX0FOT04gfCBN QVBfUFJJVkFURSwgLTEsIDApOworICAgIGJ1ZmZlciA9IHN0YXRpY19jYXN0PFQqPihtbWFwKDAs IHNpemUsIFBST1RfUkVBRCB8IFBST1RfV1JJVEUsIE1BUF9BTk9OIHwgTUFQX1BSSVZBVEUsIC0x LCAwKSk7CisgICAgcmV0dXJuIGJ1ZmZlciAhPSBNQVBfRkFJTEVEOwogI2Vsc2UKLSAgICByZXR1 cm4gZmFzdE1hbGxvYyhzaXplKTsKKyAgICBidWZmZXIgPSBzdGF0aWNfY2FzdDxUKj4oZmFzdE1h bGxvYyhzaXplKSk7CisgICAgcmV0dXJuICEhYnVmZmVyOwogI2VuZGlmCiB9CiAKQEAgLTkwLDgg KzkzLDggQEAgdm9pZCBBcmd1bWVudEVuY29kZXI6OnJlc2VydmUoc2l6ZV90IHNpemUpCiAgICAg d2hpbGUgKG5ld0NhcGFjaXR5IDwgc2l6ZSkKICAgICAgICAgbmV3Q2FwYWNpdHkgKj0gMjsKIAot ICAgIHVpbnQ4X3QqIG5ld0J1ZmZlciA9IHN0YXRpY19jYXN0PHVpbnQ4X3QqPihhbGxvY0J1ZmZl cihuZXdDYXBhY2l0eSkpOwotICAgIGlmICghbmV3QnVmZmVyKQorICAgIHVpbnQ4X3QqIG5ld0J1 ZmZlcjsKKyAgICBpZiAoIWFsbG9jQnVmZmVyKG5ld0J1ZmZlciwgbmV3Q2FwYWNpdHkpKQogICAg ICAgICBDUkFTSCgpOwogCiAgICAgbWVtY3B5KG5ld0J1ZmZlciwgbV9idWZmZXIsIG1fYnVmZmVy U2l6ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5l Y3Rpb25NYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25N YWMubW0KaW5kZXggMWNlMzEyMDY1OWE5MTQwY2RiMTIyZmUwZjkyZDk5NWNjODQ5NTU2Yy4uNWVk OTY5YzBiMDIyMzkwMjY5Mjg4ODY1MTdjOWMzNTc1NTA5OTkyYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlvbk1hYy5tbQpAQCAtMjgzLDggKzI4Mywx MSBAQCBib29sIENvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRy PE1lc3NhZ2VFbmNvZGVyPiBlbmNvZGVyKQogCiAgICAgY2hhciBzdGFja0J1ZmZlcltpbmxpbmVN ZXNzYWdlTWF4U2l6ZV07CiAgICAgY2hhciogYnVmZmVyID0gJnN0YWNrQnVmZmVyWzBdOwotICAg IGlmIChtZXNzYWdlU2l6ZSA+IGlubGluZU1lc3NhZ2VNYXhTaXplKQorICAgIGlmIChtZXNzYWdl U2l6ZSA+IGlubGluZU1lc3NhZ2VNYXhTaXplKSB7CiAgICAgICAgIGJ1ZmZlciA9IChjaGFyKilt bWFwKDAsIG1lc3NhZ2VTaXplLCBQUk9UX1JFQUQgfCBQUk9UX1dSSVRFLCBNQVBfQU5PTiB8IE1B UF9QUklWQVRFLCAtMSwgMCk7CisgICAgICAgIGlmIChidWZmZXIgPT0gTUFQX0ZBSUxFRCkKKyAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAKICAgICBib29sIGlzQ29tcGxleCA9IChu dW1iZXJPZlBvcnREZXNjcmlwdG9ycyArIG51bWJlck9mT09MTWVtb3J5RGVzY3JpcHRvcnMgPiAw KTsKIAo=