141297 2015-02-05 11:21:31 -0800 [WK2][Cocoa] Populate m_contentsFilter bloom filter from the main dispatch queue NetworkCacheStorage::initialize() 2015-02-05 13:48:28 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez barraclough commit-queue kling koivisto oldest_to_newest 1067149 0 cdumez 2015-02-05 11:21:31 -0800 Populate m_contentsFilter bloom filter from the main dispatch queue NetworkCacheStorage::initialize() to avoid thread-safety issues. 1067151 1 246116 cdumez 2015-02-05 11:25:51 -0800 Created attachment 246116 Patch 1067185 2 246116 koivisto 2015-02-05 13:05:43 -0800 Comment on attachment 246116 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246116&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:142 > + dispatch_async(dispatch_get_main_queue(), [this, hash] { > + m_contentsFilter.add(hash); > + }); This gets called a lot so dispatching every item individually is not very optimal. But we can do better later if needed. 1067201 3 246116 commit-queue 2015-02-05 13:48:22 -0800 Comment on attachment 246116 Patch Clearing flags on attachment: 246116 Committed r179704: <http://trac.webkit.org/changeset/179704> 1067202 4 commit-queue 2015-02-05 13:48:28 -0800 All reviewed patches have been landed. Closing bug. 246116 2015-02-05 11:25:51 -0800 2015-02-05 13:48:22 -0800 Patch bug-141297-20150205112550.patch text/plain 2376 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5Njk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzFkNmViN2UxZGM0MGE0 ZTg0YjJkN2U2MjcwMDFlNjkyZjQzODFkMS4uZmQ1MzRjYTdhNGRmMDIyNDM5MGRlYTdhMDMwY2Rj MmNkOTJjMjQ0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAyLTA1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1bQ29jb2FdIFBvcHVs YXRlIG1fY29udGVudHNGaWx0ZXIgYmxvb20gZmlsdGVyIGZyb20gdGhlIG1haW4gZGlzcGF0Y2gg cXVldWUgTmV0d29ya0NhY2hlU3RvcmFnZTo6aW5pdGlhbGl6ZSgpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEyOTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQb3B1bGF0ZSBtX2NvbnRlbnRzRmlsdGVy IGJsb29tIGZpbHRlciBmcm9tIHRoZSBtYWluIGRpc3BhdGNoIHF1ZXVlCisgICAgICAgIE5ldHdv cmtDYWNoZVN0b3JhZ2U6OmluaXRpYWxpemUoKSB0byBhdm9pZCB0aHJlYWQtc2FmZXR5IGlzc3Vl cy4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2VD b2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlU3RvcmFnZTo6aW5pdGlhbGl6 ZSk6CisKIDIwMTUtMDItMDQgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAg ICAgICAgIEF2b2lkIGNvcHlpbmcgc3RkOjpmdW5jdGlvbnMgYWNyb3NzIHRocmVhZHMgaW4gTmV0 d29ya0NhY2hlU3RvcmFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZUNvY29hLm1tIGIvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZUNvY29hLm1tCmluZGV4IDJlNDQ0 NjE2ZDJjNmQ5OGY3ZWM1ZTY0MWU1MzY5NDExNjQxMzBiNDQuLjRmNDE1ZDYzY2QzZDlmNWFlZDc2 ODNmODBlNjY2MDVlMGY3ODAzYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2VDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlQ29jb2EubW0KQEAg LTEyOSwxNiArMTI5LDE3IEBAIHZvaWQgTmV0d29ya0NhY2hlU3RvcmFnZTo6aW5pdGlhbGl6ZSgp CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKIAogICAgIFN0cmluZ0NhcHR1cmUgY2Fj aGVQYXRoQ2FwdHVyZShtX2RpcmVjdG9yeVBhdGgpOwotICAgIGF1dG8mIGRpc2tDb250ZW50c0Zp bHRlciA9IG1fY29udGVudHNGaWx0ZXI7CiAgICAgYXV0byYgZW50cnlDb3VudCA9IG1fYXBwcm94 aW1hdGVFbnRyeUNvdW50OwogCi0gICAgZGlzcGF0Y2hfYXN5bmMobV9iYWNrZ3JvdW5kSU9RdWV1 ZS5nZXQoKSwgW2NhY2hlUGF0aENhcHR1cmUsICZkaXNrQ29udGVudHNGaWx0ZXIsICZlbnRyeUNv dW50XSB7CisgICAgZGlzcGF0Y2hfYXN5bmMobV9iYWNrZ3JvdW5kSU9RdWV1ZS5nZXQoKSwgW3Ro aXMsIGNhY2hlUGF0aENhcHR1cmUsICZlbnRyeUNvdW50XSB7CiAgICAgICAgIFN0cmluZyBjYWNo ZVBhdGggPSBjYWNoZVBhdGhDYXB0dXJlLnN0cmluZygpOwotICAgICAgICB0cmF2ZXJzZUNhY2hl RmlsZXMoY2FjaGVQYXRoLCBbJmRpc2tDb250ZW50c0ZpbHRlciwgJmVudHJ5Q291bnRdKGNvbnN0 IFN0cmluZyYgZmlsZU5hbWUsIGNvbnN0IFN0cmluZyYpIHsKKyAgICAgICAgdHJhdmVyc2VDYWNo ZUZpbGVzKGNhY2hlUGF0aCwgW3RoaXMsICZlbnRyeUNvdW50XShjb25zdCBTdHJpbmcmIGZpbGVO YW1lLCBjb25zdCBTdHJpbmcmKSB7CiAgICAgICAgICAgICBOZXR3b3JrQ2FjaGVLZXk6Okhhc2hU eXBlIGhhc2g7CiAgICAgICAgICAgICBpZiAoIU5ldHdvcmtDYWNoZUtleTo6c3RyaW5nVG9IYXNo KGZpbGVOYW1lLCBoYXNoKSkKICAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICBk aXNrQ29udGVudHNGaWx0ZXIuYWRkKGhhc2gpOworICAgICAgICAgICAgZGlzcGF0Y2hfYXN5bmMo ZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgW3RoaXMsIGhhc2hdIHsKKyAgICAgICAgICAgICAg ICBtX2NvbnRlbnRzRmlsdGVyLmFkZChoYXNoKTsKKyAgICAgICAgICAgIH0pOwogICAgICAgICAg ICAgKytlbnRyeUNvdW50OwogICAgICAgICB9KTsKICAgICB9KTsK