141277 2015-02-04 17:30:26 -0800 [Media iOS] Add a debug setting to always show the optimized fullscreen button 2015-02-05 05:36:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino webkit-bug-importer oldest_to_newest 1067000 0 dino 2015-02-04 17:30:26 -0800 [Media iOS] Add a debug setting to always show the optimized fullscreen button 1067001 1 webkit-bug-importer 2015-02-04 17:32:02 -0800 <rdar://problem/19724471> 1067002 2 246071 dino 2015-02-04 17:35:03 -0800 Created attachment 246071 Patch 1067085 3 dino 2015-02-05 05:36:42 -0800 Committed r179689: <http://trac.webkit.org/changeset/179689> 246071 2015-02-04 17:35:03 -0800 2015-02-04 18:34:04 -0800 Patch bug-141277-20150205123502.patch text/plain 6687 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRmNWYwZjcyOWQ2NjE4 NTIyMjMwMTc5NzY0OWEzOTU3MjczMDBjNC4uZThiNmM3Y2MyMTdiODFjMzUzNzBjN2YyYjU2NTU4 MjRkOTlmMzIzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAyLTA0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbTWVkaWEgaU9TXSBBZGQgYSBk ZWJ1ZyBzZXR0aW5nIHRvIGFsd2F5cyBzaG93IHRoZSBvcHRpbWl6ZWQgZnVsbHNjcmVlbiBidXR0 b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTI3 NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTk3MjQ0NzE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgZGVidWcgb3B0aW9uIHNvIHRoYXQg d2UgY2FuIHRlc3QgdGhlIG9wdGltaXplZCBmdWxsc2NyZWVuCisgICAgICAgIGNvbnRyb2wgb24g bWVkaWEgdGhhdCBkb2Vzbid0IHN1cHBvcnQgaXQuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlh Y29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qczogQWRkIGdTaW11bGF0ZU9wdGltaXplZEZ1bGxz Y3JlZW5BdmFpbGFibGUuCisgICAgICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5jcmVhdGVD b250cm9scyk6IENoZWNrIHRoZSBzZXR0aW5nLgorICAgICAgICAoQ29udHJvbGxlcklPUy5wcm90 b3R5cGUuY29uZmlndXJlSW5saW5lQ29udHJvbHMpOiBEaXR0by4KKyAgICAgICAgKENvbnRyb2xs ZXJJT1MucHJvdG90eXBlLmZvcm1hdFRpbWUpOiBEcml2ZS1ieSB3aGl0ZXNwYWNlIGNsZWFudXAu CisgICAgICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5oYW5kbGVCYXNlR2VzdHVyZUNoYW5n ZSk6CisgICAgICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5oYW5kbGVXcmFwcGVyVG91Y2hT dGFydCk6CisgICAgICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5oYW5kbGVPcHRpbWl6ZWRG dWxsc2NyZWVuVG91Y2hFbmQpOgorICAgICAgICAoQ29udHJvbGxlcklPUy5wcm90b3R5cGUuaGFu ZGxlUHJlc2VudGF0aW9uTW9kZUNoYW5nZSk6IERyaXZlLWJ5IHZhcmlhYmxlIHJlbmFtaW5nLgor CiAyMDE1LTAyLTA0ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAg ICAgICAgIFtpT1NdIGFkZCBtZXRob2QgdG8gdG9nZ2xlIHBsYXliYWNrIHdoZW4gaW4gdGhlIGJh Y2tncm91bmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9s cy9tZWRpYUNvbnRyb2xzaU9TLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRy b2xzL21lZGlhQ29udHJvbHNpT1MuanMKaW5kZXggZDA3MTBmMjg2MzczNzU4YjIxODgwNjExMTMx ODJjMzQ1MjI0Yjg4YS4uMjIxOTJhMTljNzQyMjc4NGYzNDA1MWI0ZTIzNGQ4MzQ1ZmU5NTIwMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNpT1MuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNpT1MuanMKQEAgLTI1LDYgKzI1LDcgQEAgQ29udHJvbGxlcklPUy5TdGFydFBs YXliYWNrQ29udHJvbHMgPSAyOwogLyogR2xvYmFscyAqLwogQ29udHJvbGxlcklPUy5nV2lyZWxl c3NJbWFnZSA9ICdkYXRhOmltYWdlL3N2Zyt4bWw7dXRmOCw8c3ZnIHhtbG5zPSJodHRwOi8vd3d3 LnczLm9yZy8yMDAwL3N2ZyIgdmlld0JveD0iMCAwIDIwMCAyNDUiPjxnIGZpbGw9IiMxMDYwRkUi PjxwYXRoIGQ9Ik0xOTMuNiw2LjN2MTIxLjZINi40VjYuM0gxOTMuNiBNMTk5LjEsMC43SDAuOXYx MzIuN2gxOTguMlYwLjdMMTk5LjEsMC43eiIvPjxwYXRoIGQ9Ik00My41LDEzOS4zYzE1LjgsOCwz NS4zLDEyLjcsNTYuNSwxMi43czQwLjctNC43LDU2LjUtMTIuN0g0My41eiIvPjwvZz48ZyB0ZXh0 LWFuY2hvcj0ibWlkZGxlIiBmb250LWZhbWlseT0iSGVsdmV0aWNhIE5ldWUiPjx0ZXh0IHg9IjEw MCIgeT0iMjA0IiBmaWxsPSJ3aGl0ZSIgZm9udC1zaXplPSIyNCI+IyNERVZJQ0VfVFlQRSMjPC90 ZXh0Pjx0ZXh0IHg9IjEwMCIgeT0iMjM0IiBmaWxsPSIjNUM1QzVDIiBmb250LXNpemU9IjIxIj4j I0RFVklDRV9OQU1FIyM8L3RleHQ+PC9nPjwvc3ZnPic7CiBDb250cm9sbGVySU9TLmdTaW11bGF0 ZVdpcmVsZXNzUGxheWJhY2tUYXJnZXQgPSBmYWxzZTsgLy8gVXNlZCBmb3IgdGVzdGluZyB3aGVu IHRoZXJlIGFyZSBubyB3aXJlbGVzcyB0YXJnZXRzLgorQ29udHJvbGxlcklPUy5nU2ltdWxhdGVP cHRpbWl6ZWRGdWxsc2NyZWVuQXZhaWxhYmxlID0gZmFsc2U7IC8vIFVzZWQgZm9yIHRlc3Rpbmcg d2hlbiBvcHRpbWl6ZWQgZnVsbHNjcmVlbiBpcyBub3QgYXZhaWxhYmxlLgogCiBDb250cm9sbGVy SU9TLnByb3RvdHlwZSA9IHsKICAgICBhZGRWaWRlb0xpc3RlbmVyczogZnVuY3Rpb24oKSB7CkBA IC0xNDgsNyArMTQ5LDggQEAgQ29udHJvbGxlcklPUy5wcm90b3R5cGUgPSB7CiAKICAgICAgICAg dmFyIGlubGluZVBsYXliYWNrUGxhY2Vob2xkZXIgPSB0aGlzLmNvbnRyb2xzLmlubGluZVBsYXli YWNrUGxhY2Vob2xkZXIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKICAgICAgICAg aW5saW5lUGxheWJhY2tQbGFjZWhvbGRlci5zZXRBdHRyaWJ1dGUoJ3BzZXVkbycsICctd2Via2l0 LW1lZGlhLWNvbnRyb2xzLWlubGluZS1wbGF5YmFjay1wbGFjZWhvbGRlcicpOwotICAgICAgICBp bmxpbmVQbGF5YmFja1BsYWNlaG9sZGVyLmNsYXNzTGlzdC5hZGQodGhpcy5DbGFzc05hbWVzLmhp ZGRlbik7CisgICAgICAgIGlmICghQ29udHJvbGxlcklPUy5nU2ltdWxhdGVPcHRpbWl6ZWRGdWxs c2NyZWVuQXZhaWxhYmxlKQorICAgICAgICAgICAgaW5saW5lUGxheWJhY2tQbGFjZWhvbGRlci5j bGFzc0xpc3QuYWRkKHRoaXMuQ2xhc3NOYW1lcy5oaWRkZW4pOwogICAgICAgICBpbmxpbmVQbGF5 YmFja1BsYWNlaG9sZGVyLnNldEF0dHJpYnV0ZSgnYXJpYS1sYWJlbCcsIHRoaXMuVUlTdHJpbmco J0Rpc3BsYXkgT3B0aW1pemVkIEZ1bGwgU2NyZWVuJykpOwogCiAgICAgICAgIHZhciB3aXJlbGVz c1RhcmdldFBpY2tlciA9IHRoaXMuY29udHJvbHMud2lyZWxlc3NUYXJnZXRQaWNrZXIgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCdidXR0b24nKTsKQEAgLTIyMSw3ICsyMjMsNyBAQCBDb250cm9s bGVySU9TLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuY29udHJvbHMudGltZWxpbmVC b3guYXBwZW5kQ2hpbGQodGhpcy5jb250cm9scy5yZW1haW5pbmdUaW1lKTsKICAgICAgICAgfQog ICAgICAgICBpZiAoIXRoaXMuaXNBdWRpbygpKSB7Ci0gICAgICAgICAgICBpZiAoJ3dlYmtpdFN1 cHBvcnRzUHJlc2VudGF0aW9uTW9kZScgaW4gdGhpcy52aWRlbyAmJiB0aGlzLnZpZGVvLndlYmtp dFN1cHBvcnRzUHJlc2VudGF0aW9uTW9kZSgnb3B0aW1pemVkJykpCisgICAgICAgICAgICBpZiAo Q29udHJvbGxlcklPUy5nU2ltdWxhdGVPcHRpbWl6ZWRGdWxsc2NyZWVuQXZhaWxhYmxlIHx8ICgn d2Via2l0U3VwcG9ydHNQcmVzZW50YXRpb25Nb2RlJyBpbiB0aGlzLnZpZGVvICYmIHRoaXMudmlk ZW8ud2Via2l0U3VwcG9ydHNQcmVzZW50YXRpb25Nb2RlKCdvcHRpbWl6ZWQnKSkpCiAgICAgICAg ICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5hcHBlbmRDaGlsZCh0aGlzLmNvbnRyb2xzLm9w dGltaXplZEZ1bGxzY3JlZW5CdXR0b24pOwogICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5l bC5hcHBlbmRDaGlsZCh0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24pOwogICAgICAgICB9 CkBAIC0zNDAsNyArMzQyLDcgQEAgQ29udHJvbGxlcklPUy5wcm90b3R5cGUgPSB7CiAgICAgaGFu ZGxlQmFzZUdlc3R1cmVDaGFuZ2U6IGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAgICAgIGlmICghdGhp cy52aWRlby5jb250cm9scyB8fCB0aGlzLmlzQXVkaW8oKSB8fCB0aGlzLmlzRnVsbFNjcmVlbigp IHx8IHRoaXMuZ2VzdHVyZVN0YXJ0VGltZSA9PT0gdW5kZWZpbmVkIHx8IHRoaXMuY29udHJvbHNU eXBlID09IENvbnRyb2xsZXJJT1MuU3RhcnRQbGF5YmFja0NvbnRyb2xzKQogICAgICAgICAgICAg cmV0dXJuOwotICAgICAgICAKKwogICAgICAgICB2YXIgc2NhbGVEZXRlY3Rpb25UaHJlc2hvbGQg PSAwLjI7CiAgICAgICAgIGlmIChldmVudC5zY2FsZSA+IDEgKyBzY2FsZURldGVjdGlvblRocmVz aG9sZCB8fCBldmVudC5zY2FsZSA8IDEgLSBzY2FsZURldGVjdGlvblRocmVzaG9sZCkKICAgICAg ICAgICAgIGRlbGV0ZSB0aGlzLmxhc3REb3VibGVUb3VjaFRpbWU7CkBAIC0zNTQsNyArMzU2LDcg QEAgQ29udHJvbGxlcklPUy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47CiAKICAg ICAgICAgdmFyIHZlbG9jaXR5ID0gTWF0aC5hYnMoZXZlbnQuc2NhbGUgLSAxKSAvIGR1cmF0aW9u OwotICAgICAgICAKKwogICAgICAgICB2YXIgcGluY2hPdXRWZWxvY2l0eVRocmVzaG9sZCA9IDI7 CiAgICAgICAgIHZhciBwaW5jaE91dEdlc3R1cmVTY2FsZVRocmVzaG9sZCA9IDEuMjU7CiAgICAg ICAgIGlmICh2ZWxvY2l0eSA8IHBpbmNoT3V0VmVsb2NpdHlUaHJlc2hvbGQgfHwgZXZlbnQuc2Nh bGUgPCBwaW5jaE91dEdlc3R1cmVTY2FsZVRocmVzaG9sZCkKQEAgLTM3Myw3ICszNzUsNyBAQCBD b250cm9sbGVySU9TLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAg ICB0aGlzLm1vc3RSZWNlbnROdW1iZXJPZlRhcmdldHRlZFRvdWNoZXMgPSBldmVudC50YXJnZXRU b3VjaGVzLmxlbmd0aDsKLSAgICAgICAgCisKICAgICAgICAgaWYgKHRoaXMuY29udHJvbHNBcmVI aWRkZW4oKSkgewogICAgICAgICAgICAgdGhpcy5zaG93Q29udHJvbHMoKTsKICAgICAgICAgICAg IGlmICh0aGlzLmhpZGVUaW1lcikKQEAgLTQ1NiwxOSArNDU4LDE5IEBAIENvbnRyb2xsZXJJT1Mu cHJvdG90eXBlID0gewogICAgICAgICBlbHNlCiAgICAgICAgICAgICB0aGlzLnZpZGVvLndlYmtp dFNldFByZXNlbnRhdGlvbk1vZGUoJ29wdGltaXplZCcpOwogICAgIH0sCi0gICAgICAgIAorCiAg ICAgaGFuZGxlT3B0aW1pemVkRnVsbHNjcmVlblRvdWNoU3RhcnQ6IGZ1bmN0aW9uKCkgewogICAg ICAgICB0aGlzLmNvbnRyb2xzLm9wdGltaXplZEZ1bGxzY3JlZW5CdXR0b24uY2xhc3NMaXN0LmFk ZCgnYWN0aXZlJyk7CiAgICAgfSwKLSAgICAgICAgCisKICAgICBoYW5kbGVPcHRpbWl6ZWRGdWxs c2NyZWVuVG91Y2hFbmQ6IGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAgICAgIHRoaXMuY29udHJvbHMu b3B0aW1pemVkRnVsbHNjcmVlbkJ1dHRvbi5jbGFzc0xpc3QucmVtb3ZlKCdhY3RpdmUnKTsKLSAg ICAgICAgCisKICAgICAgICAgdGhpcy5oYW5kbGVPcHRpbWl6ZWRGdWxsc2NyZWVuQnV0dG9uQ2xp Y2tlZCgpOwotICAgICAgICAKKwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAotICAgICAg ICAKKwogICAgIGhhbmRsZU9wdGltaXplZEZ1bGxzY3JlZW5Ub3VjaENhbmNlbDogZnVuY3Rpb24o ZXZlbnQpIHsKICAgICAgICAgdGhpcy5jb250cm9scy5vcHRpbWl6ZWRGdWxsc2NyZWVuQnV0dG9u LmNsYXNzTGlzdC5yZW1vdmUoJ2FjdGl2ZScpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTYx MCw4ICs2MTIsOCBAQCBDb250cm9sbGVySU9TLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAg ICB0aGlzLmNvbnRyb2xzLmlubGluZVBsYXliYWNrUGxhY2Vob2xkZXIuY2xhc3NMaXN0LmFkZCh0 aGlzLkNsYXNzTmFtZXMuaGlkZGVuKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAg ICAgIGNhc2UgJ29wdGltaXplZCc6Ci0gICAgICAgICAgICAgICAgdmFyIGJhY2tncm91bmRJbWFn ZVNWRyA9ICJ1cmwoJyIgKyB0aGlzLmhvc3QubWVkaWFVSUltYWdlRGF0YSgib3B0aW1pemVkLWZ1 bGxzY3JlZW4tcGxhY2Vob2xkZXIiKSArICInKSI7Ci0gICAgICAgICAgICAgICAgdGhpcy5jb250 cm9scy5pbmxpbmVQbGF5YmFja1BsYWNlaG9sZGVyLnN0eWxlLmJhY2tncm91bmRJbWFnZSA9IGJh Y2tncm91bmRJbWFnZVNWRzsKKyAgICAgICAgICAgICAgICB2YXIgYmFja2dyb3VuZEltYWdlID0g InVybCgnIiArIHRoaXMuaG9zdC5tZWRpYVVJSW1hZ2VEYXRhKCJvcHRpbWl6ZWQtZnVsbHNjcmVl bi1wbGFjZWhvbGRlciIpICsgIicpIjsKKyAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLmlu bGluZVBsYXliYWNrUGxhY2Vob2xkZXIuc3R5bGUuYmFja2dyb3VuZEltYWdlID0gYmFja2dyb3Vu ZEltYWdlOwogICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMuaW5saW5lUGxheWJhY2tQbGFj ZWhvbGRlci5zZXRBdHRyaWJ1dGUoJ2FyaWEtbGFiZWwnLCAidmlkZW8gcGxheWJhY2sgcGxhY2Vo b2xkZXIiKTsKICAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLmlubGluZVBsYXliYWNrUGxh Y2Vob2xkZXIuY2xhc3NMaXN0LnJlbW92ZSh0aGlzLkNsYXNzTmFtZXMuaGlkZGVuKTsKICAgICAg ICAgICAgICAgICBicmVhazsK