141258 2015-02-04 12:58:50 -0800 Optimized equal() functions in StringImpl.h are not ASan compatible 2015-02-04 15:38:51 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=140873 P2 Normal --- 1 ap ap benjamin cmarcelo commit-queue dbates msaboff oldest_to_newest 1066892 0 ap 2015-02-04 12:58:50 -0800 equal() reads out of bounds; we started seeing this after the fix for bug 140873. 1066902 1 246045 ap 2015-02-04 13:55:12 -0800 Created attachment 246045 proposed fix 1066932 2 246045 dbates 2015-02-04 14:43:17 -0800 Comment on attachment 246045 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=246045&action=review > Source/WTF/wtf/text/StringImpl.h:878 > +#if (CPU(X86_64) || CPU(ARM64)) && !ASAN_ENABLED You may want to consider checking ASAN_ENABLED in an if-statement and changing the #if to #elif on this line such that these #if/elif/else-macro blocks look like: #if ASAN_ENABLED ... #elif CPU(X86_64) || CPU(ARM64) ... ... #else ... #endif Then we do not need to add the conjunct !ASAN_ENABLED to each macro conditional expression. 1066943 3 246045 ap 2015-02-04 14:57:32 -0800 Comment on attachment 246045 proposed fix I wanted to keep debug-only code after production code - we usually try to keep the "best" variant first in WebKit code base. 1066968 4 246045 commit-queue 2015-02-04 15:38:47 -0800 Comment on attachment 246045 proposed fix Clearing flags on attachment: 246045 Committed r179644: <http://trac.webkit.org/changeset/179644> 1066969 5 commit-queue 2015-02-04 15:38:51 -0800 All reviewed patches have been landed. Closing bug. 246045 2015-02-04 13:55:12 -0800 2015-02-04 15:38:47 -0800 proposed fix StringImplEqual.txt text/plain 2642 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNzk2MjcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAyLTA0ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE9wdGltaXplZCBlcXVhbCgpIGZ1bmN0aW9ucyBp biBTdHJpbmdJbXBsLmggYXJlIG5vdCBBU2FuIGNvbXBhdGlibGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTI1OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nSW1wbC5oOiAo V1RGOjplcXVhbCk6IEFkZCBjdXN0b20gaW1wbGVtZW50YXRpb25zIGZvciBBU2FuLgorCiAyMDE1 LTAyLTA0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHJl bW92ZUZpcnN0KHZhbHVlKSAvIHJlbW92ZUFsbCh2YWx1ZSkgbWV0aG9kcyB0byBXVEY6OlZlY3Rv cgpJbmRleDogU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgJKHJldmlzaW9uIDE3OTYxNykKKysrIFNv dXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC04NzUsNyAr ODc1LDcgQEAgaW5saW5lIFQgbG9hZFVuYWxpZ25lZChjb25zdCBjaGFyKiBzKQogfQogCiAvLyBE byBjb21wYXJpc29ucyA4IG9yIDQgYnl0ZXMtYXQtYS10aW1lIG9uIGFyY2hpdGVjdHVyZXMgd2hl cmUgaXQncyBzYWZlLgotI2lmIENQVShYODZfNjQpIHx8IENQVShBUk02NCkKKyNpZiAoQ1BVKFg4 Nl82NCkgfHwgQ1BVKEFSTTY0KSkgJiYgIUFTQU5fRU5BQkxFRAogQUxXQVlTX0lOTElORSBib29s IGVxdWFsKGNvbnN0IExDaGFyKiBhTENoYXIsIGNvbnN0IExDaGFyKiBiTENoYXIsIHVuc2lnbmVk IGxlbmd0aCkKIHsKICAgICB1bnNpZ25lZCBkd29yZExlbmd0aCA9IGxlbmd0aCA+PiAzOwpAQCAt OTQ1LDcgKzk0NSw3IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChjb25zdCBVQ2hhciogYVUK IAogICAgIHJldHVybiB0cnVlOwogfQotI2VsaWYgQ1BVKFg4NikKKyNlbGlmIENQVShYODYpICYm ICFBU0FOX0VOQUJMRUQKIEFMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChjb25zdCBMQ2hhciogYUxD aGFyLCBjb25zdCBMQ2hhciogYkxDaGFyLCB1bnNpZ25lZCBsZW5ndGgpCiB7CiAgICAgY29uc3Qg Y2hhciogYSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KGFMQ2hhcik7CkBAIC05OTIs NyArOTkyLDcgQEAgQUxXQVlTX0lOTElORSBib29sIGVxdWFsKGNvbnN0IFVDaGFyKiBhVQogCiAg ICAgcmV0dXJuIHRydWU7CiB9Ci0jZWxpZiBQTEFURk9STShJT1MpICYmIFdURl9BUk1fQVJDSF9B VF9MRUFTVCg3KQorI2VsaWYgUExBVEZPUk0oSU9TKSAmJiBXVEZfQVJNX0FSQ0hfQVRfTEVBU1Qo NykgJiYgIUFTQU5fRU5BQkxFRAogQUxXQVlTX0lOTElORSBib29sIGVxdWFsKGNvbnN0IExDaGFy KiBhLCBjb25zdCBMQ2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKQogewogICAgIGJvb2wgaXNFcXVh bCA9IGZhbHNlOwpAQCAtMTA4MCw5ICsxMDgwLDI2IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBlcXVh bChjb25zdCBVQ2hhciogYSwKICAgICAgICAgKTsKICAgICByZXR1cm4gaXNFcXVhbDsKIH0KLSNl bHNlCisjZWxpZiAhQVNBTl9FTkFCTEVECiBBTFdBWVNfSU5MSU5FIGJvb2wgZXF1YWwoY29uc3Qg TENoYXIqIGEsIGNvbnN0IExDaGFyKiBiLCB1bnNpZ25lZCBsZW5ndGgpIHsgcmV0dXJuICFtZW1j bXAoYSwgYiwgbGVuZ3RoKTsgfQogQUxXQVlTX0lOTElORSBib29sIGVxdWFsKGNvbnN0IFVDaGFy KiBhLCBjb25zdCBVQ2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKSB7IHJldHVybiAhbWVtY21wKGEs IGIsIGxlbmd0aCAqIHNpemVvZihVQ2hhcikpOyB9CisjZWxzZQorQUxXQVlTX0lOTElORSBib29s IGVxdWFsKGNvbnN0IExDaGFyKiBhLCBjb25zdCBMQ2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKQor eworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgeworICAgICAgICBp ZiAoYVtpXSAhPSBiW2ldKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKyAgICBy ZXR1cm4gdHJ1ZTsKK30KK0FMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChjb25zdCBVQ2hhciogYSwg Y29uc3QgVUNoYXIqIGIsIHVuc2lnbmVkIGxlbmd0aCkKK3sKKyAgICBmb3IgKHVuc2lnbmVkIGkg PSAwOyBpIDwgbGVuZ3RoOyArK2kpIHsKKyAgICAgICAgaWYgKGFbaV0gIT0gYltpXSkKKyAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisgICAgcmV0dXJuIHRydWU7Cit9CiAjZW5kaWYK IAogQUxXQVlTX0lOTElORSBib29sIGVxdWFsKGNvbnN0IExDaGFyKiBhLCBjb25zdCBVQ2hhciog YiwgdW5zaWduZWQgbGVuZ3RoKQo=