141255 2015-02-04 12:07:58 -0800 test-webkitpy fails on Mac without iphoneos SDK 2015-02-04 14:05:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad iOS 8.1 RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates ap commit-queue ddkilzer glenn oldest_to_newest 1066875 0 dbates 2015-02-04 12:07:58 -0800 We should support running the Python unit tests on a Mac without the iphoneos SDK. 1066876 1 dbates 2015-02-04 12:09:06 -0800 <rdar://problem/19619691> 1066877 2 246041 dbates 2015-02-04 12:12:31 -0800 Created attachment 246041 Patch and unit test As mentioned in the ChangeLog entry for PlatformInfo.xcode_sdk_version(), I took advantage of the behavior that xcrun --show-sdk-version only writes to standard output if the SDK is installed to return the empty string when the SDK is not installed. Let me know if it is preferred to explicitly check the exit status of xcrun and return the empty string instead of making use of this behavior. 1066878 3 246041 ddkilzer 2015-02-04 12:16:32 -0800 Comment on attachment 246041 Patch and unit test r=me 1066879 4 246041 ap 2015-02-04 12:17:11 -0800 Comment on attachment 246041 Patch and unit test View in context: https://bugs.webkit.org/attachment.cgi?id=246041&action=review > Tools/Scripts/webkitpy/port/ios.py:57 > + raise Exception("Ensure that the Xcode command line tools and the iphoneos SDK are installed.") Maybe add a "please" somewhere here? E.g. "Please install Xcode command line tools and the iPhone SDK". Also, why do we need command line tools? I thought that we didn't rely on them. 1066880 5 dbates 2015-02-04 12:24:22 -0800 (In reply to comment #4) > Comment on attachment 246041 [details] > Patch and unit test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246041&action=review > > > Tools/Scripts/webkitpy/port/ios.py:57 > > + raise Exception("Ensure that the Xcode command line tools and the iphoneos SDK are installed.") > > Maybe add a "please" somewhere here? E.g. "Please install Xcode command line > tools and the iPhone SDK". > > Also, why do we need command line tools? I thought that we didn't rely on > them. After talking with Alexey Proskuryakov on IRC today (02/04) we confirmed that xcrun is included with a default OS install. So, I will update the exception message to read: "Please install the iOS SDK." 1066881 6 dbates 2015-02-04 12:26:29 -0800 Committed r179622: <http://trac.webkit.org/changeset/179622> 1066907 7 dbates 2015-02-04 14:05:19 -0800 Fixed exception message per comment 5 and committed this in <http://trac.webkit.org/changeset/179629>. 246041 2015-02-04 12:12:31 -0800 2015-02-04 12:16:32 -0800 Patch and unit test bug-141255-20150204121230.patch text/plain 4554 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MjIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjZkOTRmNDY1MDVhNzE2NzFlZDI2OGIxMGM3NjM0ODAw ZWI1MjU2ZC4uYzYxZGE1MzkyZjEzYTYzZmM1NzM3NzY5Zjc3MjVlZjU1NTQzODc4MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDE1LTAyLTA0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICB0ZXN0LXdlYmtpdHB5IGZhaWxzIG9uIE1hYyB3aXRob3V0IGlwaG9uZW9zIFNESworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMjU1CisgICAg ICAgIHJkYXI6Ly9wcm9ibGVtLzE5NjE5NjkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgdGVzdC13ZWJraXRweSBm YWlscyBvbiBhIE1hYyB3aXRob3V0IHRoZSBpT1MgU0RLLiBXZSBzaG91bGQKKyAgICAgICAgc2hv dWxkIG5vdCByZXF1aXJlIHRoZSBpcGhvbmVvcyBTREsgdG8gYmUgaW5zdGFsbGVkIHRvIHJ1biB0 aGUgd2Via2l0cHkgdGVzdHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vcGxhdGZvcm1pbmZvLnB5OgorICAgICAgICAoUGxhdGZvcm1JbmZvLnhjb2RlX3Nka192 ZXJzaW9uKTogQWRkZWQ7IHJldHVybiB0aGUgdmVyc2lvbiBvZiB0aGUgc3BlY2lmaWVkIFNESywg aWYKKyAgICAgICAgaW5zdGFsbGVkLiBXZSB0YWtlIGFkdmFudGFnZSBvZiB0aGUgYmVoYXZpb3Ig dGhhdCB4Y3J1biAtLXNob3ctc2RrLXZlcnNpb24gb25seSB3cml0ZXMKKyAgICAgICAgdG8gc3Rh bmRhcmQgb3V0cHV0IGlmIHRoZSBTREsgaXMgaW5zdGFsbGVkIHRvIHJldHVybiB0aGUgZW1wdHkg c3RyaW5nIGlmIHRoZSBTREsgaXMKKyAgICAgICAgbm90IGluc3RhbGxlZC4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvX21vY2sucHk6CisgICAg ICAgIChNb2NrUGxhdGZvcm1JbmZvLnhjb2RlX3Nka192ZXJzaW9uKTogQWRkZWQuCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weToKKyAgICAgICAgKElPU1BvcnQuZGV0ZXJt aW5lX2Z1bGxfcG9ydF9uYW1lKTogTW9kaWZpZWQgdG8gY2FsbCBQbGF0Zm9ybUluZm8ueGNvZGVf c2RrX3ZlcnNpb24oKQorICAgICAgICB0byBnZXQgdGhlIHZlcnNpb24gb2YgdGhlIGlwaG9uZW9z IFNESywgaWYgaW5zdGFsbGVkLgorCiAyMDE1LTAxLTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIERpc2FibGUgYnVpbGRpbmcgSmF2YSBhcHBs ZXRzIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vcGxhdGZvcm1pbmZvLnB5CmluZGV4IGEyNjEyNWM4YWZmNzkxYjE0ZDdmNzYzNmZiMmRm NjQ0MDFlZGE2YzcuLjkyZDYyYThmZWFmOTc1OTY0MzA4NTI3N2NiNDgyYWI0OTVkOTY2MzggMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWlu Zm8ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3Jt aW5mby5weQpAQCAtMjksNiArMjksNyBAQAogaW1wb3J0IHJlCiBpbXBvcnQgc3lzCiAKK2Zyb20g d2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IEV4ZWN1dGl2ZQogCiBjbGFz cyBQbGF0Zm9ybUluZm8ob2JqZWN0KToKICAgICAiIiJUaGlzIGNsYXNzIHByb3ZpZGVzIGEgY29u c2lzdGVudCAoYW5kIG1vY2thYmxlKSBpbnRlcnByZXRhdGlvbiBvZgpAQCAtMTE4LDYgKzExOSwx MiBAQCBjbGFzcyBQbGF0Zm9ybUluZm8ob2JqZWN0KToKICAgICAgICAgZXhjZXB0OgogICAgICAg ICAgICAgcmV0dXJuIHN5cy5tYXhpbnQKIAorICAgIGRlZiB4Y29kZV9zZGtfdmVyc2lvbihzZWxm LCBzZGtfbmFtZSk6CisgICAgICAgIGlmIHNlbGYuaXNfbWFjKCk6CisgICAgICAgICAgICAjIEFz c3VtZXMgdGhhdCB4Y3J1biBkb2VzIG5vdCB3cml0ZSB0byBzdGFuZGFyZCBvdXRwdXQgb24gZmFp bHVyZSAoZS5nLiBTREsgZG9lcyBub3QgZXhpc3QpLgorICAgICAgICAgICAgcmV0dXJuIHNlbGYu X2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbInhjcnVuIiwgIi0tc2RrIiwgc2RrX25hbWUsICItLXNo b3ctc2RrLXZlcnNpb24iXSwgcmV0dXJuX3N0ZGVycj1GYWxzZSwgZXJyb3JfaGFuZGxlcj1FeGVj dXRpdmUuaWdub3JlX2Vycm9yKS5yc3RyaXAoKQorICAgICAgICByZXR1cm4gJycKKwogICAgIGRl ZiBfZGV0ZXJtaW5lX29zX25hbWUoc2VsZiwgc3lzX3BsYXRmb3JtKToKICAgICAgICAgaWYgc3lz X3BsYXRmb3JtID09ICdkYXJ3aW4nOgogICAgICAgICAgICAgcmV0dXJuICdtYWMnCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvX21v Y2sucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZv X21vY2sucHkKaW5kZXggYmM3MjgxMGNmYzY5MTNhMzY2N2E4ZGE1ODJhMThkNWY1NTEwMWQ0OC4u MjFhNjkyMjY1ZTBkNWMxNmNiMWQ4MjI4OWU3MTJhNjc5ZTdiZTg4NSAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mb19tb2NrLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm9fbW9j ay5weQpAQCAtNTUsMyArNTUsNiBAQCBjbGFzcyBNb2NrUGxhdGZvcm1JbmZvKG9iamVjdCk6CiAK ICAgICBkZWYgdGVybWluYWxfd2lkdGgoc2VsZik6CiAgICAgICAgIHJldHVybiA4MAorCisgICAg ZGVmIHhjb2RlX3Nka192ZXJzaW9uKHNlbGYsIHNka19uYW1lKToKKyAgICAgICAgcmV0dXJuICc4 LjEnCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQppbmRleCBkNTdjZDQzZDMyOWY1ZjNmNzE5 YjFhMDkzNGNkMDgyMWU0YTY5ZjM3Li4yM2MyYjk5MjE3NDQ0MWNjYTgwZDg0ZDU2ZWJhMWFlNTRi ZmQzYjhlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkKQEAgLTUyLDE2ICs1MiwxMSBA QCBjbGFzcyBJT1NQb3J0KEFwcGxlUG9ydCk6CiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIGRl dGVybWluZV9mdWxsX3BvcnRfbmFtZShjbHMsIGhvc3QsIG9wdGlvbnMsIHBvcnRfbmFtZSk6CiAg ICAgICAgIGlmIHBvcnRfbmFtZSA9PSBjbHMucG9ydF9uYW1lOgotICAgICAgICAgICAgc2RrX3Zl cnNpb24gPSAnOC4wJwotICAgICAgICAgICAgIyBGSVhNRTogV2Ugc2hvdWxkIG1vdmUgdGhlIGNh bGwgdG8geGNydW4gdG8gdGhlIFBsYXRmb3JtSW5mbyBvYmplY3Qgc28gdGhhdAotICAgICAgICAg ICAgIyB3ZSBjYW4gdXNlIE1vY2tQbGF0Zm9ybUluZm8gdG8gc2V0IGFuIGV4cGVjdGF0aW9uIHdo ZW4gcnVubmluZyB0aGUgdW5pdCB0ZXN0cy4KLSAgICAgICAgICAgIGlmIG9zLnBhdGguaXNmaWxl KCcvdXNyL2Jpbi94Y3J1bicpOgotICAgICAgICAgICAgICAgIHNka19jb21tYW5kX291dHB1dCA9 IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KFsnL3Vzci9iaW4veGNydW4nLCAnLS1zZGsnLCAnaXBo b25lb3MnLCAnLS1zaG93LXNkay12ZXJzaW9uJ10sIHN0ZGVycj1Ob25lKS5yc3RyaXAoKQotICAg ICAgICAgICAgICAgIGlmIHNka19jb21tYW5kX291dHB1dDoKLSAgICAgICAgICAgICAgICAgICAg c2RrX3ZlcnNpb24gPSBzZGtfY29tbWFuZF9vdXRwdXQKLQotICAgICAgICAgICAgcG9ydF9uYW1l ID0gcG9ydF9uYW1lICsgJy0nICsgcmUubWF0Y2goJ14oWzAtOV0rKScsIHNka192ZXJzaW9uKS5n cm91cCgxKQotCisgICAgICAgICAgICBpcGhvbmVvc19zZGtfdmVyc2lvbiA9IGhvc3QucGxhdGZv cm0ueGNvZGVfc2RrX3ZlcnNpb24oJ2lwaG9uZW9zJykKKyAgICAgICAgICAgIGlmIG5vdCBpcGhv bmVvc19zZGtfdmVyc2lvbjoKKyAgICAgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oIkVuc3Vy ZSB0aGF0IHRoZSBYY29kZSBjb21tYW5kIGxpbmUgdG9vbHMgYW5kIHRoZSBpcGhvbmVvcyBTREsg YXJlIGluc3RhbGxlZC4iKQorICAgICAgICAgICAgbWFqb3JfdmVyc2lvbl9udW1iZXIgPSBpcGhv bmVvc19zZGtfdmVyc2lvbi5zcGxpdCgnLicpWzBdCisgICAgICAgICAgICBwb3J0X25hbWUgPSBw b3J0X25hbWUgKyAnLScgKyBtYWpvcl92ZXJzaW9uX251bWJlcgogICAgICAgICByZXR1cm4gcG9y dF9uYW1lCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgKmFyZ3MsICoqa3dhcmdzKToK