141251 2015-02-04 08:32:59 -0800 Make sure CachedFont clients do not override both fontLoaded and notifyFinished 2017-04-25 15:29:13 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 j.isorce webkit-unassigned beidson commit-queue japhet mmaxfield thorton oldest_to_newest 1066808 0 j.isorce 2015-02-04 08:32:59 -0800 Similar to what have been done for CachedImage clients: https://bugs.webkit.org/show_bug.cgi?id=140722 With CachedFont all clients already only implement fontLoaded but lets make sure the situation remains simple in the future. Patch coming soon. 1066811 1 246034 j.isorce 2015-02-04 08:40:46 -0800 Created attachment 246034 CachedFont: ensure clients overrides fontLoaded instead of notifyFinished. 1300806 2 246034 beidson 2017-04-24 19:05:16 -0700 Comment on attachment 246034 CachedFont: ensure clients overrides fontLoaded instead of notifyFinished. This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant. 1301280 3 mmaxfield 2017-04-25 15:29:13 -0700 Yeah, the implementation of this has completely changed. This bug is now irrelevant. 246034 2015-02-04 08:40:46 -0800 2017-04-24 19:05:16 -0700 CachedFont: ensure clients overrides fontLoaded instead of notifyFinished. 0001-CachedFont-ensure-clients-overrides-fontLoaded-inste.patch text/plain 2252 j.isorce RnJvbSA5MDEwY2UwMmRjNjc2Yjg2MDVmNzk0YjdmNjA2NWY2ZmFhYWRlNzBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gSXNvcmNlIDxqLmlzb3JjZUBzYW1zdW5nLmNvbT4K RGF0ZTogV2VkLCAyMSBKYW4gMjAxNSAxMzoyNzozMSArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIENh Y2hlZEZvbnQ6IGVuc3VyZSBjbGllbnRzIG92ZXJyaWRlcyBmb250TG9hZGVkIGluc3RlYWQgb2YK IG5vdGlmeUZpbmlzaGVkLiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQxMjUxCgpBdCB0aGUgbW9tZW50IGFsbCBzdWIgY2xhc3NlcyBkbyBub3Qgb3ZlcnJpZGUgbm90 aWZ5RmluaXNoZWQuClRoaXMgcGF0Y2ggbWFrZSBzdXJlIGl0IHJlbWFpbnMgdGhlIHNhbWUgaW4g dGhlIGZ1dHVyZS4KClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBsb2FkZXIvY2FjaGUv Q2FjaGVkRm9udENsaWVudC5oOgpNYWtlIENhY2hlZEZvbnRDbGllbnQ6Om5vdGlmeUZpbmlzaGVk IGZpbmFsIHRvIG1ha2Ugc3VyZQpzdWIgY2xhc3NlcyBpbXBsZW1lbnQgZm9udExvYWRlZCBpbnN0 ZWFkLgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg fCAxNCArKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEZv bnRDbGllbnQuaCB8ICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDFhZmNiOGYuLmJjY2UxN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBA QAogMjAxNS0wMi0wNCAgSnVsaWVuIElzb3JjZSAgPGouaXNvcmNlQHNhbXN1bmcuY29tPgogCisg ICAgICAgIENhY2hlZEZvbnQ6IGVuc3VyZSBjbGllbnRzIG92ZXJyaWRlcyBmb250TG9hZGVkIGlu c3RlYWQgb2Ygbm90aWZ5RmluaXNoZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDEyNTEKKworICAgICAgICBBdCB0aGUgbW9tZW50IGFsbCBzdWIg Y2xhc3NlcyBkbyBub3Qgb3ZlcnJpZGUgbm90aWZ5RmluaXNoZWQuCisgICAgICAgIFRoaXMgcGF0 Y2ggbWFrZSBzdXJlIGl0IHJlbWFpbnMgdGhlIHNhbWUgaW4gdGhlIGZ1dHVyZS4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxvYWRlci9jYWNoZS9D YWNoZWRGb250Q2xpZW50Lmg6CisgICAgICAgIE1ha2UgQ2FjaGVkRm9udENsaWVudDo6bm90aWZ5 RmluaXNoZWQgZmluYWwgdG8gbWFrZSBzdXJlCisgICAgICAgIHN1YiBjbGFzc2VzIGltcGxlbWVu dCBmb250TG9hZGVkIGluc3RlYWQuCisKKzIwMTUtMDItMDQgIEp1bGllbiBJc29yY2UgIDxqLmlz b3JjZUBzYW1zdW5nLmNvbT4KKwogICAgICAgICBSZW5kZXI6IHByb3Blcmx5IHVwZGF0ZSBib2R5 J3MgYmFja2dyb3VuZCBpbWFnZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQwMTgzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRGb250Q2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2Fj aGVkRm9udENsaWVudC5oCmluZGV4IGU4NzA0MGUuLjA0ODk4MjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRGb250Q2xpZW50LmgKKysrIGIvU291cmNlL1dl YkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEZvbnRDbGllbnQuaApAQCAtMzgsNiArMzgsOSBAQCBw dWJsaWM6CiAgICAgc3RhdGljIENhY2hlZFJlc291cmNlQ2xpZW50VHlwZSBleHBlY3RlZFR5cGUo KSB7IHJldHVybiBGb250VHlwZTsgfQogICAgIHZpcnR1YWwgQ2FjaGVkUmVzb3VyY2VDbGllbnRU eXBlIHJlc291cmNlQ2xpZW50VHlwZSgpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIGV4cGVjdGVk VHlwZSgpOyB9CiAgICAgdmlydHVhbCB2b2lkIGZvbnRMb2FkZWQoQ2FjaGVkRm9udCopIHsgfQor CisgICAgLy8gVXNlIGZvbnRMb2FkZWQgaW5zdGVhZC4KKyAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5 RmluaXNoZWQoQ2FjaGVkUmVzb3VyY2UqKSBvdmVycmlkZSBmaW5hbCB7IH0KIH07CiAKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKLS0gCjEuOS4xCgo=