141248 2015-02-04 07:40:55 -0800 [WinCairo] Crash when media player is destroyed. 2015-02-23 07:22:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue darin ossy oldest_to_newest 1066801 0 peavo 2015-02-04 07:40:55 -0800 A COM smart pointer is both released, and set to null. This means that the COM Release method is called twice, causing a crash. 1066802 1 246032 peavo 2015-02-04 07:44:44 -0800 Created attachment 246032 Patch 1066830 2 246032 darin 2015-02-04 09:19:37 -0800 Comment on attachment 246032 Patch I remember we found some trick to make it impossible to call deref() on a RefPtr, but I don’t remember what it was or if we did it. 1066843 3 peavo 2015-02-04 09:54:25 -0800 (In reply to comment #2) > Comment on attachment 246032 [details] > Patch > > I remember we found some trick to make it impossible to call deref() on a > RefPtr, but I don’t remember what it was or if we did it. I see, would be nice to have that in the COMPtr class aswell. Thanks for reviewing :) 1071187 4 peavo 2015-02-23 06:31:39 -0800 cq+ ? ;) 1071194 5 246032 commit-queue 2015-02-23 07:22:16 -0800 Comment on attachment 246032 Patch Clearing flags on attachment: 246032 Committed r180501: <http://trac.webkit.org/changeset/180501> 1071195 6 commit-queue 2015-02-23 07:22:22 -0800 All reviewed patches have been landed. Closing bug. 246032 2015-02-04 07:44:44 -0800 2015-02-23 07:22:16 -0800 Patch bug-141248-20150204164432.patch text/plain 1376 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTYwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAyLTA0ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ3Jh c2ggd2hlbiBtZWRpYSBwbGF5ZXIgaXMgZGVzdHJveWVkLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBDT00gc21hcnQgcG9pbnRlciBpcyBib3RoIHJl bGVhc2VkLCBhbmQgc2V0IHRvIG51bGwuCisgICAgICAgIFRoaXMgbWVhbnMgdGhhdCB0aGUgQ09N IFJlbGVhc2UgbWV0aG9kIGlzIGNhbGxlZCB0d2ljZSwgY2F1c2luZyBhIGNyYXNoLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRh dGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5k YXRpb246OmVuZFNlc3Npb24pOgorCiAyMDE1LTAyLTA0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIHJlbW92ZUZpcnN0KHZhbHVlKSAvIHJlbW92ZUFsbCh2 YWx1ZSkgbWV0aG9kcyB0byBXVEY6OlZlY3RvcgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAJKHJldmlzaW9uIDE3OTU0MSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZv dW5kYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDUsNyArMjQ1LDYgQEAgYm9vbCBNZWRp YVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OgogewogICAgIGlmIChtX21lZGlhU2Vzc2lv bikgewogICAgICAgICBtX21lZGlhU2Vzc2lvbi0+U2h1dGRvd24oKTsKLSAgICAgICAgbV9tZWRp YVNlc3Npb24tPlJlbGVhc2UoKTsKICAgICAgICAgbV9tZWRpYVNlc3Npb24gPSBudWxscHRyOwog ICAgIH0KIAo=