141238 2015-02-03 23:50:17 -0800 Perf dashboard doesn’t show the right unit for Safari UI tests 2016-02-16 13:52:15 -0800 1 1 1 Unclassified WebKit Perf Dashboard 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141237 1 rniwa rniwa benjamin cdumez commit-queue kling rniwa oldest_to_newest 1066763 0 rniwa 2015-02-03 23:50:17 -0800 I had to monkey-patch the perf dashboard to show the right unit for Safari UI tests. 1066764 1 246023 rniwa 2015-02-04 00:03:49 -0800 Created attachment 246023 Fixes the bug 1066842 2 246023 rniwa 2015-02-04 09:52:24 -0800 Comment on attachment 246023 Fixes the bug Thanks for the review! 1066858 3 246023 rniwa 2015-02-04 10:16:41 -0800 Comment on attachment 246023 Fixes the bug Clearing flags on attachment: 246023 Committed r179613: <http://trac.webkit.org/changeset/179613> 1066859 4 rniwa 2015-02-04 10:16:53 -0800 All reviewed patches have been landed. Closing bug. 246023 2015-02-04 00:03:49 -0800 2015-02-04 10:16:41 -0800 Fixes the bug bug-141238-20150204000348.patch text/plain 5430 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5NTk4KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE1LTAyLTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBlcmYgZGFzaGJvYXJkIGRvZXNu4oCZdCBzaG93IHRoZSByaWdodCB1bml0IGZv ciBTYWZhcmkgVUkgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0MTIzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFNhZmFyaSBVSSB0ZXN0cyB1c2UgY3VzdG9tIG1ldHJpY3MgdGhhdCBlbmQgd2l0 aCAiVGltZSIuIFRoaXMgcGF0Y2ggdGVhY2hlcyB0aGUgcGVyZiBkYXNoYm9hcmQgaG93IHRvCisg ICAgICAgIGdldCB0aGUgdW5pdCBmb3IgYSBnaXZlbiBtZXRyaWMgYmFzZWQgb24gdGhlIHN1ZmZp eCBvZiB0aGUgbWV0cmljIG5hbWUgaW5zdGVhZCBvZiBoYXJkLWNvZGluZyB0aGUgbWFwcGluZwor ICAgICAgICBiZXR3ZWVuIG1ldHJpY3MgYW5kIHRoZWlyIHVuaXRzLgorCisgICAgICAgICogcHVi bGljL2pzL2hlbHBlci1jbGFzc2VzLmpzOgorICAgICAgICAoUGVyZlRlc3RSdW5zKTogVXNlIHRo ZSBzdWZmaXggb2YgdGhlIG1ldHJpYyBuYW1lIHRvIGNvbXB1dGUgdGhlIHVuaXQuCisgICAgICAg ICogcHVibGljL3YyL21hbmlmZXN0LmpzOgorICAgICAgICAoQXBwLk1hbmlmZXN0LmZldGNoUnVu c1dpdGhQbGF0Zm9ybUFuZE1ldHJpYyk6IERpdHRvLiBBbHNvIHNldCAidXNlU0kiIHByb3BlcnR5 IGlmZiBmb3IgImJ5dGVzIi4KKyAgICAgICAgKiBwdWJsaWMvdjIvaW50ZXJhY3RpdmUtY2hhcnQu anM6CisgICAgICAgIChBcHAuSW50ZXJhY3RpdmVDaGFydENvbXBvbmVudC5fY29uc3RydWN0R3Jh cGhJZlBvc3NpYmxlKTogUmVzcGVjdCB1c2VTSS4gVXNlIHRvUHJlY2lzaW9uKDMpIG90aGVyd2lz ZS4KKyAgICAgICAgKEFwcC5JbnRlcmFjdGl2ZUNoYXJ0Q29tcG9uZW50Ll9yZWxheW91dERhdGFB bmRBeGVzKTogUGxhY2UgdGhlIHVuaXQgdmVydGljYWxseSBvbiB0aGUgbGVmdCBvZiB0aWNrcy4K KwogMjAxNS0wMi0wMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBEb27igJl0IHVzZSByZXBvc2l0b3J5IG5hbWVzIGFzIGlk4oCZcy4KSW5kZXg6IFdlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvanMvaGVscGVyLWNsYXNzZXMuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9qcy9oZWxwZXItY2xhc3Nlcy5qcwko cmV2aXNpb24gMTc5NTkxKQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9qcy9o ZWxwZXItY2xhc3Nlcy5qcwkod29ya2luZyBjb3B5KQpAQCAtMTUxLDE2ICsxNTEsMTQgQEAgZnVu Y3Rpb24gUGVyZlRlc3RSdW5zKG1ldHJpYywgcGxhdGZvcm0pIAogICAgIHZhciBjYWNoZWRVbml0 ID0gbnVsbDsKICAgICB2YXIgY2FjaGVkU2NhbGluZ0ZhY3RvciA9IG51bGw7CiAgICAgdmFyIGJh c2VsaW5lcyA9IHt9OworICAgIHZhciBzdWZmaXggPSBtZXRyaWMubmFtZS5tYXRjaCgnKFtBLXpd W2Etel0rfEZyYW1lUmF0ZSkkJylbMF07CiAgICAgdmFyIHVuaXQgPSB7J0NvbWJpbmVkJzogJycs IC8vIEFzc3VtZSBzbWFsbGVyIGlzIGJldHRlciBmb3Igbm93LgogICAgICAgICAnRnJhbWVSYXRl JzogJ2ZwcycsCiAgICAgICAgICdSdW5zJzogJy9zJywKICAgICAgICAgJ1RpbWUnOiAnbXMnLAog ICAgICAgICAnTWFsbG9jJzogJ0InLAotICAgICAgICAnSlNIZWFwJzogJ0InLAotICAgICAgICAn QWxsb2NhdGlvbnMnOiAnQicsCi0gICAgICAgICdFbmRBbGxvY2F0aW9ucyc6ICdCJywKLSAgICAg ICAgJ01heEFsbG9jYXRpb25zJzogJ0InLAotICAgICAgICAnTWVhbkFsbG9jYXRpb25zJzogJ0In fVttZXRyaWMubmFtZV07CisgICAgICAgICdIZWFwJzogJ0InLAorICAgICAgICAnQWxsb2NhdGlv bnMnOiAnQid9W3N1ZmZpeF07CiAKICAgICAvLyBXZSBjYW4ndCBkbyB0aGlzIGluIFBlcmZUZXN0 UmVzdWx0IGJlY2F1c2UgYWxsIHJlc3VsdHMgZm9yIGVhY2ggbWV0cmljIG5lZWQgdG8gc2hhcmUg dGhlIHNhbWUgdW5pdCBhbmQgdGhlIHNhbWUgc2NhbGluZyBmYWN0b3IuCiAgICAgZnVuY3Rpb24g Y29tcHV0ZVNjYWxpbmdGYWN0b3JJZk5lZWRlZCgpIHsKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Vi a2l0Lm9yZy9wdWJsaWMvdjIvaW50ZXJhY3RpdmUtY2hhcnQuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi c2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9pbnRlcmFjdGl2ZS1jaGFydC5qcwkocmV2 aXNpb24gMTc5NTkwKQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9pbnRl cmFjdGl2ZS1jaGFydC5qcwkod29ya2luZyBjb3B5KQpAQCAtNjYsNyArNjYsOCBAQCBBcHAuSW50 ZXJhY3RpdmVDaGFydENvbXBvbmVudCA9IEVtYmVyLkNvCiAgICAgICAgIH0KIAogICAgICAgICBp ZiAodGhpcy5nZXQoJ3Nob3dZQXhpcycpKSB7Ci0gICAgICAgICAgICB0aGlzLl95QXhpcyA9IGQz LnN2Zy5heGlzKCkuc2NhbGUodGhpcy5feSkub3JpZW50KCJsZWZ0IikudGlja3MoNikudGlja0Zv cm1hdChkMy5mb3JtYXQoInMiKSk7CisgICAgICAgICAgICB0aGlzLl95QXhpcyA9IGQzLnN2Zy5h eGlzKCkuc2NhbGUodGhpcy5feSkub3JpZW50KCJsZWZ0IikudGlja3MoNikudGlja0Zvcm1hdCgK KyAgICAgICAgICAgICAgICBjaGFydERhdGEudXNlU0kgPyBkMy5mb3JtYXQoInMiKSA6IGQzLmZv cm1hdCgiLjNnIikpOwogICAgICAgICAgICAgdGhpcy5feUF4aXNMYWJlbHMgPSBzdmcuYXBwZW5k KCJnIikKICAgICAgICAgICAgICAgICAuYXR0cigiY2xhc3MiLCAieSBheGlzIik7CiAgICAgICAg IH0KQEAgLTI5NSwxMiArMjk2LDExIEBAIEFwcC5JbnRlcmFjdGl2ZUNoYXJ0Q29tcG9uZW50ID0g RW1iZXIuQ28KICAgICAgICAgdGhpcy5feUF4aXNMYWJlbHMuY2FsbCh0aGlzLl95QXhpcyk7CiAg ICAgICAgIGlmICh0aGlzLl95QXhpc1VuaXRDb250YWluZXIpCiAgICAgICAgICAgICB0aGlzLl95 QXhpc1VuaXRDb250YWluZXIucmVtb3ZlKCk7CisgICAgICAgIHZhciB4ID0gLSAzICogdGhpcy5f cmVtOworICAgICAgICB2YXIgeSA9IHRoaXMuX2NvbnRlbnRIZWlnaHQgLyAyOwogICAgICAgICB0 aGlzLl95QXhpc1VuaXRDb250YWluZXIgPSB0aGlzLl95QXhpc0xhYmVscy5hcHBlbmQoInRleHQi KQotICAgICAgICAgICAgLmF0dHIoIngiLCAwLjUgKiB0aGlzLl9yZW0pCi0gICAgICAgICAgICAu YXR0cigieSIsIDAuMiAqIHRoaXMuX3JlbSkKLSAgICAgICAgICAgIC5hdHRyKCJkeSIsIDAuOCAq IHRoaXMuX3JlbSkKLSAgICAgICAgICAgIC5zdHlsZSgidGV4dC1hbmNob3IiLCAic3RhcnQiKQot ICAgICAgICAgICAgLnN0eWxlKCJ6LWluZGV4IiwgIjEwMCIpCisgICAgICAgICAgICAuYXR0cigi dHJhbnNmb3JtIiwgInJvdGF0ZSg5MCAwIDApIHRyYW5zbGF0ZSgiICsgeSArICIsICIgKyAoLXgp ICsgIikiKQorICAgICAgICAgICAgLnN0eWxlKCJ0ZXh0LWFuY2hvciIsICJtaWRkbGUiKQogICAg ICAgICAgICAgLnRleHQodGhpcy5feUF4aXNVbml0KTsKICAgICB9LAogICAgIF91cGRhdGVNYXJr ZWREb3RzOiBmdW5jdGlvbiAoKSB7CkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVi bGljL3YyL21hbmlmZXN0LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9y Zy9wdWJsaWMvdjIvbWFuaWZlc3QuanMJKHJldmlzaW9uIDE3OTU5MCkKKysrIFdlYnNpdGVzL3Bl cmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvbWFuaWZlc3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTI3 MiwxOCArMjcyLDE5IEBAIEFwcC5NYW5pZmVzdCA9IEVtYmVyLkNvbnRyb2xsZXIuZXh0ZW5kKHsK ICAgICAgICAgICAgIHZhciBwbGF0Zm9ybSA9IEFwcC5NYW5pZmVzdC5wbGF0Zm9ybShwbGF0Zm9y bUlkKTsKICAgICAgICAgICAgIHZhciBtZXRyaWMgPSBBcHAuTWFuaWZlc3QubWV0cmljKG1ldHJp Y0lkKTsKIAotICAgICAgICAgICAgLy8gRklYTUU6IEluY2x1ZGUgdGhpcyBpbmZvcm1hdGlvbiBp biBKU09OIGFuZCBwcm9jZXNzIGl0IGluIFJ1bnNEYXRhLmZldGNoUnVucwotICAgICAgICAgICAg dmFyIHVuaXQgPSB7J0NvbWJpbmVkJzogJycsIC8vIEFzc3VtZSBzbWFsbGVyIGlzIGJldHRlciBm b3Igbm93LgorICAgICAgICAgICAgdmFyIHN1ZmZpeCA9IG1ldHJpYy5nZXQoJ25hbWUnKS5tYXRj aCgnKFtBLXpdW2Etel0rfEZyYW1lUmF0ZSkkJylbMF07CisgICAgICAgICAgICB2YXIgdW5pdCA9 IHsKICAgICAgICAgICAgICAgICAnRnJhbWVSYXRlJzogJ2ZwcycsCi0gICAgICAgICAgICAgICAg J1J1bnMnOiAncnVucy9zJywKKyAgICAgICAgICAgICAgICAnUnVucyc6ICcvcycsCiAgICAgICAg ICAgICAgICAgJ1RpbWUnOiAnbXMnLAogICAgICAgICAgICAgICAgICdNYWxsb2MnOiAnYnl0ZXMn LAotICAgICAgICAgICAgICAgICdKU0hlYXAnOiAnYnl0ZXMnLAotICAgICAgICAgICAgICAgICdB bGxvY2F0aW9ucyc6ICdieXRlcycsCi0gICAgICAgICAgICAgICAgJ0VuZEFsbG9jYXRpb25zJzog J2J5dGVzJywKLSAgICAgICAgICAgICAgICAnTWF4QWxsb2NhdGlvbnMnOiAnYnl0ZXMnLAotICAg ICAgICAgICAgICAgICdNZWFuQWxsb2NhdGlvbnMnOiAnYnl0ZXMnfVttZXRyaWMuZ2V0KCduYW1l JyldOworICAgICAgICAgICAgICAgICdIZWFwJzogJ2J5dGVzJywKKyAgICAgICAgICAgICAgICAn QWxsb2NhdGlvbnMnOiAnYnl0ZXMnCisgICAgICAgICAgICB9W3N1ZmZpeF07CisKKyAgICAgICAg ICAgIC8vIEZJWE1FOiBJbmNsdWRlIHRoaXMgaW5mb3JtYXRpb24gaW4gSlNPTiBhbmQgcHJvY2Vz cyBpdCBpbiBSdW5zRGF0YS5mZXRjaFJ1bnMKICAgICAgICAgICAgIHJ1bnMudW5pdCA9IHVuaXQ7 CisgICAgICAgICAgICBydW5zLnVzZVNJID0gdW5pdCA9PSAnYnl0ZXMnOwogCiAgICAgICAgICAg ICByZXR1cm4ge3BsYXRmb3JtOiBwbGF0Zm9ybSwgbWV0cmljOiBtZXRyaWMsIHJ1bnM6IHJ1bnN9 OwogICAgICAgICB9KTsK