141236 2015-02-03 23:44:42 -0800 When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green 2015-02-04 10:00:08 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue oldest_to_newest 1066759 0 ap 2015-02-03 23:44:42 -0800 Right now, leaks bot fails with the below error and no leaks: "Exiting early after 50 crashes and 0 timeouts. 2655 tests run. 50 failures" This shouldn't be green. 1066762 1 246022 ap 2015-02-03 23:47:59 -0800 Created attachment 246022 proposed fix If we ever get the leaks bot to a state where there are no leaks at all, but failures do happen, this can be further tweaked to not show orange. This is too far away into the future to care about now. 1066848 2 246022 commit-queue 2015-02-04 10:00:05 -0800 Comment on attachment 246022 proposed fix Clearing flags on attachment: 246022 Committed r179608: <http://trac.webkit.org/changeset/179608> 1066849 3 commit-queue 2015-02-04 10:00:08 -0800 All reviewed patches have been landed. Closing bug. 246022 2015-02-03 23:47:59 -0800 2015-02-04 10:00:05 -0800 proposed fix LeaksTooGreen.txt text/plain 2085 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3OTU5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTAyLTAzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFdoZW4gdGVzdHMgZmFpbCBvbiBsZWFrcyBib3Qgc28gbXVjaCB0aGF0IHRo ZXJlIGFyZSBubyBsZWFrcyBkZXRlY3RlZCwgZGFzaGJvYXJkIGVycm9uZW91c2x5IHNob3dzIGdy ZWVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEy MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hi b2FyZC9TY3JpcHRzL0J1aWxkYm90TGVha3NRdWV1ZVZpZXcuanM6CisgICAgICAgIChCdWlsZGJv dExlYWtzUXVldWVWaWV3LnByb3RvdHlwZS51cGRhdGUuYXBwZW5kTGVha3NRdWV1ZVN0YXR1cyk6 CisKIDIwMTUtMDItMDMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIFdLUGFnZU5hdmlnYXRpb25DbGllbnQgYXMgQyBTUEkgYXJvdW5kIEFQSTo6 TmF2aWdhdGlvbkNsaWVudCwgYW5kIGFkb3B0IGluIFdLVFIKSW5kZXg6IFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL0J1aWxkYm90TGVha3NRdWV1ZVZpZXcuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJv YXJkL1NjcmlwdHMvQnVpbGRib3RMZWFrc1F1ZXVlVmlldy5qcwkocmV2aXNpb24gMTc5NDQzKQor KysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RMZWFrc1F1ZXVlVmlldy5qcwkod29ya2lu ZyBjb3B5KQpAQCAtNjUsNyArNjUsNyBAQCBCdWlsZGJvdExlYWtzUXVldWVWaWV3LnByb3RvdHlw ZSA9IHsKICAgICAgICAgICAgICAgICAgICAgICAgIHZhciBsZWFrc1ZpZXdlclVSTCA9IGl0ZXJh dGlvbi5yZXN1bHRVUkxzWyJ2aWV3IGxlYWtzIl07CiAgICAgICAgICAgICAgICAgICAgICAgICB2 YXIgc3RhdHVzID0gbmV3IFN0YXR1c0xpbmVWaWV3KG1lc3NhZ2VFbGVtZW50LCBTdGF0dXNMaW5l Vmlldy5TdGF0dXMuTmV1dHJhbCwgbGVha0NvdW50ID09PSAxID8gInVuaXF1ZSBsZWFrIiA6ICJ1 bmlxdWUgbGVha3MiLCBsZWFrQ291bnQsIGxlYWtzVmlld2VyVVJMKTsKICAgICAgICAgICAgICAg ICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAgICAgICAgICB2YXIgc3RhdHVzID0gbmV3IFN0 YXR1c0xpbmVWaWV3KG1lc3NhZ2VFbGVtZW50LCBTdGF0dXNMaW5lVmlldy5TdGF0dXMuR29vZCwg aXRlcmF0aW9uLnRleHQsIG51bGwsIGJ1aWxkUGFnZVVSTCk7CisgICAgICAgICAgICAgICAgICAg ICAgICB2YXIgc3RhdHVzID0gbmV3IFN0YXR1c0xpbmVWaWV3KG1lc3NhZ2VFbGVtZW50LCBTdGF0 dXNMaW5lVmlldy5TdGF0dXMuRGFuZ2VyLCBpdGVyYXRpb24udGV4dCwgbnVsbCwgYnVpbGRQYWdl VVJMKTsKICAgICAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICB2YXIg dXJsID0gaXRlcmF0aW9uLnF1ZXVlLmJ1aWxkYm90LmJ1aWxkUGFnZVVSTEZvckl0ZXJhdGlvbihp dGVyYXRpb24pOwogICAgICAgICAgICAgICAgICAgICB2YXIgc3RhdHVzID0gbmV3IFN0YXR1c0xp bmVWaWV3KG1lc3NhZ2VFbGVtZW50LCBTdGF0dXNMaW5lVmlldy5TdGF0dXMuRGFuZ2VyLCBpdGVy YXRpb24udGV4dCwgbnVsbCwgYnVpbGRQYWdlVVJMKTsK