141230 2015-02-03 21:21:13 -0800 Regression(r179584): Assertion hit in toResourceLoadPriority() on Yosemite 2015-02-03 22:25:12 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141186 1 cdumez cdumez ap koivisto oldest_to_newest 1066723 0 cdumez 2015-02-03 21:21:13 -0800 Regression(r179584): Assertion hit in toResourceLoadPriority() on Yosemite: SHOULD NEVER BE REACHED /Volumes/Data/slave/yosemite-debug/build/Source/WebCore/platform/network/cf/ResourceRequestCFNet.h(58) : WebCore::ResourceLoadPriority WebCore::toResourceLoadPriority(int) 1 0x10f2de430 WTFCrash 2 0x1149ae111 WebCore::toResourceLoadPriority(int) 3 0x1149ac9ed WebCore::ResourceRequest::doUpdateResourceRequest() 4 0x1149a97e2 WebCore::ResourceRequestBase::updateResourceRequest(WebCore::HTTPBodyUpdatePolicy) const 5 0x1149aa29e WebCore::ResourceRequestBase::url() const 6 0x11a5306de -[WebFrame loadRequest:] 7 0x10e634fa5 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) 8 0x10e633ada runTestingServerLoop() 9 0x10e63326a dumpRenderTree(int, char const**) 10 0x10e635906 DumpRenderTreeMain(int, char const**) 11 0x10e6855c2 main 12 0x7fff880015c9 start Not sure what's happening yet. The CFNetwork doc (CFURLRequestPriority) does not indicate -1 as being a valid resource load priority value. 1066725 1 246014 cdumez 2015-02-03 21:24:52 -0800 Created attachment 246014 Patch 1066727 2 ap 2015-02-03 21:36:27 -0800 > The CFNetwork doc (CFURLRequestPriority) does not indicate -1 as being a valid resource load priority value. I recall that we define custom priority levels and don't use normal CFNetwork ones. Perhaps -1 is one of those? 1066728 3 cdumez 2015-02-03 21:39:40 -0800 (In reply to comment #2) > > The CFNetwork doc (CFURLRequestPriority) does not indicate -1 as being a valid resource load priority value. > > I recall that we define custom priority levels and don't use normal > CFNetwork ones. Perhaps -1 is one of those? Where would those be? We always call toResourceLoadPriority(wkGetHTTPRequestPriority()). I looked at the wkGetHTTPRequestPriority() implementation but couldn't find anything custom. 1066731 4 cdumez 2015-02-03 21:43:26 -0800 Also, when calling wkSetHTTPRequestPriority(), we always use toPlatformRequestPriority() on the priority. I took care in r179584 to remove -1 from that function already so we should never be setting -1 ourselves. 1066732 5 ap 2015-02-03 21:49:22 -0800 Looking at CFURLRequest.h, CFURLRequestPriority is documented to have values from 0 to 2. However, we call WKSetHTTPRequestMaximumPriority to change that, and use values up to 4. This indeed doesn't answer the question of where -1 comes from. Did you check CFNetwork source code? 1066733 6 cdumez 2015-02-03 21:51:27 -0800 (In reply to comment #5) > Looking at CFURLRequest.h, CFURLRequestPriority is documented to have values > from 0 to 2. However, we call WKSetHTTPRequestMaximumPriority to change > that, and use values up to 4. > > This indeed doesn't answer the question of where -1 comes from. Did you > check CFNetwork source code? Yes, this is what I am currently doing (so far no explanation though). I still think we should land this patch in the mean time though to make the bots happy. We were handling -1 in this function prior to r179584 already. 1066742 7 246014 cdumez 2015-02-03 22:25:06 -0800 Comment on attachment 246014 Patch Clearing flags on attachment: 246014 Committed r179593: <http://trac.webkit.org/changeset/179593> 1066743 8 cdumez 2015-02-03 22:25:12 -0800 All reviewed patches have been landed. Closing bug. 246014 2015-02-03 21:24:52 -0800 2015-02-03 22:25:06 -0800 Patch bug-141230-20150203212451.patch text/plain 1606 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMzZjI2NmNlZDFiZmFi MDA0ZWUwYzU5MTYzNzkwNjBlNjA1MGRhZi4uNGYzYTBmYzZiYmUwYjk1NjUwYTVmMjFiZmMxMzk3 MmZiMDVkNmE2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTAyLTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVncmVzc2lvbihyMTc5NTg0 KTogQXNzZXJ0aW9uIGhpdCBpbiB0b1Jlc291cmNlTG9hZFByaW9yaXR5KCkgb24gWW9zZW1pdGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTIzMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhbmRsZSAt MSBwcmlvcml0eSB2YWx1ZSBhZ2FpbiBpbiB0b1Jlc291cmNlTG9hZFByaW9yaXR5KCkgYXMgaXQg c2VlbXMgdG8KKyAgICAgICAgYmUgcmV0dXJuZWQgYnkgQ0ZOZXR3b3JrIG9uIHNvbWUgY29uZmln dXJhdGlvbnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5IGNvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVx dWVzdENGTmV0Lmg6CisgICAgICAgIChXZWJDb3JlOjp0b1Jlc291cmNlTG9hZFByaW9yaXR5KToK KworMjAxNS0wMi0wMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAg IERyb3AgUmVzb3VyY2VMb2FkUHJpb3JpdHlVbnJlc29sdmVkIHJlc291cmNlIGxvYWQgcHJpb3Jp dHkgYW5kIHVzZSBPcHRpb25hbDw+IGluc3RlYWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTE4NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVxdWVzdENGTmV0LmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVxdWVzdENGTmV0LmgKaW5kZXggNzY5 YzhlNTk2NDY5MThlYzI1YTA5MDFhZjE2ZGFjZjNiMDJjOWYwNy4uNWU5YWI4MDE1ZGIzZjg3NTM4 ZjZkNDY1YmYwZmU4NmViZDM3MGU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jZi9SZXNvdXJjZVJlcXVlc3RDRk5ldC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXF1ZXN0Q0ZOZXQuaApAQCAtNDQsNiArNDQs NyBAQCBDRlVSTFJlcXVlc3RSZWYgY2ZVUkxSZXF1ZXN0KGNvbnN0IFJlc291cmNlUmVxdWVzdCYp OwogaW5saW5lIFJlc291cmNlTG9hZFByaW9yaXR5IHRvUmVzb3VyY2VMb2FkUHJpb3JpdHkoaW50 IHByaW9yaXR5KQogewogICAgIHN3aXRjaCAocHJpb3JpdHkpIHsKKyAgICBjYXNlIC0xOgogICAg IGNhc2UgMDoKICAgICAgICAgcmV0dXJuIFJlc291cmNlTG9hZFByaW9yaXR5VmVyeUxvdzsKICAg ICBjYXNlIDE6Cg==