141224 2015-02-03 17:40:33 -0800 Every PageOverlayClientImpl leaks 2015-02-03 17:58:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca mitz sam simon.fraser oldest_to_newest 1066669 0 thorton 2015-02-03 17:40:33 -0800 Every PageOverlayClientImpl leaks 1066670 1 245997 thorton 2015-02-03 17:40:51 -0800 Created attachment 245997 Patch 1066671 2 thorton 2015-02-03 17:41:15 -0800 rdar://problem/19652939 1066677 3 245997 simon.fraser 2015-02-03 17:51:24 -0800 Comment on attachment 245997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245997&action=review > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:105 > + std::unique_ptr<Client> m_client; It's weird for thing to own its client, but perhaps this isn't a client in the normal sense. 1066678 4 thorton 2015-02-03 17:56:42 -0800 (In reply to comment #3) > Comment on attachment 245997 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245997&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:105 > > + std::unique_ptr<Client> m_client; > > It's weird for thing to own its client, but perhaps this isn't a client in > the normal sense. These are internal-ish client wrapper-ish things; it's not that weird, all of the API clients (Loader, Policy, etc.) on WKPage work exactly the same way. 1066680 5 thorton 2015-02-03 17:58:37 -0800 http://trac.webkit.org/changeset/179586 245997 2015-02-03 17:40:51 -0800 2015-02-03 17:51:24 -0800 Patch bug-141224-20150203174051.patch text/plain 9375 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTIyM2IxMzQxZWY0N2My NzMxN2JhODg5OGFlOGM3NzUzYzM1YWFmMi4uMDA4YWRkZGNjZGRmNWQwZTRkYTIzNjUwZmJmMzgz YmY5N2MyYjYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE1LTAyLTAzICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBFdmVyeSBQ YWdlT3ZlcmxheUNsaWVudEltcGwgbGVha3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MTIyNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTk2NTI5 Mzk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZU92ZXJsYXkuY3BwOgor ICAgICAgICAoV0tCdW5kbGVQYWdlT3ZlcmxheUNyZWF0ZSk6CisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2VPdmVybGF5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZU92 ZXJsYXk6OmNyZWF0ZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VPdmVybGF5OjpXZWJQYWdl T3ZlcmxheSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VPdmVybGF5OjpwYWdlT3ZlcmxheURl c3Ryb3llZCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VPdmVybGF5Ojp3aWxsTW92ZVRvUGFn ZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VPdmVybGF5OjpkaWRNb3ZlVG9QYWdlKToKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZU92ZXJsYXk6OmRyYXdSZWN0KToKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZU92ZXJsYXk6Om1vdXNlRXZlbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdl T3ZlcmxheTo6ZGlkU2Nyb2xsRnJhbWUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlT3Zlcmxh eTo6YWN0aW9uQ29udGV4dEZvclJlc3VsdEF0UG9pbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQ YWdlT3ZlcmxheTo6ZGF0YURldGVjdG9yc0RpZFByZXNlbnRVSSk6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2VPdmVybGF5OjpkYXRhRGV0ZWN0b3JzRGlkQ2hhbmdlVUkpOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlT3ZlcmxheTo6ZGF0YURldGVjdG9yc0RpZEhpZGVVSSk6CisgICAgICAgIChX ZWJLaXQ6OldlYlBhZ2VPdmVybGF5Ojpjb3B5QWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVN0cmluZ1Zh bHVlRm9yUG9pbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlT3ZlcmxheTo6Y29weUFjY2Vz c2liaWxpdHlBdHRyaWJ1dGVCb29sVmFsdWVGb3JQb2ludCk6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2VPdmVybGF5Ojpjb3B5QWNjZXNzaWJpbGl0eUF0dHJpYnV0ZU5hbWVzKToKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZU92ZXJsYXkuaDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUGFnZU92ZXJsYXk6OmNsaWVudCk6CisgICAgICAgIEtlZXAgdGhlIFBhZ2VPdmVybGF5Q2xp ZW50SW1wbCBhcyBhIHVuaXF1ZV9wdHIgaW5zdGVhZCBvZiBhIGxlYWtlZCByZWZlcmVuY2UsCisg ICAgICAgIGVuc3VyaW5nIHRoYXQgaXQncyBjbGVhbmVkIHVwIHdoZW4gdGhlIFdlYlBhZ2VPdmVy bGF5IGlzIHRvcm4gZG93bi4KKwogMjAxNS0wMi0wMyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBh cHBsZS5jb20+CiAKICAgICAgICAgTWVtb3J5IGNhY2hlIGZvciByZXNvdXJjZXMgcGVuZGluZyBk aXNrIHdyaXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVk QnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZU92ZXJsYXkuY3BwIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2VPdmVybGF5LmNwcAppbmRl eCA1N2M1OTU0YjZmOWUyNmUyZDdmNTZjYzMwZmI4YzU2ZWNkN2Q0ODFkLi5hZTQ1YWFmMjlkZDYx MTNkMDg4NTJkMzllYjgwMTMyMzJkNDczZDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZU92ZXJsYXkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5k bGVQYWdlT3ZlcmxheS5jcHAKQEAgLTIyNCw5ICsyMjQsNyBAQCBXS1R5cGVJRCBXS0J1bmRsZVBh Z2VPdmVybGF5R2V0VHlwZUlEKCkKIFdLQnVuZGxlUGFnZU92ZXJsYXlSZWYgV0tCdW5kbGVQYWdl T3ZlcmxheUNyZWF0ZShXS0J1bmRsZVBhZ2VPdmVybGF5Q2xpZW50QmFzZSogd2tDbGllbnQpCiB7 CiAgICAgYXV0byBjbGllbnRJbXBsID0gc3RkOjptYWtlX3VuaXF1ZTxQYWdlT3ZlcmxheUNsaWVu dEltcGw+KHdrQ2xpZW50KTsKLQotICAgIC8vIEZJWE1FOiBMb29rcyBsaWtlIHRoaXMgbGVha3Mg dGhlIGNsaWVudEltcGwuCi0gICAgcmV0dXJuIHRvQVBJKFdlYlBhZ2VPdmVybGF5OjpjcmVhdGUo KmNsaWVudEltcGwucmVsZWFzZSgpKS5sZWFrUmVmKCkpOworICAgIHJldHVybiB0b0FQSShXZWJQ YWdlT3ZlcmxheTo6Y3JlYXRlKFdURjo6bW92ZShjbGllbnRJbXBsKSkubGVha1JlZigpKTsKIH0K IAogdm9pZCBXS0J1bmRsZVBhZ2VPdmVybGF5U2V0QWNjZXNzaWJpbGl0eUNsaWVudChXS0J1bmRs ZVBhZ2VPdmVybGF5UmVmIGJ1bmRsZVBhZ2VPdmVybGF5UmVmLCBXS0J1bmRsZVBhZ2VPdmVybGF5 QWNjZXNzaWJpbGl0eUNsaWVudEJhc2UqIGNsaWVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlT3ZlcmxheS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZU92ZXJsYXkuY3BwCmluZGV4IGRiOTg2NWNiNTUy YzYwOTgxMDU1MWNjOTdhNzYwOGRlYzExYjhmNDQuLjllNDA4NmU5YzIzMjY2NmIyYWIxZGFmMTFk ZDM1YWQ2ZGQ5ZjhkMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlT3ZlcmxheS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2VPdmVybGF5LmNwcApAQCAtNDIsMTUgKzQyLDE2IEBAIHN0YXRpYyBIYXNo TWFwPFBhZ2VPdmVybGF5KiwgV2ViUGFnZU92ZXJsYXkqPiYgb3ZlcmxheU1hcCgpCiAgICAgcmV0 dXJuIG1hcDsKIH0KIAotUGFzc1JlZlB0cjxXZWJQYWdlT3ZlcmxheT4gV2ViUGFnZU92ZXJsYXk6 OmNyZWF0ZShXZWJQYWdlT3ZlcmxheTo6Q2xpZW50JiBjbGllbnQsIFBhZ2VPdmVybGF5OjpPdmVy bGF5VHlwZSBvdmVybGF5VHlwZSkKK1Bhc3NSZWZQdHI8V2ViUGFnZU92ZXJsYXk+IFdlYlBhZ2VP dmVybGF5OjpjcmVhdGUoc3RkOjp1bmlxdWVfcHRyPFdlYlBhZ2VPdmVybGF5OjpDbGllbnQ+IGNs aWVudCwgUGFnZU92ZXJsYXk6Ok92ZXJsYXlUeXBlIG92ZXJsYXlUeXBlKQogewotICAgIHJldHVy biBhZG9wdFJlZihuZXcgV2ViUGFnZU92ZXJsYXkoY2xpZW50LCBvdmVybGF5VHlwZSkpOworICAg IHJldHVybiBhZG9wdFJlZihuZXcgV2ViUGFnZU92ZXJsYXkoV1RGOjptb3ZlKGNsaWVudCksIG92 ZXJsYXlUeXBlKSk7CiB9CiAKLVdlYlBhZ2VPdmVybGF5OjpXZWJQYWdlT3ZlcmxheShXZWJQYWdl T3ZlcmxheTo6Q2xpZW50JiBjbGllbnQsIFBhZ2VPdmVybGF5OjpPdmVybGF5VHlwZSBvdmVybGF5 VHlwZSkKK1dlYlBhZ2VPdmVybGF5OjpXZWJQYWdlT3ZlcmxheShzdGQ6OnVuaXF1ZV9wdHI8V2Vi UGFnZU92ZXJsYXk6OkNsaWVudD4gY2xpZW50LCBQYWdlT3ZlcmxheTo6T3ZlcmxheVR5cGUgb3Zl cmxheVR5cGUpCiAgICAgOiBtX292ZXJsYXkoUGFnZU92ZXJsYXk6OmNyZWF0ZSgqdGhpcywgb3Zl cmxheVR5cGUpKQotICAgICwgbV9jbGllbnQoY2xpZW50KQorICAgICwgbV9jbGllbnQoV1RGOjpt b3ZlKGNsaWVudCkpCiB7CisgICAgQVNTRVJUKG1fY2xpZW50KTsKICAgICBvdmVybGF5TWFwKCku YWRkKG1fb3ZlcmxheS5nZXQoKSwgdGhpcyk7CiB9CiAKQEAgLTkwLDY5ICs5MSw2OSBAQCB2b2lk IFdlYlBhZ2VPdmVybGF5OjpwYWdlT3ZlcmxheURlc3Ryb3llZChQYWdlT3ZlcmxheSYpCiAgICAg ICAgIG1fb3ZlcmxheSA9IG51bGxwdHI7CiAgICAgfQogCi0gICAgbV9jbGllbnQucGFnZU92ZXJs YXlEZXN0cm95ZWQoKnRoaXMpOworICAgIG1fY2xpZW50LT5wYWdlT3ZlcmxheURlc3Ryb3llZCgq dGhpcyk7CiB9CiAKIHZvaWQgV2ViUGFnZU92ZXJsYXk6OndpbGxNb3ZlVG9QYWdlKFBhZ2VPdmVy bGF5JiwgUGFnZSogcGFnZSkKIHsKLSAgICBtX2NsaWVudC53aWxsTW92ZVRvUGFnZSgqdGhpcywg cGFnZSA/IFdlYlBhZ2U6OmZyb21Db3JlUGFnZShwYWdlKSA6IG51bGxwdHIpOworICAgIG1fY2xp ZW50LT53aWxsTW92ZVRvUGFnZSgqdGhpcywgcGFnZSA/IFdlYlBhZ2U6OmZyb21Db3JlUGFnZShw YWdlKSA6IG51bGxwdHIpOwogfQogCiB2b2lkIFdlYlBhZ2VPdmVybGF5OjpkaWRNb3ZlVG9QYWdl KFBhZ2VPdmVybGF5JiwgUGFnZSogcGFnZSkKIHsKLSAgICBtX2NsaWVudC5kaWRNb3ZlVG9QYWdl KCp0aGlzLCBwYWdlID8gV2ViUGFnZTo6ZnJvbUNvcmVQYWdlKHBhZ2UpIDogbnVsbHB0cik7Cisg ICAgbV9jbGllbnQtPmRpZE1vdmVUb1BhZ2UoKnRoaXMsIHBhZ2UgPyBXZWJQYWdlOjpmcm9tQ29y ZVBhZ2UocGFnZSkgOiBudWxscHRyKTsKIH0KIAogdm9pZCBXZWJQYWdlT3ZlcmxheTo6ZHJhd1Jl Y3QoUGFnZU92ZXJsYXkmLCBHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGNvbnN0IEludFJlY3Qm IGRpcnR5UmVjdCkKIHsKLSAgICBtX2NsaWVudC5kcmF3UmVjdCgqdGhpcywgY29udGV4dCwgZGly dHlSZWN0KTsKKyAgICBtX2NsaWVudC0+ZHJhd1JlY3QoKnRoaXMsIGNvbnRleHQsIGRpcnR5UmVj dCk7CiB9CiAKIGJvb2wgV2ViUGFnZU92ZXJsYXk6Om1vdXNlRXZlbnQoUGFnZU92ZXJsYXkmLCBj b25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmIGV2ZW50KQogewotICAgIHJldHVybiBtX2NsaWVudC5t b3VzZUV2ZW50KCp0aGlzLCBldmVudCk7CisgICAgcmV0dXJuIG1fY2xpZW50LT5tb3VzZUV2ZW50 KCp0aGlzLCBldmVudCk7CiB9CiAKIHZvaWQgV2ViUGFnZU92ZXJsYXk6OmRpZFNjcm9sbEZyYW1l KFBhZ2VPdmVybGF5JiwgRnJhbWUmIGZyYW1lKQogewotICAgIG1fY2xpZW50LmRpZFNjcm9sbEZy YW1lKCp0aGlzLCBXZWJGcmFtZTo6ZnJvbUNvcmVGcmFtZShmcmFtZSkpOworICAgIG1fY2xpZW50 LT5kaWRTY3JvbGxGcmFtZSgqdGhpcywgV2ViRnJhbWU6OmZyb21Db3JlRnJhbWUoZnJhbWUpKTsK IH0KIAogI2lmIFBMQVRGT1JNKE1BQykKIEREQWN0aW9uQ29udGV4dCAqV2ViUGFnZU92ZXJsYXk6 OmFjdGlvbkNvbnRleHRGb3JSZXN1bHRBdFBvaW50KEZsb2F0UG9pbnQgbG9jYXRpb24sIFJlZlB0 cjxXZWJDb3JlOjpSYW5nZT4mIHJhbmdlSGFuZGxlKQogewotICAgIHJldHVybiBtX2NsaWVudC5h Y3Rpb25Db250ZXh0Rm9yUmVzdWx0QXRQb2ludCgqdGhpcywgbG9jYXRpb24sIHJhbmdlSGFuZGxl KTsKKyAgICByZXR1cm4gbV9jbGllbnQtPmFjdGlvbkNvbnRleHRGb3JSZXN1bHRBdFBvaW50KCp0 aGlzLCBsb2NhdGlvbiwgcmFuZ2VIYW5kbGUpOwogfQogCiB2b2lkIFdlYlBhZ2VPdmVybGF5Ojpk YXRhRGV0ZWN0b3JzRGlkUHJlc2VudFVJKCkKIHsKLSAgICBtX2NsaWVudC5kYXRhRGV0ZWN0b3Jz RGlkUHJlc2VudFVJKCp0aGlzKTsKKyAgICBtX2NsaWVudC0+ZGF0YURldGVjdG9yc0RpZFByZXNl bnRVSSgqdGhpcyk7CiB9CiAKIHZvaWQgV2ViUGFnZU92ZXJsYXk6OmRhdGFEZXRlY3RvcnNEaWRD aGFuZ2VVSSgpCiB7Ci0gICAgbV9jbGllbnQuZGF0YURldGVjdG9yc0RpZENoYW5nZVVJKCp0aGlz KTsKKyAgICBtX2NsaWVudC0+ZGF0YURldGVjdG9yc0RpZENoYW5nZVVJKCp0aGlzKTsKIH0KIAog dm9pZCBXZWJQYWdlT3ZlcmxheTo6ZGF0YURldGVjdG9yc0RpZEhpZGVVSSgpCiB7Ci0gICAgbV9j bGllbnQuZGF0YURldGVjdG9yc0RpZEhpZGVVSSgqdGhpcyk7CisgICAgbV9jbGllbnQtPmRhdGFE ZXRlY3RvcnNEaWRIaWRlVUkoKnRoaXMpOwogfQogI2VuZGlmIC8vIFBMQVRGT1JNKE1BQykKIAog Ym9vbCBXZWJQYWdlT3ZlcmxheTo6Y29weUFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVTdHJpbmdWYWx1 ZUZvclBvaW50KFBhZ2VPdmVybGF5JiwgU3RyaW5nIGF0dHJpYnV0ZSwgRmxvYXRQb2ludCBwYXJh bWV0ZXIsIFN0cmluZyYgdmFsdWUpCiB7Ci0gICAgcmV0dXJuIG1fY2xpZW50LmNvcHlBY2Nlc3Np YmlsaXR5QXR0cmlidXRlU3RyaW5nVmFsdWVGb3JQb2ludCgqdGhpcywgYXR0cmlidXRlLCBwYXJh bWV0ZXIsIHZhbHVlKTsKKyAgICByZXR1cm4gbV9jbGllbnQtPmNvcHlBY2Nlc3NpYmlsaXR5QXR0 cmlidXRlU3RyaW5nVmFsdWVGb3JQb2ludCgqdGhpcywgYXR0cmlidXRlLCBwYXJhbWV0ZXIsIHZh bHVlKTsKIH0KIAogYm9vbCBXZWJQYWdlT3ZlcmxheTo6Y29weUFjY2Vzc2liaWxpdHlBdHRyaWJ1 dGVCb29sVmFsdWVGb3JQb2ludChQYWdlT3ZlcmxheSYsIFN0cmluZyBhdHRyaWJ1dGUsIEZsb2F0 UG9pbnQgcGFyYW1ldGVyLCBib29sJiB2YWx1ZSkKIHsKLSAgICByZXR1cm4gbV9jbGllbnQuY29w eUFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVCb29sVmFsdWVGb3JQb2ludCgqdGhpcywgYXR0cmlidXRl LCBwYXJhbWV0ZXIsIHZhbHVlKTsKKyAgICByZXR1cm4gbV9jbGllbnQtPmNvcHlBY2Nlc3NpYmls aXR5QXR0cmlidXRlQm9vbFZhbHVlRm9yUG9pbnQoKnRoaXMsIGF0dHJpYnV0ZSwgcGFyYW1ldGVy LCB2YWx1ZSk7CiB9CiAKIFZlY3RvcjxTdHJpbmc+IFdlYlBhZ2VPdmVybGF5Ojpjb3B5QWNjZXNz aWJpbGl0eUF0dHJpYnV0ZU5hbWVzKFBhZ2VPdmVybGF5JiwgYm9vbCBwYXJhbWV0ZXJpemVkTmFt ZXMpCiB7Ci0gICAgcmV0dXJuIG1fY2xpZW50LmNvcHlBY2Nlc3NpYmlsaXR5QXR0cmlidXRlTmFt ZXMoKnRoaXMsIHBhcmFtZXRlcml6ZWROYW1lcyk7CisgICAgcmV0dXJuIG1fY2xpZW50LT5jb3B5 QWNjZXNzaWJpbGl0eUF0dHJpYnV0ZU5hbWVzKCp0aGlzLCBwYXJhbWV0ZXJpemVkTmFtZXMpOwog fQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlT3ZlcmxheS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2VPdmVybGF5LmgKaW5kZXggNTc2ZjVhOTc1N2Y3MzVmN2JmODc1 M2RjNGFmMzhhYWMxNTY2YjA4ZS4uZmJiZTYyYTJhMjg1MWYzNjg5NmY2ZjA2Mjc3OThhOGE2NjA3 ZjFhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2VPdmVybGF5LmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2VPdmVybGF5LmgKQEAgLTQ0LDEwICs0NCw5IEBAIGNsYXNzIFdlYlBhZ2U7CiBjbGFzcyBXZWJQ YWdlT3ZlcmxheSA6IHB1YmxpYyBBUEk6Ok9iamVjdEltcGw8QVBJOjpPYmplY3Q6OlR5cGU6OkJ1 bmRsZVBhZ2VPdmVybGF5PiwgcHJpdmF0ZSBXZWJDb3JlOjpQYWdlT3ZlcmxheTo6Q2xpZW50IHsK IHB1YmxpYzoKICAgICBjbGFzcyBDbGllbnQgewotICAgIHByb3RlY3RlZDoKKyAgICBwdWJsaWM6 CiAgICAgICAgIHZpcnR1YWwgfkNsaWVudCgpIHsgfQogCi0gICAgcHVibGljOgogICAgICAgICB2 aXJ0dWFsIHZvaWQgcGFnZU92ZXJsYXlEZXN0cm95ZWQoV2ViUGFnZU92ZXJsYXkmKSA9IDA7CiAg ICAgICAgIHZpcnR1YWwgdm9pZCB3aWxsTW92ZVRvUGFnZShXZWJQYWdlT3ZlcmxheSYsIFdlYlBh Z2UqKSA9IDA7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRNb3ZlVG9QYWdlKFdlYlBhZ2VPdmVy bGF5JiwgV2ViUGFnZSopID0gMDsKQEAgLTY3LDcgKzY2LDcgQEAgcHVibGljOgogICAgICAgICB2 aXJ0dWFsIFZlY3RvcjxTdHJpbmc+IGNvcHlBY2Nlc3NpYmlsaXR5QXR0cmlidXRlTmFtZXMoV2Vi UGFnZU92ZXJsYXkmLCBib29sIC8qIHBhcmFtZXRlcml6ZWROYW1lcyAqLykgeyByZXR1cm4gVmVj dG9yPFN0cmluZz4oKTsgfQogICAgIH07CiAKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxXZWJQYWdl T3ZlcmxheT4gY3JlYXRlKENsaWVudCYsIFdlYkNvcmU6OlBhZ2VPdmVybGF5OjpPdmVybGF5VHlw ZSA9IFdlYkNvcmU6OlBhZ2VPdmVybGF5OjpPdmVybGF5VHlwZTo6Vmlldyk7CisgICAgc3RhdGlj IFBhc3NSZWZQdHI8V2ViUGFnZU92ZXJsYXk+IGNyZWF0ZShzdGQ6OnVuaXF1ZV9wdHI8Q2xpZW50 PiwgV2ViQ29yZTo6UGFnZU92ZXJsYXk6Ok92ZXJsYXlUeXBlID0gV2ViQ29yZTo6UGFnZU92ZXJs YXk6Ok92ZXJsYXlUeXBlOjpWaWV3KTsKICAgICBzdGF0aWMgV2ViUGFnZU92ZXJsYXkqIGZyb21D b3JlT3ZlcmxheShXZWJDb3JlOjpQYWdlT3ZlcmxheSYpOwogICAgIHZpcnR1YWwgfldlYlBhZ2VP dmVybGF5KCk7CiAKQEAgLTc3LDcgKzc2LDcgQEAgcHVibGljOgogICAgIHZvaWQgY2xlYXIoKTsK IAogICAgIFdlYkNvcmU6OlBhZ2VPdmVybGF5KiBjb3JlT3ZlcmxheSgpIGNvbnN0IHsgcmV0dXJu IG1fb3ZlcmxheS5nZXQoKTsgfQotICAgIENsaWVudCYgY2xpZW50KCkgY29uc3QgeyByZXR1cm4g bV9jbGllbnQ7IH0KKyAgICBDbGllbnQmIGNsaWVudCgpIGNvbnN0IHsgcmV0dXJuICptX2NsaWVu dDsgfQogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIEREQWN0aW9uQ29udGV4dCAqYWN0aW9uQ29u dGV4dEZvclJlc3VsdEF0UG9pbnQoV2ViQ29yZTo6RmxvYXRQb2ludCwgUmVmUHRyPFdlYkNvcmU6 OlJhbmdlPiYpOwpAQCAtODcsNyArODYsNyBAQCBwdWJsaWM6CiAjZW5kaWYKIAogcHJpdmF0ZToK LSAgICBXZWJQYWdlT3ZlcmxheShDbGllbnQmLCBXZWJDb3JlOjpQYWdlT3ZlcmxheTo6T3Zlcmxh eVR5cGUpOworICAgIFdlYlBhZ2VPdmVybGF5KHN0ZDo6dW5pcXVlX3B0cjxDbGllbnQ+LCBXZWJD b3JlOjpQYWdlT3ZlcmxheTo6T3ZlcmxheVR5cGUpOwogCiAgICAgLy8gV2ViQ29yZTo6UGFnZU92 ZXJsYXk6OkNsaWVudAogICAgIHZpcnR1YWwgdm9pZCBwYWdlT3ZlcmxheURlc3Ryb3llZChXZWJD b3JlOjpQYWdlT3ZlcmxheSYpIG92ZXJyaWRlOwpAQCAtMTAzLDcgKzEwMiw3IEBAIHByaXZhdGU6 CiAKIAogICAgIFJlZlB0cjxXZWJDb3JlOjpQYWdlT3ZlcmxheT4gbV9vdmVybGF5OwotICAgIENs aWVudCYgbV9jbGllbnQ7CisgICAgc3RkOjp1bmlxdWVfcHRyPENsaWVudD4gbV9jbGllbnQ7CiB9 OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK