141220 2015-02-03 17:06:37 -0800 /api/runs.php should have main function 2015-02-03 17:47:38 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141226 1 rniwa rniwa benjamin kling oldest_to_newest 1066648 0 rniwa 2015-02-03 17:06:37 -0800 Wrap the code inside main function for clarity. 1066655 1 245991 rniwa 2015-02-03 17:15:11 -0800 Created attachment 245991 Refactoring 1066656 2 rniwa 2015-02-03 17:17:54 -0800 Landed in r179583. 245991 2015-02-03 17:15:11 -0800 2015-02-03 17:17:03 -0800 Refactoring fix141220 text/plain 4247 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5NTgyKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTAyLTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIC9hcGkvcnVucy5waHAgc2hvdWxkIGhhdmUgbWFpbiBmdW5jdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMjIwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV3JhcHBlZCB0aGUgY29k ZSBpbnNpZGUgbWFpbiBmdW5jdGlvbiBmb3IgY2xhcml0eS4KKworICAgICAgICAqIHB1YmxpYy9h cGkvcnVucy5waHA6CisKIDIwMTUtMDEtMjcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguICJldGEiIGlzbid0IHNldCBvbiBh IGluLXByb2dyZXNzIGJ1aWxkIG9uIGEgbmV3bHkgYWRkZWQgYnVpbGRlci4KSW5kZXg6IFdlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvYXBpL3J1bnMucGhwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvYXBpL3J1bnMucGhwCShyZXZpc2lvbiAxNzk1 MzkpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2FwaS9ydW5zLnBocAkod29y a2luZyBjb3B5KQpAQCAtMiwzNyArMiw2IEBACiAKIHJlcXVpcmUoJy4uL2luY2x1ZGUvanNvbi1o ZWFkZXIucGhwJyk7CiAKLSRwYXRocyA9IGFycmF5X2tleV9leGlzdHMoJ1BBVEhfSU5GTycsICRf U0VSVkVSKSA/IGV4cGxvZGUoJy8nLCB0cmltKCRfU0VSVkVSWydQQVRIX0lORk8nXSwgJy8nKSkg OiBhcnJheSgpOwotCi1pZiAoY291bnQoJHBhdGhzKSAhPSAxKQotICAgIGV4aXRfd2l0aF9lcnJv cignSW52YWxpZFJlcXVlc3QnKTsKLQotJHBhcnRzID0gZXhwbG9kZSgnLScsICRwYXRoc1swXSk7 Ci1pZiAoY291bnQoJHBhcnRzKSAhPSAyKQotICAgIGV4aXRfd2l0aF9lcnJvcignSW52YWxpZFJl cXVlc3QnKTsKLQotJGRiID0gbmV3IERhdGFiYXNlOwotaWYgKCEkZGItPmNvbm5lY3QoKSkKLSAg ICBleGl0X3dpdGhfZXJyb3IoJ0RhdGFiYXNlQ29ubmVjdGlvbkZhaWx1cmUnKTsKLQotLy8gRklY TUU6IFdlIHNob3VsZCBzdXBwb3J0IHJldmFsaWNhdGlvbiBhcyB3ZWxsIGFzIGNhY2hpbmcgcmVz dWx0cyBpbiB0aGUgc2VydmVyIHNpZGUuCi0kbWF4YWdlID0gY29uZmlnKCdqc29uQ2FjaGVNYXhB Z2UnKTsKLWhlYWRlcignRXhwaXJlczogJyAuIGdtZGF0ZSgnRCwgZCBNIFkgSDppOnMnLCB0aW1l KCkgKyAkbWF4YWdlKSAuICcgR01UJyk7Ci1oZWFkZXIoIkNhY2hlLUNvbnRyb2w6IG1heGFnZT0k bWF4YWdlIik7Ci0KLSRwbGF0Zm9ybV9pZCA9IGludHZhbCgkcGFydHNbMF0pOwotJG1ldHJpY19p ZCA9IGludHZhbCgkcGFydHNbMV0pOwotJGNvbmZpZ19yb3dzID0gJGRiLT5xdWVyeV9hbmRfZmV0 Y2hfYWxsKCdTRUxFQ1QgY29uZmlnX2lkLCBjb25maWdfdHlwZSwgY29uZmlnX3BsYXRmb3JtLCBj b25maWdfbWV0cmljCi0gICAgRlJPTSB0ZXN0X2NvbmZpZ3VyYXRpb25zIFdIRVJFIGNvbmZpZ19t ZXRyaWMgPSAkMSBBTkQgY29uZmlnX3BsYXRmb3JtID0gJDInLCBhcnJheSgkbWV0cmljX2lkLCAk cGxhdGZvcm1faWQpKTsKLWlmICghJGNvbmZpZ19yb3dzKQotICAgIGV4aXRfd2l0aF9lcnJvcign Q29uZmlndXJhdGlvbk5vdEZvdW5kJyk7Ci0KLSRyZXBvc2l0b3J5X2lkX3RvX25hbWUgPSBhcnJh eSgpOwotaWYgKCRyZXBvc2l0b3J5X3RhYmxlID0gJGRiLT5mZXRjaF90YWJsZSgncmVwb3NpdG9y aWVzJykpIHsKLSAgICBmb3JlYWNoICgkcmVwb3NpdG9yeV90YWJsZSBhcyAkcmVwb3NpdG9yeSkK LSAgICAgICAgJHJlcG9zaXRvcnlfaWRfdG9fbmFtZVskcmVwb3NpdG9yeVsncmVwb3NpdG9yeV9p ZCddXSA9ICRyZXBvc2l0b3J5WydyZXBvc2l0b3J5X25hbWUnXTsKLX0KLQogZnVuY3Rpb24gZmV0 Y2hfcnVuc19mb3JfY29uZmlnKCRkYiwgJGNvbmZpZykgewogICAgICRyYXdfcnVucyA9ICRkYi0+ cXVlcnlfYW5kX2ZldGNoX2FsbCgnCiAgICAgICAgIFNFTEVDVCB0ZXN0X3J1bnMuKiwgYnVpbGRz LiosIGFycmF5X2FnZygoY29tbWl0X3JlcG9zaXRvcnksIGNvbW1pdF9yZXZpc2lvbiwgY29tbWl0 X3RpbWUpKSBBUyByZXZpc2lvbnMKQEAgLTgxLDEyICs1MCw0NSBAQAogICAgICAgICAnYnVpbGRl cicgPT4gJHJ1blsnYnVpbGRfYnVpbGRlciddKTsKIH0KIAotJHJlc3VsdHMgPSBhcnJheSgpOwot Zm9yZWFjaCAoJGNvbmZpZ19yb3dzIGFzICRjb25maWcpIHsKLSAgICBpZiAoJHJ1bnMgPSBmZXRj aF9ydW5zX2Zvcl9jb25maWcoJGRiLCAkY29uZmlnKSkKLSAgICAgICAgJHJlc3VsdHNbJGNvbmZp Z1snY29uZmlnX3R5cGUnXV0gPSAkcnVuczsKK2Z1bmN0aW9uIG1haW4oJHBhdGgpIHsKKyAgICBp ZiAoY291bnQoJHBhdGgpICE9IDEpCisgICAgICAgIGV4aXRfd2l0aF9lcnJvcignSW52YWxpZFJl cXVlc3QnKTsKKworICAgICRwYXJ0cyA9IGV4cGxvZGUoJy0nLCAkcGF0aFswXSk7CisgICAgaWYg KGNvdW50KCRwYXJ0cykgIT0gMikKKyAgICAgICAgZXhpdF93aXRoX2Vycm9yKCdJbnZhbGlkUmVx dWVzdCcpOworCisgICAgJGRiID0gbmV3IERhdGFiYXNlOworICAgIGlmICghJGRiLT5jb25uZWN0 KCkpCisgICAgICAgIGV4aXRfd2l0aF9lcnJvcignRGF0YWJhc2VDb25uZWN0aW9uRmFpbHVyZScp OworCisgICAgLy8gRklYTUU6IFdlIHNob3VsZCBzdXBwb3J0IHJldmFsaWNhdGlvbiBhcyB3ZWxs IGFzIGNhY2hpbmcgcmVzdWx0cyBpbiB0aGUgc2VydmVyIHNpZGUuCisgICAgJG1heGFnZSA9IGNv bmZpZygnanNvbkNhY2hlTWF4QWdlJyk7CisgICAgaGVhZGVyKCdFeHBpcmVzOiAnIC4gZ21kYXRl KCdELCBkIE0gWSBIOmk6cycsIHRpbWUoKSArICRtYXhhZ2UpIC4gJyBHTVQnKTsKKyAgICBoZWFk ZXIoIkNhY2hlLUNvbnRyb2w6IG1heGFnZT0kbWF4YWdlIik7CisKKyAgICAkcGxhdGZvcm1faWQg PSBpbnR2YWwoJHBhcnRzWzBdKTsKKyAgICAkbWV0cmljX2lkID0gaW50dmFsKCRwYXJ0c1sxXSk7 CisgICAgJGNvbmZpZ19yb3dzID0gJGRiLT5xdWVyeV9hbmRfZmV0Y2hfYWxsKCdTRUxFQ1QgY29u ZmlnX2lkLCBjb25maWdfdHlwZSwgY29uZmlnX3BsYXRmb3JtLCBjb25maWdfbWV0cmljCisgICAg ICAgIEZST00gdGVzdF9jb25maWd1cmF0aW9ucyBXSEVSRSBjb25maWdfbWV0cmljID0gJDEgQU5E IGNvbmZpZ19wbGF0Zm9ybSA9ICQyJywgYXJyYXkoJG1ldHJpY19pZCwgJHBsYXRmb3JtX2lkKSk7 CisgICAgaWYgKCEkY29uZmlnX3Jvd3MpCisgICAgICAgIGV4aXRfd2l0aF9lcnJvcignQ29uZmln dXJhdGlvbk5vdEZvdW5kJyk7CisKKyAgICAkcmVwb3NpdG9yeV9pZF90b19uYW1lID0gYXJyYXko KTsKKyAgICBpZiAoJHJlcG9zaXRvcnlfdGFibGUgPSAkZGItPmZldGNoX3RhYmxlKCdyZXBvc2l0 b3JpZXMnKSkgeworICAgICAgICBmb3JlYWNoICgkcmVwb3NpdG9yeV90YWJsZSBhcyAkcmVwb3Np dG9yeSkKKyAgICAgICAgICAgICRyZXBvc2l0b3J5X2lkX3RvX25hbWVbJHJlcG9zaXRvcnlbJ3Jl cG9zaXRvcnlfaWQnXV0gPSAkcmVwb3NpdG9yeVsncmVwb3NpdG9yeV9uYW1lJ107CisgICAgfQor CisgICAgJHJlc3VsdHMgPSBhcnJheSgpOworICAgIGZvcmVhY2ggKCRjb25maWdfcm93cyBhcyAk Y29uZmlnKSB7CisgICAgICAgIGlmICgkcnVucyA9IGZldGNoX3J1bnNfZm9yX2NvbmZpZygkZGIs ICRjb25maWcpKQorICAgICAgICAgICAgJHJlc3VsdHNbJGNvbmZpZ1snY29uZmlnX3R5cGUnXV0g PSAkcnVuczsKKyAgICB9CisKKyAgICBleGl0X3dpdGhfc3VjY2VzcygkcmVzdWx0cyk7CiB9CiAK LWV4aXRfd2l0aF9zdWNjZXNzKCRyZXN1bHRzKTsKK21haW4oYXJyYXlfa2V5X2V4aXN0cygnUEFU SF9JTkZPJywgJF9TRVJWRVIpID8gZXhwbG9kZSgnLycsIHRyaW0oJF9TRVJWRVJbJ1BBVEhfSU5G TyddLCAnLycpKSA6IGFycmF5KCkpOwogCiA/Pgo=