141219 2015-02-03 16:42:32 -0800 video.controls should not return true just because of fullscreen 2015-02-04 10:16:16 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer oldest_to_newest 1066641 0 eric.carlson 2015-02-03 16:42:32 -0800 HTMLMediaElement::controls always returns true when an element is in fullscreen. While it may be necessary to show native controls when in fullscreen, video.controls should reflect the attribute value. 1066642 1 eric.carlson 2015-02-03 16:43:50 -0800 <rdar://problem/19237142> 1066683 2 246002 eric.carlson 2015-02-03 18:01:19 -0800 Created attachment 246002 Proposed patch. 1066807 3 246002 dino 2015-02-04 08:24:36 -0800 Comment on attachment 246002 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=246002&action=review > Source/WebCore/ChangeLog:3 > + video.attribute should not return true just because of fullscreen Should this be "video.controls"? 1066855 4 246002 commit-queue 2015-02-04 10:16:12 -0800 Comment on attachment 246002 Proposed patch. Clearing flags on attachment: 246002 Committed r179612: <http://trac.webkit.org/changeset/179612> 1066856 5 commit-queue 2015-02-04 10:16:16 -0800 All reviewed patches have been landed. Closing bug. 246002 2015-02-03 18:01:19 -0800 2015-02-04 10:16:12 -0800 Proposed patch. patch_2.txt text/plain 6090 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTU4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTAyLTAzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIHZpZGVvLmF0dHJpYnV0 ZSBzaG91bGQgbm90IHJldHVybiB0cnVlIGp1c3QgYmVjYXVzZSBvZiBmdWxsc2NyZWVuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEyMTkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IHVwZGF0ZWQgbWVkaWEvdmlkZW8tZnVsbHNjcmVlZW4tb25seS1jb250cm9scy5odG1sCisKKyAg ICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzOgorICAg ICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuc2hvdWxkSGF2ZUNvbnRyb2xzKToKKyAgICAgICAg KiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qczoKKyAgICAgICAgKENv bnRyb2xsZXJJT1MucHJvdG90eXBlLmlzRnVsbFNjcmVlbik6CisKKyAgICAgICAgKiBodG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6 Y29udHJvbHMpOiBEb24ndCBjb25zaWRlciBmdWxsc2NyZWVuIHN0YXR1cy4KKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNvbmZpZ3VyZU1lZGlhQ29udHJvbHMpOiBDcmVhdGUg Y29udHJvbHMgaWYgYSB2aWRlbyBlbGVtZW50CisgICAgICAgICAgICBpc24ndCBhbGxvd2VkIHRv IHBsYXkgaW5saW5lLCBvciBpZiBpdCBpcyBpbiBmdWxsc2NyZWVuLgorCiAyMDE1LTAyLTAzICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRHJvcCBSZXNvdXJjZUxv YWRQcmlvcml0eVVucmVzb2x2ZWQgcmVzb3VyY2UgbG9hZCBwcmlvcml0eSBhbmQgdXNlIE9wdGlv bmFsPD4gaW5zdGVhZApJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz L21lZGlhQ29udHJvbHNBcHBsZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCShyZXZpc2lvbiAxNzk0NDIp CisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fw cGxlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNTAsNiArMjUwLDkgQEAgQ29udHJvbGxlci5wcm90 b3R5cGUgPSB7CiAKICAgICBzaG91bGRIYXZlQ29udHJvbHM6IGZ1bmN0aW9uKCkKICAgICB7Cisg ICAgICAgIGlmICghdGhpcy5pc0F1ZGlvKCkgJiYgIXRoaXMuaG9zdC5tZWRpYVBsYXliYWNrQWxs b3dzSW5saW5lKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisKICAgICAgICAgcmV0dXJuIHRo aXMudmlkZW8uY29udHJvbHMgfHwgdGhpcy5pc0Z1bGxTY3JlZW4oKTsKICAgICB9LAogCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVk aWFDb250cm9sc2lPUy5qcwkocmV2aXNpb24gMTc5NDQyKQorKysgU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMJKHdvcmtpbmcgY29weSkKQEAg LTQxMyw3ICs0MTMsNyBAQCBDb250cm9sbGVySU9TLnByb3RvdHlwZSA9IHsKIAogICAgIGlzRnVs bFNjcmVlbjogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMudmlkZW8ud2Vi a2l0RGlzcGxheWluZ0Z1bGxzY3JlZW47CisgICAgICAgIHJldHVybiB0aGlzLnZpZGVvLndlYmtp dERpc3BsYXlpbmdGdWxsc2NyZWVuICYmIHRoaXMucHJlc2VudGF0aW9uTW9kZSgpICE9ICdvcHRp bWl6ZWQnOwogICAgIH0sCiAKICAgICBoYW5kbGVGdWxsc2NyZWVuQnV0dG9uQ2xpY2tlZDogZnVu Y3Rpb24oZXZlbnQpIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50 LmNwcAkocmV2aXNpb24gMTc5NDQyKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk2NiwxNCArMjk2Niw2IEBAIGJvb2wgSFRN TE1lZGlhRWxlbWVudDo6Y29udHJvbHMoKSBjb25zdAogICAgIGlmIChmcmFtZSAmJiAhZnJhbWUt PnNjcmlwdCgpLmNhbkV4ZWN1dGVTY3JpcHRzKE5vdEFib3V0VG9FeGVjdXRlU2NyaXB0KSkKICAg ICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICAvLyBhbHdheXMgc2hvdyBjb250cm9scyBmb3Igdmlk ZW8gd2hlbiBmdWxsc2NyZWVuIHBsYXliYWNrIGlzIHJlcXVpcmVkLgotICAgIGlmIChpc1ZpZGVv KCkgJiYgbV9tZWRpYVNlc3Npb24tPnJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2so KnRoaXMpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLQotICAgIC8vIEFsd2F5cyBzaG93IGNvbnRy b2xzIHdoZW4gaW4gZnVsbCBzY3JlZW4gbW9kZS4KLSAgICBpZiAoaXNGdWxsc2NyZWVuKCkpCi0g ICAgICAgIHJldHVybiB0cnVlOwotCiAgICAgcmV0dXJuIGZhc3RIYXNBdHRyaWJ1dGUoY29udHJv bHNBdHRyKTsKIH0KIApAQCAtNTI1NiwxMyArNTI0OCwyMyBAQCBib29sIEhUTUxNZWRpYUVsZW1l bnQ6OmNyZWF0ZU1lZGlhQ29udHJvCiAKIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6Y29uZmlndXJl TWVkaWFDb250cm9scygpCiB7CisgICAgYm9vbCByZXF1aXJlQ29udHJvbHMgPSBjb250cm9scygp OworCisgICAgLy8gQWx3YXlzIGNyZWF0ZSBjb250cm9scyBmb3IgdmlkZW8gd2hlbiBmdWxsc2Ny ZWVuIHBsYXliYWNrIGlzIHJlcXVpcmVkLgorICAgIGlmIChpc1ZpZGVvKCkgJiYgbV9tZWRpYVNl c3Npb24tPnJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKnRoaXMpKQorICAgICAg ICByZXF1aXJlQ29udHJvbHMgPSB0cnVlOworCisgICAgLy8gQWx3YXlzIGNyZWF0ZSBjb250cm9s cyB3aGVuIGluIGZ1bGwgc2NyZWVuIG1vZGUuCisgICAgaWYgKGlzRnVsbHNjcmVlbigpKQorICAg ICAgICByZXF1aXJlQ29udHJvbHMgPSB0cnVlOworCiAjaWYgRU5BQkxFKE1FRElBX0NPTlRST0xT X1NDUklQVCkKLSAgICBpZiAoIWNvbnRyb2xzKCkgfHwgIWluRG9jdW1lbnQoKSkKKyAgICBpZiAo IXJlcXVpcmVDb250cm9scyB8fCAhaW5Eb2N1bWVudCgpKQogICAgICAgICByZXR1cm47CiAKICAg ICBlbnN1cmVVc2VyQWdlbnRTaGFkb3dSb290KCk7CiAjZWxzZQotICAgIGlmICghY29udHJvbHMo KSB8fCAhaW5Eb2N1bWVudCgpKSB7CisgICAgaWYgKCFyZXF1aXJlQ29udHJvbHMgfHwgIWluRG9j dW1lbnQoKSkgewogICAgICAgICBpZiAoaGFzTWVkaWFDb250cm9scygpKQogICAgICAgICAgICAg bWVkaWFDb250cm9scygpLT5oaWRlKCk7CiAgICAgICAgIHJldHVybjsKSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDE3OTU4NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDEzIEBACisyMDE1LTAyLTAzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgorCisgICAgICAgIHZpZGVvLmF0dHJpYnV0ZSBzaG91bGQgbm90IHJldHVybiB0cnVl IGp1c3QgYmVjYXVzZSBvZiBmdWxsc2NyZWVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEyMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL3ZpZGVvLWZ1bGxzY3JlZWVuLW9ubHktY29udHJv bHMtZXhwZWN0ZWQudHh0OiBVcGRhdGUuCisgICAgICAgICogbWVkaWEvdmlkZW8tZnVsbHNjcmVl ZW4tb25seS1jb250cm9scy5odG1sOiBEaXR0by4KKwogMjAxNS0wMi0wMyAgQWxleGV5IFByb3Nr dXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L2V2ZW50LWxpc3RlbmVyLWdjLmh0bWwgaXMgZmxha3kKSW5kZXg6IExheW91dFRlc3RzL21l ZGlhL3ZpZGVvLWZ1bGxzY3JlZWVuLW9ubHktY29udHJvbHMtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLWZ1bGxzY3JlZWVuLW9ubHktY29udHJvbHMt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxNzk0NDIpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS92aWRl by1mdWxsc2NyZWVlbi1vbmx5LWNvbnRyb2xzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpA QCAtMiw2ICsyLDggQEAgVGhpcyB0ZXN0cyB0aGF0IHdoZW4gaW5saW5lLXBsYXliYWNrIGlzIAog CiAKIFJVTihpbnRlcm5hbHMuc2V0TWVkaWFTZXNzaW9uUmVzdHJpY3Rpb25zKCd2aWRlbycsICdJ bmxpbmVWaWRlb1BsYXliYWNrUmVzdHJpY3RlZCcpKQorRVhQRUNURUQgKHZpZGVvLmhhc0F0dHJp YnV0ZSgnY29udHJvbHMnKSA9PSAnZmFsc2UnKSBPSworRVhQRUNURUQgKHZpZGVvLmNvbnRyb2xz ID09ICdmYWxzZScpIE9LCiBFWFBFQ1RFRCAoc2hhZG93Um9vdCA9IGludGVybmFscy5zaGFkb3dS b290KHZpZGVvKSAhPSAnbnVsbCcpIE9LCiBFWFBFQ1RFRCAocGFuZWwgPSBtZWRpYUNvbnRyb2xz RWxlbWVudChzaGFkb3dSb290LmZpcnN0Q2hpbGQsICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBh bmVsJykgIT0gJ251bGwnKSBPSwogRVhQRUNURUQgKGludGVybmFscy5zaGFkb3dQc2V1ZG9JZChw YW5lbCkgPT0gJy13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwnKSBPSwpJbmRleDogTGF5b3V0 VGVzdHMvbWVkaWEvdmlkZW8tZnVsbHNjcmVlZW4tb25seS1jb250cm9scy5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLWZ1bGxzY3JlZWVuLW9ubHktY29udHJvbHMu aHRtbAkocmV2aXNpb24gMTc5NDQyKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tZnVsbHNj cmVlZW4tb25seS1jb250cm9scy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xNCw2ICsxNCw5IEBA CiAgICAgdmFyIHZpZGVvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3ZpZGVvJyk7CiAgICAg dmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVudC90ZXN0Iik7CiAKKyAg ICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmhhc0F0dHJpYnV0ZSgnY29udHJvbHMnKSIsIGZhbHNlKTsK KyAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmNvbnRyb2xzIiwgZmFsc2UpOworCiAgICAgaWYgKHdp bmRvdy5pbnRlcm5hbHMpIHsKICAgICAgICAgdGVzdEV4cGVjdGVkKCJzaGFkb3dSb290ID0gaW50 ZXJuYWxzLnNoYWRvd1Jvb3QodmlkZW8pIiwgbnVsbCwgIiE9Iik7CiAgICAgICAgIHRlc3RFeHBl Y3RlZCgicGFuZWwgPSBtZWRpYUNvbnRyb2xzRWxlbWVudChzaGFkb3dSb290LmZpcnN0Q2hpbGQs ICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsJykiLCBudWxsLCAiIT0iKTsK