141204 2015-02-03 10:26:56 -0800 TypeSet can use 1 byte instead of 4 bytes for its m_seenTypes member variable 2015-02-04 12:27:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam fpizlo ggaren mark.lam mmirman msaboff oldest_to_newest 1066486 0 saam 2015-02-03 10:26:56 -0800 No need to use the extra three bytes if we don't need them. 1066497 1 245949 saam 2015-02-03 10:51:50 -0800 Created attachment 245949 patch 1066874 2 saam 2015-02-04 12:04:37 -0800 landed in: http://trac.webkit.org/changeset/179621 1066882 3 245949 joepeck 2015-02-04 12:27:26 -0800 Comment on attachment 245949 patch View in context: https://bugs.webkit.org/attachment.cgi?id=245949&action=review > Source/JavaScriptCore/runtime/TypeSet.h:54 > -enum RuntimeType { > +enum RuntimeType : uint8_t { > TypeNothing = 0x0, > TypeFunction = 0x1, > TypeUndefined = 0x2, Do we need to count "Symbol" types now that they landed? js> function foo(arg) { console.log(arg); } js> foo(Symbol("test")); Seems this would bump us over this edge, at least up to 16 bits. 245949 2015-02-03 10:51:50 -0800 2015-02-04 09:04:11 -0800 patch patch.diff text/plain 3517 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5NTU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTAyLTAzICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBUeXBlU2V0IGNhbiB1c2UgMSBieXRlIGluc3RlYWQgb2YgNCBieXRlcyBmb3IgaXRzIG1f c2VlblR5cGVzIG1lbWJlciB2YXJpYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgbm8gbmVlZCB0byB1c2UgMzIgYml0cyB0byBzdG9y ZSBhIFR5cGVTZXQ6OlJ1bnRpbWVUeXBlIHNldCAKKyAgICAgICAgYml0LXZlY3RvciB3aGVuIHRo ZSBsYXJnZXN0IHZhbHVlIGZvciBhIHNpbmdsZSBUeXBlU2V0OjpSdW50aW1lVHlwZSAKKyAgICAg ICAgaXMgMHg4MC4gOCBiaXRzIGlzIGVub3VnaCB0byByZXByZXNlbnQgdGhlIHNldCBvZiBzZWVu IHR5cGVzLgorCisgICAgICAgICogZGZnL0RGR0ZpeHVwUGhhc2UuY3BwOgorICAgICAgICAoSlND OjpERkc6OkZpeHVwUGhhc2U6OmZpeHVwTm9kZSk6CisgICAgICAgICogcnVudGltZS9UeXBlU2V0 LmNwcDoKKyAgICAgICAgKEpTQzo6VHlwZVNldDo6ZG9lc1R5cGVDb25mb3JtVG8pOgorICAgICAg ICAqIHJ1bnRpbWUvVHlwZVNldC5oOgorICAgICAgICAoSlNDOjpUeXBlU2V0OjpzZWVuVHlwZXMp OgorCiAyMDE1LTAyLTAzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIFtXaW5dIFByb2plY3QgZmlsZSBjbGVhbnVwcyBhZnRlciByMTc5NDI5LgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCShyZXZpc2lvbiAx Nzk0NzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTQzLDcgKzExNDMsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAg Ly8gKFRoZSBvdGhlciBkaXJlY3Rpb24gZG9lcyBub3QgaG9sZCBpbiBnZW5lcmFsKS4KIAogICAg ICAgICAgICAgUmVmUHRyPFR5cGVTZXQ+IHR5cGVTZXQgPSBub2RlLT50eXBlTG9jYXRpb24oKS0+ bV9pbnN0cnVjdGlvblR5cGVTZXQ7Ci0gICAgICAgICAgICB1aW50MzJfdCBzZWVuVHlwZXMgPSB0 eXBlU2V0LT5zZWVuVHlwZXMoKTsKKyAgICAgICAgICAgIHVpbnQ4X3Qgc2VlblR5cGVzID0gdHlw ZVNldC0+c2VlblR5cGVzKCk7CiAgICAgICAgICAgICBpZiAodHlwZVNldC0+ZG9lc1R5cGVDb25m b3JtVG8oVHlwZU1hY2hpbmVJbnQpKSB7CiAgICAgICAgICAgICAgICAgbm9kZS0+Y29udmVydFRv Q2hlY2soKTsKICAgICAgICAgICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCktPnNob3VsZFNwZWN1 bGF0ZUludDMyKCkpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UeXBlU2V0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UeXBlU2V0 LmNwcAkocmV2aXNpb24gMTc5NDc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv VHlwZVNldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Nyw3ICsxNTcsNyBAQCBTdHJpbmcgVHlw ZVNldDo6ZHVtcFR5cGVzKCkgY29uc3QKICAgICByZXR1cm4gc2Vlbi50b1N0cmluZygpOwogfQog Ci1ib29sIFR5cGVTZXQ6OmRvZXNUeXBlQ29uZm9ybVRvKHVpbnQzMl90IHRlc3QpIGNvbnN0Citi b29sIFR5cGVTZXQ6OmRvZXNUeXBlQ29uZm9ybVRvKHVpbnQ4X3QgdGVzdCkgY29uc3QKIHsKICAg ICAvLyBUaGlzIGZ1bmN0aW9uIGNoZWNrcyBpZiBvdXIgc2VlbiB0eXBlcyBjb25mb3JtICB0byB0 aGUgdHlwZXMgZGVzY3JpYmVkIGJ5IHRoZSB0ZXN0IGJpdHN0cmluZy4gKGkuZSB3ZSBoYXZlbid0 IHNlZW4gbW9yZSB0eXBlcyB0aGFuIHRlc3QpLgogICAgIC8vIFdlIGFyZSA8PSB0byB0aG9zZSB0 eXBlcyBpZiBBTkRpbmcgd2l0aCB0aGUgYml0c3RyaW5nIGRvZXNuJ3QgemVybyBvdXQgYW55IG9m IG91ciBiaXRzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVHlwZVNldC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1R5cGVTZXQuaAko cmV2aXNpb24gMTc5NDc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVHlwZVNl dC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw3ICs0OCw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiBj bGFzcyBKU1ZhbHVlOwogCi1lbnVtIFJ1bnRpbWVUeXBlIHsKK2VudW0gUnVudGltZVR5cGUgOiB1 aW50OF90IHsKICAgICBUeXBlTm90aGluZyAgICAgICAgICAgID0gMHgwLAogICAgIFR5cGVGdW5j dGlvbiAgICAgICAgICAgPSAweDEsCiAgICAgVHlwZVVuZGVmaW5lZCAgICAgICAgICA9IDB4MiwK QEAgLTEwOCwxMiArMTA4LDEyIEBAIHB1YmxpYzoKICAgICBTdHJpbmcgbGVhc3RDb21tb25BbmNl c3RvcigpIGNvbnN0OwogICAgIFJlZjxJbnNwZWN0b3I6OlByb3RvY29sOjpSdW50aW1lOjpUeXBl U2V0PiBpbnNwZWN0b3JUeXBlU2V0KCkgY29uc3Q7CiAgICAgYm9vbCBpc0VtcHR5KCkgY29uc3Qg eyByZXR1cm4gbV9zZWVuVHlwZXMgPT0gVHlwZU5vdGhpbmc7IH0KLSAgICBib29sIGRvZXNUeXBl Q29uZm9ybVRvKHVpbnQzMl90IHRlc3QpIGNvbnN0OwotICAgIHVpbnQzMl90IHNlZW5UeXBlcygp IGNvbnN0IHsgcmV0dXJuIG1fc2VlblR5cGVzOyB9CisgICAgYm9vbCBkb2VzVHlwZUNvbmZvcm1U byh1aW50OF90IHRlc3QpIGNvbnN0OworICAgIHVpbnQ4X3Qgc2VlblR5cGVzKCkgY29uc3QgeyBy ZXR1cm4gbV9zZWVuVHlwZXM7IH0KICAgICBTdHJ1Y3R1cmVTZXQgc3RydWN0dXJlU2V0KCkgY29u c3QgeyByZXR1cm4gbV9zdHJ1Y3R1cmVTZXQ7IH07CiAKIHByaXZhdGU6Ci0gICAgdWludDMyX3Qg bV9zZWVuVHlwZXM7CisgICAgdWludDhfdCBtX3NlZW5UeXBlczsKICAgICBib29sIG1faXNPdmVy Zmxvd247CiAgICAgVmVjdG9yPFJlZlB0cjxTdHJ1Y3R1cmVTaGFwZT4+IG1fc3RydWN0dXJlSGlz dG9yeTsKICAgICBTdHJ1Y3R1cmVTZXQgbV9zdHJ1Y3R1cmVTZXQ7Cg==