14120 2007-06-13 06:28:07 -0700 [GDK] Support input methods 2008-05-28 11:05:36 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) All All RESOLVED FIXED Gtk P2 Normal --- 16454 17009 1 alp webkit-unassigned alp christian gwright sanxiyn oldest_to_newest 7702 0 alp 2007-06-13 06:28:07 -0700 The editor client should support Gtk+ input methods for desktop accessibility and mobile device virtual keyboards. 63936 1 17849 gwright 2007-12-11 09:00:53 -0800 Created attachment 17849 Initial implementation of GTK Input methods, including Hildon This is an initial implementation for GTK input method support in EditorClientGtk. It also includes support for the Hildon input methods from the Maemo platform used on the Nokia internet tablets. These Hildon specific changes are #ifdef'd. 63968 2 17849 alp 2007-12-11 15:36:14 -0800 Comment on attachment 17849 Initial implementation of GTK Input methods, including Hildon Making these changes as discussed before landing: Add ChangeLog entry Make sure resources are unref'd Don't re-introduced deprecated "page" terminology 63975 3 alp 2007-12-11 16:11:47 -0800 Initial patch landed in r28634. Not closing this bug since IM support is not complete yet and there are CCs. 63978 4 sanxiyn 2007-12-11 18:15:02 -0800 I tested the patch. I need the input method support to input Korean. I used search text field on Korean Wikipedia to test. 1. X Input Method did not work at all. 2. imhangul (GTK+ input module) did change something, but produced garbage characters. 3. I tried to test IPA, but I found no way to select different GTK+ input module. I usually do that by using context menu. (I could switch to imhangul with hot key though.) 63979 5 alp 2007-12-11 18:25:15 -0800 That is e(In reply to comment #4) > I tested the patch. I need the input method support to input Korean. I used > search text field on Korean Wikipedia to test. > > 1. X Input Method did not work at all. > 2. imhangul (GTK+ input module) did change something, but produced garbage > characters. > 3. I tried to test IPA, but I found no way to select different GTK+ input > module. I usually do that by using context menu. (I could switch to imhangul > with hot key though.) > This is exactly what I'd expect. As the ChangeLog entry explained, the patch only implements the infrastructure for IM support, but happens to be sufficient for limited virtual keyboard support on mobile devices already. The work to go from here to getting complete support is pretty clear. We just need to implement the various IM signals and functions in terms of EditorClientGtk. The one change we'll need to make outside of EditorClientGtk is to add a new field to PlatformKeyboardEvent.h to pass around the GDK event -- this is the exact same strategy the Mac port uses. Completing this feature would only take maybe half a day for someone with WebKit/GTK+ experience. 64035 6 17849 alp 2007-12-12 09:29:29 -0800 Comment on attachment 17849 Initial implementation of GTK Input methods, including Hildon Landed in r28634. Clearing the review flag since this bug needs to remain open. 64322 7 alp 2007-12-15 12:55:18 -0800 Seo, Here's a patch to try in the meantime: http://bugs.webkit.org/show_bug.cgi?id=16454 Does it improve the input situation at all? 69318 8 alp 2008-02-03 23:30:02 -0800 Commit r29958 fixing Bug #17046 added input method selection support to the context menu. 69764 9 alp 2008-02-08 02:47:41 -0800 I have a feeling that with r30090 input methods are starting to become useful for international users. I have no idea if it's at a usable state but I can switch between the various methods with the context menu, type in Arabic using SCIM etc. Seo, are we getting there? Is this usable for you? 69900 10 christian 2008-02-08 23:10:41 -0800 Tested to verify the current status of Input Method support: Input methods that match typed letters directly to resulting letters of the target script seem to work, such as Cyrillic. Input methods that combine input letters to syllables or complex glyphs, such as Japanese, do not work for me. 69901 11 alp 2008-02-09 00:02:17 -0800 (In reply to comment #10) > Tested to verify the current status of Input Method support: > > Input methods that match typed letters directly to resulting letters of the > target script seem to work, such as Cyrillic. > > Input methods that combine input letters to syllables or complex glyphs, such > as Japanese, do not work for me. > Did you apply the hack I suggested in bug #16792 to make Chinese/Japanese text render? Without it, you'll have to test with either simple, non-wide text, or actual complex text like Arabic. 81766 12 alp 2008-05-28 11:05:36 -0700 Fix landed in r34176. 17849 2007-12-11 09:00:53 -0800 2007-12-12 09:29:29 -0800 Initial implementation of GTK Input methods, including Hildon hildon-input.patch text/plain 3862 gwright ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNw cCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcAppbmRleCAw NjM0ZTI5Li42NTU0NjBlIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JD bGllbnRHdGsuY3BwCkBAIC00OCw2ICs0OCwxNCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK IAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK3N0YXRpYyB2b2lkIGltQ29udGV4dENvbW1pdHRlZChH dGtJTUNvbnRleHQqIGNvbnRleHQsIGNvbnN0IGNoYXIqIHN0ciwgRWRpdG9yQ2xpZW50KiBjbGll bnQpCit7CisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUqIHBhZ2VEYXRhID0gV0VCS0lUX1dFQl9W SUVXX0dFVF9QUklWQVRFKGNsaWVudC0+bV9wYWdlKTsKKyAgICBGcmFtZSogZnJhbWUgPSBwYWdl RGF0YS0+Y29yZVBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKTsK KyAgICBmcmFtZS0+ZWRpdG9yKCktPmluc2VydFRleHRXaXRob3V0U2VuZGluZ1RleHRFdmVudChz dHIsIGZhbHNlKTsKK30KKworCiBib29sIEVkaXRvckNsaWVudDo6c2hvdWxkRGVsZXRlUmFuZ2Uo UmFuZ2UqKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CkBAIC0zNjAsMTYgKzM2OCwyNCBAQCB2 b2lkIEVkaXRvckNsaWVudDo6aGFuZGxlSW5wdXRNZXRob2RLZXlwcmVzcyhLZXlib2FyZEV2ZW50 KikKIEVkaXRvckNsaWVudDo6RWRpdG9yQ2xpZW50KFdlYktpdFdlYlZpZXcqIHBhZ2UpCiAgICAg OiBtX3BhZ2UocGFnZSkKIHsKKyAgICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcGFnZURhdGEgPSBX RUJLSVRfV0VCX1ZJRVdfR0VUX1BSSVZBVEUobV9wYWdlKTsKKyAgICBwYWdlRGF0YS0+aW1Db250 ZXh0ID0gZ3RrX2ltX211bHRpY29udGV4dF9uZXcoKTsKKyAgICBnX3NpZ25hbF9jb25uZWN0KHBh Z2VEYXRhLT5pbUNvbnRleHQsICJjb21taXQiLCBHX0NBTExCQUNLKGltQ29udGV4dENvbW1pdHRl ZCksIHRoaXMpOwogfQogCiB2b2lkIEVkaXRvckNsaWVudDo6dGV4dEZpZWxkRGlkQmVnaW5FZGl0 aW5nKEVsZW1lbnQqKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgZ3RrX2ltX2NvbnRl eHRfZm9jdXNfaW4oV0VCS0lUX1dFQl9WSUVXX0dFVF9QUklWQVRFKG1fcGFnZSktPmltQ29udGV4 dCk7CiB9CiAKIHZvaWQgRWRpdG9yQ2xpZW50Ojp0ZXh0RmllbGREaWRFbmRFZGl0aW5nKEVsZW1l bnQqKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUq IHBhZ2VEYXRhID0gV0VCS0lUX1dFQl9WSUVXX0dFVF9QUklWQVRFKG1fcGFnZSk7CisKKyAgICBn dGtfaW1fY29udGV4dF9mb2N1c19vdXQocGFnZURhdGEtPmltQ29udGV4dCk7CisjaWZkZWYgTUFF TU9fQ0hBTkdFUworICAgIGhpbGRvbl9ndGtfaW1fY29udGV4dF9oaWRlKHBhZ2VEYXRhLT5pbUNv bnRleHQpOworI2VuZGlmCiB9CiAKIHZvaWQgRWRpdG9yQ2xpZW50Ojp0ZXh0RGlkQ2hhbmdlSW5U ZXh0RmllbGQoRWxlbWVudCopCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L0VkaXRvckNsaWVudEd0ay5oIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGll bnRHdGsuaAppbmRleCBkMTNkMzNiLi43N2E4NjI2IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5oCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmgKQEAgLTEwOCw3ICsxMDgsNiBAQCBuYW1lc3BhY2UgV2Vi S2l0IHsKICAgICAgICAgdmlydHVhbCB2b2lkIGdldEd1ZXNzZXNGb3JXb3JkKGNvbnN0IFdlYkNv cmU6OlN0cmluZyYsIFdURjo6VmVjdG9yPFdlYkNvcmU6OlN0cmluZz4mIGd1ZXNzZXMpOwogICAg ICAgICB2aXJ0dWFsIHZvaWQgc2V0SW5wdXRNZXRob2RTdGF0ZShib29sIGVuYWJsZWQpOwogCi0g ICAgcHJpdmF0ZToKICAgICAgICAgV2ViS2l0V2ViVmlldyogbV9wYWdlOwogICAgIH07CiB9CmRp ZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYlZpZXcvd2Via2l0cHJpdmF0ZS5oIGIvV2ViS2l0L2d0 ay9XZWJWaWV3L3dlYmtpdHByaXZhdGUuaAppbmRleCA4NDFiMGVlLi44YWRmZmYzIDEwMDY0NAot LS0gYS9XZWJLaXQvZ3RrL1dlYlZpZXcvd2Via2l0cHJpdmF0ZS5oCisrKyBiL1dlYktpdC9ndGsv V2ViVmlldy93ZWJraXRwcml2YXRlLmgKQEAgLTYxLDYgKzYxLDggQEAgZXh0ZXJuICJDIiB7CiAK ICAgICAgICAgSGFzaFNldDxHdGtXaWRnZXQqPiBjaGlsZHJlbjsKICAgICAgICAgYm9vbCBlZGl0 YWJsZTsKKworICAgICAgICBHdGtJTUNvbnRleHQqIGltQ29udGV4dDsKICAgICB9OwogCiAgICAg I2RlZmluZSBXRUJLSVRfV0VCX0ZSQU1FX0dFVF9QUklWQVRFKG9iaikgICAgKEdfVFlQRV9JTlNU QU5DRV9HRVRfUFJJVkFURSgob2JqKSwgV0VCS0lUX1RZUEVfV0VCX0ZSQU1FLCBXZWJLaXRXZWJG cmFtZVByaXZhdGUpKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJWaWV3L3dlYmtpdHdlYnZp ZXcuY3BwIGIvV2ViS2l0L2d0ay9XZWJWaWV3L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDFlYzc2 ZjguLjlmOWYzZGMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViVmlldy93ZWJraXR3ZWJ2aWV3 LmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYlZpZXcvd2Via2l0d2Vidmlldy5jcHAKQEAgLTM5LDYg KzM5LDcgQEAKICNpbmNsdWRlICJDaHJvbWVDbGllbnRHdGsuaCIKICNpbmNsdWRlICJDb250ZXh0 TWVudUNsaWVudEd0ay5oIgogI2luY2x1ZGUgIkRyYWdDbGllbnRHdGsuaCIKKyNpbmNsdWRlICJF ZGl0b3IuaCIKICNpbmNsdWRlICJFZGl0b3JDbGllbnRHdGsuaCIKICNpbmNsdWRlICJFdmVudEhh bmRsZXIuaCIKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKQEAgLTE3MSw2ICsxNzIsMjIg QEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19idXR0b25fcmVsZWFzZV9ldmVudChH dGtXaWRnZXQqIHdpZGdldCwgR2RrRXZlbnQKIHsKICAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdl YmtpdF93ZWJfdmlld19nZXRfbWFpbl9mcmFtZShXRUJLSVRfV0VCX1ZJRVcod2lkZ2V0KSkpOwog CisgICAgV2ViS2l0V2ViVmlldyogcGFnZSA9IFdFQktJVF9XRUJfVklFVyh3aWRnZXQpOworICAg IFdlYktpdFdlYlZpZXdQcml2YXRlKiBwYWdlRGF0YSA9IFdFQktJVF9XRUJfVklFV19HRVRfUFJJ VkFURShwYWdlKTsKKyAgICBGcmFtZSogZm9jdXNlZEZyYW1lID0gcGFnZURhdGEtPmNvcmVQYWdl LT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZEZyYW1lKCk7CisKKyAgICBHZGtXaW5kb3cqIHdp bmRvdyA9IGd0a193aWRnZXRfZ2V0X3BhcmVudF93aW5kb3cod2lkZ2V0KTsKKworICAgIGlmIChm b2N1c2VkRnJhbWUtPmVkaXRvcigpLT5jYW5FZGl0KCkpIHsKKyAgICAgICAgZ3RrX2ltX2NvbnRl eHRfc2V0X2NsaWVudF93aW5kb3cocGFnZURhdGEtPmltQ29udGV4dCwgd2luZG93KTsKKworI2lm ZGVmIE1BRU1PX0NIQU5HRVMKKyAgICAgICAgaGlsZG9uX2d0a19pbV9jb250ZXh0X2ZpbHRlcl9l dmVudChwYWdlRGF0YS0+aW1Db250ZXh0LCAoR2RrRXZlbnQqKWV2ZW50KTsKKyAgICAgICAgaGls ZG9uX2d0a19pbV9jb250ZXh0X3Nob3cocGFnZURhdGEtPmltQ29udGV4dCk7CisjZW5kaWYKKwor ICAgIH0KKwogICAgIHJldHVybiBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZU1vdXNlUmVs ZWFzZUV2ZW50KFBsYXRmb3JtTW91c2VFdmVudChldmVudCkpOwogfQogCg==