141188 2015-02-02 20:37:21 -0800 [EFL] Build failed after r179113 2015-02-03 07:18:16 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 hs85.jeong webkit-unassigned cgarcia gyuyoung.kim hyungwook.lee lucas.de.marchi ossy zan oldest_to_newest 1066347 0 hs85.jeong 2015-02-02 20:37:21 -0800 /usr/include/libpng12/png.h:2659:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ /usr/include/libpng12/png.h:2667:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ /usr/include/libpng12/png.h:2675:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ Introduce the build fail after removing the -Wno-error=literal-suffix. My gcc version is gcc (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1. ================= in https://bugs.webkit.org/show_bug.cgi?id=140886 ===================== Comment 1 Csaba Osztrogonác 2015-01-26 05:48:46 PST Created attachment 245344 [details] Patch Let's remove these flags, we don't need them after http://trac.webkit.org/changeset/179110 ========================================================================================== Dear Csaba Osztrogonác, Is it related with the gcc version? 1066408 1 245935 hyungwook.lee 2015-02-03 06:18:43 -0800 Created attachment 245935 patch 1066409 2 hyungwook.lee 2015-02-03 06:19:39 -0800 I've same errors and I've uploaded my local patch for all. 1066410 3 245936 hyungwook.lee 2015-02-03 06:23:04 -0800 Created attachment 245936 patch 1066411 4 245937 hyungwook.lee 2015-02-03 06:25:00 -0800 Created attachment 245937 patch 1066412 5 ossy 2015-02-03 06:26:37 -0800 No, it isn't related to GCC version, but the non-C++11 compatible libpng version. I assume you still have Ubuntu 13.10, which isn't supported long time ago. https://wiki.ubuntu.com/Releases - End of life of 13.10: July 17, 2014 https://lists.ubuntu.com/archives/ubuntu-announce/2014-June/000185.html I suggest you should upgrade your system or fix your png.h locally, it is only 1-1 space in 3 lines. ;) I don't like the idea to disable literal-suffix warnings for all sources and for GTK and EFL too because of a non supported distribution. 1066413 6 hyungwook.lee 2015-02-03 06:37:36 -0800 I agree with you that the root cause is the non-C++11 compatible libpng version. Thanks for your feedback. 1066417 7 gyuyoung.kim 2015-02-03 07:18:16 -0800 (In reply to comment #6) > I agree with you that the root cause is the non-C++11 compatible libpng > version. > > Thanks for your feedback. Closed this bug because of Ossy's review. I agree with Ossy's comment. 245935 2015-02-03 06:18:43 -0800 2015-02-03 06:23:04 -0800 patch patch text/plain 1274 hyungwook.lee SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTIz NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAy LTAzICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAg ICAgIEFkZCAtV25vLWVycm9yPWxpdGVyYWwtc3VmZml4IGZsYWcgdG8gZml4IGNvbXBpbGF0aW9u IGVycm9zIGluIEVGTC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MTE4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBjb21waWxhdGlvbiBlcnJvcnMgYWZ0ZXIgcmVtb3ZpbmcgdGhlIC1Xbm8tZXJy b3I9bGl0ZXJhbC1zdWZmaXguCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVy cy5jbWFrZToKKwogMjAxNS0wMS0yNiAgTmlrb3MgQW5kcm9uaWtvcyAgPG5pa29zLmFuZHJvbmlr b3Mtd2Via2l0QGNpc3JhLmNhbm9uLmNvbS5hdT4KIAogICAgICAgICBBcHBseSBmZVR1cmJ1bGVu Y2Ugc3BlYyBjaGFuZ2UgdG8gZml4IHplcm8gbGVuZ3RoIHZlY3RvciBnZW5lcmF0aW9uCkluZGV4 OiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv Y21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQkocmV2aXNpb24gMTc5MjM1KQorKysgU291cmNlL2Nt YWtlL1dlYktpdEhlbHBlcnMuY21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTIyLDcgKzIyLDcgQEAK IAogICAgICAgICAjIEVuYWJsZSBlcnJvcnMgb24gd2FybmluZwogICAgICAgICBpZiAoT1BUSU9O X0VOQUJMRV9XRVJST1IpCi0gICAgICAgICAgICBzZXQoT0xEX0NPTVBJTEVfRkxBR1MgIi1XZXJy b3IgLVduby1lcnJvcj11bnVzZWQtcGFyYW1ldGVyICR7T0xEX0NPTVBJTEVfRkxBR1N9IikKKyAg ICAgICAgICAgIHNldChPTERfQ09NUElMRV9GTEFHUyAiLVdlcnJvciAtV25vLWVycm9yPXVudXNl ZC1wYXJhbWV0ZXIgLVduby1lcnJvcj1saXRlcmFsLXN1ZmZpeCAke09MRF9DT01QSUxFX0ZMQUdT fSIpCiAgICAgICAgIGVuZGlmICgpCiAKICAgICAgICAgc2V0X3RhcmdldF9wcm9wZXJ0aWVzKCR7 X3RhcmdldH0gUFJPUEVSVElFUwo= 245936 2015-02-03 06:23:04 -0800 2015-02-03 06:25:00 -0800 patch patch text/plain 1219 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTIzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAyLTAzICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIE5lZWQgYSBz aG9ydCBkZXNjcmlwdGlvbiAoT09QUyEpLgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BT ISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9J bWFnZUJ1ZmZlckNhaXJvLmNwcDoKKwogMjAxNS0wMS0yNyAgUm9nZXIgRm9uZyAgPHJvZ2VyX2Zv bmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkdMMjogRGlzYWJsZSB2YXJpb3VzIGV4dGVuc2lv bnMgb24gV2ViR0wyIGNvbnRleHQgdGhhdCBoYXZlIGJlZW4gcHJvbW90ZWQgdG8gY29yZS4KSW5k ZXg6IFNvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCShyZXZpc2lvbiAxNzkyMzUpCisrKyBTb3VyY2Uv Y21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMjIsNyArMjIsNyBA QAogCiAgICAgICAgICMgRW5hYmxlIGVycm9ycyBvbiB3YXJuaW5nCiAgICAgICAgIGlmIChPUFRJ T05fRU5BQkxFX1dFUlJPUikKLSAgICAgICAgICAgIHNldChPTERfQ09NUElMRV9GTEFHUyAiLVdl cnJvciAtV25vLWVycm9yPXVudXNlZC1wYXJhbWV0ZXIgJHtPTERfQ09NUElMRV9GTEFHU30iKQor ICAgICAgICAgICAgc2V0KE9MRF9DT01QSUxFX0ZMQUdTICItV2Vycm9yIC1Xbm8tZXJyb3I9dW51 c2VkLXBhcmFtZXRlciAtV25vLWVycm9yPWxpdGVyYWwtc3VmZml4ICR7T0xEX0NPTVBJTEVfRkxB R1N9IikKICAgICAgICAgZW5kaWYgKCkKIAogICAgICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMo JHtfdGFyZ2V0fSBQUk9QRVJUSUVTCg== 245937 2015-02-03 06:25:00 -0800 2015-02-03 06:25:00 -0800 patch patch text/plain 1275 hyungwook.lee SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTIz NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAy LTAzICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAg ICAgIEFkZCAtV25vLWVycm9yPWxpdGVyYWwtc3VmZml4IGZsYWcgdG8gZml4IGNvbXBpbGF0aW9u IGVycm9ycyBpbiBFRkwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDExODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggY29tcGlsYXRpb24gZXJyb3JzIGFmdGVyIHJlbW92aW5nIHRoZSAtV25vLWVy cm9yPWxpdGVyYWwtc3VmZml4LgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEhlbHBl cnMuY21ha2U6CisKIDIwMTUtMDEtMjYgIE5pa29zIEFuZHJvbmlrb3MgIDxuaWtvcy5hbmRyb25p a29zLXdlYmtpdEBjaXNyYS5jYW5vbi5jb20uYXU+CiAKICAgICAgICAgQXBwbHkgZmVUdXJidWxl bmNlIHNwZWMgY2hhbmdlIHRvIGZpeCB6ZXJvIGxlbmd0aCB2ZWN0b3IgZ2VuZXJhdGlvbgpJbmRl eDogU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UJKHJldmlzaW9uIDE3OTIzNSkKKysrIFNvdXJjZS9j bWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0yMiw3ICsyMiw3IEBA CiAKICAgICAgICAgIyBFbmFibGUgZXJyb3JzIG9uIHdhcm5pbmcKICAgICAgICAgaWYgKE9QVElP Tl9FTkFCTEVfV0VSUk9SKQotICAgICAgICAgICAgc2V0KE9MRF9DT01QSUxFX0ZMQUdTICItV2Vy cm9yIC1Xbm8tZXJyb3I9dW51c2VkLXBhcmFtZXRlciAke09MRF9DT01QSUxFX0ZMQUdTfSIpCisg ICAgICAgICAgICBzZXQoT0xEX0NPTVBJTEVfRkxBR1MgIi1XZXJyb3IgLVduby1lcnJvcj11bnVz ZWQtcGFyYW1ldGVyIC1Xbm8tZXJyb3I9bGl0ZXJhbC1zdWZmaXggJHtPTERfQ09NUElMRV9GTEFH U30iKQogICAgICAgICBlbmRpZiAoKQogCiAgICAgICAgIHNldF90YXJnZXRfcHJvcGVydGllcygk e190YXJnZXR9IFBST1BFUlRJRVMK