141179 2015-02-02 15:43:27 -0800 [GTK] TestWebKitAccessibility is not skipped 2015-02-03 10:25:57 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro cgarcia clopez commit-queue mcatanzaro oldest_to_newest 1066271 0 mcatanzaro 2015-02-02 15:43:27 -0800 TestWebKitAccessibility should be skipped due to bug #132134, but it's not being skipped due to a thinko. 1066272 1 245908 mcatanzaro 2015-02-02 15:45:03 -0800 Created attachment 245908 Patch 1066384 2 cgarcia 2015-02-03 00:39:02 -0800 This probably means the test is not so flaky, I prefer not to skip tests that are working. 1066401 3 mcatanzaro 2015-02-03 05:31:43 -0800 It fails very often, or I would not propose to skip it, see bug #132134 1066404 4 cgarcia 2015-02-03 05:46:26 -0800 (In reply to comment #3) > It fails very often, or I would not propose to skip it, see bug #132134 how often? where did you get that information from? I don't see the test failing in the bots: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29 1066406 5 mcatanzaro 2015-02-03 05:57:03 -0800 (In reply to comment #4) > how often? I've seen it work sometimes, but it almost always fails when I run it unless it is the only test being run (and even then it sometimes works, so "flaky"). There's also bug #140413. > where did you get that information from? I don't see the test > failing in the bots: > > https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29 I don't know why it works on the bots. At least we should remove the broken skip, if nothing else. 1066407 6 mcatanzaro 2015-02-03 05:59:03 -0800 Specifically, https://bugs.webkit.org/show_bug.cgi?id=132134#c12 1066414 7 cgarcia 2015-02-03 06:38:14 -0800 Skipped tests are for the bots, if this depends on the environment and it works in the bots, I would just remove the incorrect skip, and let the test run in the bots. Skipped tests are a source of unnoticed regressions. 1066416 8 245938 mcatanzaro 2015-02-03 07:09:28 -0800 Created attachment 245938 Patch 1066483 9 245938 commit-queue 2015-02-03 10:25:54 -0800 Comment on attachment 245938 Patch Clearing flags on attachment: 245938 Committed r179554: <http://trac.webkit.org/changeset/179554> 1066484 10 commit-queue 2015-02-03 10:25:57 -0800 All reviewed patches have been landed. Closing bug. 245908 2015-02-02 15:45:03 -0800 2015-02-03 07:09:25 -0800 Patch bug-141179-20150202174512.patch text/plain 1809 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NDY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjJjY2Y0N2I1NDVjZWYzMjM4MTgzY2UwY2ZjMzgyZmJk MjJmNTJmZC4uZGU2NGQ3N2M0MmI4YWZkMzM4ZDIzNDAxM2IzMDczNDNlNDc0ZGIyYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTAyLTAyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBUZXN0V2ViS2l0QWNjZXNzaWJpbGl0eSBzaG91bGQgYmUgc2tp cHBlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQx MTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVh bGx5IHNraW0gVGVzdFdlYktpdEFjY2Vzc2liaWxpdHkKKworICAgICAgICAqIFNjcmlwdHMvcnVu LWd0ay10ZXN0czoKKyAgICAgICAgKFRlc3RSdW5uZXIpOgorCiAyMDE1LTAxLTMxICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIGV2ZW4gbW9yZSBNb3VudGFp biBMaW9uIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBi L1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwppbmRleCA4YTgyNjkzNGU0MjhmNzJlZWM4MmFm OTE4OWM1Yzk1Y2YyYWFhZjdmLi5hZTIxMWU2ZWJiZjA4YmRhZDFkNGIyOTM5Yzc2MDNlNjY1ZjU3 NWY3IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMv U2NyaXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC02Myw3ICs2Myw3IEBAIGNsYXNzIFRlc3RSdW5uZXI6 CiAgICAgU0tJUFBFRCA9IFsKICAgICAgICAgU2tpcHBlZFRlc3QoIldlYktpdDJHdGsvVGVzdFVJ Q2xpZW50IiwgIi93ZWJraXQyL1dlYktpdFdlYlZpZXcvbW91c2UtdGFyZ2V0IiwgIlRlc3QgdGlt ZXMgb3V0IGFmdGVyIHIxNTA4OTAiLCAxMTc2ODkpLAogICAgICAgICBTa2lwcGVkVGVzdCgiV2Vi S2l0Mkd0ay9UZXN0Q29udGV4dE1lbnUiLCBTa2lwcGVkVGVzdC5FTlRJUkVfU1VJVEUsICJUZXN0 IHRpbWVzIG91dCBhZnRlciByMTUwODkwIiwgMTE3Njg5KSwKLSAgICAgICAgU2tpcHBlZFRlc3Qo IldlYktpdDJBUElUZXN0cy9UZXN0V2ViS2l0QWNjZXNzaWJpbGl0eSIsICIvd2Via2l0Mi9XZWJL aXRBY2Nlc3NpYmlsaXR5L2F0c3BpLWJhc2ljLWhpZXJhcmNoeSIsICJUZXN0IGlzIGZsYWt5Iiwg MTMyMTM0KSwKKyAgICAgICAgU2tpcHBlZFRlc3QoIldlYktpdDJHdGsvVGVzdFdlYktpdEFjY2Vz c2liaWxpdHkiLCAiL3dlYmtpdDIvV2ViS2l0QWNjZXNzaWJpbGl0eS9hdHNwaS1iYXNpYy1oaWVy YXJjaHkiLCAiVGVzdCBpcyBmbGFreSIsIDEzMjEzNCksCiAgICAgICAgIFNraXBwZWRUZXN0KCJX ZWJLaXQyR3RrL1Rlc3RDb29raWVNYW5hZ2VyIiwgIi93ZWJraXQyL1dlYktpdENvb2tpZU1hbmFn ZXIvcGVyc2lzdGVudC1zdG9yYWdlIiwgIlRlc3QgaXMgZmxha3kiLCAxMzQ1ODApLAogICAgICAg ICBTa2lwcGVkVGVzdCgiV2ViS2l0Mi9UZXN0V2ViS2l0MiIsICJXZWJLaXQyLk1vdXNlTW92ZUFm dGVyQ3Jhc2giLCAiVGVzdCBpcyBmbGFreSIsIDg1MDY2KSwKICAgICAgICAgU2tpcHBlZFRlc3Qo IldlYktpdDIvVGVzdFdlYktpdDIiLCAiV2ViS2l0Mi5OZXdGaXJzdFZpc3VhbGx5Tm9uRW1wdHlM YXlvdXRGb3JJbWFnZXMiLCAiVGVzdCBpcyBmbGFreSIsIDg1MDY2KSwK 245938 2015-02-03 07:09:28 -0800 2015-02-03 10:25:54 -0800 Patch bug-141179-20150203090927.patch text/plain 1781 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NDY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjJjY2Y0N2I1NDVjZWYzMjM4MTgzY2UwY2ZjMzgyZmJk MjJmNTJmZC4uOTgwY2U0YWE3YTkxZmIxMjkwYThjNTVlMmQzNjg4MzQwYzRjZmIyYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTAyLTAzICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBUZXN0V2ViS2l0QWNjZXNzaWJpbGl0eSBpcyBub3Qgc2tpcHBl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMTc5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qg YXR0ZW1wdCB0byBza2lwIFRlc3RXZWJLaXRBY2Nlc3NpYmlsaXR5LiBUaGlzIHBhdGggaXMgd3Jv bmcgc28gaXQgd2FzIG5vdCBiZWluZworICAgICAgICBza2lwcGVkLCBhbmQgaXQgYXBwYXJlbnRs eSB3b3JrcyByZWxpYWJseSBvbiB0aGUgYm90cy4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWd0 ay10ZXN0czoKKyAgICAgICAgKFRlc3RSdW5uZXIpOgorCiAyMDE1LTAxLTMxICBTYW0gV2Vpbmln ICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIGV2ZW4gbW9yZSBNb3VudGFpbiBM aW9uIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBiL1Rv b2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwppbmRleCA4YTgyNjkzNGU0MjhmNzJlZWM4MmFmOTE4 OWM1Yzk1Y2YyYWFhZjdmLi4xNGQxZWFhYzkzN2UwZGE5NWRmZjY2NjhiOWQxMDlhYTY3NGQ5OGU1 IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMvU2Ny aXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC02Myw3ICs2Myw2IEBAIGNsYXNzIFRlc3RSdW5uZXI6CiAg ICAgU0tJUFBFRCA9IFsKICAgICAgICAgU2tpcHBlZFRlc3QoIldlYktpdDJHdGsvVGVzdFVJQ2xp ZW50IiwgIi93ZWJraXQyL1dlYktpdFdlYlZpZXcvbW91c2UtdGFyZ2V0IiwgIlRlc3QgdGltZXMg b3V0IGFmdGVyIHIxNTA4OTAiLCAxMTc2ODkpLAogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0 Mkd0ay9UZXN0Q29udGV4dE1lbnUiLCBTa2lwcGVkVGVzdC5FTlRJUkVfU1VJVEUsICJUZXN0IHRp bWVzIG91dCBhZnRlciByMTUwODkwIiwgMTE3Njg5KSwKLSAgICAgICAgU2tpcHBlZFRlc3QoIldl YktpdDJBUElUZXN0cy9UZXN0V2ViS2l0QWNjZXNzaWJpbGl0eSIsICIvd2Via2l0Mi9XZWJLaXRB Y2Nlc3NpYmlsaXR5L2F0c3BpLWJhc2ljLWhpZXJhcmNoeSIsICJUZXN0IGlzIGZsYWt5IiwgMTMy MTM0KSwKICAgICAgICAgU2tpcHBlZFRlc3QoIldlYktpdDJHdGsvVGVzdENvb2tpZU1hbmFnZXIi LCAiL3dlYmtpdDIvV2ViS2l0Q29va2llTWFuYWdlci9wZXJzaXN0ZW50LXN0b3JhZ2UiLCAiVGVz dCBpcyBmbGFreSIsIDEzNDU4MCksCiAgICAgICAgIFNraXBwZWRUZXN0KCJXZWJLaXQyL1Rlc3RX ZWJLaXQyIiwgIldlYktpdDIuTW91c2VNb3ZlQWZ0ZXJDcmFzaCIsICJUZXN0IGlzIGZsYWt5Iiwg ODUwNjYpLAogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0Mi9UZXN0V2ViS2l0MiIsICJXZWJL aXQyLk5ld0ZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckltYWdlcyIsICJUZXN0IGlzIGZs YWt5IiwgODUwNjYpLAo=