141170 2015-02-02 14:11:02 -0800 Add diagnostic logging for ResourceResponse's source 2015-02-02 18:22:45 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez barraclough commit-queue japhet kling koivisto oldest_to_newest 1066217 0 cdumez 2015-02-02 14:11:02 -0800 Add diagnostic logging for ResourceResponse's source (network, disk cache, disk cache after validation) to give us an idea of our network cache efficacy. Radar: <rdar://problem/19632080> 1066219 1 245899 cdumez 2015-02-02 14:15:09 -0800 Created attachment 245899 Patch 1066299 2 245899 koivisto 2015-02-02 17:14:53 -0800 Comment on attachment 245899 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245899&action=review > Source/WebCore/loader/ResourceLoader.cpp:300 > +static inline void logResourceResponseSource(Frame* frame, ResourceResponseBase::Source source) inline seems overkill 1066302 3 245899 koivisto 2015-02-02 17:18:38 -0800 Comment on attachment 245899 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245899&action=review >> Source/WebCore/loader/ResourceLoader.cpp:300 >> +static inline void logResourceResponseSource(Frame* frame, ResourceResponseBase::Source source) > > inline seems overkill it is nicer to use ResourceResponse::Source, the Base is just an implementation detail. 1066313 4 cdumez 2015-02-02 18:22:45 -0800 Committed r179533: <http://trac.webkit.org/changeset/179533> 245899 2015-02-02 14:15:09 -0800 2015-02-02 17:14:53 -0800 Patch bug-141170-20150202141519.patch text/plain 6554 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY5NDYwMGYxODFiOTYw N2FjMDJlNDhlYWU1MDgzNTY0YjJlODQ4Yi4uNTc4NjMyNDU0NzJjOWY5YjIzMTBhYjRhYjk2YmYy YzljZTY2NTNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE1LTAyLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGRpYWdub3N0aWMgbG9n Z2luZyBmb3IgUmVzb3VyY2VSZXNwb25zZSdzIHNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMTcwCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xOTYzMjA4MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgZGlhZ25vc3RpYyBsb2dnaW5nIGZvciBSZXNvdXJjZVJlc3BvbnNlJ3Mgc291cmNl IChuZXR3b3JrLCBkaXNrCisgICAgICAgIGNhY2hlLCBkaXNrIGNhY2hlIGFmdGVyIHZhbGlkYXRp b24pIHRvIGdpdmUgdXMgYW4gaWRlYSBvZiBvdXIgbmV0d29yaworICAgICAgICBjYWNoZSBlZmZp Y2FjeS4KKworICAgICAgICAqIGxvYWRlci9SZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpsb2dSZXNvdXJjZVJlc3BvbnNlU291cmNlKToKKyAgICAgICAgKFdlYkNvcmU6OlJl c291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorICAgICAgICAqIHBhZ2UvRGlhZ25v c3RpY0xvZ2dpbmdLZXlzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRpYWdub3N0aWNMb2dnaW5n S2V5czo6bmV0d29ya0tleSk6CisgICAgICAgIChXZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ0tl eXM6OmRpc2tDYWNoZUtleSk6CisgICAgICAgIChXZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ0tl eXM6OmRpc2tDYWNoZUFmdGVyVmFsaWRhdGlvbktleSk6CisgICAgICAgIChXZWJDb3JlOjpEaWFn bm9zdGljTG9nZ2luZ0tleXM6OnJlc291cmNlUmVzcG9uc2VLZXkpOgorICAgICAgICAoV2ViQ29y ZTo6RGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpzY3JpcHRLZXkpOgorICAgICAgICAoV2ViQ29yZTo6 RGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpzb3VyY2VLZXkpOgorICAgICAgICAqIHBhZ2UvRGlhZ25v c3RpY0xvZ2dpbmdLZXlzLmg6CisKIDIwMTUtMDItMDIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBBbWJpZ3VvdXMgbmFtaW5nOiBEbyBub3QgY2FsbCByZXBsYWNl ZENvbnRlbnRSZWN0KCkncyByZXR1cm4gdmFsdWUgcGFpbnQgcmVjdC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IDhkYjQ3NzQxNzQ3NzAzMGExMzdjZmM5NDI1 MWJmYjZkZDEzNzA4ODIuLmM1ZDZhNGU1MWFlYTkwNDE5MTY0ZjM2NTkzYzcxNDg1ZDQxN2RhNjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcApAQCAtMzIsMTIgKzMy LDE1IEBACiAKICNpbmNsdWRlICJBcHBsaWNhdGlvbkNhY2hlSG9zdC5oIgogI2luY2x1ZGUgIkF1 dGhlbnRpY2F0aW9uQ2hhbGxlbmdlLmgiCisjaW5jbHVkZSAiRGlhZ25vc3RpY0xvZ2dpbmdDbGll bnQuaCIKKyNpbmNsdWRlICJEaWFnbm9zdGljTG9nZ2luZ0tleXMuaCIKICNpbmNsdWRlICJEb2N1 bWVudExvYWRlci5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVMb2FkZXIu aCIKICNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudC5oIgogI2luY2x1ZGUgIkluc3BlY3Rvcklu c3RydW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgIkxvYWRlclN0cmF0ZWd5LmgiCisjaW5jbHVkZSAi TWFpbkZyYW1lLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyYXRl Z2llcy5oIgogI2luY2x1ZGUgIlByb2dyZXNzVHJhY2tlci5oIgpAQCAtMjk0LDYgKzI5NywyOSBA QCB2b2lkIFJlc291cmNlTG9hZGVyOjpkaWRTZW5kRGF0YSh1bnNpZ25lZCBsb25nIGxvbmcsIHVu c2lnbmVkIGxvbmcgbG9uZykKIHsKIH0KIAorc3RhdGljIGlubGluZSB2b2lkIGxvZ1Jlc291cmNl UmVzcG9uc2VTb3VyY2UoRnJhbWUqIGZyYW1lLCBSZXNvdXJjZVJlc3BvbnNlQmFzZTo6U291cmNl IHNvdXJjZSkKK3sKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm47CisKKyAgICBTdHJp bmcgc291cmNlS2V5OworICAgIHN3aXRjaCAoc291cmNlKSB7CisgICAgY2FzZSBSZXNvdXJjZVJl c3BvbnNlQmFzZTo6U291cmNlOjpOZXR3b3JrOgorICAgICAgICBzb3VyY2VLZXkgPSBEaWFnbm9z dGljTG9nZ2luZ0tleXM6Om5ldHdvcmtLZXkoKTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBS ZXNvdXJjZVJlc3BvbnNlQmFzZTo6U291cmNlOjpEaXNrQ2FjaGU6CisgICAgICAgIHNvdXJjZUtl eSA9IERpYWdub3N0aWNMb2dnaW5nS2V5czo6ZGlza0NhY2hlS2V5KCk7CisgICAgICAgIGJyZWFr OworICAgIGNhc2UgUmVzb3VyY2VSZXNwb25zZUJhc2U6OlNvdXJjZTo6RGlza0NhY2hlQWZ0ZXJW YWxpZGF0aW9uOgorICAgICAgICBzb3VyY2VLZXkgPSBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmRp c2tDYWNoZUFmdGVyVmFsaWRhdGlvbktleSgpOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFJl c291cmNlUmVzcG9uc2VCYXNlOjpTb3VyY2U6OlVua25vd246CisgICAgICAgIHJldHVybjsKKyAg ICB9CisKKyAgICBmcmFtZS0+bWFpbkZyYW1lKCkuZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQoKS5s b2dEaWFnbm9zdGljTWVzc2FnZVdpdGhWYWx1ZShEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnJlc291 cmNlUmVzcG9uc2VLZXkoKSwgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpzb3VyY2VLZXkoKSwgc291 cmNlS2V5KTsKK30KKwogdm9pZCBSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKGNv bnN0IFJlc291cmNlUmVzcG9uc2UmIHIpCiB7CiAgICAgQVNTRVJUKCFtX3JlYWNoZWRUZXJtaW5h bFN0YXRlKTsKQEAgLTMwMiw2ICszMjgsOCBAQCB2b2lkIFJlc291cmNlTG9hZGVyOjpkaWRSZWNl aXZlUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcikKICAgICAvLyBhbnl0aGluZyBp bmNsdWRpbmcgcG9zc2libHkgZGVyZWZpbmcgdGhpczsgb25lIGV4YW1wbGUgb2YgdGhpcyBpcyBS YWRhciAzMjY2MjE2LgogICAgIFJlZjxSZXNvdXJjZUxvYWRlcj4gcHJvdGVjdCgqdGhpcyk7CiAK KyAgICBsb2dSZXNvdXJjZVJlc3BvbnNlU291cmNlKG1fZnJhbWUuZ2V0KCksIHIuc291cmNlKCkp OworCiAgICAgbV9yZXNwb25zZSA9IHI7CiAKICAgICBpZiAoRm9ybURhdGEqIGRhdGEgPSBtX3Jl cXVlc3QuaHR0cEJvZHkoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25v c3RpY0xvZ2dpbmdLZXlzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dp bmdLZXlzLmNwcAppbmRleCAxZDJkZjc4ZGRmOGNlY2I4ZjRlYzRjZTZiZmYwODQ4Y2MzY2YxMmY0 Li40NjQ1ZjcyMGMwYjZkMGRkYzFjNDY2MDQwMjY1YzliN2U5M2RiNjk1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuY3BwCkBAIC0xMDMsNiArMTAzLDEx IEBAIFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6Om5hdmlnYXRpb25LZXkoKQogICAgIHJl dHVybiBBU0NJSUxpdGVyYWwoIm5hdmlnYXRpb24iKTsKIH0KIAorU3RyaW5nIERpYWdub3N0aWNM b2dnaW5nS2V5czo6bmV0d29ya0tleSgpCit7CisgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgibmV0 d29yayIpOworfQorCiBTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpub0NhY2hlS2V5KCkK IHsKICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJub0NhY2hlIik7CkBAIC0yNjMsNiArMjY4LDE2 IEBAIFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmRldmljZVByb3hpbWl0eUtleSgpCiAg ICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiZGV2aWNlUHJveGltaXR5Iik7CiB9CiAKK1N0cmluZyBE aWFnbm9zdGljTG9nZ2luZ0tleXM6OmRpc2tDYWNoZUtleSgpCit7CisgICAgcmV0dXJuIEFTQ0lJ TGl0ZXJhbCgiZGlza0NhY2hlIik7Cit9CisKK1N0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6 OmRpc2tDYWNoZUFmdGVyVmFsaWRhdGlvbktleSgpCit7CisgICAgcmV0dXJuIEFTQ0lJTGl0ZXJh bCgiZGlza0NhY2hlQWZ0ZXJWYWxpZGF0aW9uIik7Cit9CisKIFN0cmluZyBEaWFnbm9zdGljTG9n Z2luZ0tleXM6OnJlbG9hZEtleSgpCiB7CiAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgicmVsb2Fk Iik7CkBAIC0yNzgsNiArMjkzLDExIEBAIFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnJl c291cmNlUmVxdWVzdEtleSgpCiAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgicmVzb3VyY2VSZXF1 ZXN0Iik7CiB9CiAKK1N0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnJlc291cmNlUmVzcG9u c2VLZXkoKQoreworICAgIHJldHVybiBBU0NJSUxpdGVyYWwoInJlc291cmNlUmVzcG9uc2UiKTsK K30KKwogU3RyaW5nIERpYWdub3N0aWNMb2dnaW5nS2V5czo6cmV2YWxpZGF0aW5nS2V5KCkKIHsK ICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJyZXZhbGlkYXRpbmciKTsKQEAgLTI5OCw2ICszMTgs MTEgQEAgU3RyaW5nIERpYWdub3N0aWNMb2dnaW5nS2V5czo6c2NyaXB0S2V5KCkKICAgICByZXR1 cm4gQVNDSUlMaXRlcmFsKCJzY3JpcHQiKTsKIH0KIAorU3RyaW5nIERpYWdub3N0aWNMb2dnaW5n S2V5czo6c291cmNlS2V5KCkKK3sKKyAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJzb3VyY2VLZXki KTsKK30KKwogU3RyaW5nIERpYWdub3N0aWNMb2dnaW5nS2V5czo6c3R5bGVTaGVldEtleSgpCiB7 CiAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgic3R5bGVTaGVldCIpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmgKaW5kZXggNWU1NGFmZjBiYzUyZTUzYzg4ZWVm MGM1ZmJmODE4OWM4OWMyYjVhMS4uN2Q2Mzc0NDQyMDdhMGNjYzQ1NDI1YWE2ZTQwMWEyM2Q3MDBj ZTM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tl eXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5oCkBA IC00MCw2ICs0MCw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgU3RyaW5nIGRldmljZU1vdGlvbktl eSgpOwogICAgIHN0YXRpYyBTdHJpbmcgZGV2aWNlT3JpZW50YXRpb25LZXkoKTsKICAgICBzdGF0 aWMgU3RyaW5nIGRldmljZVByb3hpbWl0eUtleSgpOworICAgIHN0YXRpYyBTdHJpbmcgZGlza0Nh Y2hlS2V5KCk7CisgICAgc3RhdGljIFN0cmluZyBkaXNrQ2FjaGVBZnRlclZhbGlkYXRpb25LZXko KTsKICAgICBzdGF0aWMgU3RyaW5nIGRvY3VtZW50TG9hZGVyU3RvcHBpbmdLZXkoKTsKICAgICBz dGF0aWMgU3RyaW5nIGVuZ2luZUZhaWxlZFRvTG9hZEtleSgpOwogICAgIHN0YXRpYyBTdHJpbmcg ZXhwaXJlZEtleSgpOwpAQCAtNjEsNiArNjMsNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFN0cmlu ZyBtZWRpYUxvYWRpbmdGYWlsZWRLZXkoKTsKICAgICBzdGF0aWMgU3RyaW5nIG11c3RSZXZhbGlk YXRlSXNFeHBpcmVkS2V5KCk7CiAgICAgc3RhdGljIFN0cmluZyBuYXZpZ2F0aW9uS2V5KCk7Cisg ICAgc3RhdGljIFN0cmluZyBuZXR3b3JrS2V5KCk7CiAgICAgc3RhdGljIFN0cmluZyBub0NhY2hl S2V5KCk7CiAgICAgc3RhdGljIFN0cmluZyBub0N1cnJlbnRIaXN0b3J5SXRlbUtleSgpOwogICAg IHN0YXRpYyBTdHJpbmcgbm9Eb2N1bWVudExvYWRlcktleSgpOwpAQCAtODYsOSArODksMTEgQEAg cHVibGljOgogICAgIHN0YXRpYyBTdHJpbmcgcmVsb2FkS2V5KCk7CiAgICAgc3RhdGljIFN0cmlu ZyByZXNvdXJjZUtleSgpOwogICAgIHN0YXRpYyBTdHJpbmcgcmVzb3VyY2VSZXF1ZXN0S2V5KCk7 CisgICAgc3RhdGljIFN0cmluZyByZXNvdXJjZVJlc3BvbnNlS2V5KCk7CiAgICAgc3RhdGljIFN0 cmluZyByZXZhbGlkYXRpbmdLZXkoKTsKICAgICBzdGF0aWMgU3RyaW5nIHNhbWVMb2FkS2V5KCk7 CiAgICAgc3RhdGljIFN0cmluZyBzY3JpcHRLZXkoKTsKKyAgICBzdGF0aWMgU3RyaW5nIHNvdXJj ZUtleSgpOwogICAgIHN0YXRpYyBTdHJpbmcgc3R5bGVTaGVldEtleSgpOwogICAgIHN0YXRpYyBT dHJpbmcgc3ZnRG9jdW1lbnRLZXkoKTsKICAgICBzdGF0aWMgU3RyaW5nIHVudXNlZEtleSgpOwo=