141169 2015-02-02 13:56:24 -0800 REGRESSION(r179477): arguments simplification no longer works 2015-02-02 15:36:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo oldest_to_newest 1066214 0 fpizlo 2015-02-02 13:56:24 -0800 That change broke arguments simplification because PhantomLocal on the arguments register tells arguments simplification that it can't simplify anything. PhantomLocal also confuses the Flush strength reduction and we were also missing some other cases there. This resolves all of those issues. 1066216 1 245898 fpizlo 2015-02-02 14:01:47 -0800 Created attachment 245898 the patch 1066218 2 245898 mark.lam 2015-02-02 14:14:37 -0800 Comment on attachment 245898 the patch You added a CPS rethreading phase. Have you run perf numbers to make sure that there's no regression? r=me if no perf regression. 1066267 3 fpizlo 2015-02-02 15:34:35 -0800 (In reply to comment #2) > Comment on attachment 245898 [details] > the patch > > You added a CPS rethreading phase. Have you run perf numbers to make sure > that there's no regression? > > r=me if no perf regression. Performance is good. This is a progression on earley and no significant changes elsewhere. 1066269 4 fpizlo 2015-02-02 15:36:56 -0800 Landed in http://trac.webkit.org/changeset/179504 245898 2015-02-02 14:01:47 -0800 2015-02-02 14:14:37 -0800 the patch blah.patch text/plain 2887 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5NDk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE1LTAyLTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTihyMTc5NDc3KTogYXJndW1lbnRzIHNpbXBsaWZpY2F0aW9uIG5vIGxvbmdlciB3 b3JrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQx MTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBUaGUgb3BlcmF0aW9ucyBpbnZvbHZlZCBpbiBjYWxsZWUvc2NvcGUgYWNjZXNzIGRvbid0 IGV4aXQgYW5kIHNob3VsZG4ndCBnZXQgaW4gdGhlIHdheQorICAgICAgICBvZiBzdHJlbmd0aC1y ZWR1Y2luZyBhIEZsdXNoIHRvIGEgUGhhbnRvbUxvY2FsLiBUaGVuIHRoZSBQaGFudG9tTG9jYWwg c2hvdWxkbid0IGdldCBpbgorICAgICAgICB0aGUgd2F5IG9mIGZ1cnRoZXIgc3VjaCBzdHJlbmd0 aC1yZWR1Y3Rpb24uIFdlIGFsc28gbmVlZCB0byBjYW5vbmljYWxpemUgUGhhbnRvbUxvY2FsCisg ICAgICAgIGJlZm9yZSBydW5uaW5nIGFyZ3VtZW50cyBzaW1wbGlmaWNhdGlvbi4KKworICAgICAg ICAqIGRmZy9ERkdNYXlFeGl0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjptYXlFeGl0KToKKyAg ICAgICAgKiBkZmcvREZHUGxhbi5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6UGxhbjo6Y29tcGls ZUluVGhyZWFkSW1wbCk6CisgICAgICAgICogZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2Uu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OlN0cmVuZ3RoUmVkdWN0aW9uUGhhc2U6OmhhbmRsZU5v ZGUpOgorCiAyMDE1LTAyLTAyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3VwcG9ydCBjb25zb2xlLnRhYmxlCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR01heUV4aXQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTWF5RXhpdC5jcHAJKHJldmlzaW9uIDE3OTQ3OCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTWF5RXhpdC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTgxLDYgKzgxLDkgQEAgYm9vbCBtYXlFeGl0KEdyYXBoJiBncmFwaCwgTm9kZSogbm9k ZSkKICAgICBjYXNlIFBoYW50b21OZXdPYmplY3Q6CiAgICAgY2FzZSBQdXRMb2NhbDoKICAgICBj YXNlIEtpbGxMb2NhbDoKKyAgICBjYXNlIEdldENhbGxlZToKKyAgICBjYXNlIEdldFNjb3BlOgor ICAgIGNhc2UgUGhhbnRvbUxvY2FsOgogICAgICAgICBicmVhazsKICAgICAgICAgCiAgICAgZGVm YXVsdDoKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcAkocmV2aXNpb24g MTc5NDc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjU3LDggKzI1Nyw5IEBAIFBsYW46OkNvbXBpbGF0aW9uUGF0aCBQbGFuOjpj b21waWxlSW5UaHIKICAgICAgICAgCiAgICAgcGVyZm9ybVN0cmVuZ3RoUmVkdWN0aW9uKGRmZyk7 CiAgICAgcGVyZm9ybUxvY2FsQ1NFKGRmZyk7CisgICAgcGVyZm9ybUNQU1JldGhyZWFkaW5nKGRm Zyk7IC8vIENhbm9uaWNhbGl6ZSBQaGFudG9tTG9jYWwgdG8gUGhhbnRvbQogICAgIHBlcmZvcm1B cmd1bWVudHNTaW1wbGlmaWNhdGlvbihkZmcpOwotICAgIHBlcmZvcm1DUFNSZXRocmVhZGluZyhk ZmcpOworICAgIHBlcmZvcm1DUFNSZXRocmVhZGluZyhkZmcpOyAvLyBUaGlzIHNob3VsZCBkbyBu b3RoaW5nLCBpZiBhcmd1bWVudHMgc2ltcGxpZmljYXRpb24gZGlkIG5vdGhpbmcuCiAgICAgcGVy Zm9ybUNGQShkZmcpOwogICAgIHBlcmZvcm1Db25zdGFudEZvbGRpbmcoZGZnKTsKICAgICBib29s IGNoYW5nZWQgPSBmYWxzZTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Ry ZW5ndGhSZWR1Y3Rpb25QaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTdHJlbmd0aFJlZHVjdGlvblBoYXNlLmNwcAkocmV2aXNpb24gMTc5NDc4KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJlbmd0aFJlZHVjdGlvblBoYXNlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjU2LDYgKzI1Niw4IEBAIHByaXZhdGU6CiAgICAgICAgICAg ICAgICAgICAgIGNhc2UgRG91YmxlQ29uc3RhbnQ6CiAgICAgICAgICAgICAgICAgICAgIGNhc2Ug SW50NTJDb25zdGFudDoKICAgICAgICAgICAgICAgICAgICAgY2FzZSBHZXRTY29wZToKKyAgICAg ICAgICAgICAgICAgICAgY2FzZSBQaGFudG9tTG9jYWw6CisgICAgICAgICAgICAgICAgICAgIGNh c2UgR2V0Q2FsbGVlOgogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg ICAgICAgCiAgICAgICAgICAgICAgICAgICAgIGRlZmF1bHQ6Cg==