141167 2015-02-02 12:15:59 -0800 Restore interface before exiting optimized fullscreen mode. 2015-02-03 15:45:39 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue eric.carlson oldest_to_newest 1066186 0 jeremyj-wk 2015-02-02 12:15:59 -0800 Restore interface before exiting optimized fullscreen mode. 1066189 1 245893 jeremyj-wk 2015-02-02 12:25:33 -0800 Created attachment 245893 Patch 1066601 2 245893 simon.fraser 2015-02-03 15:32:32 -0800 Comment on attachment 245893 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245893&action=review > Source/WebCore/platform/spi/ios/AVKitSPI.h:77 > +- (void)playerViewController:(AVPlayerViewController *)playerViewController restoreUserInterfaceForOptimizedFullscreeStopWithCompletionHandler:(void (^)(BOOL restored))completionHandler; restoreUserInterfaceForOptimizedFullscree*n*StopWithCompletionHandler? I think this would be much nicer as some kind of "did exit fullscreen" with some flags. 1066614 3 245893 commit-queue 2015-02-03 15:45:36 -0800 Comment on attachment 245893 Patch Clearing flags on attachment: 245893 Committed r179575: <http://trac.webkit.org/changeset/179575> 1066615 4 commit-queue 2015-02-03 15:45:39 -0800 All reviewed patches have been landed. Closing bug. 245893 2015-02-02 12:25:33 -0800 2015-02-03 15:45:36 -0800 Patch bug-141167-20150202122542.patch text/plain 4023 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJhNDI0NTViMzE4Mzk3 NGUxYTFhODdjMDg4MTM0MDkyYjRlYTM2Yi4uMGI1ZWUxOTY2MjU3NWE3ZTM0MWZiNjFkMzhjYWM4 MDJjN2NlZmNjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAyLTAyICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBSZXN0b3JlIGludGVyZmFj ZSBiZWZvcmUgZXhpdGluZyBvcHRpbWl6ZWQgZnVsbHNjcmVlbiBtb2RlLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMTY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgYWxsb3dzIHRo ZSB1c2VyIGludGVyZmFjZSB0byBiZSByZXN0b3JlZCBiZWZvcmUgZXhpdGluZyBvcHRpbWl6ZWQg ZnVsbHNjcmVlbiBtb2RlLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNj cmVlbkludGVyZmFjZUFWS2l0Lmg6IEFkZCBkZWNsYXJhdGlvbi4KKyAgICAgICAgKiBwbGF0Zm9y bS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW06IAorICAgICAgICAoLVtX ZWJBVlBsYXllckNvbnRyb2xsZXIgcGxheWVyVmlld0NvbnRyb2xsZXI6cmVzdG9yZVVzZXJJbnRl cmZhY2VGb3JPcHRpbWl6ZWRGdWxsc2NyZWVuU3RvcFdpdGhDb21wbGV0aW9uSGFuZGxlcjpdKTog QWRkZWQuCisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZnVsbHNj cmVlbk1heVJldHVyblRvSW5saW5lKTogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vc3BpL2lv cy9BVktpdFNQSS5oOiBBZGQgbmV3IFNQSS4KKwogMjAxNS0wMS0xNiAgQ29tbWl0IFF1ZXVlICA8 Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjE3ODUzMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJW aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0LmgKaW5kZXggM2Y3MWJhMjVhNWVm YjE3MWNiYzIxN2YwNGE5NGJlOGY4ZWYyNDFlYS4uMDE1MmI0YmQ1YTAwNTNiYjM5MzI0NTdkN2Jl MTBlMjUwODc0YmY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dl YlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0LmgKQEAgLTkzLDYgKzkz LDcgQEAgcHVibGljOgogICAgIEhUTUxNZWRpYUVsZW1lbnQ6OlZpZGVvRnVsbHNjcmVlbk1vZGUg bW9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fbW9kZTsgfQogICAgIHZvaWQgc2V0SXNPcHRpbWl6ZWQo Ym9vbCk7CiAgICAgYm9vbCBtYXlBdXRvbWF0aWNhbGx5U2hvd1ZpZGVvT3B0aW1pemVkKCk7Cisg ICAgYm9vbCBmdWxsc2NyZWVuTWF5UmV0dXJuVG9JbmxpbmUoKTsKIAogcHJvdGVjdGVkOgogICAg IHZvaWQgc2V0dXBGdWxsc2NyZWVuSW50ZXJuYWwoUGxhdGZvcm1MYXllciYsIEludFJlY3QgaW5p dGlhbFJlY3QsIFVJVmlldyAqLCBIVE1MTWVkaWFFbGVtZW50OjpWaWRlb0Z1bGxzY3JlZW5Nb2Rl LCBib29sIGFsbG93T3B0aW1pemVkRnVsbHNjcmVlbik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZL aXQubW0KaW5kZXggYWVlMTllNzdhMWQxMTRiNjA1MjQ2MTU4YThlZDY5MjRmODk3ZmMzZC4uODAy OTZkMTY3M2Y2NmY3ZjUxNDAyMDUwYWQ5OTgxZTNlMTQwZjQ2MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VBVktpdC5tbQpAQCAtMTc1LDYgKzE3NSwxMiBAQCBTT0ZUX0xJTktfQ09OU1RBTlQoQ29y ZU1lZGlhLCBrQ01UaW1lSW5kZWZpbml0ZSwgQ01UaW1lKQogICAgIHJldHVybiBOTzsKIH0KIAor LSAodm9pZClwbGF5ZXJWaWV3Q29udHJvbGxlcjooQVZQbGF5ZXJWaWV3Q29udHJvbGxlciAqKXBs YXllclZpZXdDb250cm9sbGVyIHJlc3RvcmVVc2VySW50ZXJmYWNlRm9yT3B0aW1pemVkRnVsbHNj cmVlblN0b3BXaXRoQ29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKEJPT0wgcmVzdG9yZWQpKWNv bXBsZXRpb25IYW5kbGVyCit7CisgICAgVU5VU0VEX1BBUkFNKHBsYXllclZpZXdDb250cm9sbGVy KTsKKyAgICBjb21wbGV0aW9uSGFuZGxlcihzZWxmLmZ1bGxzY3JlZW5JbnRlcmZhY2UtPmZ1bGxz Y3JlZW5NYXlSZXR1cm5Ub0lubGluZSgpKTsKK30KKwogLSAodm9pZClwbGF5OihpZClzZW5kZXIK IHsKICAgICBVTlVTRURfUEFSQU0oc2VuZGVyKTsKQEAgLTExMjEsNSArMTEyNywxMCBAQCBib29s IFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjptYXlBdXRvbWF0aWNhbGx5U2hvd1Zp ZGVvT3B0aW1pemVkKCkKICAgICByZXR1cm4gW21fcGxheWVyQ29udHJvbGxlciBpc1BsYXlpbmdd ICYmIG1fbW9kZSA9PSBIVE1MTWVkaWFFbGVtZW50OjpWaWRlb0Z1bGxzY3JlZW5Nb2RlU3RhbmRh cmQgJiYgd2tJc09wdGltaXplZEZ1bGxzY3JlZW5TdXBwb3J0ZWQoKTsKIH0KIAorYm9vbCBXZWJW aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZnVsbHNjcmVlbk1heVJldHVyblRvSW5saW5l KCkKK3sKKyAgICBtX2Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlci0+ZnVsbHNjcmVlbk1heVJldHVy blRvSW5saW5lKCk7CisgICAgcmV0dXJuIHRydWU7Cit9CiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL2lvcy9BVktpdFNQSS5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vc3BpL2lvcy9BVktpdFNQSS5oCmluZGV4IGY3OGFmOWEwMTZkZGQzYjA1MDhk OWUzMDRkNWRlNTMzMGQzOGFmMDUuLjI3MTM0YTFjYTliNmNjMmJjZWU5ZWZiNTg4Y2QyOTBlMmRj YTIwNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9pb3MvQVZLaXRT UEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvaW9zL0FWS2l0U1BJLmgKQEAg LTc0LDYgKzc0LDcgQEAgdHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwgQVZQbGF5ZXJWaWV3Q29u dHJvbGxlckV4aXRGdWxsU2NyZWVuUmVhc29uKSB7CiAgICAgQVZQbGF5ZXJWaWV3Q29udHJvbGxl ckV4aXRGdWxsU2NyZWVuUmVhc29uUmVtb3RlQ29udHJvbFN0b3BFdmVudFJlY2VpdmVkID0gMywK IH07CiAtIChCT09MKXBsYXllclZpZXdDb250cm9sbGVyOihBVlBsYXllclZpZXdDb250cm9sbGVy ICopcGxheWVyVmlld0NvbnRyb2xsZXIgc2hvdWxkRXhpdEZ1bGxTY3JlZW5XaXRoUmVhc29uOihB VlBsYXllclZpZXdDb250cm9sbGVyRXhpdEZ1bGxTY3JlZW5SZWFzb24pcmVhc29uOworLSAodm9p ZClwbGF5ZXJWaWV3Q29udHJvbGxlcjooQVZQbGF5ZXJWaWV3Q29udHJvbGxlciAqKXBsYXllclZp ZXdDb250cm9sbGVyIHJlc3RvcmVVc2VySW50ZXJmYWNlRm9yT3B0aW1pemVkRnVsbHNjcmVlU3Rv cFdpdGhDb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoQk9PTCByZXN0b3JlZCkpY29tcGxldGlv bkhhbmRsZXI7CiBAZW5kCiAKIHR5cGVkZWYgTlNJbnRlZ2VyIEFWUGxheWVyVmlld0NvbnRyb2xs ZXJPcHRpbWl6ZWRGdWxsc2NyZWVuU3RvcFJlYXNvbjsK