141166 2015-02-02 11:52:29 -0800 Web Inspector: CSS Autocompletion: Autodetect many color supporting properties 2015-02-02 14:45:04 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1066169 0 joepeck 2015-02-02 11:52:29 -0800 * SUMMARY CSS Autocompletion: Autodetect many color supporting properties. This will be useful for custom properties for a CSS augmented agent. We could even thin our own list to shorthand properties lacking "color", but I think it is fine to keep the list nearly complete for now. 1066171 1 webkit-bug-importer 2015-02-02 11:53:09 -0800 <rdar://problem/19687816> 1066173 2 245890 joepeck 2015-02-02 11:54:42 -0800 Created attachment 245890 [PATCH] Proposed Fix 1066239 3 joepeck 2015-02-02 14:45:04 -0800 http://trac.webkit.org/changeset/179501 245890 2015-02-02 11:54:42 -0800 2015-02-02 14:34:30 -0800 [PATCH] Proposed Fix color.patch text/plain 4078 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlhZTlmN2EuLmI4ZTk4YzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAyLTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIEF1 dG9jb21wbGV0aW9uOiBBdXRvZGV0ZWN0IG1hbnkgY29sb3Igc3VwcG9ydGluZyBwcm9wZXJ0aWVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDExNjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanM6CisgICAgICAgIEFkZCBTdHJpbmcucHJvdG90eXBl LmVuZHNXaXRoLiBHcm91cCBTdHJpbmcgZXh0ZW5zaW9ucyB0b2dldGhlci4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMuZm9yUHJvcGVydHkpOgorICAgICAg ICBJZiBhIHByb3BlcnR5IG5hbWUgZW5kcyBpbiAiY29sb3IiLCBwcm92aWRlIENTUyBjb2xvciBj b21wbGV0aW9ucy4KKworICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9u cy5pc0NvbG9yQXdhcmVQcm9wZXJ0eSk6IERlbGV0ZWQuCisgICAgICAgIFRoaXMgd2FzIHVudXNl ZCBhbmQgZGlzYWdyZWVzIHNsaWdodGx5IHdpdGggdGhlIGltcGxlbWVudGF0aW9uIGFib3ZlLgor CiAyMDE1LTAxLTI5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogRXh0ZW5kIENTUy5nZXRTdXBwb3J0ZWRDU1NQcm9wZXJ0aWVz IHRvIHByb3ZpZGUgdmFsdWVzIGZvciBwcm9wZXJ0aWVzIGZvciBDU1MgQXVnbWVudGVkIEpTQ29u dGV4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9VdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNl L1V0aWxpdGllcy5qcwppbmRleCA0MTg2YzExLi44ZDJkZGRmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcwpAQCAtMzkz LDE0ICszOTMsNiBAQCBPYmplY3QuZGVmaW5lUHJvcGVydHkoRG9jdW1lbnRGcmFnbWVudC5wcm90 b3R5cGUsICJjcmVhdGVDaGlsZCIsCiAgICAgdmFsdWU6IEVsZW1lbnQucHJvdG90eXBlLmNyZWF0 ZUNoaWxkCiB9KTsKIAotT2JqZWN0LmRlZmluZVByb3BlcnR5KFN0cmluZy5wcm90b3R5cGUsICJj b250YWlucyIsCi17Ci0gICAgdmFsdWU6IGZ1bmN0aW9uKHZhbHVlKQotICAgIHsKLSAgICAgICAg cmV0dXJuIHRoaXMuaW5kZXhPZih2YWx1ZSkgIT09IC0xOwotICAgIH0KLX0pOwotCiBPYmplY3Qu ZGVmaW5lUHJvcGVydHkoQXJyYXkucHJvdG90eXBlLCAiY29udGFpbnMiLAogewogICAgIHZhbHVl OiBmdW5jdGlvbih2YWx1ZSkKQEAgLTQ0NCw2ICs0MzYsMTQgQEAgT2JqZWN0LmRlZmluZVByb3Bl cnR5KEFycmF5LnByb3RvdHlwZSwgImtleVNldCIsCiAgICAgfQogfSk7CiAKK09iamVjdC5kZWZp bmVQcm9wZXJ0eShTdHJpbmcucHJvdG90eXBlLCAiY29udGFpbnMiLAoreworICAgIHZhbHVlOiBm dW5jdGlvbih2YWx1ZSkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLmluZGV4T2YodmFsdWUp ICE9PSAtMTsKKyAgICB9Cit9KTsKKwogT2JqZWN0LmRlZmluZVByb3BlcnR5KFN0cmluZy5wcm90 b3R5cGUsICJ0cmltTWlkZGxlIiwKIHsKICAgICB2YWx1ZTogZnVuY3Rpb24obWF4TGVuZ3RoKQpA QCAtNTkyLDYgKzU5MiwxNyBAQCBPYmplY3QuZGVmaW5lUHJvcGVydHkoU3RyaW5nLnByb3RvdHlw ZSwgInN0YXJ0c1dpdGgiLAogICAgIH0KIH0pOwogCitPYmplY3QuZGVmaW5lUHJvcGVydHkoU3Ry aW5nLnByb3RvdHlwZSwgImVuZHNXaXRoIiwKK3sKKyAgICB2YWx1ZTogZnVuY3Rpb24oc3RyaW5n KQorICAgIHsKKyAgICAgICAgdmFyIHBvc2l0aW9uID0gdGhpcy5sZW5ndGggLSBzdHJpbmcubGVu Z3RoOworICAgICAgICBpZiAocG9zaXRpb24gPCAwKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNl OworICAgICAgICByZXR1cm4gdGhpcy5pbmRleE9mKHN0cmluZywgcG9zaXRpb24pID09PSBwb3Np dGlvbjsKKyAgICB9Cit9KTsKKwogT2JqZWN0LmRlZmluZVByb3BlcnR5KFN0cmluZy5wcm90b3R5 cGUsICJoYXNoIiwKIHsKICAgICBnZXQ6IGZ1bmN0aW9uKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29y ZENvbXBsZXRpb25zLmpzCmluZGV4IGNjN2IwMTcuLjg2NmVhNGIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlv bnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NT U0tleXdvcmRDb21wbGV0aW9ucy5qcwpAQCAtNDUsNiArNDUsOCBAQCBXZWJJbnNwZWN0b3IuQ1NT S2V5d29yZENvbXBsZXRpb25zLmZvclByb3BlcnR5ID0gZnVuY3Rpb24ocHJvcGVydHlOYW1lKQog ICAgICAgICBhY2NlcHRlZEtleXdvcmRzID0gYWNjZXB0ZWRLZXl3b3Jkcy5jb25jYXQoV2ViSW5z cGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fY29sb3JzKTsKICAgICBlbHNlIGlmIChpc05v dFByZWZpeGVkICYmICgiLXdlYmtpdC0iICsgcHJvcGVydHlOYW1lKSBpbiBXZWJJbnNwZWN0b3Iu Q1NTS2V5d29yZENvbXBsZXRpb25zLl9jb2xvckF3YXJlUHJvcGVydGllcykKICAgICAgICAgYWNj ZXB0ZWRLZXl3b3JkcyA9IGFjY2VwdGVkS2V5d29yZHMuY29uY2F0KFdlYkluc3BlY3Rvci5DU1NL ZXl3b3JkQ29tcGxldGlvbnMuX2NvbG9ycyk7CisgICAgZWxzZSBpZiAocHJvcGVydHlOYW1lLmVu ZHNXaXRoKCJjb2xvciIpKQorICAgICAgICBhY2NlcHRlZEtleXdvcmRzID0gYWNjZXB0ZWRLZXl3 b3Jkcy5jb25jYXQoV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fY29sb3JzKTsK IAogICAgIC8vIE9ubHkgc3VnZ2VzdCAiaW5oZXJpdCIgb24gaW5oZXJpdGFibGUgcHJvcGVydGll cyBldmVuIHRob3VnaCBpdCBpcyB2YWxpZCBvbiBhbGwgcHJvcGVydGllcy4KICAgICBpZiAocHJv cGVydHlOYW1lIGluIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMuSW5oZXJpdGVk UHJvcGVydGllcykKQEAgLTYwLDExICs2Miw2IEBAIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29t cGxldGlvbnMuZm9yUHJvcGVydHkgPSBmdW5jdGlvbihwcm9wZXJ0eU5hbWUpCiAgICAgcmV0dXJu IG5ldyBXZWJJbnNwZWN0b3IuQ1NTQ29tcGxldGlvbnMoYWNjZXB0ZWRLZXl3b3JkcywgdHJ1ZSk7 CiB9OwogCi1XZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLmlzQ29sb3JBd2FyZVBy b3BlcnR5ID0gZnVuY3Rpb24ocHJvcGVydHlOYW1lKQotewotICAgIHJldHVybiBXZWJJbnNwZWN0 b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLl9jb2xvckF3YXJlUHJvcGVydGllc1twcm9wZXJ0eU5h bWVdID09PSB0cnVlOwotfTsKLQogV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5h ZGRDdXN0b21Db21wbGV0aW9ucyA9IGZ1bmN0aW9uKHByb3BlcnRpZXMpCiB7CiAgICAgLy8gQ09N UEFUSUJJTElUWSAoaU9TIDYpOiBUaGlzIHVzZWQgdG8gYmUgYW4gYXJyYXkgb2Ygc3RyaW5ncy4g VGhleSB3b24ndCBoYXZlIGN1c3RvbSB2YWx1ZXMuCg==