141164 2015-02-02 11:01:53 -0800 run-jsc-stress-tests should pass JSC_timeout to remote hosts 2015-02-11 09:10:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141079 141165 1 ossy ossy commit-queue darin fpizlo ggaren mark.lam mhahnenb msaboff oliver ossy oldest_to_newest 1066149 0 ossy 2015-02-02 11:01:53 -0800 SSIA 1066151 1 245886 ossy 2015-02-02 11:06:17 -0800 Created attachment 245886 Patch 1066464 2 245886 mhahnenb 2015-02-03 09:56:19 -0800 Comment on attachment 245886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245886&action=review > Tools/Scripts/run-jsc-stress-tests:1364 > + remoteScript += "export DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" && " > + remoteScript += "export JSC_timeout=#{Shellwords.shellescape(ENV['JSC_timeout'])} && " > + remoteScript += "sh runscript\"" I think if you're going to export these you should also unset them after executing the runscript or something. 1066470 3 ossy 2015-02-03 10:06:29 -0800 (In reply to comment #2) > Comment on attachment 245886 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245886&action=review > > > Tools/Scripts/run-jsc-stress-tests:1364 > > + remoteScript += "export DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" && " > > + remoteScript += "export JSC_timeout=#{Shellwords.shellescape(ENV['JSC_timeout'])} && " > > + remoteScript += "sh runscript\"" > > I think if you're going to export these you should also unset them after > executing the runscript or something. These exports are valid for this ssh command and its child processes, they are reset automatically after the command finished. 1067647 4 ossy 2015-02-07 23:06:36 -0800 ping? 1068343 5 ossy 2015-02-11 06:35:46 -0800 Dear reviewers, could you possibly review this patch? 1068371 6 245886 commit-queue 2015-02-11 09:10:18 -0800 Comment on attachment 245886 Patch Clearing flags on attachment: 245886 Committed r179930: <http://trac.webkit.org/changeset/179930> 1068372 7 commit-queue 2015-02-11 09:10:23 -0800 All reviewed patches have been landed. Closing bug. 245886 2015-02-02 11:06:17 -0800 2015-02-11 09:10:18 -0800 Patch bug-141164-20150202110625.patch text/plain 2653 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NDc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjhkZWMzZjAwZjFiNzA3MDNhMjgxMGUwZjc2NmM3MGU4 ZjBjOWEzMi4uMTVmNDQ2ZmM1NGI2MmNhNWVhOGM4YWVlZGU1OWQ0YjMzNzBiMzk2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDE1LTAyLTAyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgcnVuLWpzYy1zdHJlc3MtdGVzdHMgc2hvdWxkIHBhc3MgSlNDX3RpbWVvdXQgdG8g cmVtb3RlIGhvc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDExNjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGRpdG9uYWxseSByZW1vdmVkIElNUE9SVEFOVF9FTlZTLCBzaW5jZSBKU0NfdGltZW91 dCB3YXMgdGhlIG9ubHkgb25lLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10 ZXN0czoKKworMjAxNS0wMi0wMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgorCiAgICAgICAgIFJlbW92ZSBjb3B5L3Bhc3RlIGNvZGUgZnJvbSBydW4tanNjLXN0cmVzcy10 ZXN0cyB0byBkZXRlcm1pbmUgbnVtYmVyT2ZUZXN0cwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMTU4CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRl c3RzCmluZGV4IDdlZjIzOTA2NmZmY2U2YTE2NGM0YzZjMzU2OWQyNzRkY2UwYjI2YjcuLjA0NDVm YmRjZWJjZGE5MzA5ZDI0MmIzMjNlMjNkZjM5Mjc5NDAxNGIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0 cmVzcy10ZXN0cwpAQCAtMzksOCArMzksNiBAQCByYWlzZSB1bmxlc3MgU0NSSVBUU19QQVRILmRp cm5hbWUuYmFzZW5hbWUudG9fcyA9PSAiVG9vbHMiCiAKIEhFTFBFUlNfUEFUSCA9IFNDUklQVFNf UEFUSCArICJqc2Mtc3RyZXNzLXRlc3QtaGVscGVycyIKIAotSU1QT1JUQU5UX0VOVlMgPSBbIkpT Q190aW1lb3V0Il0KLQogYmVnaW4KICAgICByZXF1aXJlICdzaGVsbHdvcmRzJwogcmVzY3VlIEV4 Y2VwdGlvbiA9PiBlCkBAIC00ODUsMTIgKzQ4Myw3IEBAIGNsYXNzIFBsYW4KICAgICAgICAgc2Ny aXB0ICs9ICJjZCAucnVubmVyXG4iCiAKICAgICAgICAgc2NyaXB0ICs9ICJleHBvcnQgRFlMRF9G UkFNRVdPUktfUEFUSD0kKGNkICN7JHRlc3RpbmdGcmFtZXdvcmtQYXRoLmRpcm5hbWV9OyBwd2Qp XG4iCi0gICAgICAgIElNUE9SVEFOVF9FTlZTLmVhY2ggewotICAgICAgICAgICAgfCBrZXkgfAot ICAgICAgICAgICAgaWYgRU5WW2tleV0KLSAgICAgICAgICAgICAgICBzY3JpcHQgKz0gImV4cG9y dCAje2tleX09I3tTaGVsbHdvcmRzLnNoZWxsZXNjYXBlKEVOVltrZXldKX1cbiIKLSAgICAgICAg ICAgIGVuZAotICAgICAgICB9CisgICAgICAgIHNjcmlwdCArPSAiZXhwb3J0IEpTQ190aW1lb3V0 PSN7U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShFTlZbJ0pTQ190aW1lb3V0J10pfVxuIgogICAgICAg ICBzY3JpcHQgKz0gIiN7c2hlbGxDb21tYW5kfSB8fCBleGl0IDEiCiAgICAgICAgICJlY2hvICN7 U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShzY3JpcHQpfSA+ICN7U2hlbGx3b3Jkcy5zaGVsbGVzY2Fw ZSgoUGF0aG5hbWUubmV3KCIuLiIpICsgQG5hbWUpLnRvX3MpfSIKICAgICBlbmQKQEAgLTEzNjYs OCArMTM1OSw5IEBAIGRlZiBydW5TaGVsbFRlc3RSdW5uZXIKICAgICAgICAgcmVtb3RlU2NyaXB0 ICs9ICJybSAtcmYgI3skb3V0cHV0RGlyLmJhc2VuYW1lfSAmJiAiCiAgICAgICAgIHJlbW90ZVNj cmlwdCArPSAidGFyIHh6ZiAjeyR0YXJGaWxlTmFtZX0gJiYgIgogICAgICAgICByZW1vdGVTY3Jp cHQgKz0gImNkICN7JG91dHB1dERpci5iYXNlbmFtZX0vLnJ1bm5lciAmJiAiCi0gICAgICAgIHJl bW90ZVNjcmlwdCArPSAiRFlMRF9GUkFNRVdPUktfUEFUSD1cXFwiXFwkKGNkICN7JHRlc3RpbmdG cmFtZXdvcmtQYXRoLmRpcm5hbWV9OyBwd2QpXFxcIiBzaCBydW5zY3JpcHQiCi0gICAgICAgIHJl bW90ZVNjcmlwdCArPSAiXCIiCisgICAgICAgIHJlbW90ZVNjcmlwdCArPSAiZXhwb3J0IERZTERf RlJBTUVXT1JLX1BBVEg9XFxcIlxcJChjZCAjeyR0ZXN0aW5nRnJhbWV3b3JrUGF0aC5kaXJuYW1l fTsgcHdkKVxcXCIgJiYgIgorICAgICAgICByZW1vdGVTY3JpcHQgKz0gImV4cG9ydCBKU0NfdGlt ZW91dD0je1NoZWxsd29yZHMuc2hlbGxlc2NhcGUoRU5WWydKU0NfdGltZW91dCddKX0gJiYgIgor ICAgICAgICByZW1vdGVTY3JpcHQgKz0gInNoIHJ1bnNjcmlwdFwiIgogICAgICAgICBydW5BbmRN b25pdG9yVGVzdFJ1bm5lckNvbW1hbmQoInNzaCIsICItcCIsICRyZW1vdGVQb3J0LnRvX3MsICIj eyRyZW1vdGVVc2VyfUAjeyRyZW1vdGVIb3N0fSIsIHJlbW90ZVNjcmlwdCkKICAgICBlbHNlCiAg ICAgICAgIERpci5jaGRpcigkcnVubmVyRGlyKSB7Cg==