141115 2015-01-31 04:59:55 -0800 new Date(NaN).toJSON() must return null instead of throwing a TypeError 2015-08-27 18:53:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://es5.github.io/#x15.9.5.44 ES5, InRadar P2 Normal --- 1 claude.pache ljharb commit-queue darin fpizlo ljharb p.niemirski timothy webkit-bug-importer ysuzuki oldest_to_newest 1065809 0 claude.pache 2015-01-31 04:59:55 -0800 When the toJSON method is applied to an invalid date, it must return null, and not throwing a TypeError. Note that this behaviour is different from the toISOString method. For reference, see [ES5.1 Date.prototype.toJSON], steps 2 and 3. [ES5.1 Date.prototype.toJSON]: http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.5.44 1110406 1 ljharb 2015-07-18 17:29:11 -0700 It'd be nice to fix this one - Safari/WebKit seem to be skipping step 3. 1110518 2 257066 ljharb 2015-07-19 14:45:58 -0700 Created attachment 257066 Patch 1110530 3 257066 ysuzuki 2015-07-19 15:20:19 -0700 Comment on attachment 257066 Patch r=me 1110533 4 257066 darin 2015-07-19 15:37:44 -0700 Comment on attachment 257066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257066&action=review > Source/JavaScriptCore/runtime/DatePrototype.cpp:1076 > + JSValue timeValue = object->toPrimitive(exec, PreferNumber); This patch seems wrong. If "this" has a valueOf function, the code will call that function, but will ignore the value the function returns except for checking it to see if it’s infinity or NaN. I don’t think that’s correct behavior. Is that really the behavior the specification calls for? If so, why? 1110534 5 ljharb 2015-07-19 15:40:05 -0700 Absolutely it is. It's specifically to catch the case that WebKit is buggy here on: when toISOString() would throw, toJSON should NOT throw, but should return `null`. 1110535 6 ljharb 2015-07-19 15:40:47 -0700 Put another way, serializing an object to JSON should ideally never cause it to throw, but you can't serialize an invalid date to JSON in WebKit - because it throws (incorrectly). 1110536 7 darin 2015-07-19 15:44:01 -0700 OK, that sounds wrong. This will work with the built in toISOString function. But note that we intentionally call whatever toISOString function is present, which could be any arbitrary function. How can we predict what toISOString will do without calling it? It could even be a function that returns different values when you call it multiple times. I’m pretty sure the right way to handle this is to detect that toISOString tried to throw an exception, and then clear the exception and return null. Not to try to preflight it, which can’t be done reliably. 1110537 8 257066 ysuzuki 2015-07-19 15:44:07 -0700 Comment on attachment 257066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257066&action=review >> Source/JavaScriptCore/runtime/DatePrototype.cpp:1076 >> + JSValue timeValue = object->toPrimitive(exec, PreferNumber); > > This patch seems wrong. > > If "this" has a valueOf function, the code will call that function, but will ignore the value the function returns except for checking it to see if it’s infinity or NaN. I don’t think that’s correct behavior. > > Is that really the behavior the specification calls for? If so, why? This behavior is actually specified here. http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.5.44 1. Let O be the result of calling ToObject, giving it the this value as its argument. 2. Let tv be ToPrimitive(O, hint Number). 3. If tv is a Number and is not finite, return null. 4. Let toISO be the result of calling the [[Get]] internal method of O with argument "toISOString". 5. If IsCallable(toISO) is false, throw a TypeError exception. 6. Return the result of calling the [[Call]] internal method of toISO with O as the this value and an empty argument list. And it is the same in the ES6 spec. http://ecma-international.org/ecma-262/6.0/#sec-date.prototype.tojso tv is just used to check that the toPrimitive result value is finite or not. I think this is becacuse Date#toJSON is defined as the generic function. The spec notes that > NOTE 2 The toJSON function is intentionally generic; it does not require that its this value be a Date object. Therefore, it can be transferred to other kinds of objects for use as a method. However, it does require that any such object have a toISOString method. So to check the held value, instead of extracting the value of Date's private field, it calls `toPrimitive` to extract it from the possibly date object. 1110538 9 darin 2015-07-19 15:46:10 -0700 OK, that is a strange way to specify it, but I accept that it’s what the standard calls for. 1110540 10 257066 commit-queue 2015-07-19 16:11:25 -0700 Comment on attachment 257066 Patch Clearing flags on attachment: 257066 Committed r187016: <http://trac.webkit.org/changeset/187016> 1110541 11 commit-queue 2015-07-19 16:11:29 -0700 All reviewed patches have been landed. Closing bug. 1121534 12 webkit-bug-importer 2015-08-27 18:53:12 -0700 <rdar://problem/22468732> 257066 2015-07-19 14:45:58 -0700 2015-07-19 16:11:25 -0700 Patch bug-141115-20150719144446.patch text/plain 3775 ljharb U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk YzkxYzFiOGE1YzhjNmY0MGZiNWIxNzJjYTliMDBhZmEwZDI4NjNmLi44MDAzMmRiZDhkNjc2YjE1 OGUxOTg3NzBjNDE4OTI1MjJlMTAwNWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0wNy0xOSAgSm9yZGFuIEhhcmJhbmQgIDxsamhhcmJAZ21haWwuY29t PgorCisgICAgICAgIG5ldyBEYXRlKE5hTikudG9KU09OKCkgbXVzdCByZXR1cm4gbnVsbCBpbnN0 ZWFkIG9mIHRocm93aW5nIGEgVHlwZUVycm9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDExMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvRGF0ZVByb3RvdHlwZS5jcHA6CisgICAgICAg IChKU0M6OmRhdGVQcm90b0Z1bmNUb0pTT04pOgorCiAyMDE1LTA3LTE4ICBTYWFtIGJhcmF0aSAg PHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KIAogICAgICAgICBsZXhpY2FsIHNjb3BpbmcgaXMgYnJv a2VuIHdpdGggcmVzcGVjdCB0byAiYnJlYWsiIGFuZCAiY29udGludWUiCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCmluZGV4IDc3ZGIxMDJmMGYy MjZhNGQ2N2RiYzA4YmZlMGQ5NTQ0MWVmMzYwNWUuLmZlODc0NzkxNjhmOWQwOTFiZjExOWExNTY2 YWRiM2QxNjIxYzhmOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0RhdGVQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Rh dGVQcm90b3R5cGUuY3BwCkBAIC0xMDcyLDcgKzEwNzIsMTMgQEAgRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBkYXRlUHJvdG9GdW5jVG9KU09OKEV4ZWNTdGF0ZSogZXhlYykKICAgICBKU09i amVjdCogb2JqZWN0ID0ganNDYXN0PEpTT2JqZWN0Kj4odGhpc1ZhbHVlLnRvVGhpcyhleGVjLCBO b3RTdHJpY3RNb2RlKSk7CiAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQogICAgICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTnVsbCgpKTsKLSAgICAKKworICAgIEpTVmFsdWUgdGlt ZVZhbHVlID0gb2JqZWN0LT50b1ByaW1pdGl2ZShleGVjLCBQcmVmZXJOdW1iZXIpOworICAgIGlm IChleGVjLT5oYWRFeGNlcHRpb24oKSkKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShq c051bGwoKSk7CisgICAgaWYgKHRpbWVWYWx1ZS5pc051bWJlcigpICYmICEodGltZVZhbHVlLmlz SW50MzIoKSB8fCBzdGQ6OmlzZmluaXRlKHRpbWVWYWx1ZS5hc0RvdWJsZSgpKSkpCisgICAgICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdWxsKCkpOworCiAgICAgSlNWYWx1ZSB0b0lTT1Zh bHVlID0gb2JqZWN0LT5nZXQoZXhlYywgZXhlYy0+dm0oKS5wcm9wZXJ0eU5hbWVzLT50b0lTT1N0 cmluZyk7CiAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQogICAgICAgICByZXR1cm4gSlNW YWx1ZTo6ZW5jb2RlKGpzTnVsbCgpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ODk2ZmIxZDAyMmY5NWMxOWU1OTg5YmY2 NjAyZmY5YTRmYTYzMjJkLi41YTZkNDFjMGE3NWZiNTVlYWM1YzQ4MDc0OWViMDE3Y2FiNzFjM2Nm IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDctMTkgIEpvcmRhbiBIYXJiYW5kICA8bGpo YXJiQGdtYWlsLmNvbT4KKworICAgICAgICBuZXcgRGF0ZShOYU4pLnRvSlNPTigpIG11c3QgcmV0 dXJuIG51bGwgaW5zdGVhZCBvZiB0aHJvd2luZyBhIFR5cGVFcnJvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMTE1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqcy9kb20vSlNPTi1zdHJpbmdpZnkt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGpzL3Jlc291cmNlcy9KU09OLXN0cmluZ2lmeS5qczoK KwogMjAxNS0wNy0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIGluc3BlY3Rvci9jb25zb2xlL2NvbW1hbmQtbGluZS1hcGkuaHRtbCBpcyBzbG93IG9uIERl YnVnIFlvc2VtaXRlIFdLMgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvZG9tL0pTT04tc3Ry aW5naWZ5LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2pzL2RvbS9KU09OLXN0cmluZ2lmeS1l eHBlY3RlZC50eHQKaW5kZXggYmZkODI0Nzk2MWI5NmQwNzM3NTBjYjVlMzRkMDY1Y2ZlNTQ2ZGUz OS4uOGU3MzJlYzc2MjRiNTQ1Y2MzYWJjMjM3ZjQ3YjQ2NjE5NmIzYmYwZCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvanMvZG9tL0pTT04tc3RyaW5naWZ5LWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9qcy9kb20vSlNPTi1zdHJpbmdpZnktZXhwZWN0ZWQudHh0CkBAIC05Nyw2ICs5Nywx MCBAQCBmdW5jdGlvbiAoanNvbk9iamVjdCl7CiAgICAgfQogUEFTUyB0ZXN0c1tpXShuYXRpdmVK U09OKSB0aHJldyBleGNlcHRpb24gQW4gZXhjZXB0aW9uLgogZnVuY3Rpb24gKGpzb25PYmplY3Qp eworICAgICAgICByZXR1cm4ganNvbk9iamVjdC5zdHJpbmdpZnkobmV3IERhdGUoTmFOKSk7Cisg ICAgfQorUEFTUyB0ZXN0c1tpXShuYXRpdmVKU09OKSBpcyB0ZXN0c1tpXS5leHBlY3RlZAorZnVu Y3Rpb24gKGpzb25PYmplY3QpewogICAgICAgICB2YXIgZCA9IG5ldyBEYXRlKDApOwogICAgICAg ICBkLnRvSVNPU3RyaW5nID0gbnVsbDsKICAgICAgICAgcmV0dXJuIGpzb25PYmplY3Quc3RyaW5n aWZ5KGQpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvcmVzb3VyY2VzL0pTT04tc3RyaW5n aWZ5LmpzIGIvTGF5b3V0VGVzdHMvanMvcmVzb3VyY2VzL0pTT04tc3RyaW5naWZ5LmpzCmluZGV4 IGJlYzE4ODViYjhmMGEyNGFkYTc4ZDY2MDc5OGM2YzZmNWY3MDFjYzYuLmUxZTNlNjA3YmNjOWI1 YjM4ZmJiOTExOGU2YTUwZmI0YTliOGU5ODYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL3Jl c291cmNlcy9KU09OLXN0cmluZ2lmeS5qcworKysgYi9MYXlvdXRUZXN0cy9qcy9yZXNvdXJjZXMv SlNPTi1zdHJpbmdpZnkuanMKQEAgLTEwMSw2ICsxMDEsMTAgQEAgZnVuY3Rpb24gY3JlYXRlVGVz dHMoKSB7CiAgICAgfSk7CiAgICAgcmVzdWx0W3Jlc3VsdC5sZW5ndGggLSAxXS50aHJvd3MgPSB0 cnVlOwogICAgIHJlc3VsdC5wdXNoKGZ1bmN0aW9uKGpzb25PYmplY3QpeworICAgICAgICByZXR1 cm4ganNvbk9iamVjdC5zdHJpbmdpZnkobmV3IERhdGUoTmFOKSk7CisgICAgfSk7CisgICAgcmVz dWx0W3Jlc3VsdC5sZW5ndGggLSAxXS5leHBlY3RlZCA9ICdudWxsJzs7CisgICAgcmVzdWx0LnB1 c2goZnVuY3Rpb24oanNvbk9iamVjdCl7CiAgICAgICAgIHZhciBkID0gbmV3IERhdGUoMCk7CiAg ICAgICAgIGQudG9JU09TdHJpbmcgPSBudWxsOwogICAgICAgICByZXR1cm4ganNvbk9iamVjdC5z dHJpbmdpZnkoZCk7Cg==