141112 2015-01-31 00:50:31 -0800 REGRESSION (r177689): Emoji variation sequences rendered incorrectly (as characters from other non-emoji font) 2015-01-31 20:17:59 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 mitz mmaxfield ap commit-queue mmaxfield oldest_to_newest 1065793 0 mitz 2015-01-31 00:50:31 -0800 <rdar://problem/19656263> For example, ♥️ (BLACK HEART SUIT + VS16) looks like “î G”. This was caused by a mistake in <http://trac.webkit.org/r177689>, the fix for bug 138683: in ComplexTextController::collectComplexTextRunsForCharacters(), the test if (CFEqual(cgFont.get(), runCGFont.get())) was replaced with a tautology if (CFEqual(runFontEqualityObject.get(), runFontEqualityObject.get())) This is easy to fix by removing the (re)definition of runFontEqualityObject inside the for loop and checking if (CFEqual(runFont->platformData().objectForEqualityCheck().get(), runFontEqualityObject.get())) 1065867 1 mmaxfield 2015-01-31 14:31:36 -0800 Whoops :( 1065888 2 245806 mmaxfield 2015-01-31 16:46:20 -0800 Created attachment 245806 Patch 1065928 3 245806 commit-queue 2015-01-31 20:17:56 -0800 Comment on attachment 245806 Patch Clearing flags on attachment: 245806 Committed r179459: <http://trac.webkit.org/changeset/179459> 1065929 4 commit-queue 2015-01-31 20:17:59 -0800 All reviewed patches have been landed. Closing bug. 245806 2015-01-31 16:46:20 -0800 2015-01-31 20:17:56 -0800 Patch bug-141112-20150131164628.patch text/plain 4211 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjU2Njc4YzRmYTBjZGMx ZjMxYjU5YjJhODUwNDczNTMyNDI3YzdkMy4uMWU1YTQ3NTk0MjA1M2QzMzlmYmY4Mjc3YTFhNmNi NTU5Nzk0MzQ0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAxLTMxICBNeWxl cyBDLiBNYXhmaWVsZCAgPGxpdGhlcnVtQGdtYWlsLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9O IChyMTc3Njg5KTogRW1vamkgdmFyaWF0aW9uIHNlcXVlbmNlcyByZW5kZXJlZCBpbmNvcnJlY3Rs eSAoYXMgY2hhcmFjdGVycyBmcm9tIG90aGVyIG5vbi1lbW9qaSBmb250KQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMTEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHlwbyBpbiByMTc3Njg5LgorCisg ICAgICAgIFRlc3Q6IHBsYXRmb3JtL21hYy9mYXN0L3RleHQvY29tYmluaW5nLW1hcmstcGFpbnQu aHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJv bGxlckNvcmVUZXh0Lm1tOgorICAgICAgICAoV2ViQ29yZTo6Q29tcGxleFRleHRDb250cm9sbGVy Ojpjb2xsZWN0Q29tcGxleFRleHRSdW5zRm9yQ2hhcmFjdGVycyk6CisKIDIwMTUtMDEtMzAgIFNh bSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNZXJnZSBTaW1wbGVGb250RGF0 YUlPUy5tbSBhbmQgU2ltcGxlRm9udERhdGFNYWMubW0gaW50byBGb250Q29jb2EubW0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENv bnRyb2xsZXJDb3JlVGV4dC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21h Yy9Db21wbGV4VGV4dENvbnRyb2xsZXJDb3JlVGV4dC5tbQppbmRleCA3OWUxYWNhZGUwZDI3OTZj ZTgwMDk0MjQzODk1MzFmZmNkN2Y0ODc2Li5kNmVjM2E2YmEyODc0ZjUyM2FmYzhkMjlhZmMyZDA3 ZjcyMTgzMjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvQ29tcGxleFRleHRDb250cm9sbGVyQ29yZVRleHQubW0KKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlckNvcmVUZXh0Lm1tCkBA IC0yNjEsOCArMjYxLDcgQEAgdm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OmNvbGxlY3RDb21w bGV4VGV4dFJ1bnNGb3JDaGFyYWN0ZXJzKGNvbnN0IFVDaGFyKiBjcCwKICAgICAgICAgICAgICAg ICAgICAgcnVuRm9udCA9IG1fZm9udC5mYWxsYmFja1Jhbmdlc0F0KGkpLmZvbnRGb3JDaGFyYWN0 ZXIoYmFzZUNoYXJhY3Rlcik7CiAgICAgICAgICAgICAgICAgICAgIGlmICghcnVuRm9udCkKICAg ICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAgICAgICAgICBSZXRh aW5QdHI8Q0ZUeXBlUmVmPiBydW5Gb250RXF1YWxpdHlPYmplY3QgPSBydW5Gb250LT5wbGF0Zm9y bURhdGEoKS5vYmplY3RGb3JFcXVhbGl0eUNoZWNrKCk7Ci0gICAgICAgICAgICAgICAgICAgIGlm IChDRkVxdWFsKHJ1bkZvbnRFcXVhbGl0eU9iamVjdC5nZXQoKSwgcnVuRm9udEVxdWFsaXR5T2Jq ZWN0LmdldCgpKSkKKyAgICAgICAgICAgICAgICAgICAgaWYgKENGRXF1YWwocnVuRm9udC0+cGxh dGZvcm1EYXRhKCkub2JqZWN0Rm9yRXF1YWxpdHlDaGVjaygpLmdldCgpLCBydW5Gb250RXF1YWxp dHlPYmplY3QuZ2V0KCkpKQogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICAgICAgICAgIHJ1bkZvbnQgPSBudWxscHRyOwogICAgICAgICAgICAgICAgIH0KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCA5MmE0MjAxZDNiOTkwNGVkZWU4NDA5ZjQ0MzM5MjhmYTVjZDIzMjdmLi5hYThmNmVmMDljMDkx NmE0ZjEyMDZkZjM2YjZkZDQ1YmViMjZmN2QwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUt MDEtMzEgIE15bGVzIEMuIE1heGZpZWxkICA8bGl0aGVydW1AZ21haWwuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIxNzc2ODkpOiBFbW9qaSB2YXJpYXRpb24gc2VxdWVuY2VzIHJlbmRlcmVk IGluY29ycmVjdGx5IChhcyBjaGFyYWN0ZXJzIGZyb20gb3RoZXIgbm9uLWVtb2ppIGZvbnQpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDExMTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt L21hYy9mYXN0L3RleHQvY29tYmluaW5nLW1hcmstcGFpbnQtZXhwZWN0ZWQuaHRtbDogQWRkZWQu CisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3QvdGV4dC9jb21iaW5pbmctbWFyay1wYWludC5o dG1sOiBBZGRlZC4KKwogMjAxNS0wMS0zMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRA Y3JmLmNhbm9uLmZyPgogCiAgICAgICAgIEltcG9ydCBXM0Mgd2ViIHBsYXRmb3JtIHRlc3RzIGlu ZnJhc3RydWN0dXJlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90 ZXh0L2NvbWJpbmluZy1tYXJrLXBhaW50LWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvZmFzdC90ZXh0L2NvbWJpbmluZy1tYXJrLXBhaW50LWV4cGVjdGVkLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uYjUyOWZhNGE4YzlmZTc0OGY1MzE0ZTZlMzU2NTgzMDliOTc5MDA0MAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RleHQvY29tYmluaW5n LW1hcmstcGFpbnQtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDkgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD48L2hlYWQ+Cis8Ym9keT4KK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHRo YXQgY29tYmluaW5nIG1hcmtzIGFyZSBkcmF3bi4gSXQgZG9lcyBzbyBieSBkcmF3aW5nIGEgY29t YmluaW5nIG1hcmsgaW50byBhIGNvbnRleHQgd2hpY2ggaGFzIGJlZW4gY2xpcHBlZCBzbyB0aGF0 IHRoZSBlbnRpcmUgYm94IGlzIGZpbGxlZCB3aXRoIHRoZSBjb21iaW5pbmcgbWFyay4KKzxkaXYg c3R5bGU9IndpZHRoOiA3NTBweDsgaGVpZ2h0OiA2MHB4OyBiYWNrZ3JvdW5kOiBibGFjazsiPgor PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZmFzdC90ZXh0L2NvbWJpbmluZy1tYXJrLXBhaW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvZmFzdC90ZXh0L2NvbWJpbmluZy1tYXJrLXBhaW50Lmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uYzk5Y2Q2OGZkMTJiYWJlZWVjNzlhNjlkNDIwNDAxZDQ4NTZhMWNhZgotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RleHQvY29tYmluaW5nLW1hcmst cGFpbnQuaHRtbApAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhl YWQ+PC9oZWFkPgorPGJvZHk+CitUaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0IGNvbWJpbmluZyBt YXJrcyBhcmUgZHJhd24uIEl0IGRvZXMgc28gYnkgZHJhd2luZyBhIGNvbWJpbmluZyBtYXJrIGlu dG8gYSBjb250ZXh0IHdoaWNoIGhhcyBiZWVuIGNsaXBwZWQgc28gdGhhdCB0aGUgZW50aXJlIGJv eCBpcyBmaWxsZWQgd2l0aCB0aGUgY29tYmluaW5nIG1hcmsuCis8ZGl2IHN0eWxlPSJ3aWR0aDog NzUwcHg7IGhlaWdodDogNjBweDsgb3ZlcmZsb3c6IGhpZGRlbjsiPgorPGRpdiBzdHlsZT0icG9z aXRpb246IHJlbGF0aXZlOyBsZWZ0OiAwcHg7IHRvcDogLTI2MHB4OyBmb250LXNpemU6IDEwMDBw eDsiPiZuYnNwOyYjeDAzNWU7PGRpdj4KKzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=