141097 2015-01-30 13:35:57 -0800 GC marking threads should clear malloc caches 2015-01-30 17:16:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren barraclough cdumez kling mhahnenb oldest_to_newest 1065632 0 ggaren 2015-01-30 13:35:57 -0800 GC marking threads should clear malloc caches 1065646 1 245740 ggaren 2015-01-30 14:11:14 -0800 Created attachment 245740 Patch 1065648 2 245740 kling 2015-01-30 14:18:53 -0800 Comment on attachment 245740 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245740&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + This is an attempt to amelirate a potential memory use regression ameliorate 1065649 3 ggaren 2015-01-30 14:22:52 -0800 Committed r179411: <http://trac.webkit.org/changeset/179411> 1065653 4 ggaren 2015-01-30 14:27:51 -0800 Committed r179412: <http://trac.webkit.org/changeset/179412> 1065660 5 245740 mhahnenb 2015-01-30 14:50:03 -0800 Comment on attachment 245740 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245740&action=review > Source/JavaScriptCore/heap/GCThread.cpp:79 > + WTF::releaseFastMallocFreeMemoryForThisThread(); I wonder if it makes more sense to do this at the end of collection rather than between phases? Seems a shame to clear out the per-thread malloc cache between marking and copying since copying might want to reuse some stuff from the marking phase. 1065662 6 mhahnenb 2015-01-30 14:54:11 -0800 Also, maybe I dunno what scavenging is... 1065682 7 ggaren 2015-01-30 15:47:39 -0800 > I wonder if it makes more sense to do this at the end of collection rather > than between phases? Yeah, end of collection is better. How to achieve? Maybe move the code to the end of the 'case Copy' block? 1065696 8 mhahnenb 2015-01-30 16:14:46 -0800 Yeah that seems ok. There shouldn't be any parallel work left to do at the end of the CopyPhase, so that sounds like a good time to clear the malloc caches on those threads. 1065698 9 mhahnenb 2015-01-30 16:17:21 -0800 Another idea might be to only clear the caches during collections caused by the GCTimer. 1065703 10 ggaren 2015-01-30 16:27:53 -0800 Reopening to attach new patch. 1065704 11 245755 ggaren 2015-01-30 16:27:54 -0800 Created attachment 245755 Patch 1065706 12 ggaren 2015-01-30 16:29:17 -0800 Committed r179422: <http://trac.webkit.org/changeset/179422> 1065710 13 cdumez 2015-01-30 16:34:33 -0800 Looks like some JSC tests are failing on the bots after this change? https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/builds/1796/steps/jscore-test/logs/stdio 1065711 14 cdumez 2015-01-30 16:35:52 -0800 See also: https://build.webkit.org/builders/Apple%20Mavericks%20LLINT%20CLoop%20%28BuildAndTest%29/builds/11932/steps/webkit-jsc-cloop-test/logs/stdio 1065733 15 ggaren 2015-01-30 17:16:34 -0800 Turned out to be a sporadic failure in that date test. 245740 2015-01-30 14:11:14 -0800 2015-01-30 16:27:49 -0800 Patch bug-141097-20150130141121.patch text/plain 7873 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5NDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE1LTAxLTMwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgR0MgbWFya2luZyB0aHJlYWRzIHNob3VsZCBjbGVhciBtYWxsb2MgY2FjaGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEwOTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGFuIGF0dGVt cHQgdG8gYW1lbGlyYXRlIGEgcG90ZW50aWFsIG1lbW9yeSB1c2UgcmVncmVzc2lvbgorICAgICAg ICBjYXVzZWQgYnkgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDkw MAorICAgICAgICBVc2UgRmFzdE1hbGxvYyAoYm1hbGxvYykgaW5zdGVhZCBvZiBCbG9ja0FsbG9j YXRvciBmb3IgR0MgcGFnZXMuCisKKyAgICAgICAgRmFzdE1hbGxvYyBtYXkgYWNjdW11bGF0ZSBh IHBlci10aHJlYWQgY2FjaGUgb24gZWFjaCBvZiB0aGUgOC1pc2gKKyAgICAgICAgR0MgbWFya2lu ZyB0aHJlYWRzLCB3aGljaCBjYW4gYmUgZXhwZW5zaXZlLgorCisgICAgICAgICogaGVhcC9HQ1Ro cmVhZC5jcHA6CisgICAgICAgIChKU0M6OkdDVGhyZWFkOjp3YWl0Rm9yTmV4dFBoYXNlKTogU2Nh dmVuZ2UgdGhlIGN1cnJlbnQgdGhyZWFkIGJlZm9yZQorICAgICAgICBnb2luZyB0byBzbGVlcC4g VGhlcmUncyBwcm9iYWJseSBub3QgdG9vIG11Y2ggdmFsdWUgdG8ga2VlcGluZyBvdXIKKyAgICAg ICAgcGVyLXRocmVhZCBjYWNoZSBiZXR3ZWVuIEdDcywgYW5kIGl0IGhhcyBzb21lIG1lbW9yeSBm b290cHJpbnQuCisKIDIwMTUtMDEtMzAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBSZW5hbWUgc2hhcmVkKCkgc3RhdGljIG1lbWJlciBmdW5jdGlvbnMgdG8gc2lu Z2xldG9uKCkgZm9yIHNpbmdsZXRvbiBjbGFzc2VzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvR0NUaHJlYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL0dDVGhyZWFkLmNwcAkocmV2aXNpb24gMTc5NDA5KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvR0NUaHJlYWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAog LyoKLSAqIENvcHlyaWdodCAoQykgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CisgKiBDb3B5cmlnaHQgKEMpIDIwMTIsIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkg Zm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHBy b3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC03Niw2ICs3Niw4IEBAIEdD UGhhc2UgR0NUaHJlYWQ6OndhaXRGb3JOZXh0UGhhc2UoKQogICAgIGlmICghbV9zaGFyZWQubV9u dW1iZXJPZkFjdGl2ZUdDVGhyZWFkcykKICAgICAgICAgbV9zaGFyZWQubV9hY3Rpdml0eUNvbmRp dGlvblZhcmlhYmxlLm5vdGlmeV9vbmUoKTsKIAorICAgIFdURjo6cmVsZWFzZUZhc3RNYWxsb2NG cmVlTWVtb3J5Rm9yVGhpc1RocmVhZCgpOworCiAgICAgbV9zaGFyZWQubV9waGFzZUNvbmRpdGlv blZhcmlhYmxlLndhaXQobG9jaywgW3RoaXNdIHsgcmV0dXJuIG1fc2hhcmVkLm1fY3VycmVudFBo YXNlICE9IE5vUGhhc2U7IH0pOwogICAgIG1fc2hhcmVkLm1fbnVtYmVyT2ZBY3RpdmVHQ1RocmVh ZHMrKzsKICAgICByZXR1cm4gbV9zaGFyZWQubV9jdXJyZW50UGhhc2U7CkluZGV4OiBTb3VyY2Uv V1RGL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNp b24gMTc5NDA5KQorKysgU291cmNlL1dURi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxOCBAQAorMjAxNS0wMS0zMCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29t PgorCisgICAgICAgIEdDIG1hcmtpbmcgdGhyZWFkcyBzaG91bGQgY2xlYXIgbWFsbG9jIGNhY2hl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMDk3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BsaXQg dGhlIHNjYXZlbmdpbmcgQVBJIGludG8gcGVyLXRocmVhZCB2cyBnbG9iYWwsIHNvIHRoYXQgeW91 IGNhbgorICAgICAgICByZXF1ZXN0IHRvIHNjYXZlbmdlIHlvdXIgb3duIHRocmVhZCB3aXRob3V0 IHNjYXZlbmdpbmcgdGhlIHdob2xlIGhlYXAuCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5j cHA6CisgICAgICAgIChXVEY6OnJlbGVhc2VGYXN0TWFsbG9jRnJlZU1lbW9yeUZvclRoaXNUaHJl YWQpOgorICAgICAgICAoV1RGOjpUQ01hbGxvY19UaHJlYWRDYWNoZTo6Q3JlYXRlQ2FjaGVJZk5l Y2Vzc2FyeSk6CisgICAgICAgICogd3RmL0Zhc3RNYWxsb2MuaDoKKwogMjAxNS0wMS0zMCAgQW50 dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgT1NPYmplY3RQdHIgZG9l cyBub3Qgd29yayB3aXRoIGRpc3BhdGNoX2RhdGFfdCBvbiBNYXZlcmljcwpJbmRleDogU291cmNl L1dURi93dGYvRmFzdE1hbGxvYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvRmFz dE1hbGxvYy5jcHAJKHJldmlzaW9uIDE3OTQwOSkKKysrIFNvdXJjZS9XVEYvd3RmL0Zhc3RNYWxs b2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsNiBAQAogLy8gQ29weXJpZ2h0IChjKSAy MDA1LCAyMDA3LCBHb29nbGUgSW5jLgogLy8gQWxsIHJpZ2h0cyByZXNlcnZlZC4KLS8vIENvcHly aWdodCAoQykgMjAwNSwgMjAwNiwgMjAwNywgMjAwOCwgMjAwOSwgMjAxMSBBcHBsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCisvLyBDb3B5cmlnaHQgKEMpIDIwMDUsIDIwMDYsIDIwMDcsIDIw MDgsIDIwMDksIDIwMTEsIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogLy8g CiAvLyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3 aXRoIG9yIHdpdGhvdXQKIC8vIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0 aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTIwOSw2ICsyMDksNyBAQCB2b2lk KiBmYXN0UmVhbGxvYyh2b2lkKiBwLCBzaXplX3QgbikKIH0KIAogdm9pZCByZWxlYXNlRmFzdE1h bGxvY0ZyZWVNZW1vcnkoKSB7IH0KK3ZvaWQgcmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVtb3J5Rm9y VGhpc1RocmVhZCgpIHsgfQogICAgIAogRmFzdE1hbGxvY1N0YXRpc3RpY3MgZmFzdE1hbGxvY1N0 YXRpc3RpY3MoKQogewpAQCAtMjg3LDYgKzI4OCwxMSBAQCBUcnlNYWxsb2NSZXR1cm5WYWx1ZSB0 cnlGYXN0Q2FsbG9jKHNpemVfCiAgICAgcmV0dXJuIGZhc3RDYWxsb2MobnVtRWxlbWVudHMsIGVs ZW1lbnRTaXplKTsKIH0KICAgICAKK3ZvaWQgcmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVtb3J5Rm9y VGhpc1RocmVhZCgpCit7CisgICAgYm1hbGxvYzo6YXBpOjpzY2F2ZW5nZVRoaXNUaHJlYWQoKTsK K30KKwogdm9pZCByZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnkoKQogewogICAgIGJtYWxsb2M6 OmFwaTo6c2NhdmVuZ2UoKTsKQEAgLTQ0ODMsMTEgKzQ0ODksMTUgQEAgdm9pZCAqKCpfX21lbWFs aWduX2hvb2spKHNpemVfdCwgc2l6ZV90LAogI2VuZGlmCiAKICNpZmRlZiBXVEZfQ0hBTkdFUwot dm9pZCByZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnkoKQordm9pZCByZWxlYXNlRmFzdE1hbGxv Y0ZyZWVNZW1vcnlGb3JUaGlzVGhyZWFkKCkKIHsKLSAgICAvLyBGbHVzaCBmcmVlIHBhZ2VzIGlu IHRoZSBjdXJyZW50IHRocmVhZCBjYWNoZSBiYWNrIHRvIHRoZSBwYWdlIGhlYXAuCiAgICAgaWYg KFRDTWFsbG9jX1RocmVhZENhY2hlKiB0aHJlYWRDYWNoZSA9IFRDTWFsbG9jX1RocmVhZENhY2hl OjpHZXRDYWNoZUlmUHJlc2VudCgpKQogICAgICAgICB0aHJlYWRDYWNoZS0+Q2xlYW51cCgpOwor fQorCit2b2lkIHJlbGVhc2VGYXN0TWFsbG9jRnJlZU1lbW9yeSgpCit7CisgICAgcmVsZWFzZUZh c3RNYWxsb2NGcmVlTWVtb3J5Rm9yVGhpc1RocmVhZCgpOwogCiAgICAgU3BpbkxvY2tIb2xkZXIg aCgmcGFnZWhlYXBfbG9jayk7CiAgICAgcGFnZWhlYXAtPlJlbGVhc2VGcmVlUGFnZXMoKTsKSW5k ZXg6IFNvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RG L3d0Zi9GYXN0TWFsbG9jLmgJKHJldmlzaW9uIDE3OTQwOSkKKysrIFNvdXJjZS9XVEYvd3RmL0Zh c3RNYWxsb2MuaAkod29ya2luZyBjb3B5KQpAQCAtNzcsNiArNzcsNyBAQCBuYW1lc3BhY2UgV1RG IHsKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBmYXN0RnJlZSh2b2lkKik7CiAKICAgICBX VEZfRVhQT1JUX1BSSVZBVEUgdm9pZCByZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnkoKTsKKyAg ICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCByZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnlGb3JU aGlzVGhyZWFkKCk7CiAgICAgCiAgICAgc3RydWN0IEZhc3RNYWxsb2NTdGF0aXN0aWNzIHsKICAg ICAgICAgc2l6ZV90IHJlc2VydmVkVk1CeXRlczsKSW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3 OTQwOSkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTAxLTMwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+ CisKKyAgICAgICAgR0MgbWFya2luZyB0aHJlYWRzIHNob3VsZCBjbGVhciBtYWxsb2MgY2FjaGVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEwOTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGxpdCB0 aGUgc2NhdmVuZ2luZyBBUEkgaW50byBwZXItdGhyZWFkIHZzIGdsb2JhbCwgc28gdGhhdCB5b3Ug Y2FuCisgICAgICAgIHJlcXVlc3QgdG8gc2NhdmVuZ2UgeW91ciBvd24gdGhyZWFkIHdpdGhvdXQg c2NhdmVuZ2luZyB0aGUgd2hvbGUgaGVhcC4KKworICAgICAgICAqIGJtYWxsb2MvQ2FjaGUuY3Bw OgorICAgICAgICAoYm1hbGxvYzo6Q2FjaGU6OnNjYXZlbmdlKToKKyAgICAgICAgKiBibWFsbG9j L2JtYWxsb2MuaDoKKyAgICAgICAgKGJtYWxsb2M6OmFwaTo6c2NhdmVuZ2VUaGlzVGhyZWFkKToK KyAgICAgICAgKGJtYWxsb2M6OmFwaTo6c2NhdmVuZ2UpOgorCiAyMDE1LTAxLTI4ICBEYW5hIEJ1 cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBBU2FuIGZsYWcgc2V0 dGluZ3MgZnJvbSBEZWJ1Z1JlbGVhc2UueGNjb25maWcgdG8gQmFzZS54Y2NvbmZpZwpJbmRleDog U291cmNlL2JtYWxsb2MvYm1hbGxvYy9DYWNoZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2Jt YWxsb2MvYm1hbGxvYy9DYWNoZS5jcHAJKHJldmlzaW9uIDE3OTQwOSkKKysrIFNvdXJjZS9ibWFs bG9jL2JtYWxsb2MvQ2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoK LSAqIENvcHlyaWdodCAoQykgMjAxNCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiBDb3B5cmlnaHQgKEMpIDIwMTQsIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC00OCw5ICs0OCw2IEBAIHZvaWQg Q2FjaGU6OnNjYXZlbmdlKCkKIAogICAgIGNhY2hlLT5hbGxvY2F0b3IoKS5zY2F2ZW5nZSgpOwog ICAgIGNhY2hlLT5kZWFsbG9jYXRvcigpLnNjYXZlbmdlKCk7Ci0KLSAgICBzdGQ6OnVuaXF1ZV9s b2NrPFN0YXRpY011dGV4PiBsb2NrKFBlclByb2Nlc3M8SGVhcD46Om11dGV4KCkpOwotICAgIFBl clByb2Nlc3M8SGVhcD46OmdldCgpLT5zY2F2ZW5nZShsb2NrLCBzdGQ6OmNocm9ubzo6bWlsbGlz ZWNvbmRzKDApKTsKIH0KIAogQ2FjaGU6OkNhY2hlKCkKSW5kZXg6IFNvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvYm1hbGxvYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvYm1h bGxvYy5oCShyZXZpc2lvbiAxNzk0MDkpCisrKyBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL2JtYWxs b2MuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMp IDIwMTQgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAy MDE0LCAyMDE1IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3Ry aWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhv dXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucwpAQCAtMjQsNiArMjQsOSBAQAogICovCiAKICNpbmNsdWRlICJDYWNo ZS5oIgorI2luY2x1ZGUgIkhlYXAuaCIKKyNpbmNsdWRlICJQZXJQcm9jZXNzLmgiCisjaW5jbHVk ZSAiU3RhdGljTXV0ZXguaCIKIAogbmFtZXNwYWNlIGJtYWxsb2MgewogbmFtZXNwYWNlIGFwaSB7 CkBAIC00NywxMSArNTAsMTkgQEAgaW5saW5lIHZvaWQqIHJlYWxsb2Modm9pZCogb2JqZWN0LCBz aXplXwogewogICAgIHJldHVybiBDYWNoZTo6cmVhbGxvY2F0ZShvYmplY3QsIG5ld1NpemUpOwog fQotICAgIAotaW5saW5lIHZvaWQgc2NhdmVuZ2UoKQorCitpbmxpbmUgdm9pZCBzY2F2ZW5nZVRo aXNUaHJlYWQoKQogewogICAgIENhY2hlOjpzY2F2ZW5nZSgpOwogfQogCitpbmxpbmUgdm9pZCBz Y2F2ZW5nZSgpCit7CisgICAgc2NhdmVuZ2VUaGlzVGhyZWFkKCk7CisKKyAgICBzdGQ6OnVuaXF1 ZV9sb2NrPFN0YXRpY011dGV4PiBsb2NrKFBlclByb2Nlc3M8SGVhcD46Om11dGV4KCkpOworICAg IFBlclByb2Nlc3M8SGVhcD46OmdldCgpLT5zY2F2ZW5nZShsb2NrLCBzdGQ6OmNocm9ubzo6bWls bGlzZWNvbmRzKDApKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgYXBpCiB9IC8vIG5hbWVzcGFjZSBi bWFsbG9jCg== 245755 2015-01-30 16:27:54 -0800 2015-01-30 16:28:47 -0800 Patch bug-141097-20150130162801.patch text/plain 1943 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5NDIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE1LTAxLTMwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgR0MgbWFya2luZyB0aHJlYWRzIHNob3VsZCBjbGVhciBtYWxsb2MgY2FjaGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEwOTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb2xsb3ctdXAgYmFzZWQg b24gTWFyayBIYWhuZW5iZXJnJ3MgcmV2aWV3OiBSZWxlYXNlIGFmdGVyIHRoZSBjb3B5CisgICAg ICAgIHBoYXNlLCByYXRoZXIgdGhhbiBhZnRlciBhbnkgcGhhc2UsIHNpbmNlIHdlJ2QgcmF0aGVy IG5vdCByZWxlYXNlCisgICAgICAgIGJldHdlZW4gbWFya2luZyBhbmQgY29weWluZy4KKworICAg ICAgICAqIGhlYXAvR0NUaHJlYWQuY3BwOgorICAgICAgICAoSlNDOjpHQ1RocmVhZDo6d2FpdEZv ck5leHRQaGFzZSk6CisgICAgICAgIChKU0M6OkdDVGhyZWFkOjpnY1RocmVhZE1haW4pOgorCiAy MDE1LTAxLTMwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAg R0MgbWFya2luZyB0aHJlYWRzIHNob3VsZCBjbGVhciBtYWxsb2MgY2FjaGVzCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9HQ1RocmVhZC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvR0NUaHJlYWQuY3BwCShyZXZpc2lvbiAxNzk0MjEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9HQ1RocmVhZC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTc2LDggKzc2LDYgQEAgR0NQaGFzZSBHQ1RocmVhZDo6d2FpdEZvck5leHRQaGFzZSgpCiAgICAg aWYgKCFtX3NoYXJlZC5tX251bWJlck9mQWN0aXZlR0NUaHJlYWRzKQogICAgICAgICBtX3NoYXJl ZC5tX2FjdGl2aXR5Q29uZGl0aW9uVmFyaWFibGUubm90aWZ5X29uZSgpOwogCi0gICAgV1RGOjpy ZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnlGb3JUaGlzVGhyZWFkKCk7Ci0KICAgICBtX3NoYXJl ZC5tX3BoYXNlQ29uZGl0aW9uVmFyaWFibGUud2FpdChsb2NrLCBbdGhpc10geyByZXR1cm4gbV9z aGFyZWQubV9jdXJyZW50UGhhc2UgIT0gTm9QaGFzZTsgfSk7CiAgICAgbV9zaGFyZWQubV9udW1i ZXJPZkFjdGl2ZUdDVGhyZWFkcysrOwogICAgIHJldHVybiBtX3NoYXJlZC5tX2N1cnJlbnRQaGFz ZTsKQEAgLTExNyw2ICsxMTUsOSBAQCB2b2lkIEdDVGhyZWFkOjpnY1RocmVhZE1haW4oKQogICAg ICAgICAgICAgICAgIC8vIGFsbCBvZiB0aGUgYmxvY2tzIHRoYXQgdGhlIEdDVGhyZWFkcyBib3Jy b3dlZCBoYXZlIGJlZW4gcmV0dXJuZWQuIGRvbmVDb3B5aW5nKCkgCiAgICAgICAgICAgICAgICAg Ly8gcmV0dXJucyBvdXIgYm9ycm93ZWQgQ29waWVkQmxvY2ssIGFsbG93aW5nIHRoZSBjb3B5aW5n IHBoYXNlIHRvIGZpbmlzaC4KICAgICAgICAgICAgICAgICBtX2NvcHlWaXNpdG9yLT5kb25lQ29w eWluZygpOworCisgICAgICAgICAgICAgICAgV1RGOjpyZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1v cnlGb3JUaGlzVGhyZWFkKCk7CisKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAg IGNhc2UgTm9QaGFzZToKICAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hF RCgpOwo=