141064 2015-01-29 18:36:46 -0800 Web Inspector: Extend CSS.getSupportedCSSProperties to provide values for properties for CSS Augmented JSContext 2015-02-02 12:07:01 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1065448 0 joepeck 2015-01-29 18:36:46 -0800 * SUMMARY For a CSS Augmented JSContext it can provide custom CSS properties via CSS.getSupportedCSSProperties. If that is the case, they can provide custom autocompletion values. 1065449 1 joepeck 2015-01-29 18:37:10 -0800 <rdar://problem/19640303> 1065454 2 245682 joepeck 2015-01-29 18:51:54 -0800 Created attachment 245682 [PATCH] Proposed Fix 1065537 3 245682 timothy 2015-01-30 04:51:49 -0800 Comment on attachment 245682 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=245682&action=review > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:94 > + WebInspector.CSSKeywordCompletions._propertyKeywordMap[propertyName] = [...union.values()]; [...existingValues, ...newValues]? 1066156 4 joepeck 2015-02-02 11:21:58 -0800 (In reply to comment #3) > Comment on attachment 245682 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245682&action=review > > > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:94 > > + WebInspector.CSSKeywordCompletions._propertyKeywordMap[propertyName] = [...union.values()]; > > [...existingValues, ...newValues]? I wanted to avoid duplicates in the list if possible. 1066179 5 245682 commit-queue 2015-02-02 12:06:58 -0800 Comment on attachment 245682 [PATCH] Proposed Fix Clearing flags on attachment: 245682 Committed r179483: <http://trac.webkit.org/changeset/179483> 1066180 6 commit-queue 2015-02-02 12:07:01 -0800 All reviewed patches have been landed. Closing bug. 245682 2015-01-29 18:51:54 -0800 2015-02-02 12:06:58 -0800 [PATCH] Proposed Fix autocompletion.patch text/plain 5158 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg2NDFhZGIuLjQ5NGQ4N2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE1LTAxLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXh0ZW5k IENTUy5nZXRTdXBwb3J0ZWRDU1NQcm9wZXJ0aWVzIHRvIHByb3ZpZGUgdmFsdWVzIGZvciBwcm9w ZXJ0aWVzIGZvciBDU1MgQXVnbWVudGVkIEpTQ29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMDY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvcHJvdG9jb2wvQ1NTLmpzb246 CisKKzIwMTUtMDEtMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdXBwb3J0IGNvbnNvbGUudGFibGUKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTA1OAogCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0NTUy5qc29uIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9DU1MuanNvbgppbmRleCBjYzhk NzMyLi5mMDIyMTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9y L3Byb3RvY29sL0NTUy5qc29uCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv cHJvdG9jb2wvQ1NTLmpzb24KQEAgLTE0OCw3ICsxNDgsOCBAQAogICAgICAgICAgICAgInR5cGUi OiAib2JqZWN0IiwKICAgICAgICAgICAgICJwcm9wZXJ0aWVzIjogWwogICAgICAgICAgICAgICAg IHsgIm5hbWUiOiAibmFtZSIsICJ0eXBlIjogInN0cmluZyIsICJkZXNjcmlwdGlvbiI6ICJQcm9w ZXJ0eSBuYW1lLiIgfSwKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogImxvbmdoYW5kcyIsICJ0 eXBlIjogImFycmF5IiwgIm9wdGlvbmFsIjogdHJ1ZSwgIml0ZW1zIjogeyAidHlwZSI6ICJzdHJp bmciIH0sICJkZXNjcmlwdGlvbiI6ICJMb25naGFuZCBwcm9wZXJ0eSBuYW1lcy4iIH0KKyAgICAg ICAgICAgICAgICB7ICJuYW1lIjogImxvbmdoYW5kcyIsICJ0eXBlIjogImFycmF5IiwgIm9wdGlv bmFsIjogdHJ1ZSwgIml0ZW1zIjogeyAidHlwZSI6ICJzdHJpbmciIH0sICJkZXNjcmlwdGlvbiI6 ICJMb25naGFuZCBwcm9wZXJ0eSBuYW1lcy4iIH0sCisgICAgICAgICAgICAgICAgeyAibmFtZSI6 ICJ2YWx1ZXMiLCAidHlwZSI6ICJhcnJheSIsICJvcHRpb25hbCI6IHRydWUsICJpdGVtcyI6IHsg InR5cGUiOiAic3RyaW5nIiB9LCAiZGVzY3JpcHRpb24iOiAiU3VwcG9ydGVkIHZhbHVlcyBmb3Ig dGhpcyBwcm9wZXJ0eS4iIH0KICAgICAgICAgICAgIF0KICAgICAgICAgfSwKICAgICAgICAgewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5kZXggNzA5OGQ2MC4uOWFlOWY3YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTUtMDEtMjkgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBFeHRlbmQg Q1NTLmdldFN1cHBvcnRlZENTU1Byb3BlcnRpZXMgdG8gcHJvdmlkZSB2YWx1ZXMgZm9yIHByb3Bl cnRpZXMgZm9yIENTUyBBdWdtZW50ZWQgSlNDb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEwNjQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0NvbXBs ZXRpb25zLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21w bGV0aW9ucy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMu YWRkQ3VzdG9tQ29tcGxldGlvbnMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRD b21wbGV0aW9ucy5hZGRQcm9wZXJ0eUNvbXBsZXRpb25WYWx1ZXMpOgorICAgICAgICBJZiBhIHBy b3BlcnR5IGlzIHNwZWNpZmllZCB3aXRoIGN1c3RvbSB2YWx1ZXMsIGV4dGVuZCB0aGUKKyAgICAg ICAga2V5d29yZCBjb21wbGV0aW9ucyBtYXAgdG8gbWFrZSB0aG9zZSB2YWx1ZXMgYXZhaWxhYmxl CisgICAgICAgIGluIGF1dG9jb21wbGV0aW9uLgorCisyMDE1LTAxLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgUmVtb3RlIFdlYiBJbnNwZWN0b3Ig c2hvdWxkIG5vdCBzaG93IHVuZG9jayB0b29sYmFyIGJ1dHRvbnMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTA2MQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTQ29tcGxldGlvbnMuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTQ29tcGxldGlv bnMuanMKaW5kZXggODU5MjRlYy4uMzYzMzdkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0NvbXBsZXRpb25zLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NDb21wbGV0aW9ucy5qcwpA QCAtODYsNiArODYsOCBAQCBXZWJJbnNwZWN0b3IuQ1NTQ29tcGxldGlvbnMucmVxdWVzdENTU05h bWVDb21wbGV0aW9ucyA9IGZ1bmN0aW9uKCkKIAogICAgICAgICBXZWJJbnNwZWN0b3IuQ1NTQ29t cGxldGlvbnMuY3NzTmFtZUNvbXBsZXRpb25zID0gbmV3IFdlYkluc3BlY3Rvci5DU1NDb21wbGV0 aW9ucyhuYW1lcywgZmFsc2UpOwogCisgICAgICAgIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29t cGxldGlvbnMuYWRkQ3VzdG9tQ29tcGxldGlvbnMobmFtZXMpOworCiAgICAgICAgIC8vIENvZGVN aXJyb3IgaXMgbm90IGluY2x1ZGVkIGJ5IHRlc3RzIHNvIHdlIHNob3VsZG4ndCBhc3N1bWUgaXQg YWx3YXlzIGV4aXN0cy4KICAgICAgICAgLy8gSWYgaXQgaXNuJ3QgYXZhaWxhYmxlIHdlIHNraXAg TUlNRSB0eXBlIGFzc29jaWF0aW9ucy4KICAgICAgICAgaWYgKCF3aW5kb3cuQ29kZU1pcnJvcikK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9D U1NLZXl3b3JkQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCmluZGV4IGJiZGJlMmQuLmNjN2Iw MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVs cy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcwpAQCAtNjUsNiArNjUs MzUgQEAgV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5pc0NvbG9yQXdhcmVQcm9w ZXJ0eSA9IGZ1bmN0aW9uKHByb3BlcnR5TmFtZSkKICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLkNT U0tleXdvcmRDb21wbGV0aW9ucy5fY29sb3JBd2FyZVByb3BlcnRpZXNbcHJvcGVydHlOYW1lXSA9 PT0gdHJ1ZTsKIH07CiAKK1dlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMuYWRkQ3Vz dG9tQ29tcGxldGlvbnMgPSBmdW5jdGlvbihwcm9wZXJ0aWVzKQoreworICAgIC8vIENPTVBBVElC SUxJVFkgKGlPUyA2KTogVGhpcyB1c2VkIHRvIGJlIGFuIGFycmF5IG9mIHN0cmluZ3MuIFRoZXkg d29uJ3QgaGF2ZSBjdXN0b20gdmFsdWVzLgorICAgIGlmIChwcm9wZXJ0aWVzLmxlbmd0aCAmJiB0 eXBlb2YgcHJvcGVydGllc1swXSA9PT0gInN0cmluZyIpCisgICAgICAgIHJldHVybjsKKworICAg IGZvciAodmFyIHByb3BlcnR5IG9mIHByb3BlcnRpZXMpIHsKKyAgICAgICAgaWYgKHByb3BlcnR5 LnZhbHVlcykKKyAgICAgICAgICAgIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMu YWRkUHJvcGVydHlDb21wbGV0aW9uVmFsdWVzKHByb3BlcnR5Lm5hbWUsIHByb3BlcnR5LnZhbHVl cyk7CisgICAgfQorfTsKKworV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5hZGRQ cm9wZXJ0eUNvbXBsZXRpb25WYWx1ZXMgPSBmdW5jdGlvbihwcm9wZXJ0eU5hbWUsIG5ld1ZhbHVl cykKK3sKKyAgICB2YXIgZXhpc3RpbmdWYWx1ZXMgPSBXZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENv bXBsZXRpb25zLl9wcm9wZXJ0eUtleXdvcmRNYXBbcHJvcGVydHlOYW1lXTsKKyAgICBpZiAoIWV4 aXN0aW5nVmFsdWVzKSB7CisgICAgICAgIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlv bnMuX3Byb3BlcnR5S2V5d29yZE1hcFtwcm9wZXJ0eU5hbWVdID0gbmV3VmFsdWVzOworICAgICAg ICByZXR1cm47CisgICAgfQorCisgICAgdmFyIHVuaW9uID0gbmV3IFNldDsKKyAgICBmb3IgKHZh ciB2YWx1ZSBvZiBleGlzdGluZ1ZhbHVlcykKKyAgICAgICAgdW5pb24uYWRkKHZhbHVlKTsKKyAg ICBmb3IgKHZhciB2YWx1ZSBvZiBuZXdWYWx1ZXMpCisgICAgICAgIHVuaW9uLmFkZCh2YWx1ZSk7 CisKKyAgICBXZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLl9wcm9wZXJ0eUtleXdv cmRNYXBbcHJvcGVydHlOYW1lXSA9IFsuLi51bmlvbi52YWx1ZXMoKV07Cit9OworCiBXZWJJbnNw ZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLkFsbFByb3BlcnR5TmFtZXNQbGFjZWhvbGRlciA9 ICJfX2FsbC1wcm9wZXJ0aWVzX18iOwogCiBXZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRp b25zLkluaGVyaXRlZFByb3BlcnRpZXMgPSBbCg==