141061 2015-01-29 17:16:55 -0800 Remote Web Inspector should not show undock toolbar buttons 2015-01-30 15:56:46 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1065428 0 joepeck 2015-01-29 17:16:55 -0800 * SUMMARY Remote Web Inspector should not show undock toolbar buttons. * STEPS TO REPRODUCE 1. Remote Inspect iOS 8 MobileSafari or JSContext => frontend has undock buttons 1065429 1 webkit-bug-importer 2015-01-29 17:17:12 -0800 <rdar://problem/19656961> 1065430 2 joepeck 2015-01-29 17:24:31 -0800 Looks like this broke with: https://trac.webkit.org/changeset/173929 That removed: // Update the docked state based on the query string passed when the Web Inspector was loaded. this.updateDockedState(parseLocationQueryParameters().dockSide || "undocked"); Which caused the buttons to never update as "undocked" and therefore hidden. Easy fix. 1065435 3 245675 joepeck 2015-01-29 17:26:31 -0800 Created attachment 245675 [PATCH] Proposed Fix 1065538 4 245675 timothy 2015-01-30 04:54:56 -0800 Comment on attachment 245675 [PATCH] Proposed Fix Oops! Thanks! 1065687 5 245675 commit-queue 2015-01-30 15:56:42 -0800 Comment on attachment 245675 [PATCH] Proposed Fix Clearing flags on attachment: 245675 Committed r179418: <http://trac.webkit.org/changeset/179418> 1065688 6 commit-queue 2015-01-30 15:56:46 -0800 All reviewed patches have been landed. Closing bug. 245675 2015-01-29 17:26:31 -0800 2015-01-30 15:56:42 -0800 [PATCH] Proposed Fix dock-buttons.patch text/plain 1440 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI4ZDEzMzEuLjcwOThkNjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTAxLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgUmVtb3RlIFdlYiBJbnNwZWN0b3Ig c2hvdWxkIG5vdCBzaG93IHVuZG9jayB0b29sYmFyIGJ1dHRvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTA2MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4u anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCk6CisgICAgICAgIEJlIHN1 cmUgdG8gdXBkYXRlIHRoZSB0b29sYmFyJ3MgZG9jayBuYXZpZ2F0aW9uIGljb25zIGJlY2F1c2Ug dGhleQorICAgICAgICBtYXkgbmVlZCB0byBiZSBoaWRkZW4gKHRoZSBkZWZhdWx0IHN0YXRlKS4K KworMjAxNS0wMS0yOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IFN1cHBvcnQgY29uc29sZS50YWJsZQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMDU4CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCA5YmRkZDQ2 Li4yMWM1N2Y5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9NYWluLmpzCkBAIC0zMjQsNiArMzI0LDcgQEAgV2ViSW5zcGVjdG9yLmNvbnRlbnRMb2Fk ZWQgPSBmdW5jdGlvbigpCiAgICAgdGhpcy50b29sYmFyLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5l cigibW91c2Vkb3duIiwgdGhpcy5fdG9vbGJhck1vdXNlRG93bi5iaW5kKHRoaXMpKTsKICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZG9ja2VkLXJlc2l6ZXIiKS5hZGRFdmVudExpc3RlbmVy KCJtb3VzZWRvd24iLCB0aGlzLl9kb2NrZWRSZXNpemVyTW91c2VEb3duLmJpbmQodGhpcykpOwog CisgICAgdGhpcy5fdXBkYXRlRG9ja05hdmlnYXRpb25JdGVtcygpOwogICAgIHRoaXMuX3VwZGF0 ZVRvb2xiYXJIZWlnaHQoKTsKIAogICAgIGlmICh0aGlzLl9uYXZpZ2F0aW9uU2lkZWJhcldpZHRo U2V0dGluZy52YWx1ZSkK