141039 2015-01-29 09:58:45 -0800 Web Inspector: ASSERT in InspectorTimelineAgent::internalStop 2015-01-30 15:57:13 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson burg benjamin burg cmarcelo commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1065273 0 eric.carlson 2015-01-29 09:58:45 -0800 Stopwatch ASSERT when using inspector. r178433 fixed a Stopwatch::stop ASSERT in InspectorDebuggerAgent, but InspectorTimelineAgent also has a Stopwatch so it apparently needs a similar fix. ASSERTION FAILED: !isnan(m_lastStartTime) /webkit/WebKitBuild/Debug/usr/local/include/wtf/Stopwatch.h(74) : void WTF::Stopwatch::stop() 1 0x114706f60 WTFCrash 2 0x116a48415 WTF::Stopwatch::stop() 3 0x116a7f671 WebCore::InspectorTimelineAgent::internalStop() 4 0x116a7f440 WebCore::InspectorTimelineAgent::stop(WTF::String&) 5 0x116a7f75f non-virtual thunk to WebCore::InspectorTimelineAgent::stop(WTF::String&) 6 0x1142f63ce Inspector::InspectorTimelineBackendDispatcher::stop(long, Inspector::InspectorObject const&) 7 0x1142f5f80 Inspector::InspectorTimelineBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) 8 0x1142ab7a9 Inspector::InspectorBackendDispatcher::dispatch(WTF::String const&) 9 0x116993881 WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) 10 0x11177db51 WebKit::WebInspector::sendMessageToBackend(WTF::String const&) 11 0x1117888ff void IPC::callMemberFunctionImpl<WebKit::WebInspector, void (WebKit::WebInspector::*)(WTF::String const&), std::__1::tuple<WTF::String>, 0ul>(WebKit::WebInspector*, void (WebKit::WebInspector::*)(WTF::String const&), std::__1::tuple<WTF::String>&&, std::index_sequence<0ul>) 12 0x111788858 void IPC::callMemberFunction<WebKit::WebInspector, void (WebKit::WebInspector::*)(WTF::String const&), std::__1::tuple<WTF::String>, std::make_index_sequence<1ul> >(std::__1::tuple<WTF::String>&&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(WTF::String const&)) 13 0x1117887c6 void IPC::handleMessage<Messages::WebInspector::SendMessageToBackend, WebKit::WebInspector, void (WebKit::WebInspector::*)(WTF::String const&)>(IPC::MessageDecoder&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(WTF::String const&)) 14 0x111787cfa WebKit::WebInspector::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) 15 0x111787d67 non-virtual thunk to WebKit::WebInspector::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) 16 0x1111e4da3 IPC::Connection::dispatchMessage(IPC::MessageDecoder&) 17 0x1111dd120 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) 18 0x1111e4b7f IPC::Connection::dispatchOneMessage() 19 0x1111f90d2 WTF::FunctionWrapper<void (IPC::Connection::*)()>::operator()(IPC::Connection*) 20 0x1111f9055 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (IPC::Connection::*)()>, void (IPC::Connection*)>::operator()() 21 0x1111f8892 WTF::Function<void ()>::operator()() const 22 0x1111f880c std::__1::__function::__func<WTF::Function<void ()>, std::__1::allocator<WTF::Function<void ()> >, void ()>::operator()() 23 0x1146b33fa std::__1::function<void ()>::operator()() const 24 0x114740841 WTF::RunLoop::performWork() 25 0x114741b24 WTF::RunLoop::performWork(void*) 26 0x7fff8b6a4a81 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 27 0x7fff8b69700d __CFRunLoopDoSources0 28 0x7fff8b69662f __CFRunLoopRun 29 0x7fff8b696028 CFRunLoopRunSpecific 30 0x7fff9046fcc7 RunCurrentEventLoopInMode 31 0x7fff9046f95b ReceiveNextEventCommon 1065274 1 webkit-bug-importer 2015-01-29 09:58:55 -0800 <rdar://problem/19648787> 1065490 2 245694 burg 2015-01-29 22:03:48 -0800 Created attachment 245694 Patch 1065689 3 245694 commit-queue 2015-01-30 15:57:09 -0800 Comment on attachment 245694 Patch Clearing flags on attachment: 245694 Committed r179419: <http://trac.webkit.org/changeset/179419> 1065690 4 commit-queue 2015-01-30 15:57:13 -0800 All reviewed patches have been landed. Closing bug. 245694 2015-01-29 22:03:48 -0800 2015-01-30 15:57:09 -0800 Patch bug-141039-20150129220354.patch text/plain 3522 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY0NmNkZWRhOTNlNjRjOTNhMmIyYjcy MDMwN2ZjOThjN2IwNjA2YTEuLjZmMGIyMTE2YmMxY2Q2NjdmZGQ1MmZlMmQ4NzJkOWRiYmNhMDAz MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMDEtMjkgIEJyaWFuIEouIEJ1cmcgIDxidXJn QGNzLndhc2hpbmd0b24uZWR1PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFTU0VSVCBpbiBJ bnNwZWN0b3JUaW1lbGluZUFnZW50OjppbnRlcm5hbFN0b3AKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTAzOQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtZXNzYWdlcyB0byBTdG9wd2F0Y2ggYXNz ZXJ0aW9ucywgYW5kIGNsZWFuIHVwIGNvbnN0cnVjdG9yLgorCisgICAgICAgICogd3RmL1N0b3B3 YXRjaC5oOgorICAgICAgICAoV1RGOjpTdG9wd2F0Y2g6OlN0b3B3YXRjaCk6CisgICAgICAgIChX VEY6OlN0b3B3YXRjaDo6c3RhcnQpOgorICAgICAgICAoV1RGOjpTdG9wd2F0Y2g6OnN0b3ApOgor CiAyMDE1LTAxLTI5ICBTYW50b3NoIE1haHRvICA8c2FudG9zaGJpdDIwMDdAZ21haWwuY29tPgog CiAgICAgICAgIFJlZmFjdG9yIFN0cmluZzo6Zm9ybWF0IHRvIGhhbmRsZSB1bnJlYWNoZWQgdmFf ZW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDZmYzU4ZmI2ZWMyN2ExOTE3YWE0NjY4MWYyYzY5NTQ1ZTlhMmVl ZjMuLmU5MThjYjI5ODZhN2UwZmRhNzY3Y2ViNmQ0OGQ1NTk5NTAyYWYwNDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAxNS0wMS0yOSAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2Fz aGluZ3Rvbi5lZHU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQVNTRVJUIGluIEluc3BlY3Rv clRpbWVsaW5lQWdlbnQ6OmludGVybmFsU3RvcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMDM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgdW5jb25kaXRpb25hbGx5IHN0b3AgdGhlIGVudmly b25tZW50IHN0b3B3YXRjaCwgc2luY2UgaXQgY291bGQgaGF2ZQorICAgICAgICBhbHJlYWR5IHN0 b3BwZWQgZHVlIHRvIHRoZSBkZWJ1Z2dlciBwYXVzaW5nLgorCisgICAgICAgICogaW5zcGVjdG9y L0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9y VGltZWxpbmVBZ2VudDo6aW50ZXJuYWxTdG9wKToKKwogMjAxNS0wMS0yOSAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhlIGJ1aWxkIHdpdGgg bmV3ZXIgQ2xhbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TdG9wd2F0Y2guaCBiL1Nv dXJjZS9XVEYvd3RmL1N0b3B3YXRjaC5oCmluZGV4IDljYmE5YTE1YTRhYWU2NTkyOTFjYjdhOWMz NDVlMjA2ZjJlMjM0MjAuLjZlZGM0NmUxYTBlNTc4MjVkZWFmYmU2MjNkZmNmZGMyYzJmMmUyZjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1N0b3B3YXRjaC5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL1N0b3B3YXRjaC5oCkBAIC00NiwxMSArNDYsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIGlz QWN0aXZlKCkgY29uc3QgeyByZXR1cm4gIWlzbmFuKG1fbGFzdFN0YXJ0VGltZSk7IH0KIHByaXZh dGU6Ci0gICAgU3RvcHdhdGNoKCkKLSAgICAgICAgOiBtX2VsYXBzZWRUaW1lKDAuMCkKLSAgICAg ICAgLCBtX2xhc3RTdGFydFRpbWUoTkFOKQotICAgIHsKLSAgICB9CisgICAgU3RvcHdhdGNoKCkg eyByZXNldCgpOyB9CiAKICAgICBkb3VibGUgbV9lbGFwc2VkVGltZTsKICAgICBkb3VibGUgbV9s YXN0U3RhcnRUaW1lOwpAQCAtNjQsMTQgKzYwLDE0IEBAIGlubGluZSB2b2lkIFN0b3B3YXRjaDo6 cmVzZXQoKQogCiBpbmxpbmUgdm9pZCBTdG9wd2F0Y2g6OnN0YXJ0KCkKIHsKLSAgICBBU1NFUlQo aXNuYW4obV9sYXN0U3RhcnRUaW1lKSk7CisgICAgQVNTRVJUX1dJVEhfTUVTU0FHRShpc25hbiht X2xhc3RTdGFydFRpbWUpLCAiVHJpZWQgdG8gc3RhcnQgdGhlIHN0b3B3YXRjaCwgYnV0IGl0IGlz IGFscmVhZHkgcnVubmluZy4iKTsKIAogICAgIG1fbGFzdFN0YXJ0VGltZSA9IG1vbm90b25pY2Fs bHlJbmNyZWFzaW5nVGltZSgpOwogfQogCiBpbmxpbmUgdm9pZCBTdG9wd2F0Y2g6OnN0b3AoKQog ewotICAgIEFTU0VSVCghaXNuYW4obV9sYXN0U3RhcnRUaW1lKSk7CisgICAgQVNTRVJUX1dJVEhf TUVTU0FHRSghaXNuYW4obV9sYXN0U3RhcnRUaW1lKSwgIlRyaWVkIHRvIHN0b3AgdGhlIHN0b3B3 YXRjaCwgYnV0IGl0IGlzIG5vdCBydW5uaW5nLiIpOwogCiAgICAgbV9lbGFwc2VkVGltZSArPSBt b25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSAtIG1fbGFzdFN0YXJ0VGltZTsKICAgICBtX2xh c3RTdGFydFRpbWUgPSBOQU47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yVGltZWxpbmVBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yVGltZWxpbmVBZ2VudC5jcHAKaW5kZXggODBkYjE5ZDM0OTYzZmJhZjM4NjM0YjA5MzE3 ZWRhMjYxNDNhNThiNS4uYjkyMmM3OGNmZjk2ZWE0M2ZkMzk5MGJiNmI4ZDdmMDI4NTU5MjZiOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdl bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFn ZW50LmNwcApAQCAtMTI4LDcgKzEyOCwxMCBAQCB2b2lkIEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6 OmludGVybmFsU3RvcCgpCiAgICAgaWYgKCFtX2VuYWJsZWQpCiAgICAgICAgIHJldHVybjsKIAot ICAgIG1faW5zdHJ1bWVudGluZ0FnZW50cy0+aW5zcGVjdG9yRW52aXJvbm1lbnQoKS5leGVjdXRp b25TdG9wd2F0Y2goKS0+c3RvcCgpOworICAgIC8vIFRoZSBlbnZpcm9ubWVudCdzIHN0b3B3YXRj aCBjb3VsZCBiZSBhbHJlYWR5IHN0b3BwZWQgaWYgdGhlIGRlYnVnZ2VyIGhhcyBwYXVzZWQuCisg ICAgYXV0byBzdG9wd2F0Y2ggPSBtX2luc3RydW1lbnRpbmdBZ2VudHMtPmluc3BlY3RvckVudmly b25tZW50KCkuZXhlY3V0aW9uU3RvcHdhdGNoKCk7CisgICAgaWYgKHN0b3B3YXRjaC0+aXNBY3Rp dmUoKSkKKyAgICAgICAgc3RvcHdhdGNoLT5zdG9wKCk7CiAKICAgICBtX2luc3RydW1lbnRpbmdB Z2VudHMtPnNldEluc3BlY3RvclRpbWVsaW5lQWdlbnQobnVsbHB0cik7CiAK