141032 2015-01-29 07:18:16 -0800 ASSERTION FAILED: !root->needsLayout() in WebCore::FrameView::layout 2015-05-07 05:50:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116980 1 rhodovan.u-szeged hyungwook.lee cdumez commit-queue hyungwook.lee sam oldest_to_newest 1065227 0 245618 rhodovan.u-szeged 2015-01-29 07:18:16 -0800 Created attachment 245618 Test case Load this with debug WK: <style> * { display:list-item; } </style> <marquee> <font></font> </marquee> Backtrace: ASSERTION FAILED: !root->needsLayout() ../../Source/WebCore/page/FrameView.cpp(1379) : void WebCore::FrameView::layout(bool) Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fff8affd700 (LWP 10698)] 0x00007fffed72443d in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:321 321 *(int *)(uintptr_t)0xbbadbeef = 0; #0 0x00007fffed72443d in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:321 #1 0x00007ffff3520215 in WebCore::FrameView::layout (this=0x7ffff7ec4b00, allowSubtree=true) at ../../Source/WebCore/page/FrameView.cpp:1379 #2 0x00007ffff2ec5963 in WebCore::Document::implicitClose (this=0x7fff9851c000) at ../../Source/WebCore/dom/Document.cpp:2497 #3 0x00007ffff33c6915 in WebCore::FrameLoader::checkCallImplicitClose (this=0x7ffff7f37a98) at ../../Source/WebCore/loader/FrameLoader.cpp:901 #4 0x00007ffff33c6681 in WebCore::FrameLoader::checkCompleted (this=0x7ffff7f37a98) at ../../Source/WebCore/loader/FrameLoader.cpp:847 #5 0x00007ffff33c63ea in WebCore::FrameLoader::finishedParsing (this=0x7ffff7f37a98) at ../../Source/WebCore/loader/FrameLoader.cpp:767 #6 0x00007ffff2ece858 in WebCore::Document::finishedParsing (this=0x7fff9851c000) at ../../Source/WebCore/dom/Document.cpp:4629 #7 0x00007ffff32372b3 in WebCore::HTMLConstructionSite::finishedParsing (this=0x7ffff7f31800) at ../../Source/WebCore/html/parser/HTMLConstructionSite.cpp:404 #8 0x00007ffff3273c26 in WebCore::HTMLTreeBuilder::finished (this=0x7ffff7f317e0) at ../../Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2941 #9 0x00007ffff323fb32 in WebCore::HTMLDocumentParser::end (this=0x7ffff7ecc100) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:402 #10 0x00007ffff323fc00 in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x7ffff7ecc100) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:411 #11 0x00007ffff323e8b0 in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x7ffff7ecc100) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:132 #12 0x00007ffff323fc37 in WebCore::HTMLDocumentParser::attemptToEnd (this=0x7ffff7ecc100) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:423 #13 0x00007ffff323fce5 in WebCore::HTMLDocumentParser::finish (this=0x7ffff7ecc100) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:451 #14 0x00007ffff33b6ac7 in WebCore::DocumentWriter::end (this=0x7ffff7eb7aa0) at ../../Source/WebCore/loader/DocumentWriter.cpp:247 #15 0x00007ffff33a212b in WebCore::DocumentLoader::finishedLoading (this=0x7ffff7eb7a00, finishTime=0) at ../../Source/WebCore/loader/DocumentLoader.cpp:440 #16 0x00007ffff33a1e94 in WebCore::DocumentLoader::notifyFinished (this=0x7ffff7eb7a00, resource=0x7ffff7ec4680) at ../../Source/WebCore/loader/DocumentLoader.cpp:374 #17 0x00007ffff345619c in WebCore::CachedResource::checkNotify (this=0x7ffff7ec4680) at ../../Source/WebCore/loader/cache/CachedResource.cpp:296 #18 0x00007ffff345629a in WebCore::CachedResource::finishLoading (this=0x7ffff7ec4680) at ../../Source/WebCore/loader/cache/CachedResource.cpp:312 #19 0x00007ffff34528a1 in WebCore::CachedRawResource::finishLoading (this=0x7ffff7ec4680, data=0x7fff98514570) at ../../Source/WebCore/loader/cache/CachedRawResource.cpp:104 #20 0x00007ffff34050fd in WebCore::SubresourceLoader::didFinishLoading (this=0x7ffff7ec4200, finishTime=0) at ../../Source/WebCore/loader/SubresourceLoader.cpp:364 #21 0x00007ffff3400a37 in WebCore::ResourceLoader::didFinishLoading (this=0x7ffff7ec4200, finishTime=0) at ../../Source/WebCore/loader/ResourceLoader.cpp:502 #22 0x00007ffff3db16a5 in WebCore::readCallback (asyncResult=0x6ba1f0, data=0x7fff9850c100) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1295 #23 0x00007fffeb26d7e6 in async_ready_callback_wrapper (source_object=0x7c72d0, res=0x6ba1f0, user_data=user_data@entry=0x7fff9850c100) at ginputstream.c:523 #24 0x00007fffeb2930e5 in g_task_return_now (task=0x6ba1f0) at gtask.c:1077 #25 0x00007fffeb293109 in complete_in_idle_cb (task=0x6ba1f0) at gtask.c:1086 #26 0x00007fffea54ba1d in g_main_dispatch (context=0x478b00) at gmain.c:3064 #27 g_main_context_dispatch (context=context@entry=0x478b00) at gmain.c:3663 #28 0x00007fffea54bd88 in g_main_context_iterate (context=0x478b00, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3734 #29 0x00007fffea54c04a in g_main_loop_run (loop=0x901bd0) at gmain.c:3928 #30 0x00007ffff44b40b6 in WTF::RunLoop::run () at ../../Source/WTF/wtf/gtk/RunLoopGtk.cpp:59 #31 0x00007ffff299deac in WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain> (argc=2, argv=0x7fffffffd988) at ../../Source/WebKit2/Shared/unix/ChildProcessMain.h:61 #32 0x00007ffff299dd11 in WebKit::WebProcessMainUnix (argc=2, argv=0x7fffffffd988) at ../../Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:77 #33 0x00000000004008d1 in main (argc=2, argv=0x7fffffffd988) at ../../Source/WebKit2/WebProcess/EntryPoint/unix/WebProcessMain.cpp:44 1065557 1 hyungwook.lee 2015-01-30 05:59:00 -0800 I've start to look at this issue. 1066405 2 245934 hyungwook.lee 2015-02-03 05:52:18 -0800 Created attachment 245934 patch patch for this issue. 1066448 3 245934 darin 2015-02-03 08:47:35 -0800 Comment on attachment 245934 patch This patch doesn’t apply. Could you rebase and attach one that does apply? That change looks fine. 1066675 4 245998 hyungwook.lee 2015-02-03 17:45:32 -0800 Created attachment 245998 patch 1066824 5 245998 darin 2015-02-04 09:12:44 -0800 Comment on attachment 245998 patch I think this change is OK;I am a little bit unclear on this. If one layout can cause the need for another layout, maybe we have a real problem here, not just a misplaced assert. 1067066 6 hyungwook.lee 2015-02-05 01:05:13 -0800 In my understanding RenderLayer::updateLayerPositionsAfterLayout() can makes another layout when we have Marquee Element. I think FrameView::layout() looks allowing another layout internally if needed. 1067260 7 245998 commit-queue 2015-02-05 17:05:14 -0800 Comment on attachment 245998 patch Clearing flags on attachment: 245998 Committed r179726: <http://trac.webkit.org/changeset/179726> 1067261 8 commit-queue 2015-02-05 17:05:18 -0800 All reviewed patches have been landed. Closing bug. 245618 2015-01-29 07:18:16 -0800 2015-01-29 07:18:16 -0800 Test case crash.html text/html 84 rhodovan.u-szeged PHN0eWxlPgoqIHsKICAgIGRpc3BsYXk6bGlzdC1pdGVtOwp9Cjwvc3R5bGU+CjxtYXJxdWVlPgog ICAgPGZvbnQ+PC9mb250Pgo8L21hcnF1ZWU+ 245934 2015-02-03 05:52:18 -0800 2015-02-03 17:45:32 -0800 patch patch text/plain 1467 hyungwook.lee SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTU0 NikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAy LTAzICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAg ICAgIEZpeCBBU1NFUlRJT04gRkFJTEVEOiAhcm9vdC0+bmVlZHNMYXlvdXQoKSBpbiBGcmFtZVZp ZXc6OmxheW91dCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDEwMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIHBhdGNoIG1vdmVzIHRoZSAhcm9vdC0+bmVlZHNMYXlvdXQoKSBhc3NlcnQgc3Rh dGVtZW50IGFib3ZlCisgICAgICAgIHVwZGF0ZUxheWVyUG9zaXRpb25zQWZ0ZXJMYXlvdXQoKSB0 aGF0IGNhbiBtb2RpZnkgZGlydHkgYml0IHN5c3RlbQorICAgICAgICB3aGVuIHdlIGhhdmUgUmVu ZGVyTWFycXVlZS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lVmlldzo6bGF5b3V0KToKKwogMjAxNS0wMi0wMiAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE3MDU3Nik6IFN0b3JhZ2Ug bGVha3MgaW4gcGFyc2luZyBvZiBDU1MgaW1hZ2Ugc2l6ZXMKSW5kZXg6IHBhZ2UvRnJhbWVWaWV3 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBwYWdlL0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDE3OTIzNykK KysrIHBhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM1NSw2ICsxMzU1LDgg QEAKICAgICBpZiAobV9uZWVkc0Z1bGxSZXBhaW50KQogICAgICAgICByb290LT52aWV3KCkucmVw YWludFJvb3RDb250ZW50cygpOwogCisgICAgQVNTRVJUKCFyb290LT5uZWVkc0xheW91dCgpKTsK KwogICAgIGxheWVyLT51cGRhdGVMYXllclBvc2l0aW9uc0FmdGVyTGF5b3V0KHJlbmRlclZpZXco KS0+bGF5ZXIoKSwgdXBkYXRlTGF5ZXJQb3NpdGlvbkZsYWdzKGxheWVyLCBzdWJ0cmVlLCBtX25l ZWRzRnVsbFJlcGFpbnQpKTsKIAogICAgIHVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzQWZ0ZXJMYXlv dXQoKTsKQEAgLTEzNzYsOCArMTM3OCw2IEBACiAgICAgZG9jdW1lbnQuZGlydHlUb3VjaEV2ZW50 UmVjdHMoKTsKICNlbmRpZgogCi0gICAgQVNTRVJUKCFyb290LT5uZWVkc0xheW91dCgpKTsKLQog ICAgIHVwZGF0ZUNhbkJsaXRPblNjcm9sbFJlY3Vyc2l2ZWx5KCk7CiAKICAgICBoYW5kbGVEZWZl cnJlZFNjcm9sbFVwZGF0ZUFmdGVyQ29udGVudFNpemVDaGFuZ2UoKTsK 245998 2015-02-03 17:45:32 -0800 2015-02-05 17:05:14 -0800 patch patch text/plain 1578 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTU4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTA0ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIEZpeCBBU1NF UlRJT04gRkFJTEVEOiAhcm9vdC0+bmVlZHNMYXlvdXQoKSBpbiBGcmFtZVZpZXc6OmxheW91dCgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEwMzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBh dGNoIG1vdmVzIHRoZSAhcm9vdC0+bmVlZHNMYXlvdXQoKSBhc3NlcnQgc3RhdGVtZW50IGFib3Zl CisgICAgICAgIHVwZGF0ZUxheWVyUG9zaXRpb25zQWZ0ZXJMYXlvdXQoKSB0aGF0IGNhbiBtb2Rp ZnkgZGlydHkgYml0IHN5c3RlbQorICAgICAgICB3aGVuIHdlIGhhdmUgUmVuZGVyTWFycXVlZS4K KworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l Vmlldzo6bGF5b3V0KToKKwogMjAxNS0wMi0wMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIERyb3AgUmVzb3VyY2VMb2FkUHJpb3JpdHlVbnJlc29sdmVkIHJlc291 cmNlIGxvYWQgcHJpb3JpdHkgYW5kIHVzZSBPcHRpb25hbDw+IGluc3RlYWQKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDE3OTU4NSkKKysrIFNvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM1NSw2ICsxMzU1LDggQEAK ICAgICBpZiAobV9uZWVkc0Z1bGxSZXBhaW50KQogICAgICAgICByb290LT52aWV3KCkucmVwYWlu dFJvb3RDb250ZW50cygpOwogCisgICAgQVNTRVJUKCFyb290LT5uZWVkc0xheW91dCgpKTsKKwog ICAgIGxheWVyLT51cGRhdGVMYXllclBvc2l0aW9uc0FmdGVyTGF5b3V0KHJlbmRlclZpZXcoKS0+ bGF5ZXIoKSwgdXBkYXRlTGF5ZXJQb3NpdGlvbkZsYWdzKGxheWVyLCBzdWJ0cmVlLCBtX25lZWRz RnVsbFJlcGFpbnQpKTsKIAogICAgIHVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzQWZ0ZXJMYXlvdXQo KTsKQEAgLTEzNzYsOCArMTM3OCw2IEBACiAgICAgZG9jdW1lbnQuZGlydHlUb3VjaEV2ZW50UmVj dHMoKTsKICNlbmRpZgogCi0gICAgQVNTRVJUKCFyb290LT5uZWVkc0xheW91dCgpKTsKLQogICAg IHVwZGF0ZUNhbkJsaXRPblNjcm9sbFJlY3Vyc2l2ZWx5KCk7CiAKICAgICBoYW5kbGVEZWZlcnJl ZFNjcm9sbFVwZGF0ZUFmdGVyQ29udGVudFNpemVDaGFuZ2UoKTsK