141024 2015-01-28 19:46:34 -0800 Rename 'usesArguments' to 'setUsesArguments' in ASTBuilder 2015-02-04 09:16:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW P2 Trivial --- 1 cwhan.tunz webkit-unassigned darin oldest_to_newest 1065138 0 cwhan.tunz 2015-01-28 19:46:34 -0800 The method name 'usesArguments' in ASTBuilder is confusing. 'usesArguments' is used as setter method in AST Builder. In other files, usesArguments is getter method, and 'setUsesArguments' is setter method. So, it is better to rename usesArguments to setUsesArguments in ASTBuilder. 1065141 1 245604 cwhan.tunz 2015-01-28 19:48:59 -0800 Created attachment 245604 Patch 1066828 2 245604 darin 2015-02-04 09:16:11 -0800 Comment on attachment 245604 Patch I don’t think it makes sense to change this function and not change the 4 other similarly-named ones, usesThis, usesCatch, usesWith, and usesEval. You should talk to the programmers who work on this code a lot and see if they are amendable to renaming all 5 of them. 1066829 3 darin 2015-02-04 09:16:40 -0800 (In reply to comment #2) > amendable I meant "amenable" 245604 2015-01-28 19:48:59 -0800 2015-02-04 09:16:11 -0800 Patch patch.patch text/plain 2946 cwhan.tunz SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5MzI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE1LTAxLTI4ICBIYW4gQ2hvb25nd29vICA8Y3doYW4udHVuekBnbWFpbC5jb20+CisKKyAg ICAgICAgUmVuYW1lICd1c2VzQXJndW1lbnRzJyB0byAnc2V0VXNlc0FyZ3VtZW50cycgaW4gQVNU QnVpbGRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQxMDI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwYXJzZXIvQVNUQnVpbGRlci5oOgorICAgICAgICAoSlNDOjpBU1RCdWlsZGVyOjpjcmVhdGVS ZXNvbHZlKToKKyAgICAgICAgKEpTQzo6QVNUQnVpbGRlcjo6Y3JlYXRlRnVuY0RlY2xTdGF0ZW1l bnQpOgorICAgICAgICAoSlNDOjpBU1RCdWlsZGVyOjphZGRWYXIpOgorICAgICAgICAoSlNDOjpB U1RCdWlsZGVyOjpzZXRVc2VzQXJndW1lbnRzKToKKyAgICAgICAgKEpTQzo6QVNUQnVpbGRlcjo6 dXNlc0FyZ3VtZW50cyk6IERlbGV0ZWQuCisKIDIwMTUtMDEtMjggIEdlb2ZmcmV5IEdhcmVuICA8 Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmVkIGZhc3RNYWxsb2NGb3JiaWQgLyBm YXN0TWFsbG9jQWxsb3cKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVp bGRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVp bGRlci5oCShyZXZpc2lvbiAxNzkzMjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2Vy L0FTVEJ1aWxkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTY5LDcgKzE2OSw3IEBAIHB1YmxpYzoK ICAgICBFeHByZXNzaW9uTm9kZSogY3JlYXRlUmVzb2x2ZShjb25zdCBKU1Rva2VuTG9jYXRpb24m IGxvY2F0aW9uLCBjb25zdCBJZGVudGlmaWVyKiBpZGVudCwgY29uc3QgSlNUZXh0UG9zaXRpb24m IHN0YXJ0KQogICAgIHsKICAgICAgICAgaWYgKG1fdm0tPnByb3BlcnR5TmFtZXMtPmFyZ3VtZW50 cyA9PSAqaWRlbnQpCi0gICAgICAgICAgICB1c2VzQXJndW1lbnRzKCk7CisgICAgICAgICAgICBz ZXRVc2VzQXJndW1lbnRzKCk7CiAgICAgICAgIHJldHVybiBuZXcgKG1fcGFyc2VyQXJlbmEpIFJl c29sdmVOb2RlKGxvY2F0aW9uLCAqaWRlbnQsIHN0YXJ0KTsKICAgICB9CiAgICAgRXhwcmVzc2lv bk5vZGUqIGNyZWF0ZU9iamVjdExpdGVyYWwoY29uc3QgSlNUb2tlbkxvY2F0aW9uJiBsb2NhdGlv bikgeyByZXR1cm4gbmV3IChtX3BhcnNlckFyZW5hKSBPYmplY3RMaXRlcmFsTm9kZShsb2NhdGlv bik7IH0KQEAgLTM0Niw3ICszNDYsNyBAQCBwdWJsaWM6CiAgICAgICAgIEZ1bmNEZWNsTm9kZSog ZGVjbCA9IG5ldyAobV9wYXJzZXJBcmVuYSkgRnVuY0RlY2xOb2RlKGxvY2F0aW9uLCAqaW5mby5u YW1lLCBpbmZvLmJvZHksCiAgICAgICAgICAgICBtX3NvdXJjZUNvZGUtPnN1YkV4cHJlc3Npb24o aW5mby5vcGVuQnJhY2VPZmZzZXQsIGluZm8uY2xvc2VCcmFjZU9mZnNldCwgaW5mby5ib2R5U3Rh cnRMaW5lLCBpbmZvLmJvZHlTdGFydENvbHVtbiksIGluZm8ucGFyYW1ldGVycyk7CiAgICAgICAg IGlmICgqaW5mby5uYW1lID09IG1fdm0tPnByb3BlcnR5TmFtZXMtPmFyZ3VtZW50cykKLSAgICAg ICAgICAgIHVzZXNBcmd1bWVudHMoKTsKKyAgICAgICAgICAgIHNldFVzZXNBcmd1bWVudHMoKTsK ICAgICAgICAgbV9zY29wZS5tX2Z1bmNEZWNsYXJhdGlvbnMuYXBwZW5kKGRlY2wtPmJvZHkoKSk7 CiAgICAgICAgIGluZm8uYm9keS0+c2V0TG9jKGluZm8uYm9keVN0YXJ0TGluZSwgaW5mby5ib2R5 RW5kTGluZSwgbG9jYXRpb24uc3RhcnRPZmZzZXQsIGxvY2F0aW9uLmxpbmVTdGFydE9mZnNldCk7 CiAgICAgICAgIGluZm8uYm9keS0+c2V0RnVuY3Rpb25LZXl3b3JkU3RhcnQoZnVuY3Rpb25LZXl3 b3JkU3RhcnQpOwpAQCAtNTM3LDcgKzUzNyw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGFkZFZhcihj b25zdCBJZGVudGlmaWVyKiBpZGVudCwgaW50IGF0dHJzKQogICAgIHsKICAgICAgICAgaWYgKG1f dm0tPnByb3BlcnR5TmFtZXMtPmFyZ3VtZW50cyA9PSAqaWRlbnQpCi0gICAgICAgICAgICB1c2Vz QXJndW1lbnRzKCk7CisgICAgICAgICAgICBzZXRVc2VzQXJndW1lbnRzKCk7CiAgICAgICAgIEFT U0VSVChpZGVudC0+aW1wbCgpLT5pc0F0b21pYygpKTsKICAgICAgICAgbV9zY29wZS5tX3ZhckRl Y2xhcmF0aW9ucy5hcHBlbmQoc3RkOjptYWtlX3BhaXIoKmlkZW50LCBhdHRycykpOwogICAgIH0K QEAgLTcxMyw3ICs3MTMsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgaW5jQ29uc3RhbnRzKCkgeyBt X3Njb3BlLm1fbnVtQ29uc3RhbnRzKys7IH0KICAgICB2b2lkIHVzZXNUaGlzKCkgeyBtX3Njb3Bl Lm1fZmVhdHVyZXMgfD0gVGhpc0ZlYXR1cmU7IH0KICAgICB2b2lkIHVzZXNDYXRjaCgpIHsgbV9z Y29wZS5tX2ZlYXR1cmVzIHw9IENhdGNoRmVhdHVyZTsgfQotICAgIHZvaWQgdXNlc0FyZ3VtZW50 cygpIHsgbV9zY29wZS5tX2ZlYXR1cmVzIHw9IEFyZ3VtZW50c0ZlYXR1cmU7IH0KKyAgICB2b2lk IHNldFVzZXNBcmd1bWVudHMoKSB7IG1fc2NvcGUubV9mZWF0dXJlcyB8PSBBcmd1bWVudHNGZWF0 dXJlOyB9CiAgICAgdm9pZCB1c2VzV2l0aCgpIHsgbV9zY29wZS5tX2ZlYXR1cmVzIHw9IFdpdGhG ZWF0dXJlOyB9CiAgICAgdm9pZCB1c2VzRXZhbCgpIAogICAgIHsK