141015 2015-01-28 15:36:18 -0800 asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address 2015-01-28 16:30:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dburkart dburkart ap dburkart mrowe oldest_to_newest 1065048 0 dburkart 2015-01-28 15:36:18 -0800 We should use CLANG_ADDRESS_SANITIZER=YES to build with ASan, since we use xcodebuild to do all of our (mac) building. 1065053 1 245573 dburkart 2015-01-28 15:45:48 -0800 Created attachment 245573 Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES 1065059 2 245573 ap 2015-01-28 16:19:54 -0800 Comment on attachment 245573 Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES So we can remove ASAN_OTHER_LDFLAGS from everywhere now? 1065060 3 dburkart 2015-01-28 16:21:26 -0800 (In reply to comment #2) > Comment on attachment 245573 [details] > Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES > > So we can remove ASAN_OTHER_LDFLAGS from everywhere now? Yeah, I don't see why not. 1065064 4 dburkart 2015-01-28 16:30:19 -0800 Resolved in r179312. 245573 2015-01-28 15:45:48 -0800 2015-01-28 16:19:54 -0800 Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES Bug_141015.patch text/plain 1261 dburkart SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3OTMwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE1LTAxLTI4ICBEYW5hIEJ1cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+ CisKKyAgICAgICAgYXNhbi54Y2NvbmZpZyBzaG91bGQgdXNlIENMQU5HX0FERFJFU1NfU0FOSVRJ WkVSPVlFUyBpbnN0ZWFkIG9mIC1mc2FuaXRpemU9YWRkcmVzcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMDE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc2FuL2FzYW4ueGNjb25maWc6CisKIDIw MTUtMDEtMjggIEx1Y2FzIEZvcnNjaGxlciAgPGxmb3JzY2hsZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIEluY3JlYXNlIHRoZSBGaWxlVXBsb2FkIGJsb2NrIHNpemUgaW4gYW4gYXR0ZW1wdCB0byBp bXByb3ZlIG5ldHdvcmsgcGVyZm9ybWFuY2UuCkluZGV4OiBUb29scy9hc2FuL2FzYW4ueGNjb25m aWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvYXNhbi9hc2FuLnhjY29uZmlnCShyZXZpc2lvbiAxNzky NjcpCisrKyBUb29scy9hc2FuL2FzYW4ueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTEwLDgg KzEwLDkgQEAgR0NDX09QVElNSVpBVElPTl9MRVZFTF9EZWJ1ZyA9IDA7CiBHQ0NfT1BUSU1JWkFU SU9OX0xFVkVMX1Byb2R1Y3Rpb24gPSAxOwogR0NDX09QVElNSVpBVElPTl9MRVZFTF9SZWxlYXNl ID0gMTsKIAotQVNBTl9PVEhFUl9DRkxBR1MgPSAtZnNhbml0aXplPWFkZHJlc3MgLWZzYW5pdGl6 ZS1ibGFja2xpc3Q9JChBU0FOX0lHTk9SRSkgLWZuby1vbWl0LWZyYW1lLXBvaW50ZXIgLWc7CitD TEFOR19BRERSRVNTX1NBTklUSVpFUj1ZRVMKKworQVNBTl9PVEhFUl9DRkxBR1MgPSAtZnNhbml0 aXplLWJsYWNrbGlzdD0kKEFTQU5fSUdOT1JFKSAtZm5vLW9taXQtZnJhbWUtcG9pbnRlciAtZzsK IEFTQU5fT1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAkKEFTQU5fT1RIRVJfQ0ZMQUdTKTsKLUFTQU5f T1RIRVJfTERGTEFHUyA9IC1mc2FuaXRpemU9YWRkcmVzczsKIAogR0NDX0VOQUJMRV9PQkpDX0dD ID0gTk87Cg==