141006 2015-01-28 12:23:48 -0800 Web Inspector: Change Main Frame Status Buttons when debugging Augmented JSContext 2015-01-28 18:01:35 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1064986 0 joepeck 2015-01-28 12:23:48 -0800 * SUMMARY Change Main Frame Status Buttons when debugging Augmented JSContext. The Download Web Archive button doesn't really make sense. And change "Reload..." to "Restart...". 1064987 1 webkit-bug-importer 2015-01-28 12:24:12 -0800 <rdar://problem/19635014> 1064988 2 245563 joepeck 2015-01-28 12:25:32 -0800 Created attachment 245563 [PATCH] Proposed Fix 1065056 3 245563 timothy 2015-01-28 16:04:35 -0800 Comment on attachment 245563 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=245563&action=review > Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.js:60 > + this._element.classList.toggle("hidden", flag); Woot! 1065107 4 joepeck 2015-01-28 18:01:29 -0800 http://trac.webkit.org/changeset/179322 245563 2015-01-28 12:25:32 -0800 2015-01-28 18:01:35 -0800 [PATCH] Proposed Fix status-buttons.patch text/plain 4863 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk5MDNiOTkuLjYzMjdiNmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTAxLTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2hhbmdl IE1haW4gRnJhbWUgU3RhdHVzIEJ1dHRvbnMgd2hlbiBkZWJ1Z2dpbmcgQXVnbWVudGVkIEpTQ29u dGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQx MDA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBM b2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanM6CisgICAgICAgIE5ldyAi UmVzdGFydCIgc3RyaW5nLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuY2FuQXJjaGl2ZU1haW5GcmFtZSk6CisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9GcmFtZVRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkZyYW1lVHJlZUVsZW1lbnQucHJvdG90eXBlLnVwZGF0ZVN0YXR1c0Zvck1haW5GcmFt ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRnJhbWVUcmVlRWxlbWVudC5wcm90b3R5cGUuX3Vw ZGF0ZURvd25sb2FkQnV0dG9uKToKKyAgICAgICAgVXBkYXRlIHRoZSB0b29sdGlwIHdoZW4gaW4g YSBub24tV2ViIGRlYnVnZ2FibGUsIGFuZCBvbmx5IHNob3cKKyAgICAgICAgdGhlIERvd25sb2Fk IGJ1dHRvbiB3aGVuIGluIGEgV2ViIGRlYnVnZ2FibGUuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1RyZWVFbGVtZW50U3RhdHVzQnV0dG9uLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlRyZWVFbGVtZW50U3RhdHVzQnV0dG9uLnByb3RvdHlwZS5zZXQgaGlkZGVuKToKKyAgICAg ICAgT29wcyEgVGhlIGltcGxlbWVudGF0aW9uIHdhcyBiYWNrd2FyZHMuIFNpbXBsaWZ5IHdpdGgg Y2xhc3NMaXN0LnRvZ2dsZS4KKwogMjAxNS0wMS0yNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVTNjogSW1wcm92ZWQgQ29u c29sZSBGb3JtYXQgZm9yIFNldCBhbmQgTWFwIE9iamVjdHMgKGxpa2UgQXJyYXlzKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxp emVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxw cm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggYmE5ZTUzYmNhOWYyNmVhNmIwYmM5ODMyYmYy Mzc1NGJlMDAxMGEwOS4uNzU4MjE0NGUyNGI5OGI3MDEwODNmMmE0YzVhZTVkZmJkNjY3MWVhMCAx MDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSA1MAp6Y21kbjdpK1NFfDxfJH5OYTI3TF5GZUVZ KkZfY1hIdXZENUMmU093dSgzcVR7WUIpSzV0LXxKbVlzdzcoJjFNbXcKCmRlbHRhIDE0CldjbWJR WW58YTRCPF8kfk5aMDI0JiojSDFHdUxsN0QKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggNWM3M2UwZS4uOWJkZGQ0NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAt MTg4Niw3ICsxODg2LDcgQEAgV2ViSW5zcGVjdG9yLmFyY2hpdmVNYWluRnJhbWUgPSBmdW5jdGlv bigpCiAKIFdlYkluc3BlY3Rvci5jYW5BcmNoaXZlTWFpbkZyYW1lID0gZnVuY3Rpb24oKQogewot ICAgIGlmICghUGFnZUFnZW50LmFyY2hpdmUpCisgICAgaWYgKCFQYWdlQWdlbnQuYXJjaGl2ZSB8 fCB0aGlzLmRlYnVnZ2FibGVUeXBlICE9PSBXZWJJbnNwZWN0b3IuRGVidWdnYWJsZVR5cGUuV2Vi KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlJlc291 cmNlLnR5cGVGcm9tTUlNRVR5cGUoV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3VyY2VNYW5hZ2VyLm1h aW5GcmFtZS5tYWluUmVzb3VyY2UubWltZVR5cGUpID09PSBXZWJJbnNwZWN0b3IuUmVzb3VyY2Uu VHlwZS5Eb2N1bWVudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0ZyYW1lVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9GcmFtZVRyZWVFbGVtZW50LmpzCmluZGV4IGE5OTU2NGUuLmQz Nzk3ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0ZyYW1lVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRnJhbWVUcmVlRWxlbWVudC5qcwpAQCAtMjAyLDcgKzIwMiwxMiBAQCBX ZWJJbnNwZWN0b3IuRnJhbWVUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICgh dGhpcy5fbG9hZGluZ01haW5GcmFtZUJ1dHRvbnMpIHsKICAgICAgICAgICAgIHRoaXMuX2xvYWRp bmdNYWluRnJhbWVCdXR0b25zID0gdHJ1ZTsKIAotICAgICAgICAgICAgdmFyIHRvb2x0aXAgPSBX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJlbG9hZCBwYWdlICglcylcblJlbG9hZCBpZ25vcmluZyBj YWNoZSAoJXMpIikuZm9ybWF0KFdlYkluc3BlY3Rvci5fcmVsb2FkUGFnZUtleWJvYXJkU2hvcnRj dXQuZGlzcGxheU5hbWUsIFdlYkluc3BlY3Rvci5fcmVsb2FkUGFnZUlnbm9yaW5nQ2FjaGVLZXli b2FyZFNob3J0Y3V0LmRpc3BsYXlOYW1lKTsKKyAgICAgICAgICAgIHZhciB0b29sdGlwOworICAg ICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5kZWJ1Z2dhYmxlVHlwZSA9PT0gV2ViSW5zcGVjdG9y LkRlYnVnZ2FibGVUeXBlLkphdmFTY3JpcHQpCisgICAgICAgICAgICAgICAgdG9vbHRpcCA9IFdl Ykluc3BlY3Rvci5VSVN0cmluZygiUmVzdGFydCAoJXMpIikuZm9ybWF0KFdlYkluc3BlY3Rvci5f cmVsb2FkUGFnZUtleWJvYXJkU2hvcnRjdXQuZGlzcGxheU5hbWUpOworICAgICAgICAgICAgZWxz ZQorICAgICAgICAgICAgICAgIHRvb2x0aXAgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJlbG9h ZCBwYWdlICglcylcblJlbG9hZCBpZ25vcmluZyBjYWNoZSAoJXMpIikuZm9ybWF0KFdlYkluc3Bl Y3Rvci5fcmVsb2FkUGFnZUtleWJvYXJkU2hvcnRjdXQuZGlzcGxheU5hbWUsIFdlYkluc3BlY3Rv ci5fcmVsb2FkUGFnZUlnbm9yaW5nQ2FjaGVLZXlib2FyZFNob3J0Y3V0LmRpc3BsYXlOYW1lKTsK KwogICAgICAgICAgICAgd3JhcHBlZFNWR0RvY3VtZW50KHBsYXRmb3JtSW1hZ2VQYXRoKCJSZWxv YWQuc3ZnIiksIG51bGwsIHRvb2x0aXAsIGZ1bmN0aW9uKGVsZW1lbnQpIHsKICAgICAgICAgICAg ICAgICB0aGlzLl9yZWxvYWRCdXR0b24gPSBuZXcgV2ViSW5zcGVjdG9yLlRyZWVFbGVtZW50U3Rh dHVzQnV0dG9uKGVsZW1lbnQpOwogICAgICAgICAgICAgICAgIHRoaXMuX3JlbG9hZEJ1dHRvbi5h ZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UcmVlRWxlbWVudFN0YXR1c0J1dHRvbi5FdmVu dC5DbGlja2VkLCB0aGlzLl9yZWxvYWRQYWdlQ2xpY2tlZCwgdGhpcyk7CkBAIC0zNDIsNyArMzQ3 LDcgQEAgV2ViSW5zcGVjdG9yLkZyYW1lVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAg ICBpZiAoIXRoaXMuX2Rvd25sb2FkQnV0dG9uKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAg ICAgIGlmICghUGFnZUFnZW50LmFyY2hpdmUpIHsKKyAgICAgICAgaWYgKCFQYWdlQWdlbnQuYXJj aGl2ZSB8fCBXZWJJbnNwZWN0b3IuZGVidWdnYWJsZVR5cGUgIT09IFdlYkluc3BlY3Rvci5EZWJ1 Z2dhYmxlVHlwZS5XZWIpIHsKICAgICAgICAgICAgIHRoaXMuX2Rvd25sb2FkQnV0dG9uLmhpZGRl biA9IHRydWU7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVFbGVtZW50U3RhdHVz QnV0dG9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJl ZUVsZW1lbnRTdGF0dXNCdXR0b24uanMKaW5kZXggOGVlNmQ4Mi4uNDRiZTU2OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZUVsZW1lbnRT dGF0dXNCdXR0b24uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVHJlZUVsZW1lbnRTdGF0dXNCdXR0b24uanMKQEAgLTU3LDEwICs1Nyw3IEBAIFdlYklu c3BlY3Rvci5UcmVlRWxlbWVudFN0YXR1c0J1dHRvbi5wcm90b3R5cGUgPSB7CiAKICAgICBzZXQg aGlkZGVuKGZsYWcpCiAgICAgewotICAgICAgICBpZiAoZmxhZykKLSAgICAgICAgICAgIHRoaXMu X2VsZW1lbnQuY2xhc3NMaXN0LnJlbW92ZSgiaGlkZGVuIik7Ci0gICAgICAgIGVsc2UKLSAgICAg ICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZCgiaGlkZGVuIik7CisgICAgICAgIHRo aXMuX2VsZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgiaGlkZGVuIiwgZmxhZyk7CiAgICAgfSwKIAog ICAgIGdldCBlbmFibGVkKCkK