141004 2015-01-28 11:49:51 -0800 [WinCairo] Compile error in media player implementation. 2015-01-28 13:01:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue oldest_to_newest 1064973 0 peavo 2015-01-28 11:49:51 -0800 MediaPlayer::cachedResourceLoader() returns a pointer to the resource loader, not a reference. 1064977 1 245560 peavo 2015-01-28 11:52:28 -0800 Created attachment 245560 Patch 1064983 2 245560 bfulgham 2015-01-28 12:16:46 -0800 Comment on attachment 245560 Patch r=me. 1065008 3 245560 commit-queue 2015-01-28 13:01:06 -0800 Comment on attachment 245560 Patch Clearing flags on attachment: 245560 Committed r179280: <http://trac.webkit.org/changeset/179280> 1065009 4 commit-queue 2015-01-28 13:01:10 -0800 All reviewed patches have been landed. Closing bug. 245560 2015-01-28 11:52:28 -0800 2015-01-28 13:01:06 -0800 Patch bug-141004-20150128205201.patch text/plain 2362 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTI3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTI4ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvciBpbiBtZWRpYSBwbGF5ZXIgaW1wbGVtZW50YXRpb24uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEwMDQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZWRpYVBsYXllcjo6Y2FjaGVkUmVz b3VyY2VMb2FkZXIoKSByZXR1cm5zIGEgcG9pbnRlciB0byB0aGUgcmVzb3VyY2UgbG9hZGVyLCBu b3QgYSByZWZlcmVuY2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQ bGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6c2V0U2l6ZSk6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OmNyZWF0ZVZpZGVvV2luZG93KToK KwogMjAxNS0wMS0yOCAgRGFuYSBCdXJrYXJ0ICA8ZGJ1cmthcnRAYXBwbGUuY29tPgogCiAgICAg ICAgIE1vdmUgQVNhbiBmbGFnIHNldHRpbmdzIGZyb20gRGVidWdSZWxlYXNlLnhjY29uZmlnIHRv IEJhc2UueGNjb25maWcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dp bi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRp YUZvdW5kYXRpb24uY3BwCShyZXZpc2lvbiAxNzkyNzQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTk2LDggKzE5Niw4IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl TWVkaWFGb3VuZGF0aW9uOjoKICAgICBMYXlvdXRTaXplIHNjcm9sbE9mZnNldDsKIAogICAgIEZy YW1lVmlldyogdmlldyA9IG51bGxwdHI7Ci0gICAgaWYgKG1fcGxheWVyICYmIG1fcGxheWVyLT5j YWNoZWRSZXNvdXJjZUxvYWRlcigpICYmIG1fcGxheWVyLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigp LmRvY3VtZW50KCkpCi0gICAgICAgIHZpZXcgPSBtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VMb2Fk ZXIoKS5kb2N1bWVudCgpLT52aWV3KCk7CisgICAgaWYgKG1fcGxheWVyICYmIG1fcGxheWVyLT5j YWNoZWRSZXNvdXJjZUxvYWRlcigpICYmIG1fcGxheWVyLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigp LT5kb2N1bWVudCgpKQorICAgICAgICB2aWV3ID0gbV9wbGF5ZXItPmNhY2hlZFJlc291cmNlTG9h ZGVyKCktPmRvY3VtZW50KCktPnZpZXcoKTsKICAgICBpZiAodmlldykKICAgICAgICAgc2Nyb2xs T2Zmc2V0ID0gdmlldy0+c2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQb3NpdGlvbigpOwogCkBAIC00MzQs OSArNDM0LDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246Ogogewog ICAgIEhXTkQgaFduZFBhcmVudCA9IG51bGxwdHI7CiAgICAgRnJhbWVWaWV3KiB2aWV3ID0gbnVs bHB0cjsKLSAgICBpZiAoIW1fcGxheWVyIHx8ICFtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VMb2Fk ZXIoKSB8fCAhbV9wbGF5ZXItPmNhY2hlZFJlc291cmNlTG9hZGVyKCkuZG9jdW1lbnQoKSkKKyAg ICBpZiAoIW1fcGxheWVyIHx8ICFtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIoKSB8fCAh bV9wbGF5ZXItPmNhY2hlZFJlc291cmNlTG9hZGVyKCktPmRvY3VtZW50KCkpCiAgICAgICAgIHJl dHVybjsKLSAgICB2aWV3ID0gbV9wbGF5ZXItPmNhY2hlZFJlc291cmNlTG9hZGVyKCkuZG9jdW1l bnQoKS0+dmlldygpOworICAgIHZpZXcgPSBtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIo KS0+ZG9jdW1lbnQoKS0+dmlldygpOwogICAgIGlmICghdmlldyB8fCAhdmlldy0+aG9zdFdpbmRv dygpKQogICAgICAgICByZXR1cm47CiAgICAgaFduZFBhcmVudCA9IHZpZXctPmhvc3RXaW5kb3co KS0+cGxhdGZvcm1QYWdlQ2xpZW50KCk7Cg==