141000 2015-01-28 09:54:20 -0800 Make run-jsc-stress-tests --remote work on Linux too 2015-02-02 11:15:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141165 1 ossy ossy commit-queue darin ddkilzer fpizlo oliver ossy oldest_to_newest 1064929 0 ossy 2015-01-28 09:54:20 -0800 Now the --remote option of run-jsc-stress-tests works only on Mac, it would be great to be able use it on Linux too. 1064936 1 245549 ossy 2015-01-28 10:01:05 -0800 Created attachment 245549 Patch I have no idea if it will work on iOS, so it would be good if an iOS expert can review it. 1064943 2 ossy 2015-01-28 10:07:45 -0800 Some additional info why we need this changes: - The runner script is run with "sh runner" command and sh is dash on Debian/Ubuntu distros, so we have to remove the function bashisms. - find doesn't have "-depth N" option on Linux, but "-maxdepth N" is available on Linux and Mac too and do the same in this case. - find warns if we put an option after a non-option argument, so we should put is before the -name. ("find: warning: you have specified the -maxdepth option after a non-option argument -name, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it). Please specify options before other arguments.") - trap of dash doesn't know SIGINT SIGHUP SIGTERM signals, but bash and dash know INT HUP TERM signals, so let's replace them. 1065067 3 245549 darin 2015-01-28 16:32:59 -0800 Comment on attachment 245549 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245549&action=review > Tools/Scripts/jsc-stress-test-helpers/shell-runner.sh:24 > +numProcs=`sysctl -n hw.activecpu 2>/dev/null` A lot of times this pattern is dangerous; if there is some failure it is silently sent to the bit bucket. Do we really need to do this? 1065207 4 245549 ossy 2015-01-29 04:48:46 -0800 Comment on attachment 245549 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245549&action=review >> Tools/Scripts/jsc-stress-test-helpers/shell-runner.sh:24 >> +numProcs=`sysctl -n hw.activecpu 2>/dev/null` > > A lot of times this pattern is dangerous; if there is some failure it is silently sent to the bit bucket. Do we really need to do this? It always dumps error on Linux: "sysctl: cannot stat /proc/sys/hw/activecpu: No such file or directory" We don't need useless error/warning messages always on Linux, and we already use the same pattern for nproc in line27 and in jsc-stress-tests too. I think it's safe, because we handle the return code/value properly everywhere. 1065213 5 245549 commit-queue 2015-01-29 05:33:50 -0800 Comment on attachment 245549 Patch Clearing flags on attachment: 245549 Committed r179343: <http://trac.webkit.org/changeset/179343> 1065214 6 commit-queue 2015-01-29 05:33:54 -0800 All reviewed patches have been landed. Closing bug. 245549 2015-01-28 10:01:05 -0800 2015-01-29 05:33:50 -0800 Patch bug-141000-20150128100108.patch text/plain 2708 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MjUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjRlNWQ3OWM2YzIyYTlkNWNmMDQ5M2Y0NGU2Y2M4YTA1 Y2IwNGNiNS4uYjQxYTk4Y2JhNmYwYWE2ZDIxNjcxNGM1Mjk3NTIwNGRkYWY4NDBiZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTAxLTI4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgTWFrZSBydW4tanNjLXN0cmVzcy10ZXN0cyAtLXJlbW90ZSB3b3JrIG9uIExpbnV4 IHRvbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQx MDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL2pzYy1zdHJlc3MtdGVzdC1oZWxwZXJzL3NoZWxsLXJ1bm5lci5zaDogT21pdCBlcnJv ciBtZXNzYWdlIG9mIHN5c2N0bCwKKyAgICAgICAgdXNlIGJhc2gvZGFzaCBjb21wYXRpYmxlIHNp Z25hbCBuYW1lcywgdXNlIExpbnV4L01hYyBjb21wYXRpYmxlIGZpbmQgb3B0aW9ucywKKyAgICAg ICAgdXNlIGJhc2gvZGFzaCBjb21wYXRpYmxlIGZ1bmN0aW9ucy4KKyAgICAgICAgKiBTY3JpcHRz L3J1bi1qc2Mtc3RyZXNzLXRlc3RzOiBVc2UgTGludXgvTWFjIGNvbXBhdGlibGUgZmluZCBvcHRp b25zLgorCiAyMDE1LTAxLTI4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1RLXSBTdG9wIHJlbW92aW5nIGNvbG9yIG1hcmtzIGZyb20gdW5p dCB0ZXN0cyBvdXRwdXQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvanNjLXN0cmVzcy10ZXN0 LWhlbHBlcnMvc2hlbGwtcnVubmVyLnNoIGIvVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3Qt aGVscGVycy9zaGVsbC1ydW5uZXIuc2gKaW5kZXggYzBiZDQ4ZGU0MTdmYzkyZWFjZTg3NGE5MjZk ZGIwOGZmMGFjMWRhMS4uZGVjZmJkZDJlMWE0NGFhOTIyNjVlZTQxYjc2Y2ZhYzM3YzIwNWRmMCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9zaGVsbC1y dW5uZXIuc2gKKysrIGIvVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9zaGVs bC1ydW5uZXIuc2gKQEAgLTIxLDcgKzIxLDcgQEAKICMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9S IE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCiAjIFRISVMg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuCiAKLW51bVByb2NzPWBzeXNjdGwgLW4gaHcuYWN0aXZlY3B1YAorbnVtUHJvY3M9YHN5c2N0 bCAtbiBody5hY3RpdmVjcHUgMj4vZGV2L251bGxgCiBpZiBbICQ/IC1ndCAwIF0KIHRoZW4KICAg ICBudW1Qcm9jcz1gbnByb2MgLS1hbGwgMj4vZGV2L251bGxgCkBAIC0zNiwxNiArMzYsMTYgQEAg dGVzdExpc3Q9Ii5hbGxfdGVzdHMudHh0IgogdGVtcEZpbGU9Ii50ZW1wLnR4dCIKIGxvY2tEaXI9 Ii5sb2NrX2RpciIKIAotdHJhcCAia2lsbCAtOSAwIiBTSUdJTlQgU0lHSFVQIFNJR1RFUk0KK3Ry YXAgImtpbGwgLTkgMCIgSU5UIEhVUCBURVJNCiAKIGVjaG8gMCA+ICR7aW5kZXhGaWxlfQotZmlu ZCAuIC1uYW1lICd0ZXN0X3NjcmlwdF8qJyAtZGVwdGggMSA+ICR7dGVzdExpc3R9CitmaW5kIC4g LW1heGRlcHRoIDEgLW5hbWUgJ3Rlc3Rfc2NyaXB0XyonID4gJHt0ZXN0TGlzdH0KIAotZnVuY3Rp b24gbG9ja190ZXN0X2xpc3QoKSB7Citsb2NrX3Rlc3RfbGlzdCgpIHsKICAgICB1bnRpbCBta2Rp ciAke2xvY2tEaXJ9IDI+IC9kZXYvbnVsbDsgZG8gc2xlZXAgMDsgZG9uZQogfQogCi1mdW5jdGlv biB1bmxvY2tfdGVzdF9saXN0KCkgewordW5sb2NrX3Rlc3RfbGlzdCgpIHsKICAgICBybWRpciAk e2xvY2tEaXJ9CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3Mt dGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4IDEyZWI0NjBh NjFhYjAxMDA2ZjNiZGJjNTdiMmY3YjFhYTc2MDhlMjEuLjYwN2M4M2MxNWVkNGY4ZGE4ODBlY2U4 NDFlNjUzNjcwZTQ4OWVhMTYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJl c3MtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwpAQCAtMTM5 Miw3ICsxMzkyLDcgQEAgZGVmIGRldGVjdEZhaWx1cmVzCiAgICAgcmFpc2UgaWYgJGJ1bmRsZQog CiAgICAgaWYgJHJlbW90ZQotICAgICAgICBvdXRwdXQgPSBzc2hSZWFkKCJjZCAjeyRyZW1vdGVE aXJlY3Rvcnl9LyN7JG91dHB1dERpci5iYXNlbmFtZX0vLnJ1bm5lciAmJiBmaW5kIC4gLW5hbWUg XCJ0ZXN0X2ZhaWxfKlwiIC1kZXB0aCAxIikKKyAgICAgICAgb3V0cHV0ID0gc3NoUmVhZCgiY2Qg I3skcmVtb3RlRGlyZWN0b3J5fS8jeyRvdXRwdXREaXIuYmFzZW5hbWV9Ly5ydW5uZXIgJiYgZmlu ZCAuIC1tYXhkZXB0aCAxIC1uYW1lIFwidGVzdF9mYWlsXypcIiIpCiAgICAgICAgIG91dHB1dC5z cGxpdCgvXG4vKS5lYWNoIHsKICAgICAgICAgICAgIHwgbGluZSB8CiAgICAgICAgICAgICBuZXh0 IHVubGVzcyBsaW5lID1+IC90ZXN0X2ZhaWxfLwo=