140998 2015-01-28 07:42:37 -0800 [GTK] Runtime critical warnings sometimes at start up when using the network process 2015-01-29 23:23:05 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned commit-queue gustavo svillar zan oldest_to_newest 1064889 0 cgarcia 2015-01-28 07:42:37 -0800 (WebKitWebProcess:1594): GLib-CRITICAL **: g_main_loop_run: assertion 'loop != NULL' failed (WebKitWebProcess:1617): GLib-CRITICAL **: g_main_loop_run: assertion 'loop != NULL' failed (WebKitWebProcess:1609): GLib-CRITICAL **: g_main_loop_run: assertion 'loop != NULL' failed (WebKitWebProcess:1613): GLib-CRITICAL **: g_main_loop_run: assertion 'loop != NULL' failed (WebKitWebProcess:1638): GLib-CRITICAL **: g_main_loop_run: assertion 'loop != NULL' failed This is caused by the CustomProtocolManager work queue theread. This WorkQueue is created when the CustomProtocolManager object is constructed, but destroyed when it's initialized when the UI process asks to use the network process. In this case, sometimes happens that the work queue thread that runs the main loop is executed once the object has been destroyed and the main loop pointer is null. 1064892 1 245542 cgarcia 2015-01-28 07:46:04 -0800 Created attachment 245542 Patch Detach the worker thread when the work queue is destroyed, right before deleting the main loop 1064893 2 commit-queue 2015-01-28 07:47:39 -0800 Attachment 245542 did not pass style-queue: ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:55: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1065191 3 245542 zan 2015-01-29 01:58:57 -0800 Comment on attachment 245542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245542&action=review > Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:55 > - m_workQueueThread = createThread(reinterpret_cast<WTF::ThreadFunction>(&WorkQueue::startWorkQueueThread), this, threadName); > + m_workQueueThread = createThread(threadName, [this] { g_main_loop_run(m_eventLoop.get()); }); WorkQueue is ref-counted. This should probably pass a RefPtr protector into the lambda. 1065505 4 cgarcia 2015-01-29 23:23:05 -0800 Committed r179395: <http://trac.webkit.org/changeset/179395> 245542 2015-01-28 07:46:04 -0800 2015-01-29 01:58:57 -0800 Patch wk2-work-queue-detach-thread.diff text/plain 3575 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhMzZkNTEzLi5mZWRiNTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjkg QEAKIDIwMTUtMDEtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFJ1bnRpbWUgY3JpdGljYWwgd2FybmluZ3Mgc29tZXRpbWVzIGF0 IHN0YXJ0IHVwIHdoZW4gdXNpbmcgdGhlIG5ldHdvcmsgcHJvY2VzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwOTk4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBjYXVzZWQgYnkgdGhlIEN1 c3RvbVByb3RvY29sTWFuYWdlciB3b3JrIHF1ZXVlCisgICAgICAgIHRoZXJlYWQuIFRoaXMgV29y a1F1ZXVlIGlzIGNyZWF0ZWQgd2hlbiB0aGUgQ3VzdG9tUHJvdG9jb2xNYW5hZ2VyCisgICAgICAg IG9iamVjdCBpcyBjb25zdHJ1Y3RlZCwgYnV0IGRlc3Ryb3llZCB3aGVuIGl0J3MgaW5pdGlhbGl6 ZWQgd2hlbgorICAgICAgICB0aGUgVUkgcHJvY2VzcyBhc2tzIHRvIHVzZSB0aGUgbmV0d29yayBw cm9jZXNzLiBJbiB0aGlzIGNhc2UsCisgICAgICAgIHNvbWV0aW1lcyBoYXBwZW5zIHRoYXQgdGhl IHdvcmsgcXVldWUgdGhyZWFkIHRoYXQgcnVucyB0aGUgbWFpbgorICAgICAgICBsb29wIGlzIGV4 ZWN1dGVkIG9uY2UgdGhlIG9iamVjdCBoYXMgYmVlbiBkZXN0cm95ZWQgYW5kIHRoZSBtYWluCisg ICAgICAgIGxvb3AgcG9pbnRlciBpcyBudWxscHRyLgorCisgICAgICAgICogUGxhdGZvcm0vV29y a1F1ZXVlLmg6CisgICAgICAgICogUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHA6CisgICAg ICAgIChXb3JrUXVldWU6OnBsYXRmb3JtSW5pdGlhbGl6ZSk6IFVzZSBhIGxhbWJkYSBmdW5jdGlv biBmb3IgdGhlCisgICAgICAgIHRocmVhZCBib2R5LgorICAgICAgICAoV29ya1F1ZXVlOjpwbGF0 Zm9ybUludmFsaWRhdGUpOiBEZXRhY2ggdGhlIHdvcmtlciB0aHJlYWQgYmVmb3JlCisgICAgICAg IGRlbGV0aW5nIHRoZSBtYWluIGxvb3Agb2JqZWN0LgorICAgICAgICAoV29ya1F1ZXVlOjpzdGFy dFdvcmtRdWV1ZVRocmVhZCk6IERlbGV0ZWQuCisgICAgICAgIChXb3JrUXVldWU6OndvcmtRdWV1 ZVRocmVhZEJvZHkpOiBEZWxldGVkLgorCisyMDE1LTAxLTI4ICBDYXJsb3MgR2FyY2lhIENhbXBv cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkLiBBZGQgbWlzc2lu ZyBmaWxlIHRvIFdlYkluc3BlY3RvciBjb21waWxhdGlvbiBmb3IgR1RLKy4KIAogICAgICAgICAq IFBsYXRmb3JtR1RLLmNtYWtlOiBBZGQgVXNlckludGVyZmFjZS9FeHRlcm5hbC9FU0xpbnQvZXNs aW50LmpzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Xb3JrUXVldWUuaCBi L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL1dvcmtRdWV1ZS5oCmluZGV4IDkzYzdlNzguLjNjOTQy MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL1dvcmtRdWV1ZS5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL1dvcmtRdWV1ZS5oCkBAIC04OCw5ICs4OCw2IEBAIHBy aXZhdGU6CiAgICAgc3RhdGljIHZvaWQgZXhlY3V0ZUZ1bmN0aW9uKHZvaWQqKTsKICAgICBkaXNw YXRjaF9xdWV1ZV90IG1fZGlzcGF0Y2hRdWV1ZTsKICNlbGlmIFBMQVRGT1JNKEdUSykKLSAgICBz dGF0aWMgdm9pZCBzdGFydFdvcmtRdWV1ZVRocmVhZChXb3JrUXVldWUqKTsKLSAgICB2b2lkIHdv cmtRdWV1ZVRocmVhZEJvZHkoKTsKLQogICAgIFRocmVhZElkZW50aWZpZXIgbV93b3JrUXVldWVU aHJlYWQ7CiAgICAgR1JlZlB0cjxHTWFpbkNvbnRleHQ+IG1fZXZlbnRDb250ZXh0OwogICAgIE11 dGV4IG1fZXZlbnRMb29wTG9jazsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt L2d0ay9Xb3JrUXVldWVHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZ3RrL1dvcmtR dWV1ZUd0ay5jcHAKaW5kZXggYmQ4NTJkYS4uMWY3OGI5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHAKQEAgLTUyLDEzICs1MiwxNyBAQCB2b2lkIFdv cmtRdWV1ZTo6cGxhdGZvcm1Jbml0aWFsaXplKGNvbnN0IGNoYXIqIG5hbWUsIFFPUykKICAgICBp ZiAoc3RybGVuKHRocmVhZE5hbWUpID4ga1Zpc3VhbFN0dWRpb1RocmVhZE5hbWVMaW1pdCkKICAg ICAgICAgdGhyZWFkTmFtZSArPSBzdHJsZW4odGhyZWFkTmFtZSkgLSBrVmlzdWFsU3R1ZGlvVGhy ZWFkTmFtZUxpbWl0OwogCi0gICAgbV93b3JrUXVldWVUaHJlYWQgPSBjcmVhdGVUaHJlYWQocmVp bnRlcnByZXRfY2FzdDxXVEY6OlRocmVhZEZ1bmN0aW9uPigmV29ya1F1ZXVlOjpzdGFydFdvcmtR dWV1ZVRocmVhZCksIHRoaXMsIHRocmVhZE5hbWUpOworICAgIG1fd29ya1F1ZXVlVGhyZWFkID0g Y3JlYXRlVGhyZWFkKHRocmVhZE5hbWUsIFt0aGlzXSB7IGdfbWFpbl9sb29wX3J1bihtX2V2ZW50 TG9vcC5nZXQoKSk7IH0pOwogfQogCiB2b2lkIFdvcmtRdWV1ZTo6cGxhdGZvcm1JbnZhbGlkYXRl KCkKIHsKLSAgICBNdXRleExvY2tlciBsb2NrZXIobV9ldmVudExvb3BMb2NrKTsKKyAgICBpZiAo bV93b3JrUXVldWVUaHJlYWQpIHsKKyAgICAgICAgZGV0YWNoVGhyZWFkKG1fd29ya1F1ZXVlVGhy ZWFkKTsKKyAgICAgICAgbV93b3JrUXVldWVUaHJlYWQgPSAwOworICAgIH0KIAorICAgIE11dGV4 TG9ja2VyIGxvY2tlcihtX2V2ZW50TG9vcExvY2spOwogICAgIGlmIChtX2V2ZW50TG9vcCkgewog ICAgICAgICBpZiAoZ19tYWluX2xvb3BfaXNfcnVubmluZyhtX2V2ZW50TG9vcC5nZXQoKSkpCiAg ICAgICAgICAgICBnX21haW5fbG9vcF9xdWl0KG1fZXZlbnRMb29wLmdldCgpKTsKQEAgLTY4LDE2 ICs3Miw2IEBAIHZvaWQgV29ya1F1ZXVlOjpwbGF0Zm9ybUludmFsaWRhdGUoKQogICAgIG1fZXZl bnRDb250ZXh0LmNsZWFyKCk7CiB9CiAKLXZvaWQgV29ya1F1ZXVlOjpzdGFydFdvcmtRdWV1ZVRo cmVhZChXb3JrUXVldWUqIHdvcmtRdWV1ZSkKLXsKLSAgICB3b3JrUXVldWUtPndvcmtRdWV1ZVRo cmVhZEJvZHkoKTsKLX0KLQotdm9pZCBXb3JrUXVldWU6OndvcmtRdWV1ZVRocmVhZEJvZHkoKQot ewotICAgIGdfbWFpbl9sb29wX3J1bihtX2V2ZW50TG9vcC5nZXQoKSk7Ci19Ci0KIHZvaWQgV29y a1F1ZXVlOjpyZWdpc3RlclNvY2tldEV2ZW50SGFuZGxlcihpbnQgZmlsZURlc2NyaXB0b3IsIHN0 ZDo6ZnVuY3Rpb248dm9pZCAoKT4gZnVuY3Rpb24sIHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4gY2xv c2VGdW5jdGlvbikKIHsKICAgICBHUmVmUHRyPEdTb2NrZXQ+IHNvY2tldCA9IGFkb3B0R1JlZihn X3NvY2tldF9uZXdfZnJvbV9mZChmaWxlRGVzY3JpcHRvciwgMCkpOwo=