140997 2015-01-28 07:38:21 -0800 [CMake] Minimum python version should be 2.7 2015-01-28 08:30:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez andersca commit-queue gustavo gyuyoung.kim msaboff ossy oldest_to_newest 1064888 0 clopez 2015-01-28 07:38:21 -0800 The minimum python version required to build WebKit is set to 2.6. This means that cmake will pick python2.6 on any system that has it installed and will use it to call the python build scripts. This fails: $ rm -fr WebKitBuild/Release $ Tools/Scripts/build-webkit --release --gtk [...] -- Found Perl: /usr/bin/perl (found suitable version "5.20.1", minimum required is "5.10.0") -- Found PythonInterp: /usr/bin/python2.6 (found suitable version "2.6.8", minimum required is "2.6.0") -- Found Ruby: /usr/bin/ruby1.8 (found suitable version "1.8.7", minimum required is "1.8.7") [...] Creating hashtable for /home/clopez/webkit/webkit/Source/JavaScriptCore/runtime/ArrayPrototype.cpp Creating hashtable for /home/clopez/webkit/webkit/Source/JavaScriptCore/runtime/ObjectConstructor.cpp FAILED: cd /home/clopez/webkit/webkit/WebKitBuild/Release/Source/JavaScriptCore && /usr/bin/python2.6 /home/clopez/webkit/webkit/Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py --outputDir /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore --framework JavaScriptCore /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/CombinedDomains.json && mkdir -p /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/inspector && cp /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InspectorBackendDispatchers.h /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InspectorBackendDispatchers.cpp /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InspectorFrontendDispatchers.h /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InspectorFrontendDispatchers.cpp /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InspectorProtocolObjects.h /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InspectorProtocolObjects.cpp /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/inspector && mkdir -p /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/WebInspectorUI/UserInterface/Protocol && cp /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InspectorBackendCommands.js /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/WebInspectorUI/UserInterface/Protocol Traceback (most recent call last): File "/home/clopez/webkit/webkit/Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py", line 206, in <module> generate_from_specification(**options) File "/home/clopez/webkit/webkit/Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py", line 128, in generate_from_specification load_specification(protocol, primary_specification_filepath, isSupplemental=False) File "/home/clopez/webkit/webkit/Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py", line 121, in load_specification protocol.parse_specification(parsed_json, isSupplemental) File "/home/clopez/webkit/webkit/Source/JavaScriptCore/inspector/scripts/codegen/models.py", line 290, in parse_specification self.parse_domain(domain, isSupplemental) File "/home/clopez/webkit/webkit/Source/JavaScriptCore/inspector/scripts/codegen/models.py", line 303, in parse_domain types.extend([self.parse_type_declaration(declaration) for declaration in json['types']]) File "/home/clopez/webkit/webkit/Source/JavaScriptCore/inspector/scripts/codegen/models.py", line 335, in parse_type_declaration duplicate_names = find_duplicates([member.member_name for member in type_members]) File "/home/clopez/webkit/webkit/Source/JavaScriptCore/inspector/scripts/codegen/models.py", line 38, in find_duplicates return [key for key, count in collections.Counter(l).items() if count > 1] AttributeError: 'module' object has no attribute 'Counter' ninja: build stopped: subcommand failed. The failure is because of http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/inspector/scripts/codegen/models.py?rev=179246#L38 that was introduced on r178599 <http://trac.webkit.org/r178599> collections.Counter is new on python2.7 (is not available for 2.6): https://docs.python.org/2/library/collections.html Python 2.7 was released 5 years ago, so any distribution that don't has it available probably has bigger problems to compile WebKit than the python version (like compiler or library versions). Also, after r174102 <http://trac.webkit.org/r174102> the Tools require 2.7 for the minimum version of python. It was also discussed on the mailing lists that we will start requiring python 2.7: > Discussion about requiring python 2.7 for build and test machines, without any objection: > https://lists.webkit.org/pipermail/webkit-dev/2014-September/026863.html So I think we should define 2.7 also as minimum requirement for CMake also. 1064890 1 245541 clopez 2015-01-28 07:43:10 -0800 Created attachment 245541 Patch 1064903 2 245541 commit-queue 2015-01-28 08:30:33 -0800 Comment on attachment 245541 Patch Clearing flags on attachment: 245541 Committed r179251: <http://trac.webkit.org/changeset/179251> 1064904 3 commit-queue 2015-01-28 08:30:37 -0800 All reviewed patches have been landed. Closing bug. 245541 2015-01-28 07:43:10 -0800 2015-01-28 08:30:33 -0800 Patch bug-140997-20150128164314.patch text/plain 1121 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MjUwCmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IGVmMTdkYzdmOWIxYzM4NjMyMWI3YzI2ZGEzMDg3NjNiNWI0 OGMwYTcuLjA4ZTU0NDQ2ZGNhZGEzZTQ4M2E0NmQyZDViMjQ1OTliMTY2NjU3YmUgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC02NCw3ICs2NCw3IEBA IGZpbmRfcGFja2FnZShHcGVyZiAzLjAuMSBSRVFVSVJFRCkKICMgVE9ETyBFbmZvcmNlIHZlcnNp b24gcmVxdWlyZW1lbnQgZm9yIHBlcmwKIGZpbmRfcGFja2FnZShQZXJsIDUuMTAuMCBSRVFVSVJF RCkKIAotZmluZF9wYWNrYWdlKFB5dGhvbkludGVycCAyLjYuMCBSRVFVSVJFRCkKK2ZpbmRfcGFj a2FnZShQeXRob25JbnRlcnAgMi43LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoUnVieSAxLjgu NykKIAogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IGRiOTRkZWUwZjI0Mjg3N2JiODhiMWRjNGY1MzgwMWQ2ZTM5MzQzY2EuLjI5 N2YwYmQ1OTZmMTQ3OTE3OGI3MDQ1M2ZiM2Q0YjMxM2M0MDMyNTYgMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0wMS0yOCAgQ2FybG9z IEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01h a2VdIE1pbmltdW0gcHl0aG9uIHZlcnNpb24gc2hvdWxkIGJlIDIuNy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDk5NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIw MTUtMDEtMjYgIE5pa29zIEFuZHJvbmlrb3MgIDxuaWtvcy5hbmRyb25pa29zLXdlYmtpdEBjaXNy YS5jYW5vbi5jb20uYXU+CiAKICAgICAgICAgQXBwbHkgZmVUdXJidWxlbmNlIHNwZWMgY2hhbmdl IHRvIGZpeCB6ZXJvIGxlbmd0aCB2ZWN0b3IgZ2VuZXJhdGlvbgo=