<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>140996</bug_id>
          
          <creation_ts>2015-01-28 05:48:56 -0800</creation_ts>
          <short_desc>[GTK] Stop removing color marks from unit tests output</short_desc>
          <delta_ts>2015-01-28 06:48:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>pnormand</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1064874</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-01-28 05:48:56 -0800</bug_when>
    <thetext>Since r178236 google tests use a custom simplified output without any colors, so we don&apos;t need to handle the case of non ttys to remove the color marks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1064876</commentid>
    <comment_count>1</comment_count>
      <attachid>245535</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-01-28 05:50:20 -0800</bug_when>
    <thetext>Created attachment 245535
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1064882</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-01-28 06:48:35 -0800</bug_when>
    <thetext>Committed r179250: &lt;http://trac.webkit.org/changeset/179250&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>245535</attachid>
            <date>2015-01-28 05:50:20 -0800</date>
            <delta_ts>2015-01-28 06:31:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>tools-gtk-test-no-colors.diff</filename>
            <type>text/plain</type>
            <size>1873</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwZjdh
Nzc2Li45MTkzMzY5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTUtMDEtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9z
ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIFN0b3AgcmVtb3ZpbmcgY29s
b3IgbWFya3MgZnJvbSB1bml0IHRlc3RzIG91dHB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwOTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgcjE3ODIzNiBnb29nbGUgdGVzdHMgdXNlIGEg
Y3VzdG9tIHNpbXBsaWZpZWQgb3V0cHV0IHdpdGhvdXQKKyAgICAgICAgYW55IGNvbG9ycywgc28g
d2UgZG9uJ3QgbmVlZCB0byBoYW5kbGUgdGhlIGNhc2Ugb2Ygbm9uIHR0eXMgdG8KKyAgICAgICAg
cmVtb3ZlIHRoZSBjb2xvciBtYXJrcy4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0
czoKKyAgICAgICAgKFRlc3RSdW5uZXIuX19pbml0X18pOgorICAgICAgICAoVGVzdFJ1bm5lci5f
cnVuX3Rlc3RfY29tbWFuZC5wYXJzZV9saW5lKToKKworMjAxNS0wMS0yOCAgQ2FybG9zIEdhcmNp
YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gVW5pdCB0ZXN0
IC93ZWJraXQyL1dlYktpdFdlYlZpZXcvcGFnZS12aXNpYmlsaXR5IGZyb20gV2ViS2l0Mkd0ay9U
ZXN0V2ViS2l0V2ViVmlldyBmYWlscwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTMxNzMxCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0
ay10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwppbmRleCAyM2IwY2Y5Li44YTgy
NjkzIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMv
U2NyaXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC05MSw4ICs5MSw2IEBAIGNsYXNzIFRlc3RSdW5uZXI6
CiAgICAgICAgIHNlbGYuX3Rlc3RzID0gc2VsZi5fZ2V0X3Rlc3RzKHRlc3RzKQogICAgICAgICBz
ZWxmLl9za2lwcGVkX3Rlc3RzID0gVGVzdFJ1bm5lci5TS0lQUEVECiAgICAgICAgIHNlbGYuX2Rp
c2FibGVkX3Rlc3RzID0gW10KLSAgICAgICAgaWYgbm90IHN5cy5zdGRvdXQuaXNhdHR5KCk6Ci0g
ICAgICAgICAgICBzZWxmLl90dHlfY29sb3JzX3BhdHRlcm4gPSByZS5jb21waWxlKCJcMDMzXFtb
MC05O10qbSIpCiAKICAgICAgICAgIyBUaGVzZSBTUEkgZGFlbW9ucyBuZWVkIHRvIGJlIGFjdGl2
ZSBmb3IgdGhlIGFjY2Vzc2liaWxpdHkgdGVzdHMgdG8gd29yay4KICAgICAgICAgc2VsZi5fc3Bp
X3JlZ2lzdHJ5ZCA9IE5vbmUKQEAgLTI1OCwxMCArMjU2LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcjoK
ICAgICAgICAgICAgIGlmIGNoaWxkX3BpZFswXSA9PSAtMToKICAgICAgICAgICAgICAgICBjaGls
ZF9waWRbMF0gPSBzZWxmLl9nZXRfY2hpbGRfcGlkX2Zyb21fdGVzdF9vdXRwdXQobGluZSkKIAot
ICAgICAgICAgICAgaWYgc3lzLnN0ZG91dC5pc2F0dHkoKToKLSAgICAgICAgICAgICAgICBzeXMu
c3Rkb3V0LndyaXRlKGxpbmUpCi0gICAgICAgICAgICBlbHNlOgotICAgICAgICAgICAgICAgIHN5
cy5zdGRvdXQud3JpdGUoc2VsZi5fdHR5X2NvbG9yc19wYXR0ZXJuLnN1YignJywgbGluZS5yZXBs
YWNlKCdccicsICcnKSkpCisgICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKGxpbmUpCiAKICAg
ICAgICAgZGVmIHdhaXRwaWQocGlkKToKICAgICAgICAgICAgIHdoaWxlIFRydWU6Cg==
</data>
<flag name="review"
          id="270485"
          type_id="1"
          status="+"
          setter="pnormand"
    />
          </attachment>
      

    </bug>

</bugzilla>