140987 2015-01-27 23:43:59 -0800 Web Inspector: Allow text selection when the BasicBlockAnnotator is enabled 2015-01-29 23:24:56 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 saam saam graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1064817 0 saam 2015-01-27 23:43:59 -0800 Currently, we give up hope on the user selecting text when the BasicBlockAnnotator is activated, but this can be improved to allow the user to select text. 1064818 1 webkit-bug-importer 2015-01-27 23:44:17 -0800 <rdar://problem/19627420> 1064822 2 saam 2015-01-27 23:45:52 -0800 *** Bug 140988 has been marked as a duplicate of this bug. *** 1065414 3 245671 saam 2015-01-29 16:45:01 -0800 Created attachment 245671 patch This should do it once https://bugs.webkit.org/show_bug.cgi?id=141011 lands. Will submit w/ changelog after a few builds finish. 1065507 4 saam 2015-01-29 23:24:56 -0800 landed in: http://trac.webkit.org/changeset/179396 245671 2015-01-29 16:45:01 -0800 2015-01-29 16:54:01 -0800 patch patch.diff text/plain 3366 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNv ZGVUZXh0RWRpdG9yLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCShyZXZpc2lvbiAxNzkwNTQp CisrKyBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2Rl VGV4dEVkaXRvci5qcwkod29ya2luZyBjb3B5KQpAQCAtNDIsOCArNDIsNiBAQCBXZWJJbnNwZWN0 b3IuU291cmNlQ29kZVRleHRFZGl0b3IgPSBmdW5jCiAgICAgCiAgICAgdGhpcy5faXNQcm9iYWJs eU1pbmlmaWVkID0gZmFsc2U7CiAKLSAgICB0aGlzLl9oYXNGb2N1cyA9IGZhbHNlOwotCiAgICAg Ly8gRklYTUU6IEN1cnJlbnRseSB0aGlzIGp1c3QganVtcHMgYmV0d2VlbiByZXNvdXJjZXMgYW5k IHJlbGF0ZWQgc291cmNlIG1hcCByZXNvdXJjZXMuIEl0IGRvZXNuJ3QgImp1bXAgdG8gc3ltYm9s IiB5ZXQuCiAgICAgdGhpcy5fdXBkYXRlVG9rZW5UcmFja2luZ0NvbnRyb2xsZXJTdGF0ZSgpOwog CkBAIC0yNzksMjAgKzI3Nyw2IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvci5w cm90b3QKICAgICAgICAgfQogICAgIH0sCiAKLSAgICBnYWluZWRGb2N1czogZnVuY3Rpb24oKQot ICAgIHsKLSAgICAgICAgdGhpcy5faGFzRm9jdXMgPSB0cnVlOwotICAgICAgICBpZiAodGhpcy5f YmFzaWNCbG9ja0Fubm90YXRvcikKLSAgICAgICAgICAgIHRoaXMuX2Jhc2ljQmxvY2tBbm5vdGF0 b3IuY2xlYXIoKTsKLSAgICB9LAotCi0gICAgbG9zdEZvY3VzOiBmdW5jdGlvbigpCi0gICAgewot ICAgICAgICB0aGlzLl9oYXNGb2N1cyA9IGZhbHNlOwotICAgICAgICBpZiAodGhpcy5fYmFzaWNC bG9ja0Fubm90YXRvciAmJiBXZWJJbnNwZWN0b3Iuc2hvd0phdmFTY3JpcHRUeXBlSW5mb3JtYXRp b25TZXR0aW5nLnZhbHVlKQotICAgICAgICAgICAgdGhpcy5fYmFzaWNCbG9ja0Fubm90YXRvci5y ZXN1bWUoKTsKLSAgICB9LAotCiAgICAgdG9nZ2xlVHlwZUFubm90YXRpb25zOiBmdW5jdGlvbigp CiAgICAgewogICAgICAgICBpZiAoIXRoaXMuX3R5cGVUb2tlbkFubm90YXRvcikKQEAgLTE1OTUs NyArMTU3OSw3IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvci5wcm90b3QKICAg ICAgICAgICAgIFJ1bnRpbWVBZ2VudC5lbmFibGVUeXBlUHJvZmlsZXIoKTsKIAogICAgICAgICAg ICAgdGhpcy5fdHlwZVRva2VuQW5ub3RhdG9yLnJlc2V0KCk7Ci0gICAgICAgICAgICBpZiAodGhp cy5fYmFzaWNCbG9ja0Fubm90YXRvciAmJiAhdGhpcy5faGFzRm9jdXMpIHsKKyAgICAgICAgICAg IGlmICh0aGlzLl9iYXNpY0Jsb2NrQW5ub3RhdG9yKSB7CiAgICAgICAgICAgICAgICAgY29uc29s ZS5hc3NlcnQoIXRoaXMuX2Jhc2ljQmxvY2tBbm5vdGF0b3IuaXNBY3RpdmUoKSk7CiAgICAgICAg ICAgICAgICAgdGhpcy5fYmFzaWNCbG9ja0Fubm90YXRvci5yZXNldCgpOwogICAgICAgICAgICAg fQpAQCAtMTY5MCw3ICsxNjc0LDcgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9y LnByb3RvdAogICAgICAgICAgICAgICAgIHRpbWVvdXRJZGVudGlmaWVyID0gbnVsbDsKICAgICAg ICAgICAgICAgICBpZiAodGhpcy5fdHlwZVRva2VuQW5ub3RhdG9yKQogICAgICAgICAgICAgICAg ICAgICB0aGlzLl90eXBlVG9rZW5Bbm5vdGF0b3IucmVzdW1lKCk7Ci0gICAgICAgICAgICAgICAg aWYgKCF0aGlzLl9oYXNGb2N1cyAmJiB0aGlzLl9iYXNpY0Jsb2NrQW5ub3RhdG9yKQorICAgICAg ICAgICAgICAgIGlmICh0aGlzLl9iYXNpY0Jsb2NrQW5ub3RhdG9yKQogICAgICAgICAgICAgICAg ICAgICB0aGlzLl9iYXNpY0Jsb2NrQW5ub3RhdG9yLnJlc3VtZSgpOwogICAgICAgICAgICAgfS5i aW5kKHRoaXMpLCBXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3IuRHVyYXRpb25Ub1Vw ZGF0ZVR5cGVUb2tlbnNBZnRlclNjcm9sbGluZyk7CiAgICAgICAgIH0KSW5kZXg6IFNvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRv ci5qcwkocmV2aXNpb24gMTc5MDU0KQorKysgU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcwkod29ya2luZyBjb3B5KQpAQCAtNDUsOCArNDUsNiBA QCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvciA9IGZ1bmN0aW9uKGVsZW1lCiAgICAgdGhpcy5fY29k ZU1pcnJvci5vbigiY2hhbmdlIiwgdGhpcy5fY29udGVudENoYW5nZWQuYmluZCh0aGlzKSk7CiAg ICAgdGhpcy5fY29kZU1pcnJvci5vbigiZ3V0dGVyQ2xpY2siLCB0aGlzLl9ndXR0ZXJNb3VzZURv d24uYmluZCh0aGlzKSk7CiAgICAgdGhpcy5fY29kZU1pcnJvci5vbigiZ3V0dGVyQ29udGV4dE1l bnUiLCB0aGlzLl9ndXR0ZXJDb250ZXh0TWVudS5iaW5kKHRoaXMpKTsKLSAgICB0aGlzLl9jb2Rl TWlycm9yLm9uKCJmb2N1cyIsIHRoaXMuZ2FpbmVkRm9jdXMuYmluZCh0aGlzKSk7Ci0gICAgdGhp cy5fY29kZU1pcnJvci5vbigiYmx1ciIsIHRoaXMubG9zdEZvY3VzLmJpbmQodGhpcykpOwogICAg IHRoaXMuX2NvZGVNaXJyb3IuZ2V0U2Nyb2xsZXJFbGVtZW50KCkuYWRkRXZlbnRMaXN0ZW5lcigi Y2xpY2siLCB0aGlzLl9vcGVuQ2xpY2tlZExpbmtzLmJpbmQodGhpcyksIHRydWUpOwogCiAgICAg dGhpcy5fY29tcGxldGlvbkNvbnRyb2xsZXIgPSBuZXcgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JD b21wbGV0aW9uQ29udHJvbGxlcih0aGlzLl9jb2RlTWlycm9yLCB0aGlzKTsKQEAgLTgyNywxNiAr ODI1LDYgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlID0gewogICAgICAgICB0 aGlzLl9jb2RlTWlycm9yLm9wZXJhdGlvbihwcmV0dHlQcmludEFuZFVwZGF0ZUVkaXRvci5iaW5k KHRoaXMpKTsKICAgICB9LAogCi0gICAgZ2FpbmVkRm9jdXM6IGZ1bmN0aW9uKCkKLSAgICB7Ci0g ICAgICAgIC8vIEltcGxlbWVudGVkIGJ5IHN1YmNsYXNzZXMuCi0gICAgfSwKLQotICAgIGxvc3RG b2N1czogZnVuY3Rpb24oKQotICAgIHsKLSAgICAgICAgLy8gSW1wbGVtZW50ZWQgYnkgc3ViY2xh c3Nlcy4KLSAgICB9LAotCiAgICAgLy8gUHJpdmF0ZQogCiAgICAgaGFzRWRpdHM6IGZ1bmN0aW9u KCkK