140981 2015-01-27 20:03:45 -0800 Use an enum class for createFontFamilyValue()'s fromSystemFontID argument 2015-01-28 10:24:53 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue sam oldest_to_newest 1064782 0 cdumez 2015-01-27 20:03:45 -0800 Use an enum class for createFontFamilyValue()'s fromSystemFontID argument instead of a simple enum. 1064783 1 245511 cdumez 2015-01-27 20:07:18 -0800 Created attachment 245511 Patch 1064784 2 commit-queue 2015-01-27 20:09:49 -0800 Attachment 245511 did not pass style-queue: ERROR: Source/WebCore/css/CSSValuePool.cpp:132: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1064949 3 245511 commit-queue 2015-01-28 10:24:49 -0800 Comment on attachment 245511 Patch Clearing flags on attachment: 245511 Committed r179267: <http://trac.webkit.org/changeset/179267> 1064950 4 commit-queue 2015-01-28 10:24:53 -0800 All reviewed patches have been landed. Closing bug. 245511 2015-01-27 20:07:18 -0800 2015-01-28 10:24:49 -0800 Patch bug-140981-20150127200722.patch text/plain 5560 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFiZWNhNTUyZWFhNDNi YTQ3NzJhMmRlNmQxOWVjOGU3ZTFjN2E1OS4uNjI4YjZlZjU1OTFhMWRlZmVjNjNiOTE4OTc4ZmJj YzU2MzUyNWUzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTAxLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGFuIGVudW0gY2xhc3Mg Zm9yIGNyZWF0ZUZvbnRGYW1pbHlWYWx1ZSgpJ3MgZnJvbVN5c3RlbUZvbnRJRCBhcmd1bWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwOTgxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGFuIGVu dW0gY2xhc3MgZm9yIGNyZWF0ZUZvbnRGYW1pbHlWYWx1ZSgpJ3MgZnJvbVN5c3RlbUZvbnRJRCBh cmd1bWVudAorICAgICAgICBpbnN0ZWFkIG9mIGEgc2ltcGxlIGVudW0sIGFzIHN1Z2dlc3RlZCBi eSBTYW0uIFRoaXMgaXMgYSBiaXQgbmljZXIuCisKKyAgICAgICAgQWxzbywgdXNlIGEgYm9vbGVh biB0eXBlIGZvciBDU1NGb250RmFtaWx5LmZyb21TeXN0ZW1Gb250SUQgaW5zdGVhZCBvZgorICAg ICAgICB0aGUgZW51bSB0eXBlIHRvIGZhY2lsaXRhdGUgaGFuZGxpbmcuIFVzaW5nIGEgZW51bSAo Y2xhc3MpIGZvcgorICAgICAgICBDU1NGb250RmFtaWx5J3MgZnJvbVN5c3RlbUZvbnRJRCBtZW1i ZXIgaXMgbm90IHVzZWZ1bCBhcyBpdCBpcyBhbHdheXMKKyAgICAgICAgYWNjZXNzZWQgYnkgbmFt ZS4KKworICAgICAgICAqIGNzcy9DU1NGb250RmFtaWx5Lmg6CisgICAgICAgICogY3NzL0NTU1Bh cnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlU3lzdGVtRm9udCk6 CisgICAgICAgICogY3NzL0NTU1ZhbHVlUG9vbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NW YWx1ZVBvb2w6OmNyZWF0ZUZvbnRGYW1pbHlWYWx1ZSk6CisgICAgICAgICogY3NzL0NTU1ZhbHVl UG9vbC5oOgorCiAyMDE1LTAxLTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIE1vcmUgYnVpbGQgZml4ZXMgZm9yIG5ld2VyIGNsYW5nLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYW1pbHkuaCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NGb250RmFtaWx5LmgKaW5kZXggODVmMDIwNGJhZDIwMGQzNjU5MjZiYzJlNTA3MjIzNjVj YWMwNmNiMC4uZTFmMzJkYTlhZDczNzE1Y2VhMmFkMzYxYTk4NGE1MmE5ZjE5MjQzNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYW1pbHkuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTRm9udEZhbWlseS5oCkBAIC0zOSwxMSArMzksOSBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAvLyBGb250RGVzY3JpcHRpb24uIFRoaXMgZmxhZyBpcyB1c2VkIHRvIGRldGVybWlu ZSBpZiB3ZSBzaG91bGQgZG8gdGhlICJ1c2UgYmFja3NsYXNoIGFzIFllbgogLy8gc2lnbiIgaGFj ay4KIAotZW51bSBGcm9tU3lzdGVtRm9udElET3JOb3QgeyBOb3RGcm9tU3lzdGVtRm9udElELCBG cm9tU3lzdGVtRm9udElEIH07Ci0KIHN0cnVjdCBDU1NGb250RmFtaWx5IHsKICAgICBTdHJpbmcg ZmFtaWx5TmFtZTsKLSAgICBGcm9tU3lzdGVtRm9udElET3JOb3QgZnJvbVN5c3RlbUZvbnRJRDsK KyAgICBib29sIGZyb21TeXN0ZW1Gb250SUQ7CiB9OwogCiBpbmxpbmUgYm9vbCBvcGVyYXRvcj09 KGNvbnN0IENTU0ZvbnRGYW1pbHkmIGEsIGNvbnN0IENTU0ZvbnRGYW1pbHkmIGIpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQYXJzZXIuY3BwCmluZGV4IDlmNjcxNTFjMTUzOTI4ZGJiNzFlNDhiODNkYTI2MTIyYzBj YTVlZDIuLmI3ZTIzNmEyNmMxN2YwNDBiMjUyY2I0NmI1MzdiMGZjZWJmNjdkZTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC02MzIwLDcgKzYzMjAsNyBAQCB2b2lkIENTU1BhcnNlcjo6 cGFyc2VTeXN0ZW1Gb250KGJvb2wgaW1wb3J0YW50KQogICAgIGFkZFByb3BlcnR5KENTU1Byb3Bl cnR5Rm9udFdlaWdodCwgY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUoZm9udERlc2NyaXB0aW9u LndlaWdodCgpKSwgaW1wb3J0YW50KTsKICAgICBhZGRQcm9wZXJ0eShDU1NQcm9wZXJ0eUZvbnRT aXplLCBjc3NWYWx1ZVBvb2woKS5jcmVhdGVWYWx1ZShmb250RGVzY3JpcHRpb24uc3BlY2lmaWVk U2l6ZSgpLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYKSwgaW1wb3J0YW50KTsKICAgICBSZWY8 Q1NTVmFsdWVMaXN0PiBmb250RmFtaWx5TGlzdCA9IENTU1ZhbHVlTGlzdDo6Y3JlYXRlQ29tbWFT ZXBhcmF0ZWQoKTsKLSAgICBmb250RmFtaWx5TGlzdC0+YXBwZW5kKGNzc1ZhbHVlUG9vbCgpLmNy ZWF0ZUZvbnRGYW1pbHlWYWx1ZShmb250RGVzY3JpcHRpb24uZmFtaWx5QXQoMCksIEZyb21TeXN0 ZW1Gb250SUQpKTsKKyAgICBmb250RmFtaWx5TGlzdC0+YXBwZW5kKGNzc1ZhbHVlUG9vbCgpLmNy ZWF0ZUZvbnRGYW1pbHlWYWx1ZShmb250RGVzY3JpcHRpb24uZmFtaWx5QXQoMCksIEZyb21TeXN0 ZW1Gb250SUQ6OlllcykpOwogICAgIGFkZFByb3BlcnR5KENTU1Byb3BlcnR5Rm9udEZhbWlseSwg V1RGOjptb3ZlKGZvbnRGYW1pbHlMaXN0KSwgaW1wb3J0YW50KTsKICAgICBhZGRQcm9wZXJ0eShD U1NQcm9wZXJ0eUZvbnRWYXJpYW50LCBjc3NWYWx1ZVBvb2woKS5jcmVhdGVJZGVudGlmaWVyVmFs dWUoQ1NTVmFsdWVOb3JtYWwpLCBpbXBvcnRhbnQpOwogICAgIGFkZFByb3BlcnR5KENTU1Byb3Bl cnR5TGluZUhlaWdodCwgY3NzVmFsdWVQb29sKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1Zh bHVlTm9ybWFsKSwgaW1wb3J0YW50KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NWYWx1ZVBvb2wuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlUG9vbC5jcHAKaW5k ZXggNWM5NGIyNzJiNTM2NzYyMmNkOTI0OTc4ODAzYjlmZWM5YTdlMjRiMS4uMWY0MTMxMTVhMzZk MGY0OTQzY2I1MzdhOTk0Njg5ZGRjODZmZDlkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1ZhbHVlUG9vbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlUG9v bC5jcHAKQEAgLTExOSwxNiArMTE5LDE3IEBAIFJlZjxDU1NQcmltaXRpdmVWYWx1ZT4gQ1NTVmFs dWVQb29sOjpjcmVhdGVWYWx1ZShkb3VibGUgdmFsdWUsIENTU1ByaW1pdGl2ZVZhbHVlCiAgICAg cmV0dXJuICpjYWNoZVtpbnRWYWx1ZV07CiB9CiAKLVJlZjxDU1NQcmltaXRpdmVWYWx1ZT4gQ1NT VmFsdWVQb29sOjpjcmVhdGVGb250RmFtaWx5VmFsdWUoY29uc3QgU3RyaW5nJiBmYW1pbHlOYW1l LCBGcm9tU3lzdGVtRm9udElET3JOb3QgZnJvbVN5c3RlbUZvbnRJRCkKK1JlZjxDU1NQcmltaXRp dmVWYWx1ZT4gQ1NTVmFsdWVQb29sOjpjcmVhdGVGb250RmFtaWx5VmFsdWUoY29uc3QgU3RyaW5n JiBmYW1pbHlOYW1lLCBGcm9tU3lzdGVtRm9udElEIGZyb21TeXN0ZW1Gb250SUQpCiB7CiAgICAg Ly8gUmVtb3ZlIG9uZSBlbnRyeSBhdCByYW5kb20gaWYgdGhlIGNhY2hlIGdyb3dzIHRvbyBsYXJn ZS4KICAgICBjb25zdCBpbnQgbWF4aW11bUZvbnRGYW1pbHlDYWNoZVNpemUgPSAxMjg7CiAgICAg aWYgKG1fZm9udEZhbWlseVZhbHVlQ2FjaGUuc2l6ZSgpID49IG1heGltdW1Gb250RmFtaWx5Q2Fj aGVTaXplKQogICAgICAgICBtX2ZvbnRGYW1pbHlWYWx1ZUNhY2hlLnJlbW92ZShtX2ZvbnRGYW1p bHlWYWx1ZUNhY2hlLmJlZ2luKCkpOwogCi0gICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiYg dmFsdWUgPSBtX2ZvbnRGYW1pbHlWYWx1ZUNhY2hlLmFkZCh7ZmFtaWx5TmFtZSwgZnJvbVN5c3Rl bUZvbnRJRH0sIG51bGxwdHIpLml0ZXJhdG9yLT52YWx1ZTsKKyAgICBib29sIGlzRnJvbVN5c3Rl bUlEID0gZnJvbVN5c3RlbUZvbnRJRCA9PSBGcm9tU3lzdGVtRm9udElEOjpZZXM7CisgICAgUmVm UHRyPENTU1ByaW1pdGl2ZVZhbHVlPiYgdmFsdWUgPSBtX2ZvbnRGYW1pbHlWYWx1ZUNhY2hlLmFk ZCh7ZmFtaWx5TmFtZSwgaXNGcm9tU3lzdGVtSUR9LCBudWxscHRyKS5pdGVyYXRvci0+dmFsdWU7 CiAgICAgaWYgKCF2YWx1ZSkKLSAgICAgICAgdmFsdWUgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Y3Jl YXRlKENTU0ZvbnRGYW1pbHl7ZmFtaWx5TmFtZSwgZnJvbVN5c3RlbUZvbnRJRH0pOworICAgICAg ICB2YWx1ZSA9IENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUoQ1NTRm9udEZhbWlseXtmYW1pbHlO YW1lLCBpc0Zyb21TeXN0ZW1JRH0pOwogICAgIHJldHVybiAqdmFsdWU7CiB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZVBvb2wuaCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NWYWx1ZVBvb2wuaAppbmRleCBhYWM3MzZjZWM0OTEzMDkxNzcwNDZkMzgyZDM1M2MxZGEw MjQzMjAyLi40ZWMxODU2NzUyNzBmZGRkMTFmYjRiNmIxM2UzYTc4NDhmZGJkZjIyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVQb29sLmgKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU1ZhbHVlUG9vbC5oCkBAIC00MiwxMSArNDIsMTMgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogCiBjbGFzcyBDU1NWYWx1ZUxpc3Q7CiAKK2VudW0gY2xhc3MgRnJvbVN5c3RlbUZvbnRJ RCB7IE5vLCBZZXMgfTsKKwogY2xhc3MgQ1NTVmFsdWVQb29sIHsKICAgICBXVEZfTUFLRV9GQVNU X0FMTE9DQVRFRDsKIHB1YmxpYzoKICAgICBQYXNzUmVmUHRyPENTU1ZhbHVlTGlzdD4gY3JlYXRl Rm9udEZhY2VWYWx1ZShjb25zdCBBdG9taWNTdHJpbmcmKTsKLSAgICBSZWY8Q1NTUHJpbWl0aXZl VmFsdWU+IGNyZWF0ZUZvbnRGYW1pbHlWYWx1ZShjb25zdCBTdHJpbmcmLCBGcm9tU3lzdGVtRm9u dElET3JOb3QgPSBOb3RGcm9tU3lzdGVtRm9udElEKTsKKyAgICBSZWY8Q1NTUHJpbWl0aXZlVmFs dWU+IGNyZWF0ZUZvbnRGYW1pbHlWYWx1ZShjb25zdCBTdHJpbmcmLCBGcm9tU3lzdGVtRm9udElE ID0gRnJvbVN5c3RlbUZvbnRJRDo6Tm8pOwogICAgIFJlZjxDU1NJbmhlcml0ZWRWYWx1ZT4gY3Jl YXRlSW5oZXJpdGVkVmFsdWUoKSB7IHJldHVybiBtX2luaGVyaXRlZFZhbHVlLmNvcHlSZWYoKTsg fQogICAgIFJlZjxDU1NJbml0aWFsVmFsdWU+IGNyZWF0ZUltcGxpY2l0SW5pdGlhbFZhbHVlKCkg eyByZXR1cm4gbV9pbXBsaWNpdEluaXRpYWxWYWx1ZS5jb3B5UmVmKCk7IH0KICAgICBSZWY8Q1NT SW5pdGlhbFZhbHVlPiBjcmVhdGVFeHBsaWNpdEluaXRpYWxWYWx1ZSgpIHsgcmV0dXJuIG1fZXhw bGljaXRJbml0aWFsVmFsdWUuY29weVJlZigpOyB9Cg==