140976 2015-01-27 18:55:42 -0800 http/tests/xmlhttprequest/workers/methods.html sometimes times out with disk cache enabled 2015-01-28 18:53:08 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned kling oldest_to_newest 1064766 0 koivisto 2015-01-27 18:55:42 -0800 run-webkit-tests --release -2 http/tests/xmlhttprequest/workers/methods.html --iterations=100 1064772 1 245505 koivisto 2015-01-27 19:20:43 -0800 Created attachment 245505 patch 1064774 2 245505 cdumez 2015-01-27 19:31:03 -0800 Comment on attachment 245505 patch From the doc: "An invocation of a handler block with the done flag set, zero error and data set to dispatch_data_empty indicates that the I/O operation has encountered EOF." r=me. 1065071 3 245579 koivisto 2015-01-28 16:39:13 -0800 Created attachment 245579 better patch 1065083 4 245579 cdumez 2015-01-28 16:55:37 -0800 Comment on attachment 245579 better patch View in context: https://bugs.webkit.org/attachment.cgi?id=245579&action=review r=me with nit. > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:381 > + didCallCompletionHandler = true; Could you please add a ASSERT(!didCallCompletionHandler) before this? I am not 100% convinced this will be called only once with done==Yes, even after reading the doc. 1065125 5 koivisto 2015-01-28 18:53:08 -0800 Better fix: https://trac.webkit.org/r179327 245505 2015-01-27 19:20:43 -0800 2015-01-28 16:56:02 -0800 patch cache-empty-file-hang.patch text/plain 2136 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTIzNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE1LTAxLTI3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L3dvcmtlcnMvbWV0aG9kcy5odG1sIHNvbWV0aW1lcyB0aW1lcyBvdXQgd2l0aCBkaXNr IGNhY2hlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MDk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJ1bm5pbmcKKworICAgICAgICAgICAgcnVuLXdlYmtpdC10ZXN0cyAtLXJlbGVhc2Ug LTIgaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC93b3JrZXJzL21ldGhvZHMuaHRtbCAtLWl0ZXJh dGlvbnM9MTAwCisKKyAgICAgICAgd291bGQgdXN1YWxseSB0aW1lIG91dCBhbiBpdGVyYXRpb24u CisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlQ29j b2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZVN0b3JhZ2U6OmRpc3BhdGNoUmV0 cmlldmVPcGVyYXRpb24pOgorCisgICAgICAgIFVzaW5nIGRpc3BhdGNoX2lvX3JlYWQgd2l0aCBh biBlbXB0eSBmaWxlIGNhbGxzIHRoZSBoYW5kbGVyIGJsb2NrIGltbWVkaWF0ZWx5IHdpdGggZG9u ZSBib29sZWFuIHNldAorICAgICAgICB3aXRob3V0IGl0IGJlaW5nIGFuIGVycm9yLiBXZSBmYWls ZWQgdG8gY2FsbCB0aGUgY29tcGxldGlvbiBoYW5kbGVyIGFuZCBhbnkgc3luY2hyb25vdXMgeGhy IHdvdWxkIGhhbmcuCisgICAgICAgIFdlIG1heSBzZWUgYW4gZW1wdHkgY2FjaGUgZmlsZSBpZiB3 ZSBhcmUganVzdCBpbiBwcm9jZXNzIG9mIHdyaXRpbmcgaXQuCisKKyAgICAgICAgRml4IGJ5IGhh bmRsaW5nIHRoaXMgY2FzZSBzcGVjaWZpY2FsbHkuCisKIDIwMTUtMDEtMjcgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgTW9yZSBidWlsZCBmaXhlcyBmb3Ig bmV3ZXIgY2xhbmcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9O ZXR3b3JrQ2FjaGVTdG9yYWdlQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZUNvY29hLm1tCShyZXZpc2lv biAxNzkwNTIpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3Jr Q2FjaGVTdG9yYWdlQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTM3Myw4ICszNzMsMTIgQEAg dm9pZCBOZXR3b3JrQ2FjaGVTdG9yYWdlOjpkaXNwYXRjaFJldHJpZQogICAgICAgICAgICAgICAg IHJlbW92ZUVudHJ5KHJldHJpZXZlLmtleSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICAgICAgfQotICAgICAgICAgICAgaWYgKGRvbmUpCisgICAgICAgICAgICBpZiAoZG9uZSkg eworICAgICAgICAgICAgICAgIC8vIEZpbGUgZXhpc3RzIGJ1dCBpcyBlbXB0eS4gSW52b2tlIHRo ZSBjb21wbGV0aW9uIGhhbmRsZXIgYXMgaXQgaGFzbid0IGJlZW4gZG9uZSB5ZXQuCisgICAgICAg ICAgICAgICAgaWYgKGZpbGVEYXRhID09IGRpc3BhdGNoX2RhdGFfZW1wdHkpCisgICAgICAgICAg ICAgICAgICAgIHJldHJpZXZlLmNvbXBsZXRpb25IYW5kbGVyKG51bGxwdHIpOwogICAgICAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGF1dG8gZW50cnkgPSBk ZWNvZGVFbnRyeShmaWxlRGF0YSwgZmQsIHJldHJpZXZlLmtleSk7CiAgICAgICAgICAgICBib29s IHN1Y2Nlc3MgPSByZXRyaWV2ZS5jb21wbGV0aW9uSGFuZGxlcihXVEY6Om1vdmUoZW50cnkpKTsK ICAgICAgICAgICAgIGlmICghc3VjY2VzcykK 245579 2015-01-28 16:39:13 -0800 2015-01-28 16:55:37 -0800 better patch cache-empty-file-hang-fixup.patch text/plain 2917 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTMxMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAxLTI4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L3dvcmtlcnMvbWV0aG9kcy5odG1sIHNvbWV0aW1lcyB0aW1lcyBvdXQgd2l0aCBkaXNr IGNhY2hlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MDk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBwcmV2aW91cyBmaXggc29tZXRpbWVzIGludm9rZWQgdGhlIGNvbXBsZXRpb24g aGFuZGxlciB0d2ljZS4gRXhwbGljaXRseSB0cmFjayBpZiB3ZQorICAgICAgICBoYXZlIGNhbGxl ZCBpdCBvciBub3QuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2Fj aGVTdG9yYWdlQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZVN0b3JhZ2U6 OmRpc3BhdGNoUmV0cmlldmVPcGVyYXRpb24pOgorCisgICAgICAgIEFsc28gbW92ZSBlcnJvciBj YXNlIHRvIHRoZSBkb25lIGJyYW5jaC4gQWNjb3JkaW5nIHRvIHRoZSBkb2N1bWVudGF0aW9uICdk b25lJyBpcyBhbHdheXMgc2V0IG9uIGVycm9yLgorCiAyMDE1LTAxLTI4ICBCZXRoIERha2luICA8 YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgTW91bnRhaW4gTGlvbiBjb2RlIGZy b20gV2ViS2l0IGFuZCBXZWJLaXQyCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZUNvY29hLm1t CShyZXZpc2lvbiAxNzkyNTQpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNo ZS9OZXR3b3JrQ2FjaGVTdG9yYWdlQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTM2MiwyNSAr MzYyLDIzIEBAIHZvaWQgTmV0d29ya0NhY2hlU3RvcmFnZTo6ZGlzcGF0Y2hSZXRyaWUKICAgICAg ICAgaW50IGZkOwogICAgICAgICBhdXRvIGNoYW5uZWwgPSBjcmVhdGVJT0NoYW5uZWxGb3JLZXko cmV0cmlldmUua2V5LCBJT0NoYW5uZWxUeXBlOjpSZWFkLCBjYWNoZVBhdGhDYXB0dXJlLnN0cmlu ZygpLCBmZCk7CiAKLSAgICAgICAgZGlzcGF0Y2hfaW9fcmVhZChjaGFubmVsLmdldCgpLCAwLCBz dGQ6Om51bWVyaWNfbGltaXRzPHNpemVfdD46Om1heCgpLCBkaXNwYXRjaF9nZXRfbWFpbl9xdWV1 ZSgpLCBbdGhpcywgZmQsIHJldHJpZXZlXShib29sIGRvbmUsIGRpc3BhdGNoX2RhdGFfdCBmaWxl RGF0YSwgaW50IGVycm9yKSB7CisgICAgICAgIGJvb2wgZGlkQ2FsbENvbXBsZXRpb25IYW5kbGVy ID0gZmFsc2U7CisgICAgICAgIGRpc3BhdGNoX2lvX3JlYWQoY2hhbm5lbC5nZXQoKSwgMCwgc3Rk OjpudW1lcmljX2xpbWl0czxzaXplX3Q+OjptYXgoKSwgZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUo KSwgW3RoaXMsIGZkLCByZXRyaWV2ZSwgZGlkQ2FsbENvbXBsZXRpb25IYW5kbGVyXShib29sIGRv bmUsIGRpc3BhdGNoX2RhdGFfdCBmaWxlRGF0YSwgaW50IGVycm9yKSBtdXRhYmxlIHsKICAgICAg ICAgICAgIGlmIChkb25lKSB7CiAgICAgICAgICAgICAgICAgQVNTRVJUKG1fYWN0aXZlUmV0cmll dmVPcGVyYXRpb25Db3VudCk7CiAgICAgICAgICAgICAgICAgLS1tX2FjdGl2ZVJldHJpZXZlT3Bl cmF0aW9uQ291bnQ7CiAgICAgICAgICAgICAgICAgZGlzcGF0Y2hQZW5kaW5nUmV0cmlldmVPcGVy YXRpb25zKCk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAoZXJyb3IpIHsKLSAgICAg ICAgICAgICAgICByZXRyaWV2ZS5jb21wbGV0aW9uSGFuZGxlcihudWxscHRyKTsKLSAgICAgICAg ICAgICAgICByZW1vdmVFbnRyeShyZXRyaWV2ZS5rZXkpOwotICAgICAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmIChkb25lKSB7Ci0gICAgICAgICAgICAg ICAgLy8gRmlsZSBleGlzdHMgYnV0IGlzIGVtcHR5LiBJbnZva2UgdGhlIGNvbXBsZXRpb24gaGFu ZGxlciBhcyBpdCBoYXNuJ3QgYmVlbiBkb25lIHlldC4KLSAgICAgICAgICAgICAgICBpZiAoZmls ZURhdGEgPT0gZGlzcGF0Y2hfZGF0YV9lbXB0eSkKKyAgICAgICAgICAgICAgICBpZiAoIWRpZENh bGxDb21wbGV0aW9uSGFuZGxlcikKICAgICAgICAgICAgICAgICAgICAgcmV0cmlldmUuY29tcGxl dGlvbkhhbmRsZXIobnVsbHB0cik7CisgICAgICAgICAgICAgICAgaWYgKGVycm9yKQorICAgICAg ICAgICAgICAgICAgICByZW1vdmVFbnRyeShyZXRyaWV2ZS5rZXkpOwogICAgICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGF1dG8gZW50cnkgPSBkZWNvZGVF bnRyeShmaWxlRGF0YSwgZmQsIHJldHJpZXZlLmtleSk7CiAgICAgICAgICAgICBib29sIHN1Y2Nl c3MgPSByZXRyaWV2ZS5jb21wbGV0aW9uSGFuZGxlcihXVEY6Om1vdmUoZW50cnkpKTsKKyAgICAg ICAgICAgIGRpZENhbGxDb21wbGV0aW9uSGFuZGxlciA9IHRydWU7CiAgICAgICAgICAgICBpZiAo IXN1Y2Nlc3MpCiAgICAgICAgICAgICAgICAgcmVtb3ZlRW50cnkocmV0cmlldmUua2V5KTsKICAg ICAgICAgfSk7Cg==