140966 2015-01-27 15:27:57 -0800 Some NSAccessibility methods we use are deprecated on 10.10 2015-01-27 18:31:14 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario mitz samuel_white webkit-bug-importer oldest_to_newest 1064699 0 ap 2015-01-27 15:27:57 -0800 There are build failures in AccessibilityObjectMac.mm. Since we invoke these methods on untyped (id) pointers, it's somewhat random whether the compiler notices that. rdar://problem/19621388 1064704 1 245485 ap 2015-01-27 15:34:34 -0800 Created attachment 245485 proposed patch 1064716 2 ap 2015-01-27 16:13:54 -0800 Committed <http://trac.webkit.org/r179228>. 1064757 3 ap 2015-01-27 18:31:14 -0800 Added similar pragmas to a few more places as part of <http://trac.webkit.org/r179236>. 245485 2015-01-27 15:34:34 -0800 2015-01-27 15:48:53 -0800 proposed patch AccessibilityWarnings.txt text/plain 4130 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTIyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAxLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFNvbWUgTlNBY2Nlc3NpYmls aXR5IG1ldGhvZHMgd2UgdXNlIGFyZSBkZXByZWNhdGVkIG9uIDEwLjEwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA5NjYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL0Fj Y2Vzc2liaWxpdHlPYmplY3RNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5 T2JqZWN0OjpvdmVycmlkZUF0dGFjaG1lbnRQYXJlbnQpOgorICAgICAgICAoV2ViQ29yZTo6QWNj ZXNzaWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGl0eUlnbm9yZUF0dGFjaG1lbnQpOgorICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1t OgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciByb2xlXSk6CisgICAg ICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIHJvbGVEZXNjcmlwdGlvbl0pOgor ICAgICAgICBTaWxlbmNlIHRoZSB3YXJuaW5ncyBmb3Igbm93LgorCiAyMDE1LTAxLTI3ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IGh0 dHAvdGVzdHMvbWVkaWEvdmlkZW8tcGxheS1zdGFsbC5odG1sCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0TWFjLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RN YWMubW0JKHJldmlzaW9uIDE3OTIxOSkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv bWFjL0FjY2Vzc2liaWxpdHlPYmplY3RNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTUzLDggKzUz LDExIEBAIHZvaWQgQWNjZXNzaWJpbGl0eU9iamVjdDo6b3ZlcnJpZGVBdHRhY2gKICAgICAgICAg ICAgIHBhcmVudCA9IHBhcmVudC0+cGFyZW50T2JqZWN0VW5pZ25vcmVkKCk7CiAgICAgICAgIHBh cmVudFdyYXBwZXIgPSBwYXJlbnQtPndyYXBwZXIoKTsKICAgICB9Ci0gICAgCisKKyNwcmFnbWEg Y2xhbmcgZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgaWdub3JlZCAi LVdkZXByZWNhdGVkLWRlY2xhcmF0aW9ucyIKICAgICBbW3dyYXBwZXIoKSBhdHRhY2htZW50Vmll d10gYWNjZXNzaWJpbGl0eVNldE92ZXJyaWRlVmFsdWU6cGFyZW50V3JhcHBlciBmb3JBdHRyaWJ1 dGU6TlNBY2Nlc3NpYmlsaXR5UGFyZW50QXR0cmlidXRlXTsKKyNwcmFnbWEgY2xhbmcgZGlhZ25v c3RpYyBwb3AKIH0KICAgICAKIGJvb2wgQWNjZXNzaWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGl0 eUlnbm9yZUF0dGFjaG1lbnQoKSBjb25zdApAQCAtNjUsOSArNjgsMTIgQEAgYm9vbCBBY2Nlc3Np YmlsaXR5T2JqZWN0OjphY2Nlc3NpYmlsaXR5SQogICAgIGlmIChpc0F0dGFjaG1lbnQoKSAmJiAo d2lkZ2V0ID0gd2lkZ2V0Rm9yQXR0YWNobWVudFZpZXcoKSkgJiYgd2lkZ2V0LT5pc0ZyYW1lVmll dygpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1 c2gKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV2RlcHJlY2F0ZWQtZGVjbGFy YXRpb25zIgogICAgIGlmIChbd3JhcHBlcigpIGF0dGFjaG1lbnRWaWV3XSkKICAgICAgICAgcmV0 dXJuIFtbd3JhcHBlcigpIGF0dGFjaG1lbnRWaWV3XSBhY2Nlc3NpYmlsaXR5SXNJZ25vcmVkXTsK LSAgICAKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKwogICAgIC8vIEF0dGFjaG1lbnRz IGFyZSBpZ25vcmVkIGJ5IGRlZmF1bHQgKHVubGVzcyB3ZSBkZXRlcm1pbmUgdGhhdCB3ZSBzaG91 bGQgZXhwb3NlIHRoZW0pLgogICAgIHJldHVybiB0cnVlOwogfQpJbmRleDogU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0JKHJldmlzaW9uIDE3OTIxOSkKKysrIFNvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFj Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xOTY5LDggKzE5NjksMTEgQEAgc3RhdGljIE5TU3RyaW5n KiByb2xlVmFsdWVUb05TU3RyaW5nKEFjYwogCiAtIChOU1N0cmluZyopcm9sZQogeworI3ByYWdt YSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVk ICItV2RlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIgogICAgIGlmIChtX29iamVjdC0+aXNBdHRhY2ht ZW50KCkpCiAgICAgICAgIHJldHVybiBbW3NlbGYgYXR0YWNobWVudFZpZXddIGFjY2Vzc2liaWxp dHlBdHRyaWJ1dGVWYWx1ZTpOU0FjY2Vzc2liaWxpdHlSb2xlQXR0cmlidXRlXTsKKyNwcmFnbWEg Y2xhbmcgZGlhZ25vc3RpYyBwb3AKICAgICBBY2Nlc3NpYmlsaXR5Um9sZSByb2xlID0gbV9vYmpl Y3QtPnJvbGVWYWx1ZSgpOwogICAgIGlmIChyb2xlID09IENhbnZhc1JvbGUgJiYgbV9vYmplY3Qt PmNhbnZhc0hhc0ZhbGxiYWNrQ29udGVudCgpKQogICAgICAgICByb2xlID0gR3JvdXBSb2xlOwpA QCAtMjEzNSwxMSArMjEzOCwxNCBAQCAtIChOU1N0cmluZyopcm9sZURlc2NyaXB0aW9uCiB7CiAg ICAgaWYgKCFtX29iamVjdCkKICAgICAgICAgcmV0dXJuIG5pbDsKLSAgICAKKworI3ByYWdtYSBj bGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICIt V2RlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIgogICAgIC8vIGF0dGFjaG1lbnRzIGhhdmUgdGhlIEFY SW1hZ2Ugcm9sZSwgYnV0IGEgZGlmZmVyZW50IHN1YnJvbGUKICAgICBpZiAobV9vYmplY3QtPmlz QXR0YWNobWVudCgpKQogICAgICAgICByZXR1cm4gW1tzZWxmIGF0dGFjaG1lbnRWaWV3XSBhY2Nl c3NpYmlsaXR5QXR0cmlidXRlVmFsdWU6TlNBY2Nlc3NpYmlsaXR5Um9sZURlc2NyaXB0aW9uQXR0 cmlidXRlXTsKLSAgICAKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKwogICAgIE5TU3Ry aW5nKiBheFJvbGUgPSBbc2VsZiByb2xlXTsKICAgICAKICAgICBpZiAoW2F4Um9sZSBpc0VxdWFs VG9TdHJpbmc6TlNBY2Nlc3NpYmlsaXR5R3JvdXBSb2xlXSkgewpAQCAtMzE1MCw2ICszMTU2LDkg QEAgLSAoTlNBcnJheSogKWFjY2Vzc2liaWxpdHlQYXJhbWV0ZXJpemVkQQogICAgIHJldHVybiBw YXJhbUF0dHJzOwogfQogCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBj bGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMiCisKIC0g KHZvaWQpYWNjZXNzaWJpbGl0eVBlcmZvcm1QcmVzc0FjdGlvbgogewogICAgIGlmICghW3NlbGYg dXBkYXRlT2JqZWN0QmFja2luZ1N0b3JlXSkKQEAgLTMxODMsNiArMzE5Miw4IEBAIC0gKHZvaWQp YWNjZXNzaWJpbGl0eVBlcmZvcm1EZWNyZW1lbnRBY3QKICAgICAgICAgbV9vYmplY3QtPmRlY3Jl bWVudCgpOwogfQogCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCisKIC0gKHZvaWQpYWNj ZXNzaWJpbGl0eVBlcmZvcm1TaG93TWVudUFjdGlvbgogewogICAgIGlmIChtX29iamVjdC0+cm9s ZVZhbHVlKCkgPT0gQ29tYm9Cb3hSb2xlKQo=