140965 2015-01-27 15:24:30 -0800 Remove unnecessary m_cachedPage null-checks in PageCache 2015-01-27 16:48:24 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue kling koivisto oldest_to_newest 1064694 0 cdumez 2015-01-27 15:24:30 -0800 Remove unnecessary m_cachedPage null-checks in PageCache. 1064698 1 245481 cdumez 2015-01-27 15:27:38 -0800 Created attachment 245481 Patch 1064715 2 245481 kling 2015-01-27 16:04:23 -0800 Comment on attachment 245481 Patch r=me 1064726 3 245481 commit-queue 2015-01-27 16:48:20 -0800 Comment on attachment 245481 Patch Clearing flags on attachment: 245481 Committed r179229: <http://trac.webkit.org/changeset/179229> 1064727 4 commit-queue 2015-01-27 16:48:24 -0800 All reviewed patches have been landed. Closing bug. 245481 2015-01-27 15:27:38 -0800 2015-01-27 16:48:20 -0800 Patch bug-140965-20150127152742.patch text/plain 3992 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQxNWNhYTAwNzU5YTIy ZDNjYmM5ZjMyOTk2ODA3YWNhZmMwOTgxOC4uZTEyNGU0ZTFhZTVkMjg2YjY4Y2EzYTMwOTRiYzhh YWU3ODhkZTc1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAxLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5 IG1fY2FjaGVkUGFnZSBudWxsLWNoZWNrcyBpbiBQYWdlQ2FjaGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDk2NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBtX2NhY2hl ZFBhZ2UgbnVsbC1jaGVja3MgaW4gUGFnZUNhY2hlLiBXZSBpbml0aWFsaXplCisgICAgICAgIG1f Y2FjaGVkUGFnZSB3aGVuIGluc2VydGluZyB0aGUgSGlzdG9yeUl0ZW0gaW4gdGhlIHBhZ2UgY2Fj aGUgYW5kIGNsZWFyCisgICAgICAgIGl0IHdoZW4gcmVtb3ZpbmcgaXQgZnJvbSB0aGUgcGFnZSBj YWNoZS4gVGhlcmVmb3JlLCBpdCBpcyBndWFyYW50ZWVkCisgICAgICAgIHRoYXQgSGlzdG9yeUl0 ZW1zIGN1cnJlbnRseSBpbiB0aGUgcGFnZSBjYWNoZSBoYXZlIG1fY2FjaGVkUGFnZQorICAgICAg ICBpbml0aWFsaXplZCBhbmQgdGhlcmUgaXMgbm8gbmVlZCB0byBudWxsLWNoZWNrIGl0LgorCisg ICAgICAgICogaGlzdG9yeS9QYWdlQ2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZUNh Y2hlOjpmcmFtZUNvdW50KToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VDYWNoZTo6bWFya1BhZ2Vz Rm9yVmlzdGVkTGlua1N0eWxlUmVjYWxjKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VDYWNoZTo6 bWFya1BhZ2VzRm9yRnVsbFN0eWxlUmVjYWxjKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VDYWNo ZTo6bWFya1BhZ2VzRm9yRGV2aWNlU2NhbGVDaGFuZ2VkKToKKyAgICAgICAgKFdlYkNvcmU6OlBh Z2VDYWNoZTo6bWFya1BhZ2VzRm9yQ2FwdGlvblByZWZlcmVuY2VzQ2hhbmdlZCk6CisKIDIwMTUt MDEtMjcgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg U2ltcGxpZnkgaHR0cC90ZXN0cy9tZWRpYS92aWRlby1wbGF5LXN0YWxsLmh0bWwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2hpc3RvcnkvUGFnZUNhY2hlLmNwcAppbmRleCAzMWM5ODYxZjE3YTcwMTJhMjA2ZjQ5MGFiMmI4 N2QwODEzZmVjYjcwLi5mZDlkZjUyMzNmNzQzZjAxYmJhZTE0ZDMxMzBkOWI2ZWFiOTNmNTE5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCkBAIC0zOTIsNyArMzkyLDcgQEAgaW50 IFBhZ2VDYWNoZTo6ZnJhbWVDb3VudCgpIGNvbnN0CiAgICAgZm9yIChIaXN0b3J5SXRlbSogY3Vy cmVudCA9IG1faGVhZDsgY3VycmVudDsgY3VycmVudCA9IGN1cnJlbnQtPm1fbmV4dCkgewogICAg ICAgICArK2ZyYW1lQ291bnQ7CiAgICAgICAgIEFTU0VSVChjdXJyZW50LT5tX2NhY2hlZFBhZ2Up OwotICAgICAgICBmcmFtZUNvdW50ICs9IGN1cnJlbnQtPm1fY2FjaGVkUGFnZSA/IGN1cnJlbnQt Pm1fY2FjaGVkUGFnZS0+Y2FjaGVkTWFpbkZyYW1lKCktPmRlc2NlbmRhbnRGcmFtZUNvdW50KCkg OiAwOworICAgICAgICBmcmFtZUNvdW50ICs9IGN1cnJlbnQtPm1fY2FjaGVkUGFnZS0+Y2FjaGVk TWFpbkZyYW1lKCktPmRlc2NlbmRhbnRGcmFtZUNvdW50KCk7CiAgICAgfQogICAgIAogICAgIHJl dHVybiBmcmFtZUNvdW50OwpAQCAtNDAxLDI2ICs0MDEsMjYgQEAgaW50IFBhZ2VDYWNoZTo6ZnJh bWVDb3VudCgpIGNvbnN0CiB2b2lkIFBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9yVmlzdGVkTGlua1N0 eWxlUmVjYWxjKCkKIHsKICAgICBmb3IgKEhpc3RvcnlJdGVtKiBjdXJyZW50ID0gbV9oZWFkOyBj dXJyZW50OyBjdXJyZW50ID0gY3VycmVudC0+bV9uZXh0KSB7Ci0gICAgICAgIGlmIChjdXJyZW50 LT5tX2NhY2hlZFBhZ2UpCi0gICAgICAgICAgICBjdXJyZW50LT5tX2NhY2hlZFBhZ2UtPm1hcmtG b3JWaXN0ZWRMaW5rU3R5bGVSZWNhbGMoKTsKKyAgICAgICAgQVNTRVJUKGN1cnJlbnQtPm1fY2Fj aGVkUGFnZSk7CisgICAgICAgIGN1cnJlbnQtPm1fY2FjaGVkUGFnZS0+bWFya0ZvclZpc3RlZExp bmtTdHlsZVJlY2FsYygpOwogICAgIH0KIH0KIAogdm9pZCBQYWdlQ2FjaGU6Om1hcmtQYWdlc0Zv ckZ1bGxTdHlsZVJlY2FsYyhQYWdlKiBwYWdlKQogewogICAgIGZvciAoSGlzdG9yeUl0ZW0qIGN1 cnJlbnQgPSBtX2hlYWQ7IGN1cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50LT5tX25leHQpIHsKLSAg ICAgICAgQ2FjaGVkUGFnZSogY2FjaGVkUGFnZSA9IGN1cnJlbnQtPm1fY2FjaGVkUGFnZS5nZXQo KTsKLSAgICAgICAgaWYgKGNhY2hlZFBhZ2UgJiYgJnBhZ2UtPm1haW5GcmFtZSgpID09ICZjYWNo ZWRQYWdlLT5jYWNoZWRNYWluRnJhbWUoKS0+dmlldygpLT5mcmFtZSgpKQotICAgICAgICAgICAg Y2FjaGVkUGFnZS0+bWFya0ZvckZ1bGxTdHlsZVJlY2FsYygpOworICAgICAgICBDYWNoZWRQYWdl JiBjYWNoZWRQYWdlID0gKmN1cnJlbnQtPm1fY2FjaGVkUGFnZTsKKyAgICAgICAgaWYgKCZwYWdl LT5tYWluRnJhbWUoKSA9PSAmY2FjaGVkUGFnZS5jYWNoZWRNYWluRnJhbWUoKS0+dmlldygpLT5m cmFtZSgpKQorICAgICAgICAgICAgY2FjaGVkUGFnZS5tYXJrRm9yRnVsbFN0eWxlUmVjYWxjKCk7 CiAgICAgfQogfQogCiB2b2lkIFBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9yRGV2aWNlU2NhbGVDaGFu Z2VkKFBhZ2UqIHBhZ2UpCiB7CiAgICAgZm9yIChIaXN0b3J5SXRlbSogY3VycmVudCA9IG1faGVh ZDsgY3VycmVudDsgY3VycmVudCA9IGN1cnJlbnQtPm1fbmV4dCkgewotICAgICAgICBDYWNoZWRQ YWdlKiBjYWNoZWRQYWdlID0gY3VycmVudC0+bV9jYWNoZWRQYWdlLmdldCgpOwotICAgICAgICBp ZiAoY2FjaGVkUGFnZSAmJiAmcGFnZS0+bWFpbkZyYW1lKCkgPT0gJmNhY2hlZFBhZ2UtPmNhY2hl ZE1haW5GcmFtZSgpLT52aWV3KCktPmZyYW1lKCkpCi0gICAgICAgICAgICBjYWNoZWRQYWdlLT5t YXJrRm9yRGV2aWNlU2NhbGVDaGFuZ2VkKCk7CisgICAgICAgIENhY2hlZFBhZ2UmIGNhY2hlZFBh Z2UgPSAqY3VycmVudC0+bV9jYWNoZWRQYWdlOworICAgICAgICBpZiAoJnBhZ2UtPm1haW5GcmFt ZSgpID09ICZjYWNoZWRQYWdlLmNhY2hlZE1haW5GcmFtZSgpLT52aWV3KCktPmZyYW1lKCkpCisg ICAgICAgICAgICBjYWNoZWRQYWdlLm1hcmtGb3JEZXZpY2VTY2FsZUNoYW5nZWQoKTsKICAgICB9 CiB9CiAKQEAgLTQyOCw4ICs0MjgsOCBAQCB2b2lkIFBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9yRGV2 aWNlU2NhbGVDaGFuZ2VkKFBhZ2UqIHBhZ2UpCiB2b2lkIFBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9y Q2FwdGlvblByZWZlcmVuY2VzQ2hhbmdlZCgpCiB7CiAgICAgZm9yIChIaXN0b3J5SXRlbSogY3Vy cmVudCA9IG1faGVhZDsgY3VycmVudDsgY3VycmVudCA9IGN1cnJlbnQtPm1fbmV4dCkgewotICAg ICAgICBpZiAoY3VycmVudC0+bV9jYWNoZWRQYWdlKQotICAgICAgICAgICAgY3VycmVudC0+bV9j YWNoZWRQYWdlLT5tYXJrRm9yQ2FwdGlvblByZWZlcmVuY2VzQ2hhbmdlZCgpOworICAgICAgICBB U1NFUlQoY3VycmVudC0+bV9jYWNoZWRQYWdlKTsKKyAgICAgICAgY3VycmVudC0+bV9jYWNoZWRQ YWdlLT5tYXJrRm9yQ2FwdGlvblByZWZlcmVuY2VzQ2hhbmdlZCgpOwogICAgIH0KIH0KICNlbmRp Zgo=