140949 2015-01-27 12:05:53 -0800 [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work 2015-02-28 17:25:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad iOS 8.1 RESOLVED FIXED P2 Normal --- 1 dbates dbates commit-queue ddkilzer glenn oldest_to_newest 1064597 0 dbates 2015-01-27 12:05:53 -0800 run-webkit-tests --platform=ios* --lint-test-files does not link check the iOS TestExpectation files. 1064603 1 dbates 2015-01-27 12:19:25 -0800 Notice that it is sufficient to include "ios-simulator" in the list of ports without builders so as to lint TestExpectation files LayoutTests/platform/ios-simulator/TestExpectations and LayoutTests/platform/ios-simulator-wk1/TestExpectations by <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py?rev=160756#L56> and <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/factory.py?rev=179162#L124> and <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/ios.py?rev=179199#L179>. A similar argument can be made to show that ios-simulator-wk2 will instantiate a IOSSimulatorPort object where IOSSimulatorPort.get_option('webkit_test_runner') evaluates to true and hence we will lint LayoutTests/platform/ios-simulator-wk2/TestExpectations by <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/ios.py?rev=179199#L177>. 1064604 2 245460 dbates 2015-01-27 12:20:26 -0800 Created attachment 245460 Patch 1064645 3 245467 dbates 2015-01-27 14:03:01 -0800 Created attachment 245467 Patch 1064646 4 245467 dbates 2015-01-27 14:07:48 -0800 Comment on attachment 245467 Patch Clearing flags on attachment: 245467 Committed r179216: <http://trac.webkit.org/changeset/179216> 1064647 5 dbates 2015-01-27 14:07:52 -0800 All reviewed patches have been landed. Closing bug. 1073119 6 ddkilzer 2015-02-28 17:25:25 -0800 (In reply to comment #4) > Comment on attachment 245467 [details] > Patch > > Clearing flags on attachment: 245467 > > Committed r179216: <http://trac.webkit.org/changeset/179216> FWIW, this fix regressed this performance fix: Bug 135409: [iOS] run-webkit-tests runs webkit-build-directory on every test However, that regression was fixed by r180845: <http://trac.webkit.org/changeset/180845> 245460 2015-01-27 12:20:26 -0800 2015-01-27 14:02:59 -0800 Patch bug-140949-20150127122029.patch text/plain 1248 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzhjNzAxMjY3Y2E1YmQ0ZTNhNjEwMzg1MWY2MWIxMjU4 YzA3YWRmMC4uZDQxNTRlYTQ1ZGUyNmYzM2M5NGQzNDBhOTExMWQzZGE0NjViY2I3OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTAxLTI3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBydW4td2Via2l0LXRlc3RzIC0tcGxhdGZvcm09aW9zKiAtLWxpbnQtdGVzdC1m aWxlcyBkb2VzIG5vdCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDA5NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgImlvcy1zaW11bGF0b3IiIGFuZCAiaW9zLXNpbXVsYXRvci13azIiIHRv IHRoZSBsaXN0IG9mIHBvcnRzIHdpdGhvdXQKKyAgICAgICAgYnVpbGRlcnMgc28gdGhhdCBydW4t d2Via2l0LXRlc3RzIGNhbiBsaW50IHRoZSBhcHByb3ByaWF0ZSBUZXN0RXhwZWN0YXRpb24KKyAg ICAgICAgZmlsZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvYnVpbGRlcnMu cHk6CisKIDIwMTUtMDEtMjYgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dpbl0gQVNTRVJUSU9OIEZBSUxFRCAhbV9wdHIgdW5kZXIgQWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXI6OndpbkFkZE5vdGlmaWNhdGlvbkxpc3RlbmVyCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYnVpbGRlcnMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvYnVpbGRlcnMucHkKaW5kZXggZDQ5YzhjZWQ3NmQ5MmZjOTc2MWMxOTFjMzgyMzky YjVmMjczZDcxYS4uODZjZmU5N2MyNmQ2Y2Y1M2RlMmVlNGI1N2Y1M2Y0NzIxNmQ5YWUxOSAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2J1aWxkZXJzLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9idWlsZGVycy5weQpAQCAtOTEsNiArOTEsOCBAQCBf ZnV6enlfbWF0Y2hlcyA9IHsKIAogCiBfcG9ydHNfd2l0aG91dF9idWlsZGVycyA9IFsKKyAgICBy Imlvcy1zaW11bGF0b3IiLAorICAgIHIiaW9zLXNpbXVsYXRvci13azIiLAogXQogCiAK 245467 2015-01-27 14:03:01 -0800 2015-01-27 14:07:48 -0800 Patch bug-140949-20150127140305.patch text/plain 3225 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzhjNzAxMjY3Y2E1YmQ0ZTNhNjEwMzg1MWY2MWIxMjU4 YzA3YWRmMC4uYmY2OWQ5YWUyZTU4ZjczMDBiMGUxMmI4YWQ4Y2JlN2MyN2FmZjExMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDE1LTAxLTI3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBydW4td2Via2l0LXRlc3RzIC0tcGxhdGZvcm09aW9zKiAtLWxpbnQtdGVzdC1m aWxlcyBkb2VzIG5vdCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDA5NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgImlvcy1zaW11bGF0b3IiIGFuZCAiaW9zLXNpbXVsYXRvci13azIiIHRv IHRoZSBsaXN0IG9mIHBvcnRzIHdpdGhvdXQKKyAgICAgICAgYnVpbGRlcnMgc28gdGhhdCBydW4t d2Via2l0LXRlc3RzIGNhbiBsaW50IHRoZSBhcHByb3ByaWF0ZSBUZXN0RXhwZWN0YXRpb24KKyAg ICAgICAgZmlsZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvYnVpbGRlcnMu cHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weToKKyAgICAgICAgKElP U1NpbXVsYXRvclBvcnQuX19pbml0X18pOiBNb3ZlIGxvZ2ljIHRvIHF1ZXJ5IGZvciB0aGUgTWFj IGJ1aWxkIGRpcmVjdG9yeSBmcm9tIGhlcmUuLi4KKyAgICAgICAgKElPU1NpbXVsYXRvclBvcnQu cmVsYXlfcGF0aCk6IHRvIGhlcmUgYXMgdGhpcyBpcyB0aGUgb25seSBjYWxsZXIgdGhhdCBtYWtl cyB1c2Ugb2YgdGhhdAorICAgICAgICBpbmZvcm1hdGlvbiB0byBmaW5kIHRoZSBMYXlvdXRUZXN0 UmVsYXkgdG9vbC4gT3RoZXJ3aXNlLCAic2VsZi5hc3NlcnRFcXVhbChsZW4oY2FsbHMpLCAxKSIK KyAgICAgICAgaW4gdW5pdCB0ZXN0IHdlYmtpdHB5LnRvb2wuY29tbWFuZHMucmViYXNlbGluZV91 bml0dGVzdC5UZXN0UmViYXNlbGluZUV4cGVjdGF0aW9ucy50ZXN0X3JlYmFzZWxpbmVfZXhwZWN0 YXRpb25zCisgICAgICAgIHdpbGwgZmFpbCBiZWNhdXNlIElPU1NpbXVsYXRvclBvcnQuX19pbml0 X18oKSB1bHRpbWF0ZWx5IGNhbGxzIFRvb2xzL1NjcmlwdHMvd2Via2l0LWJ1aWxkLWRpcmVjdG9y eQorICAgICAgICB0byBkZXRlcm1pbmUgdGhlIE1hYyBidWlsZCBkaXJlY3RvcnkgZm9yIGVhY2gg aW5zdGFudGlhdGlvbiBvZiBJT1NTaW11bGF0b3JQb3J0LiBBbmQgdGhpcyB1bml0CisgICAgICAg IHRlc3QgaW5zdGFudGlhdGVzIGEgcG9ydCBvYmplY3QgZm9yIGVhY2ggYnVpbGRlciBsaXN0ZWQg aW4gZmlsZSBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvYnVpbGRlcnMucHkuCisKKwogMjAxNS0wMS0y NiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBB U1NFUlRJT04gRkFJTEVEICFtX3B0ciB1bmRlciBBY2Nlc3NpYmlsaXR5Q29udHJvbGxlcjo6d2lu QWRkTm90aWZpY2F0aW9uTGlzdGVuZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC9idWlsZGVycy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9idWlsZGVy cy5weQppbmRleCBkNDljOGNlZDc2ZDkyZmM5NzYxYzE5MWMzODIzOTJiNWYyNzNkNzFhLi44NmNm ZTk3YzI2ZDZjZjUzZGUyZWU0YjU3ZjUzZjQ3MjE2ZDlhZTE5IDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvYnVpbGRlcnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L2J1aWxkZXJzLnB5CkBAIC05MSw2ICs5MSw4IEBAIF9mdXp6eV9tYXRjaGVzID0g ewogCiAKIF9wb3J0c193aXRob3V0X2J1aWxkZXJzID0gWworICAgIHIiaW9zLXNpbXVsYXRvciIs CisgICAgciJpb3Mtc2ltdWxhdG9yLXdrMiIsCiBdCiAKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wb3J0L2lvcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9p b3MucHkKaW5kZXggZWFkYTQwNmJiZjJlMmY2NzA3OWQ1OTQwMDE2NWUyNWZiYzZlMzhjOS4uODIw MmZhYzQ2ZmQ1MjEwYmE4ODI5NjA3YjQxN2JmMDdhNGRjNjg2ZCAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvaW9zLnB5CkBAIC05Niw4ICs5Niw2IEBAIGNsYXNzIElPU1NpbXVsYXRvclBvcnQoUG9y dCk6CiAgICAgICAgICAgICAjIER1bXBSZW5kZXJUcmVlIHNsb3dzIGRvd24gbm90aWNhYmx5IGlm IHdlIHJ1biBtb3JlIHRoYW4gYWJvdXQgMTAwMCB0ZXN0cyBpbiBhIGJhdGNoCiAgICAgICAgICAg ICAjIHdpdGggTWFsbG9jU3RhY2tMb2dnaW5nIGVuYWJsZWQuCiAgICAgICAgICAgICBzZWxmLnNl dF9vcHRpb25fZGVmYXVsdCgiYmF0Y2hfc2l6ZSIsIDEwMDApCi0gICAgICAgIG1hY19jb25maWcg PSBwb3J0X2NvbmZpZy5Db25maWcoc2VsZi5fZXhlY3V0aXZlLCBzZWxmLl9maWxlc3lzdGVtLCAn bWFjJykKLSAgICAgICAgc2VsZi5fbWFjX2J1aWxkX2RpcmVjdG9yeSA9IG1hY19jb25maWcuYnVp bGRfZGlyZWN0b3J5KHNlbGYuZ2V0X29wdGlvbignY29uZmlndXJhdGlvbicpKQogCiAgICAgICAg IHNlbGYuX3Rlc3RpbmdfZGV2aWNlID0gTm9uZQogCkBAIC0xMTAsNyArMTA4LDggQEAgY2xhc3Mg SU9TU2ltdWxhdG9yUG9ydChQb3J0KToKIAogICAgIEBwcm9wZXJ0eQogICAgIGRlZiByZWxheV9w YXRoKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYuX21h Y19idWlsZF9kaXJlY3RvcnksIHNlbGYucmVsYXlfbmFtZSkKKyAgICAgICAgbWFjX2NvbmZpZyA9 IHBvcnRfY29uZmlnLkNvbmZpZyhzZWxmLl9leGVjdXRpdmUsIHNlbGYuX2ZpbGVzeXN0ZW0sICdt YWMnKQorICAgICAgICByZXR1cm4gc2VsZi5fZmlsZXN5c3RlbS5qb2luKG1hY19jb25maWcuYnVp bGRfZGlyZWN0b3J5KHNlbGYuZ2V0X29wdGlvbignY29uZmlndXJhdGlvbicpKSwgc2VsZi5yZWxh eV9uYW1lKQogCiAgICAgZGVmIGRlZmF1bHRfdGltZW91dF9tcyhzZWxmKToKICAgICAgICAgaWYg c2VsZi5nZXRfb3B0aW9uKCdndWFyZF9tYWxsb2MnKToK