140939 2015-01-27 07:06:41 -0800 REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development 2015-01-27 08:17:28 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad iOS 8.1 RESOLVED FIXED P2 Normal --- 1 dbates dbates ddkilzer oldest_to_newest 1064505 0 dbates 2015-01-27 07:06:41 -0800 When I ran Tools/Scripts/configure-xcode-for-ios-development Perl emitted a warning about the subroutine named "wanted" being redefined: Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106. 1064506 1 245444 dbates 2015-01-27 07:08:10 -0800 Created attachment 245444 Patch 1064510 2 245444 dbates 2015-01-27 07:32:21 -0800 Comment on attachment 245444 Patch Clearing flags on attachment: 245444 Committed r179180: <http://trac.webkit.org/changeset/179180> 1064511 3 dbates 2015-01-27 07:32:24 -0800 All reviewed patches have been landed. Closing bug. 1064519 4 245444 ddkilzer 2015-01-27 08:17:28 -0800 Comment on attachment 245444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245444&action=review > Tools/Scripts/webkitdirs.pm:2174 > - sub wanted { > + my $wantedFunction = sub { We should do the same thing for the wanted() function in webkitdirs.pm. 245444 2015-01-27 07:08:10 -0800 2015-01-27 07:32:21 -0800 Patch bug-140939-20150127070813.patch text/plain 2144 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzhjNzAxMjY3Y2E1YmQ0ZTNhNjEwMzg1MWY2MWIxMjU4 YzA3YWRmMC4uNTAxZGI0NjBmZWU1N2Y4OTFkNDA0YTE3M2JhNTU5OTk4YjY4M2FlMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTAxLTI3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OIChyMTc5MTMwKTogUGVybCB3YXJucyBhYm91dCBzdWJyb3V0aW5lIHJl ZGVmaW5pdGlvbiB3aGVuIHJ1bm5pbmcgY29uZmlndXJlLXhjb2RlLWZvci1pb3MtZGV2ZWxvcG1l bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDkz OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVz IHRoZSBQZXJsIHdhcm5pbmc6ICJTdWJyb3V0aW5lIHdhbnRlZCByZWRlZmluZWQgYXQgVG9vbHMv U2NyaXB0cy9jb25maWd1cmUteGNvZGUtZm9yLWlvcy1kZXZlbG9wbWVudCBsaW5lIDEwNi4iCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChoYXNVc2VySW5zdGFs bGVkQXBwSW5TaW11bGF0b3JEZXZpY2UpOiBQYXNzIGEgcmVmZXJlbmNlIHRvIGFuIGFub255bW91 cyBmdW5jdGlvbiBpbnN0ZWFkCisgICAgICAgIG9mIGEgbmFtZWQgZnVuY3Rpb24gdG8gZmluZCgp IHRvIGF2b2lkIHJlZGVmaW5pdGlvbiB3YXJuaW5ncyBpbiBzY3JpcHRzIHRoYXQgaW5jbHVkZSB3 ZWJraXRkaXJzLnBtCisgICAgICAgIGFuZCBkZWZpbmUgYSBmdW5jdGlvbiBjYWxsZWQgd2FudGVk LgorCiAyMDE1LTAxLTI2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIFtXaW5dIEFTU0VSVElPTiBGQUlMRUQgIW1fcHRyIHVuZGVyIEFjY2Vzc2liaWxpdHlD b250cm9sbGVyOjp3aW5BZGROb3RpZmljYXRpb25MaXN0ZW5lcgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IGUzN2VmMmY2MTAwZGNhYWM5OTQ4MTI3MDQ0NTNjYmZiMjc4NGRlYmUuLmRkYjE3YWViOTI5NDE2 MzAzYjI0YWI2NzEyNmEwMmE4YzI5MzMwZmEgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTIxNzEsNyAr MjE3MSw3IEBAIHN1YiBoYXNVc2VySW5zdGFsbGVkQXBwSW5TaW11bGF0b3JEZXZpY2UoJCQpCiAg ICAgICAgIHJldHVybiAwOyAjIE5vIHVzZXIgaW5zdGFsbGVkIGFwcHMuCiAgICAgfQogICAgIGxv Y2FsIEA6OnVzZXJJbnN0YWxsZWRBcHBCdW5kbGVzOwotICAgIHN1YiB3YW50ZWQgeworICAgIG15 ICR3YW50ZWRGdW5jdGlvbiA9IHN1YiB7CiAgICAgICAgIG15ICRmaWxlID0gJF87CiAKICAgICAg ICAgIyBJZ25vcmUgaGlkZGVuIGZpbGVzIGFuZCBkaXJlY3Rvcmllcy4KQEAgLTIxODMsOCArMjE4 Myw4IEBAIHN1YiBoYXNVc2VySW5zdGFsbGVkQXBwSW5TaW11bGF0b3JEZXZpY2UoJCQpCiAgICAg ICAgIHJldHVybiBpZiAhLWQgJGZpbGUgfHwgJGZpbGUgIX4gL1wuYXBwJC87CiAgICAgICAgIHB1 c2ggQDo6dXNlckluc3RhbGxlZEFwcEJ1bmRsZXMsICRGaWxlOjpGaW5kOjpuYW1lOwogICAgICAg ICAkRmlsZTo6RmluZDo6cHJ1bmUgPSAxOyAjIERvIG5vdCB0cmF2ZXJzZSBjb250ZW50cyBvZiBh cHAgYnVuZGxlLgotICAgIH0KLSAgICBmaW5kKFwmd2FudGVkLCAkdXNlckluc3RhbGxlZEFwcFBh dGgpOworICAgIH07CisgICAgZmluZCgkd2FudGVkRnVuY3Rpb24sICR1c2VySW5zdGFsbGVkQXBw UGF0aCk7CiAgICAgZm9yIG15ICR1c2VySW5zdGFsbGVkQXBwQnVuZGxlIChAOjp1c2VySW5zdGFs bGVkQXBwQnVuZGxlcykgewogICAgICAgICBpZiAoYXBwSWRlbnRpZmllckZyb21CdW5kbGUoJHVz ZXJJbnN0YWxsZWRBcHBCdW5kbGUpIGVxICRhcHBJZGVudGlmaWVyKSB7CiAgICAgICAgICAgICBy ZXR1cm4gMTsgIyBIYXMgdXNlciBpbnN0YWxsZWQgYXBwLgo=