140937 2015-01-27 06:55:28 -0800 [ARM] Typo fix after r176083 2015-01-27 09:13:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 136914 1 ossy ossy benjamin commit-queue msaboff ossy oldest_to_newest 1064499 0 ossy 2015-01-27 06:55:28 -0800 [ARM] Typo fix after r176083 1064500 1 245442 ossy 2015-01-27 06:55:38 -0800 Created attachment 245442 Patch 1064501 2 245442 ossy 2015-01-27 07:00:15 -0800 Comment on attachment 245442 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245442&action=review > Source/JavaScriptCore/assembler/ARMv7Assembler.h:1158 > - ASSERT(!(imm.isUInt12() & 1)); > + ASSERT(!(imm.getUInt12() & 1)); I ran into this assertion during debugging a bug on ARM Linux. It seems to be a simple typo. isUInt12() returns a logical value: 0 as false / not 0 as true, But we can't expect if the non 0 value is an odd number. I think the author wanted to expect odd number. In this case we should use getUint12() instead of isUInt12(). 1064532 3 245442 commit-queue 2015-01-27 09:13:16 -0800 Comment on attachment 245442 Patch Clearing flags on attachment: 245442 Committed r179187: <http://trac.webkit.org/changeset/179187> 1064533 4 commit-queue 2015-01-27 09:13:20 -0800 All reviewed patches have been landed. Closing bug. 245442 2015-01-27 06:55:38 -0800 2015-01-27 09:13:16 -0800 Patch bug-140937-20150127155738.patch text/plain 1428 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx N2FiMTJiNDVhNGEwNzgwMzI0Mzg2ZWY1YTZmYjJiYjA3YzI0NDAwLi5iYzIxMGQ5YmZhMjc4MGZm ODUwMGU5NzAzOTgxMzQyYmJhYmQwMGUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNSBAQAogMjAxNS0wMS0yNyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgogCisgICAgICAgIFtBUk1dIFR5cG8gZml4IGFmdGVyIHIxNzYwODMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDkzNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL0FSTXY3QXNz ZW1ibGVyLmg6CisgICAgICAgIChKU0M6OkFSTXY3QXNzZW1ibGVyOjpsZHJoKToKKworMjAxNS0w MS0yNyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCiAgICAgICAgIFtX aW5dIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLCBza2lwIGZhaWxpbmcgdGVzdHMuCiAKICAgICAgICAg KiB0ZXN0cy9leGNlcHRpb25GdXp6LnlhbWw6IFNraXAgZXhjZXB0aW9uIGZ1enogdGVzdHMgZHVl IHRvIGJ1ZzE0MDkyOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvQVJNdjdBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJN djdBc3NlbWJsZXIuaAppbmRleCBhYmVjZjY2YTU5NzlhZTA4ZmY4ZWQ3NjI1NzczNTJkN2MzOTYw Y2ViLi4wNGU1NmNlODJkNjM0MzA0ODVkZjZhMmFkNjZmMWU0ODUwM2NjZTMyIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCkBAIC0xMTU1 LDcgKzExNTUsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBBU1NFUlQocm4gIT0gQVJNUmVn aXN0ZXJzOjpwYyk7IC8vIExEUiAobGl0ZXJhbCkKICAgICAgICAgQVNTRVJUKGltbS5pc1VJbnQx MigpKTsKLSAgICAgICAgQVNTRVJUKCEoaW1tLmlzVUludDEyKCkgJiAxKSk7CisgICAgICAgIEFT U0VSVCghKGltbS5nZXRVSW50MTIoKSAmIDEpKTsKIAogICAgICAgICBpZiAoISgocnQgfCBybikg JiA4KSAmJiBpbW0uaXNVSW50NigpKQogICAgICAgICAgICAgbV9mb3JtYXR0ZXIub25lV29yZE9w NUltbTVSZWczUmVnMyhPUF9MRFJIX2ltbV9UMSwgaW1tLmdldFVJbnQ2KCkgPj4gMSwgcm4sIHJ0 KTsK