140925 2015-01-26 22:13:07 -0800 HTMLElement.dir should only return known values 2015-01-27 08:00:04 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://src.chromium.org/viewvc/blink?view=rev&revision=171861 BlinkMergeCandidate P2 Normal --- 1 cdumez cdumez ap commit-queue darin rniwa oldest_to_newest 1064425 0 cdumez 2015-01-26 22:13:07 -0800 HTMLElement.dir should only return known values according to the HTML specification: https://html.spec.whatwg.org/multipage/dom.html#dom-document-dir Chrome and Firefox 28 match the specification. IE11's behavior is slightly different: - When setting an unknown 'dir' value, an exception will be thrown. (stricter than the spec) - Setting a known 'dir' value in a non-canonical case (e.g. "RTL"), the value will be directly converted to its canonical form (e.g. "rtl") before updating the DOM tree. (close to the spec but changing the case upon setting). 1064433 1 245425 cdumez 2015-01-26 22:42:50 -0800 Created attachment 245425 Patch 1064507 2 245425 darin 2015-01-27 07:17:28 -0800 Comment on attachment 245425 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245425&action=review I made some comments but I still set commit-queue+. We can refine with a follow-up patch, I suppose. > Source/WebCore/html/HTMLElement.cpp:466 > +// Returns the conforming 'dir' value associated with the state the attribute is in (in its canonical case), if any, > +// or the empty string if the attribute is in a state that has no associated keyword value or if the attribute is > +// not in a defined state (e.g. the attribute is missing and there is no missing value default). > +// http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#limited-to-only-known-values This comment is too long. There are patterns like this throughout the DOM and I don’t think every one needs such a long comment. > Source/WebCore/html/HTMLElement.cpp:467 > +static inline const AtomicString& toValidDirValue(const AtomicString& value) I don’t think this needs to be a separate function. I would just put this logic inside the dir function. > Source/WebCore/html/HTMLElement.cpp:471 > + static NeverDestroyed<AtomicString> ltrValue("ltr", AtomicString::ConstructFromLiteral); > + static NeverDestroyed<AtomicString> rtlValue("rtl", AtomicString::ConstructFromLiteral); > + static NeverDestroyed<AtomicString> autoValue("auto", AtomicString::ConstructFromLiteral); Why not define these inside the return statements instead of in a block at the top of the function? That would actually be slightly more efficient. We could also even consider adding these strings to the “commonly used atomic strings” list in AtomicString.h. 1064514 3 245425 commit-queue 2015-01-27 07:59:59 -0800 Comment on attachment 245425 Patch Clearing flags on attachment: 245425 Committed r179181: <http://trac.webkit.org/changeset/179181> 1064515 4 commit-queue 2015-01-27 08:00:04 -0800 All reviewed patches have been landed. Closing bug. 245425 2015-01-26 22:42:50 -0800 2015-01-27 07:59:59 -0800 Patch bug-140925-20150126224253.patch text/plain 10138 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc3OGY0ZmMzZjhjY2I3 ZDZkOGM5ZjZhYzhiMzZkYTU2NDE1MjAwNy4uNmVhZThmMjMyYjYyNjA3ZWU5YjdhZTRmY2IzMTZj ODJlZTk1MGNjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDQwIEBACiAyMDE1LTAxLTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgSFRNTEVsZW1lbnQuZGlyIHNo b3VsZCBvbmx5IHJldHVybiBrbm93biB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDkyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhUTUxFbGVtZW50LmRpciBzaG91bGQgb25seSByZXR1cm4g a25vd24gdmFsdWVzIGFjY29yZGluZyB0byB0aGUgSFRNTAorICAgICAgICBzcGVjaWZpY2F0aW9u OgorICAgICAgICBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9kb20uaHRt bCNkb20tZG9jdW1lbnQtZGlyCisKKyAgICAgICAgQ2hyb21lIGFuZCBGaXJlZm94IDI4IG1hdGNo IHRoZSBzcGVjaWZpY2F0aW9uLiBJRTExJ3MgYmVoYXZpb3IgaXMKKyAgICAgICAgc2xpZ2h0bHkg ZGlmZmVyZW50OgorICAgICAgICAtIFdoZW4gc2V0dGluZyBhbiB1bmtub3duICdkaXInIHZhbHVl LCBhbiBleGNlcHRpb24gd2lsbCBiZSB0aHJvd24uCisgICAgICAgIC0gU2V0dGluZyBhIGtub3du ICdkaXInIHZhbHVlIGluIGEgbm9uLWNhbm9uaWNhbCBjYXNlIChlLmcuICJSVEwiKSwKKyAgICAg ICAgICB0aGUgdmFsdWUgd2lsbCBiZSBkaXJlY3RseSBjb252ZXJ0ZWQgdG8gaXRzIGNhbm9uaWNh bCBmb3JtIChlLmcuCisgICAgICAgICAgInJ0bCIpIGJlZm9yZSB1cGRhdGluZyB0aGUgRE9NIHRy ZWUuIChjbG9zZSB0byB0aGUgc3BlYyBidXQgY2hhbmdpbmcKKyAgICAgICAgICB0aGUgY2FzZSB1 cG9uIHNldHRpbmcpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgYmFzZWQgb24gdGhlIGZvbGxv d2luZyBCbGluayByZXZpc2lvbiBieSBtZToKKyAgICAgICAgaHR0cHM6Ly9zcmMuY2hyb21pdW0u b3JnL3ZpZXd2Yy9ibGluaz92aWV3PXJldiZyZXZpc2lvbj0xNzE4NjEKKworICAgICAgICBUZXN0 OiBmYXN0L2RvbS9kb2N1bWVudC1kaXItcHJvcGVydHkuaHRtbAorCisgICAgICAgICogaHRtbC9I VE1MRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTERvY3VtZW50OjpkaXIpOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTERvY3VtZW50OjpzZXREaXIpOgorICAgICAgICAqIGh0bWwv SFRNTERvY3VtZW50Lmg6CisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjp0b1ZhbGlkRGlyVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEVsZW1l bnQ6OmRpcik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRWxlbWVudDo6c2V0RGlyKToKKyAgICAg ICAgKiBodG1sL0hUTUxFbGVtZW50Lmg6CisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudC5pZGw6 CisKKzIwMTUtMDEtMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAg ICBEb2N1bWVudC5kaXIgc2hvdWxkIHJlZmxlY3QgdGhlICdkaXInIGF0dHJpYnV0ZSBvZiB0aGUg cm9vdCBodG1sIGVsZW1lbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0MDkyMgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxE b2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5jcHAKaW5kZXgg NTQwMGU0OWFkYjM4M2YxZjMwYmZlNmI5MDdmODU1NWQ1YmM1YzIwZC4uOGM3NWY0NTMwNjNhNDk2 MTNlNzkwMDEyYWY0MDQ1YzY2MjAxMzA0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3VtZW50 LmNwcApAQCAtNjksNiArNjksNyBAQAogI2luY2x1ZGUgIkhUTUxFbGVtZW50RmFjdG9yeS5oIgog I2luY2x1ZGUgIkhUTUxGcmFtZU93bmVyRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxGcmFtZVNl dEVsZW1lbnQuaCIKKyNpbmNsdWRlICJIVE1MSHRtbEVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1M TmFtZXMuaCIKICNpbmNsdWRlICJKU0RPTUJpbmRpbmcuaCIKICNpbmNsdWRlICJQYWdlLmgiCkBA IC0xMDUsMTkgKzEwNiwxOSBAQCBpbnQgSFRNTERvY3VtZW50OjpoZWlnaHQoKQogICAgIHJldHVy biBmcmFtZVZpZXcgPyBmcmFtZVZpZXctPmNvbnRlbnRzSGVpZ2h0KCkgOiAwOwogfQogCi1jb25z dCBBdG9taWNTdHJpbmcmIEhUTUxEb2N1bWVudDo6ZGlyKCkKK2NvbnN0IEF0b21pY1N0cmluZyYg SFRNTERvY3VtZW50OjpkaXIoKSBjb25zdAogewogICAgIGF1dG8qIGRvY3VtZW50RWxlbWVudCA9 IHRoaXMtPmRvY3VtZW50RWxlbWVudCgpOwogICAgIGlmICghaXM8SFRNTEh0bWxFbGVtZW50Pigq ZG9jdW1lbnRFbGVtZW50KSkKICAgICAgICAgcmV0dXJuIG51bGxBdG9tOwotICAgIHJldHVybiBk b2N1bWVudEVsZW1lbnQtPmZhc3RHZXRBdHRyaWJ1dGUoZGlyQXR0cik7CisgICAgcmV0dXJuIGRv d25jYXN0PEhUTUxIdG1sRWxlbWVudD4oKmRvY3VtZW50RWxlbWVudCkuZGlyKCk7CiB9CiAKIHZv aWQgSFRNTERvY3VtZW50OjpzZXREaXIoY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSkKIHsKICAg ICBhdXRvKiBkb2N1bWVudEVsZW1lbnQgPSB0aGlzLT5kb2N1bWVudEVsZW1lbnQoKTsKICAgICBp ZiAoaXM8SFRNTEh0bWxFbGVtZW50Pihkb2N1bWVudEVsZW1lbnQpKQotICAgICAgICBkb2N1bWVu dEVsZW1lbnQtPnNldEF0dHJpYnV0ZShkaXJBdHRyLCB2YWx1ZSk7CisgICAgICAgIGRvd25jYXN0 PEhUTUxIdG1sRWxlbWVudD4oKmRvY3VtZW50RWxlbWVudCkuc2V0RGlyKHZhbHVlKTsKIH0KIAog U3RyaW5nIEhUTUxEb2N1bWVudDo6ZGVzaWduTW9kZSgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M RG9jdW1lbnQuaAppbmRleCAzOGE5Yjk5N2E2Zjg4YTNkNjQwZmNiMDcwM2RkMGY5MmI1Yjc0MmMx Li4zMThkYzdmOGYxNWVlNjA2MDU4OTY3ODgzZmQ0N2IyZDEwZWJlZWY0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTERvY3VtZW50LmgKQEAgLTQ2LDcgKzQ2LDcgQEAgcHVibGljOgogICAgIGludCB3aWR0 aCgpOwogICAgIGludCBoZWlnaHQoKTsKIAotICAgIGNvbnN0IEF0b21pY1N0cmluZyYgZGlyKCk7 CisgICAgY29uc3QgQXRvbWljU3RyaW5nJiBkaXIoKSBjb25zdDsKICAgICB2b2lkIHNldERpcihj b25zdCBBdG9taWNTdHJpbmcmKTsKIAogICAgIFN0cmluZyBkZXNpZ25Nb2RlKCkgY29uc3Q7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwCmluZGV4IGExZjcyZWQyMDhhYWE2ZWQ3NjA2ZmQ5 NWY1OGQ5NWYzNGUwOTkzYTEuLmFlYzM2Zjg2Y2UwYTgwYmRiODZmYzIxZGM4NGU0MjMzNmNkODll MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwCkBAIC00NjAsNiArNDYwLDM1IEBA IHN0YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRQcm9oaWJpdFNldElubmVyT3V0ZXJUZXh0KGNvbnN0 IEhUTUxFbGVtZW50JiBlbGVtZW50KQogICAgICAgICB8fCBlbGVtZW50Lmhhc1RhZ05hbWUodHJU YWcpOwogfQogCisvLyBSZXR1cm5zIHRoZSBjb25mb3JtaW5nICdkaXInIHZhbHVlIGFzc29jaWF0 ZWQgd2l0aCB0aGUgc3RhdGUgdGhlIGF0dHJpYnV0ZSBpcyBpbiAoaW4gaXRzIGNhbm9uaWNhbCBj YXNlKSwgaWYgYW55LAorLy8gb3IgdGhlIGVtcHR5IHN0cmluZyBpZiB0aGUgYXR0cmlidXRlIGlz IGluIGEgc3RhdGUgdGhhdCBoYXMgbm8gYXNzb2NpYXRlZCBrZXl3b3JkIHZhbHVlIG9yIGlmIHRo ZSBhdHRyaWJ1dGUgaXMKKy8vIG5vdCBpbiBhIGRlZmluZWQgc3RhdGUgKGUuZy4gdGhlIGF0dHJp YnV0ZSBpcyBtaXNzaW5nIGFuZCB0aGVyZSBpcyBubyBtaXNzaW5nIHZhbHVlIGRlZmF1bHQpLgor Ly8gaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0 aXBhZ2UvY29tbW9uLWRvbS1pbnRlcmZhY2VzLmh0bWwjbGltaXRlZC10by1vbmx5LWtub3duLXZh bHVlcworc3RhdGljIGlubGluZSBjb25zdCBBdG9taWNTdHJpbmcmIHRvVmFsaWREaXJWYWx1ZShj b25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKQoreworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxB dG9taWNTdHJpbmc+IGx0clZhbHVlKCJsdHIiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21M aXRlcmFsKTsKKyAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8QXRvbWljU3RyaW5nPiBydGxWYWx1 ZSgicnRsIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCk7CisgICAgc3RhdGlj IE5ldmVyRGVzdHJveWVkPEF0b21pY1N0cmluZz4gYXV0b1ZhbHVlKCJhdXRvIiwgQXRvbWljU3Ry aW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCk7CisKKyAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2Uo dmFsdWUsIGx0clZhbHVlKSkKKyAgICAgICAgcmV0dXJuIGx0clZhbHVlOworICAgIGlmIChlcXVh bElnbm9yaW5nQ2FzZSh2YWx1ZSwgcnRsVmFsdWUpKQorICAgICAgICByZXR1cm4gcnRsVmFsdWU7 CisgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKHZhbHVlLCBhdXRvVmFsdWUpKQorICAgICAgICBy ZXR1cm4gYXV0b1ZhbHVlOworICAgIHJldHVybiBudWxsQXRvbTsKK30KKworY29uc3QgQXRvbWlj U3RyaW5nJiBIVE1MRWxlbWVudDo6ZGlyKCkgY29uc3QKK3sKKyAgICByZXR1cm4gdG9WYWxpZERp clZhbHVlKGZhc3RHZXRBdHRyaWJ1dGUoZGlyQXR0cikpOworfQorCit2b2lkIEhUTUxFbGVtZW50 OjpzZXREaXIoY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSkKK3sKKyAgICBzZXRBdHRyaWJ1dGUo ZGlyQXR0ciwgdmFsdWUpOworfQorCiB2b2lkIEhUTUxFbGVtZW50OjpzZXRJbm5lclRleHQoY29u c3QgU3RyaW5nJiB0ZXh0LCBFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBpZiAoaWVGb3JiaWRz SW5zZXJ0SFRNTCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVt ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmgKaW5kZXggOTg4NGVjN2Mx ZGE1ZmEyOTliZTg5ZTU3N2MxZjMxMTFlYTU4YmE1NC4uY2RlYWU3YWFhZjZhNzkyMjRiNGNmNTFh MjdhNmI5NjM5YTUwNjNmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxl bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuaApAQCAtODEsNiAr ODEsOSBAQCBwdWJsaWM6CiAKICAgICBIVE1MRm9ybUVsZW1lbnQqIGZvcm0oKSBjb25zdCB7IHJl dHVybiB2aXJ0dWFsRm9ybSgpOyB9CiAKKyAgICBjb25zdCBBdG9taWNTdHJpbmcmIGRpcigpIGNv bnN0OworICAgIHZvaWQgc2V0RGlyKGNvbnN0IEF0b21pY1N0cmluZyYpOworCiAgICAgYm9vbCBo YXNEaXJlY3Rpb25BdXRvKCkgY29uc3Q7CiAgICAgVGV4dERpcmVjdGlvbiBkaXJlY3Rpb25hbGl0 eUlmaGFzRGlyQXV0b0F0dHJpYnV0ZShib29sJiBpc0F1dG8pIGNvbnN0OwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEVsZW1lbnQuaWRsCmluZGV4IDVhYWU5ODA1MGQwMDI1NjcxNDYxZGM1ZDg1MzA1NmMz YzQxNWQxM2EuLjJiYjYyZmY0MjI1ZTc5MDRjMDNmOWMyOGJmZTk1MWZhNDcxYWEzY2YgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuaWRsCkBAIC0yOSw3ICsyOSw3IEBACiAgICAgICAgICAg ICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgdGl0bGU7CiAgICAgICAgICAgICAgW1Jl ZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgbGFuZzsKICAgICAgICAgICAgICBhdHRyaWJ1dGUg Ym9vbGVhbiAgICAgICAgICAgICB0cmFuc2xhdGU7Ci0gICAgICAgICAgICAgW1JlZmxlY3RdIGF0 dHJpYnV0ZSBET01TdHJpbmcgZGlyOworICAgICAgICAgICAgIGF0dHJpYnV0ZSBET01TdHJpbmcg ZGlyOwogCiAgICAgICAgICAgICAgYXR0cmlidXRlIGxvbmcgICAgICAgICAgICAgIHRhYkluZGV4 OwogICAgICAgICAgICAgIGF0dHJpYnV0ZSBib29sZWFuICAgICAgICAgICBkcmFnZ2FibGU7CmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggODM2NzQ0NTI0ZmRlZmI4Njk5MjA5NTc2MDgwNTA2MDhlMTlmMWJkNi4uYmMyZWQ4Mzdj Yjg0YjU4MWUxYTNiOGU0ZDYxODRhNzQwY2NiNjRjZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAy MDE1LTAxLTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgSFRN TEVsZW1lbnQuZGlyIHNob3VsZCBvbmx5IHJldHVybiBrbm93biB2YWx1ZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDkyNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBmYXN0L2RvbS9kb2N1 bWVudC1kaXItcHJvcGVydHkuaHRtbCB0byBtYWtlIHN1cmUgSFRNTERvY3VtZW50LmRpcgorICAg ICAgICBhbmQgSFRNTEVsZW1lbnQuZGlyIG9ubHkgcmV0dXJuIGtub3duIHZhbHVlcywgYXMgcGVy IHRoZSBIVE1MCisgICAgICAgIHNwZWNpZmljYXRpb24uCisKKyAgICAgICAgKiBmYXN0L2RvbS9k b2N1bWVudC1kaXItcHJvcGVydHktZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9tL2Rv Y3VtZW50LWRpci1wcm9wZXJ0eS5odG1sOgorCisyMDE1LTAxLTI2ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKICAgICAgICAgRG9jdW1lbnQuZGlyIHNob3VsZCByZWZsZWN0IHRo ZSAnZGlyJyBhdHRyaWJ1dGUgb2YgdGhlIHJvb3QgaHRtbCBlbGVtZW50CiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA5MjIKIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtZGlyLXByb3BlcnR5LWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LWRpci1wcm9wZXJ0eS1leHBlY3RlZC50eHQK aW5kZXggN2ZlZjczNDdiNDdjNWNmZWYzM2Q4Zjg1ODZlNjc4MDY5ZGIwZTlmMy4uZDFjNTQwODUz Yjg3MzI0MzViZjVjZGM2MWY3NzRlZDViMzgyYWE0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9kb20vZG9jdW1lbnQtZGlyLXByb3BlcnR5LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9kb2N1bWVudC1kaXItcHJvcGVydHktZXhwZWN0ZWQudHh0CkBAIC0yNyw2 ICsyNywyNiBAQCBQQVNTIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5kaXIgaXMgImx0ciIKIFJl YWQgZG9jdW1lbnQuYm9keS5kaXIgaW4gYm9keQogUEFTUyBkb2N1bWVudC5ib2R5LmRpciBpcyAi IgogCitXcml0ZSBub24tY2Fub25pY2FsIGNhc2UgZG9jdW1lbnQuZGlyIGluIGJvZHkKK1BBU1Mg ZG9jdW1lbnQuZGlyID0gJ1JUTCcgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIGRvY3Vt ZW50LmRvY3VtZW50RWxlbWVudC5nZXRBdHRyaWJ1dGUoJ2RpcicpIGlzICJSVEwiCitQQVNTIGRv Y3VtZW50LmRpciBpcyAicnRsIgorCitXcml0ZSBpbnZhbGlkIGRvY3VtZW50LmRpciBpbiBib2R5 CitQQVNTIGRvY3VtZW50LmRpciA9ICdXUk9ORycgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQ QVNTIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5nZXRBdHRyaWJ1dGUoJ2RpcicpIGlzICJXUk9O RyIKK1BBU1MgZG9jdW1lbnQuZGlyIGlzICIiCisKK1dyaXRlIG5vbi1jYW5vbmljYWwgY2FzZSBk b2N1bWVudC5ib2R5LmRpciBpbiBib2R5CitQQVNTIGRvY3VtZW50LmJvZHkuZGlyID0gJ1JUTCcg ZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIGRvY3VtZW50LmJvZHkuZ2V0QXR0cmlidXRl KCdkaXInKSBpcyAiUlRMIgorUEFTUyBkb2N1bWVudC5ib2R5LmRpciBpcyAicnRsIgorCitXcml0 ZSBpbnZhbGlkIGRvY3VtZW50LmJvZHkuZGlyIGluIGJvZHkKK1BBU1MgZG9jdW1lbnQuYm9keS5k aXIgPSAnV1JPTkcnIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgorUEFTUyBkb2N1bWVudC5ib2R5 LmdldEF0dHJpYnV0ZSgnZGlyJykgaXMgIldST05HIgorUEFTUyBkb2N1bWVudC5ib2R5LmRpciBp cyAiIgorCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LWRpci1wcm9wZXJ0eS5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtZGlyLXByb3BlcnR5Lmh0bWwKaW5k ZXggNjU2NmM2YTcyMjY2NWFjY2ExZTUxYjhjOTA5YTNlZmRjNDhjYmY2NC4uM2YwYjllZTBmMDBj OWY2M2MxM2FiMTY0MjIwODA3YmM5YjI5ZGRmOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFz dC9kb20vZG9jdW1lbnQtZGlyLXByb3BlcnR5Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9k b20vZG9jdW1lbnQtZGlyLXByb3BlcnR5Lmh0bWwKQEAgLTQzLDYgKzQzLDMwIEBAIGRlYnVnKCIi KTsKIGRlYnVnKCJSZWFkIGRvY3VtZW50LmJvZHkuZGlyIGluIGJvZHkiKTsKIHNob3VsZEJlRXF1 YWxUb1N0cmluZygiZG9jdW1lbnQuYm9keS5kaXIiLCAiIik7CiBkZWJ1ZygiIik7CisKK2RlYnVn KCJXcml0ZSBub24tY2Fub25pY2FsIGNhc2UgZG9jdW1lbnQuZGlyIGluIGJvZHkiKTsKK3Nob3Vs ZE5vdFRocm93KCJkb2N1bWVudC5kaXIgPSAnUlRMJyIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5n KCJkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuZ2V0QXR0cmlidXRlKCdkaXInKSIsICJSVEwiKTsK K3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZG9jdW1lbnQuZGlyIiwgInJ0bCIpOworZGVidWcoIiIp OworCitkZWJ1ZygiV3JpdGUgaW52YWxpZCBkb2N1bWVudC5kaXIgaW4gYm9keSIpOworc2hvdWxk Tm90VGhyb3coImRvY3VtZW50LmRpciA9ICdXUk9ORyciKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmlu ZygiZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50LmdldEF0dHJpYnV0ZSgnZGlyJykiLCAiV1JPTkci KTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZG9jdW1lbnQuZGlyIiwgIiIpOworZGVidWcoIiIp OworCitkZWJ1ZygiV3JpdGUgbm9uLWNhbm9uaWNhbCBjYXNlIGRvY3VtZW50LmJvZHkuZGlyIGlu IGJvZHkiKTsKK3Nob3VsZE5vdFRocm93KCJkb2N1bWVudC5ib2R5LmRpciA9ICdSVEwnIik7Citz aG91bGRCZUVxdWFsVG9TdHJpbmcoImRvY3VtZW50LmJvZHkuZ2V0QXR0cmlidXRlKCdkaXInKSIs ICJSVEwiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZG9jdW1lbnQuYm9keS5kaXIiLCAicnRs Iik7CitkZWJ1ZygiIik7CisKK2RlYnVnKCJXcml0ZSBpbnZhbGlkIGRvY3VtZW50LmJvZHkuZGly IGluIGJvZHkiKTsKK3Nob3VsZE5vdFRocm93KCJkb2N1bWVudC5ib2R5LmRpciA9ICdXUk9ORyci KTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZG9jdW1lbnQuYm9keS5nZXRBdHRyaWJ1dGUoJ2Rp cicpIiwgIldST05HIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRvY3VtZW50LmJvZHkuZGly IiwgIiIpOworZGVidWcoIiIpOwogPC9zY3JpcHQ+CiA8L2JvZHk+CiA8L2h0bWw+Cg==