140921 2015-01-26 19:47:21 -0800 REGRESSION (r179101): SVGUseElement::expandUseElementsInShadowTree has an object lifetime mistake 2015-01-26 20:40:04 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 darin darin andersca ap commit-queue sam zimmermann oldest_to_newest 1064357 0 darin 2015-01-26 19:47:21 -0800 REGRESSION (r179101): SVGUseElement::expandUseElementsInShadowTree has an object lifetime mistake 1064358 1 245402 darin 2015-01-26 19:48:20 -0800 Created attachment 245402 Patch 1064360 2 darin 2015-01-26 19:48:55 -0800 <rdar://problem/19602564> 1064383 3 245402 commit-queue 2015-01-26 20:40:00 -0800 Comment on attachment 245402 Patch Clearing flags on attachment: 245402 Committed r179163: <http://trac.webkit.org/changeset/179163> 1064384 4 commit-queue 2015-01-26 20:40:04 -0800 All reviewed patches have been landed. Closing bug. 245402 2015-01-26 19:48:20 -0800 2015-01-26 20:40:00 -0800 Patch bug-140921-20150126194823.patch text/plain 3960 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM0ZTg4NGMzYWNiMzVj NGI0NjA4NWFkMDVhOWFjOWIxZTUwOTNiNi4uOTJkNzVkNWRjZDBkNmQxNGUyYTRlMDNhZDMxN2M5 Yzg2ZjRhNTcyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAxLTI2ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTc5MTAx KTogU1ZHVXNlRWxlbWVudDo6ZXhwYW5kVXNlRWxlbWVudHNJblNoYWRvd1RyZWUgaGFzIGFuIG9i amVjdCBsaWZldGltZSBtaXN0YWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDA5MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBCdWcgZm91bmQgYnkgcnVubmluZyByZWdyZXNzaW9uIHRlc3RzIHdpdGgg QWRkcmVzcyBTYW5pdGl6ZXIuCisKKyAgICAgICAgKiBzdmcvU1ZHVXNlRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTVkdVc2VFbGVtZW50OjpleHBhbmRVc2VFbGVtZW50c0luU2hhZG93 VHJlZSk6IFVzZSBhIFJlZiB0byBwcm90ZWN0CisgICAgICAgIHRoZSBvcmlnaW5hbCB1c2UgZWxl bWVudCBhZnRlciBpdCdzIGJlZW4gcmVwbGFjZWQgaW4gdGhlIHRyZWU7IHdlIHVzZSBpdCBmb3IK KyAgICAgICAgb25lIG1vcmUgdGhpbmcgYWZ0ZXIgdGhhdC4KKwogMjAxNS0wMS0yNSAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXR0aW5nIEhUTUxNYXJx dWVlRWxlbWVudC50cnVlU3BlZWQgZG9lc24ndCB3b3JrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9zdmcvU1ZHVXNlRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVXNlRWxl bWVudC5jcHAKaW5kZXggMjNiMGQxYWMzNDlmZjQ5ODJlYzdjZjUyMmRhNTdiNDRjMDA5NTlkNi4u YTIyMGE3OGRlMjM4MWQ5MzkwNDAzMzRmZjM2OWFhNTAyYjU2NTZiMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR1VzZUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdVc2VFbGVtZW50LmNwcApAQCAtNjA5LDEwICs2MDksMTAgQEAgdm9pZCBTVkdVc2VFbGVt ZW50OjpleHBhbmRVc2VFbGVtZW50c0luU2hhZG93VHJlZSgpCiAgICAgYXV0byBkZXNjZW5kYW50 cyA9IGRlc2NlbmRhbnRzT2ZUeXBlPFNWR1VzZUVsZW1lbnQ+KCp1c2VyQWdlbnRTaGFkb3dSb290 KCkpOwogICAgIGF1dG8gZW5kID0gZGVzY2VuZGFudHMuZW5kKCk7CiAgICAgZm9yIChhdXRvIGl0 ID0gZGVzY2VuZGFudHMuYmVnaW4oKTsgaXQgIT0gZW5kOyApIHsKLSAgICAgICAgU1ZHVXNlRWxl bWVudCYgb3JpZ2luYWwgPSAqaXQ7CisgICAgICAgIFJlZjxTVkdVc2VFbGVtZW50PiBvcmlnaW5h bCA9ICppdDsKICAgICAgICAgaXQgPSBlbmQ7IC8vIEVmZmljaWVudGx5IHF1aWV0cyBhc3NlcnRp b25zIGR1ZSB0byB0aGUgb3V0c3RhbmRpbmcgaXRlcmF0b3IuCiAKLSAgICAgICAgQVNTRVJUKCFv cmlnaW5hbC5jYWNoZWREb2N1bWVudElzU3RpbGxMb2FkaW5nKCkpOworICAgICAgICBBU1NFUlQo IW9yaWdpbmFsLT5jYWNoZWREb2N1bWVudElzU3RpbGxMb2FkaW5nKCkpOwogCiAgICAgICAgIC8v IFNwZWM6IEluIHRoZSBnZW5lcmF0ZWQgY29udGVudCwgdGhlICd1c2UnIHdpbGwgYmUgcmVwbGFj ZWQgYnkgJ2cnLCB3aGVyZSBhbGwgYXR0cmlidXRlcyBmcm9tIHRoZQogICAgICAgICAvLyAndXNl JyBlbGVtZW50IGV4Y2VwdCBmb3IgeCwgeSwgd2lkdGgsIGhlaWdodCBhbmQgeGxpbms6aHJlZiBh cmUgdHJhbnNmZXJyZWQgdG8gdGhlIGdlbmVyYXRlZCAnZycgZWxlbWVudC4KQEAgLTYyMywxMSAr NjIzLDExIEBAIHZvaWQgU1ZHVXNlRWxlbWVudDo6ZXhwYW5kVXNlRWxlbWVudHNJblNoYWRvd1Ry ZWUoKQogICAgICAgICBBU1NFUlQocmVmZXJlbmNlZERvY3VtZW50KCkpOwogICAgICAgICBhdXRv IHJlcGxhY2VtZW50ID0gU1ZHR0VsZW1lbnQ6OmNyZWF0ZShTVkdOYW1lczo6Z1RhZywgKnJlZmVy ZW5jZWREb2N1bWVudCgpKTsKIAotICAgICAgICBvcmlnaW5hbC50cmFuc2ZlckF0dHJpYnV0ZXNU b1NoYWRvd1RyZWVSZXBsYWNlbWVudChyZXBsYWNlbWVudC5nZXQoKSk7Ci0gICAgICAgIG9yaWdp bmFsLmNsb25lQ2hpbGROb2RlcyhyZXBsYWNlbWVudC5wdHIoKSk7CisgICAgICAgIG9yaWdpbmFs LT50cmFuc2ZlckF0dHJpYnV0ZXNUb1NoYWRvd1RyZWVSZXBsYWNlbWVudChyZXBsYWNlbWVudC5n ZXQoKSk7CisgICAgICAgIG9yaWdpbmFsLT5jbG9uZUNoaWxkTm9kZXMocmVwbGFjZW1lbnQucHRy KCkpOwogCiAgICAgICAgIFJlZlB0cjxTVkdFbGVtZW50PiBjbG9uZWRUYXJnZXQ7Ci0gICAgICAg IEVsZW1lbnQqIHRhcmdldENhbmRpZGF0ZSA9IFNWR1VSSVJlZmVyZW5jZTo6dGFyZ2V0RWxlbWVu dEZyb21JUklTdHJpbmcob3JpZ2luYWwuaHJlZigpLCAqcmVmZXJlbmNlZERvY3VtZW50KCkpOwor ICAgICAgICBFbGVtZW50KiB0YXJnZXRDYW5kaWRhdGUgPSBTVkdVUklSZWZlcmVuY2U6OnRhcmdl dEVsZW1lbnRGcm9tSVJJU3RyaW5nKG9yaWdpbmFsLT5ocmVmKCksICpyZWZlcmVuY2VkRG9jdW1l bnQoKSk7CiAgICAgICAgIGlmIChpczxTVkdFbGVtZW50Pih0YXJnZXRDYW5kaWRhdGUpICYmICFp c0Rpc2FsbG93ZWRFbGVtZW50KGRvd25jYXN0PFNWR0VsZW1lbnQ+KCp0YXJnZXRDYW5kaWRhdGUp KSkgewogICAgICAgICAgICAgU1ZHRWxlbWVudCYgb3JpZ2luYWxUYXJnZXQgPSBkb3duY2FzdDxT VkdFbGVtZW50PigqdGFyZ2V0Q2FuZGlkYXRlKTsKICAgICAgICAgICAgIGNsb25lZFRhcmdldCA9 IHN0YXRpY19wb2ludGVyX2Nhc3Q8U1ZHRWxlbWVudD4ob3JpZ2luYWxUYXJnZXQuY2xvbmVFbGVt ZW50V2l0aENoaWxkcmVuKGRvY3VtZW50KCkpKTsKQEAgLTY0MSwxMiArNjQxLDEyIEBAIHZvaWQg U1ZHVXNlRWxlbWVudDo6ZXhwYW5kVXNlRWxlbWVudHNJblNoYWRvd1RyZWUoKQogICAgICAgICBy ZW1vdmVEaXNhbGxvd2VkRWxlbWVudHNGcm9tU3VidHJlZShyZXBsYWNlbWVudC5nZXQoKSk7CiAK ICAgICAgICAgLy8gUmVwbGFjZSA8dXNlPiB3aXRoIHRoZSA8Zz4gZWxlbWVudCB3ZSBjcmVhdGVk LgotICAgICAgICBvcmlnaW5hbC5wYXJlbnROb2RlKCktPnJlcGxhY2VDaGlsZChyZXBsYWNlbWVu dC5wdHIoKSwgJm9yaWdpbmFsKTsKKyAgICAgICAgb3JpZ2luYWwtPnBhcmVudE5vZGUoKS0+cmVw bGFjZUNoaWxkKHJlcGxhY2VtZW50LnB0cigpLCBvcmlnaW5hbC5wdHIoKSk7CiAKICAgICAgICAg Ly8gQ2FsbCB0cmFuc2ZlclNpemVBdHRyaWJ1dGVzVG9TaGFkb3dUcmVlVGFyZ2V0Q2xvbmUgYWZ0 ZXIgcHV0dGluZyB0aGUgY2xvbmVkIGVsZW1lbnRzIGludG8gdGhlCiAgICAgICAgIC8vIHNoYWRv dyB0cmVlIHNvIGl0IGNhbiB1c2UgU1ZHRWxlbWVudDo6Y29ycmVzcG9uZGluZ0VsZW1lbnQgd2l0 aG91dCB0cmlnZ2VyaW5nIGFuIGFzc2VydGlvbi4KICAgICAgICAgaWYgKGNsb25lZFRhcmdldCkK LSAgICAgICAgICAgIG9yaWdpbmFsLnRyYW5zZmVyU2l6ZUF0dHJpYnV0ZXNUb1NoYWRvd1RyZWVU YXJnZXRDbG9uZSgqY2xvbmVkVGFyZ2V0KTsKKyAgICAgICAgICAgIG9yaWdpbmFsLT50cmFuc2Zl clNpemVBdHRyaWJ1dGVzVG9TaGFkb3dUcmVlVGFyZ2V0Q2xvbmUoKmNsb25lZFRhcmdldCk7CiAK ICAgICAgICAgLy8gQ29udGludWUgaXRlcmF0aW5nIGZyb20gdGhlIDxnPiBlbGVtZW50IHNpbmNl IHRoZSA8dXNlPiBlbGVtZW50IHdhcyByZXBsYWNlZC4KICAgICAgICAgaXQgPSBkZXNjZW5kYW50 cy5mcm9tKHJlcGxhY2VtZW50LmdldCgpKTsK