140911 2015-01-26 16:50:51 -0800 Invoking an immediate action on link often dismisses selection 2015-01-27 11:14:44 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1064303 0 bdakin 2015-01-26 16:50:51 -0800 Invoking an immediate action on link often dismisses existing selection. It should not. rdar://problem/19572685 1064305 1 245391 bdakin 2015-01-26 16:53:22 -0800 Created attachment 245391 Patch 1064379 2 245391 thorton 2015-01-26 20:16:55 -0800 Comment on attachment 245391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245391&action=review > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:-210 > - _page->setMaintainsInactiveSelection(false); I don't think we can get rid of this one, can we? 1064569 3 bdakin 2015-01-27 11:14:44 -0800 (In reply to comment #2) > Comment on attachment 245391 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245391&action=review > > > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:-210 > > - _page->setMaintainsInactiveSelection(false); > > I don't think we can get rid of this one, can we? It actually seems like dismissContentRelativeChildWindows is typically called through WKView code on cancel, but it seems best not to rely on that, so I kept this one. There is certainly no downside. http://trac.webkit.org/changeset/179195 245391 2015-01-26 16:53:22 -0800 2015-01-26 20:16:55 -0800 Patch for-review.txt text/plain 2780 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTE1NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTI2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBJbnZva2luZyBhbiBpbW1lZGlhdGUg YWN0aW9uIG9uIGxpbmsgb2Z0ZW4gZGlzbWlzc2VzIHNlbGVjdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwOTExCisgICAgICAgIC1hbmQgY29y cmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTk1NzI2ODUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxsaW5nIF9wYWdlLT5zZXRN YWludGFpbnNJbmFjdGl2ZVNlbGVjdGlvbihmYWxzZSkgaW4gY2FuY2VsL2NvbXBsZXRlIGlzIG9m dGVuIAorICAgICAgICB0b28gc29vbi4gSW5zdGVhZCwgY2FsbCBpdCBpbiBkaXNtaXNzQ29udGVu dFJlbGF0aXZlQ2hpbGRXaW5kb3dzLiBUaGlzIGlzIG1vcmUgCisgICAgICAgIHNpbWlsYXIgdG8g dGhlIHRpbWluZyBmb3IgdGhlIFRleHRJbmRpY2F0b3IuCisgICAgICAgICogVUlQcm9jZXNzL21h Yy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dLSW1tZWRpYXRl QWN0aW9uQ29udHJvbGxlciBkaXNtaXNzQ29udGVudFJlbGF0aXZlQ2hpbGRXaW5kb3dzXSk6Cisg ICAgICAgICgtW1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlciBpbW1lZGlhdGVBY3Rpb25SZWNv Z25pemVyV2lsbFByZXBhcmU6XSk6CisgICAgICAgICgtW1dLSW1tZWRpYXRlQWN0aW9uQ29udHJv bGxlciBpbW1lZGlhdGVBY3Rpb25SZWNvZ25pemVyRGlkQ2FuY2VsQW5pbWF0aW9uOl0pOgorICAg ICAgICAoLVtXS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIgaW1tZWRpYXRlQWN0aW9uUmVjb2du aXplckRpZENvbXBsZXRlQW5pbWF0aW9uOl0pOgorCiAyMDE1LTAxLTI2ICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIERvY3VtZW50Ojpib2R5KCkgdG8g RG9jdW1lbnQ6OmJvZHlPckZyYW1lc2V0KCkgZm9yIGNsYXJpdHkKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9tYWMvV0tJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tJbW1lZGlhdGVBY3Rpb25Db250 cm9sbGVyLm1tCShyZXZpc2lvbiAxNzkxMzcpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMTQ4 LDYgKzE0OCw3IEBAIC0gKHZvaWQpZGlkUGVyZm9ybUFjdGlvbk1lbnVIaXRUZXN0Oihjb24KIAog LSAodm9pZClkaXNtaXNzQ29udGVudFJlbGF0aXZlQ2hpbGRXaW5kb3dzCiB7CisgICAgX3BhZ2Ut PnNldE1haW50YWluc0luYWN0aXZlU2VsZWN0aW9uKGZhbHNlKTsKICAgICBbX2N1cnJlbnRRTFBy ZXZpZXdNZW51SXRlbSBjbG9zZV07CiB9CiAKQEAgLTE1OCwxMCArMTU5LDEwIEBAIC0gKHZvaWQp aW1tZWRpYXRlQWN0aW9uUmVjb2duaXplcldpbGxQcmUKICAgICBpZiAoaW1tZWRpYXRlQWN0aW9u UmVjb2duaXplciAhPSBfaW1tZWRpYXRlQWN0aW9uUmVjb2duaXplcikKICAgICAgICAgcmV0dXJu OwogCi0gICAgX3BhZ2UtPnNldE1haW50YWluc0luYWN0aXZlU2VsZWN0aW9uKHRydWUpOwotCiAg ICAgW193a1ZpZXcgX2Rpc21pc3NDb250ZW50UmVsYXRpdmVDaGlsZFdpbmRvd3NdOwogCisgICAg X3BhZ2UtPnNldE1haW50YWluc0luYWN0aXZlU2VsZWN0aW9uKHRydWUpOworCiAgICAgX3BhZ2Ut PnBlcmZvcm1BY3Rpb25NZW51SGl0VGVzdEF0TG9jYXRpb24oW2ltbWVkaWF0ZUFjdGlvblJlY29n bml6ZXIgbG9jYXRpb25JblZpZXc6aW1tZWRpYXRlQWN0aW9uUmVjb2duaXplci52aWV3XSwgdHJ1 ZSk7CiAKICAgICBfc3RhdGUgPSBJbW1lZGlhdGVBY3Rpb25TdGF0ZTo6UGVuZGluZzsKQEAgLTIw Nyw3ICsyMDgsNiBAQCAtICh2b2lkKWltbWVkaWF0ZUFjdGlvblJlY29nbml6ZXJEaWRDYW5jCiAK ICAgICBfcGFnZS0+c2V0VGV4dEluZGljYXRvckFuaW1hdGlvblByb2dyZXNzKDApOwogICAgIFtz ZWxmIF9jbGVhckltbWVkaWF0ZUFjdGlvblN0YXRlXTsKLSAgICBfcGFnZS0+c2V0TWFpbnRhaW5z SW5hY3RpdmVTZWxlY3Rpb24oZmFsc2UpOwogfQogCiAtICh2b2lkKWltbWVkaWF0ZUFjdGlvblJl Y29nbml6ZXJEaWRDb21wbGV0ZUFuaW1hdGlvbjooTlNJbW1lZGlhdGVBY3Rpb25HZXN0dXJlUmVj b2duaXplciAqKWltbWVkaWF0ZUFjdGlvblJlY29nbml6ZXIKQEAgLTIxNiw3ICsyMTYsNiBAQCAt ICh2b2lkKWltbWVkaWF0ZUFjdGlvblJlY29nbml6ZXJEaWRDb21wCiAgICAgICAgIHJldHVybjsK IAogICAgIF9wYWdlLT5zZXRUZXh0SW5kaWNhdG9yQW5pbWF0aW9uUHJvZ3Jlc3MoMSk7Ci0gICAg X3BhZ2UtPnNldE1haW50YWluc0luYWN0aXZlU2VsZWN0aW9uKGZhbHNlKTsKIH0KIAogLSAoUGFz c1JlZlB0cjxXZWJIaXRUZXN0UmVzdWx0Pilfd2ViSGl0VGVzdFJlc3VsdAo=