140908 2015-01-26 16:21:15 -0800 Parse a function expression as a primary expression 2015-01-26 17:14:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140491 1 rniwa rniwa barraclough fpizlo ggaren mark.lam msaboff oliver oldest_to_newest 1064290 0 rniwa 2015-01-26 16:21:15 -0800 A function expression is a primary expression according to ES6 spec: https://people.mozilla.org/~jorendorff/es6-draft.html#sec-primary-expression Follow the spec's convention in our code. 1064295 1 245385 rniwa 2015-01-26 16:28:46 -0800 Created attachment 245385 Cleanup 1064296 2 245386 rniwa 2015-01-26 16:30:08 -0800 Created attachment 245386 Mention failIfStackOverflow() 1064297 3 245386 mark.lam 2015-01-26 16:32:39 -0800 Comment on attachment 245386 Mention failIfStackOverflow() r=me 1064309 4 rniwa 2015-01-26 17:14:15 -0800 Committed r179159: <http://trac.webkit.org/changeset/179159> 245385 2015-01-26 16:28:46 -0800 2015-01-26 16:30:05 -0800 Cleanup bug-140908-20150126162849.patch text/plain 2806 rniwa SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5MTU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTAxLTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAg IFBhcnNlIGEgZnVuY3Rpb24gZXhwcmVzc2lvbiBhcyBhIHByaW1hcnkgZXhwcmVzc2lvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwOTA4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZWQgdGhlIGNv ZGUgdG8gZ2VuZXJhdGUgYW4gQVNUIG5vZGUgZm9yIGEgZnVuY3Rpb24gZXhwcmVzc2lvbiBmcm9t IHBhcnNlTWVtYmVyRXhwcmVzc2lvbgorICAgICAgICB0byBwYXJzZVByaW1hcnlFeHByZXNzaW9u IHRvIG1hdGNoIHRoZSBFUzYgc3BlY2lmaWNhdGlvbiB0ZXJtaW5vbG9neToKKyAgICAgICAgaHR0 cHM6Ly9wZW9wbGUubW96aWxsYS5vcmcvfmpvcmVuZG9yZmYvZXM2LWRyYWZ0Lmh0bWwjc2VjLXBy aW1hcnktZXhwcmVzc2lvbgorCisgICAgICAgIFRoZXJlIHNob3VsZCBiZSBubyBiZWhhdmlvciBj aGFuZ2UgZnJvbSB0aGlzIGNoYW5nZSBzaW5jZSBwYXJzZVByaW1hcnlFeHByZXNzaW9uIGlzIG9u bHkKKyAgICAgICAgY2FsbGVkIGluIHBhcnNlTWVtYmVyRXhwcmVzc2lvbi4KKworICAgICAgICAq IHBhcnNlci9QYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFy c2VQcmltYXJ5RXhwcmVzc2lvbik6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5cGU+Ojpw YXJzZU1lbWJlckV4cHJlc3Npb24pOgorCiAyMDE1LTAxLTI2ICBNeWxlcyBDLiBNYXhmaWVsZCAg PG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gW1NWRyAtPiBPVEYgQ29udmVy dGVyXSBGbGlwIHRoZSBzd2l0Y2ggb2ZmIG9uIGlPUwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3BhcnNlci9QYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9wYXJzZXIvUGFyc2VyLmNwcAkocmV2aXNpb24gMTc5MTQ5KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDI3LDYgKzIwMjcs MTUgQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlRXhwcmVzcwogewogICAgIGZh aWxJZlN0YWNrT3ZlcmZsb3coKTsKICAgICBzd2l0Y2ggKG1fdG9rZW4ubV90eXBlKSB7CisgICAg Y2FzZSBGVU5DVElPTjogeworICAgICAgICBKU1Rva2VuTG9jYXRpb24gbG9jYXRpb24odG9rZW5M b2NhdGlvbigpKTsKKyAgICAgICAgdW5zaWduZWQgZnVuY3Rpb25LZXl3b3JkU3RhcnQgPSB0b2tl blN0YXJ0KCk7CisgICAgICAgIG5leHQoKTsKKyAgICAgICAgUGFyc2VyRnVuY3Rpb25JbmZvPFRy ZWVCdWlsZGVyPiBpbmZvOworICAgICAgICBpbmZvLm5hbWUgPSAmbV92bS0+cHJvcGVydHlOYW1l cy0+bnVsbElkZW50aWZpZXI7CisgICAgICAgIGZhaWxJZkZhbHNlKChwYXJzZUZ1bmN0aW9uSW5m byhjb250ZXh0LCBGdW5jdGlvbk5vUmVxdWlyZW1lbnRzLCBGdW5jdGlvbk1vZGUsIGZhbHNlLCBp bmZvKSksICJDYW5ub3QgcGFyc2UgZnVuY3Rpb24gZXhwcmVzc2lvbiIpOworICAgICAgICByZXR1 cm4gY29udGV4dC5jcmVhdGVGdW5jdGlvbkV4cHIobG9jYXRpb24sIGluZm8sIGZ1bmN0aW9uS2V5 d29yZFN0YXJ0KTsKKyAgICB9CiAgICAgY2FzZSBPUEVOQlJBQ0U6CiAgICAgICAgIGlmIChzdHJp Y3RNb2RlKCkpCiAgICAgICAgICAgICByZXR1cm4gcGFyc2VTdHJpY3RPYmplY3RMaXRlcmFsKGNv bnRleHQpOwpAQCAtMjE2MywxNiArMjE3Miw3IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRl cj4gVHJlZUV4cHJlc3MKICAgICAgICAgbmV3Q291bnQrKzsKICAgICB9CiAKLSAgICBpZiAobWF0 Y2goRlVOQ1RJT04pKSB7Ci0gICAgICAgIHVuc2lnbmVkIGZ1bmN0aW9uS2V5d29yZFN0YXJ0ID0g dG9rZW5TdGFydCgpOwotICAgICAgICBsb2NhdGlvbiA9IHRva2VuTG9jYXRpb24oKTsKLSAgICAg ICAgbmV4dCgpOwotICAgICAgICBQYXJzZXJGdW5jdGlvbkluZm88VHJlZUJ1aWxkZXI+IGluZm87 Ci0gICAgICAgIGluZm8ubmFtZSA9ICZtX3ZtLT5wcm9wZXJ0eU5hbWVzLT5udWxsSWRlbnRpZmll cjsKLSAgICAgICAgZmFpbElmRmFsc2UoKHBhcnNlRnVuY3Rpb25JbmZvKGNvbnRleHQsIEZ1bmN0 aW9uTm9SZXF1aXJlbWVudHMsIEZ1bmN0aW9uTW9kZSwgZmFsc2UsIGluZm8pKSwgIkNhbm5vdCBw YXJzZSBmdW5jdGlvbiBleHByZXNzaW9uIik7Ci0gICAgICAgIGJhc2UgPSBjb250ZXh0LmNyZWF0 ZUZ1bmN0aW9uRXhwcihsb2NhdGlvbiwgaW5mbywgZnVuY3Rpb25LZXl3b3JkU3RhcnQpOwotICAg IH0gZWxzZQotICAgICAgICBiYXNlID0gcGFyc2VQcmltYXJ5RXhwcmVzc2lvbihjb250ZXh0KTsK KyAgICBiYXNlID0gcGFyc2VQcmltYXJ5RXhwcmVzc2lvbihjb250ZXh0KTsKICAgICAKICAgICBm YWlsSWZGYWxzZShiYXNlLCAiQ2Fubm90IHBhcnNlIGJhc2UgZXhwcmVzc2lvbiIpOwogICAgIHdo aWxlICh0cnVlKSB7Cg== 245386 2015-01-26 16:30:08 -0800 2015-01-26 16:32:39 -0800 Mention failIfStackOverflow() bug-140908-20150126163011.patch text/plain 2858 rniwa SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5MTU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTAxLTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAg IFBhcnNlIGEgZnVuY3Rpb24gZXhwcmVzc2lvbiBhcyBhIHByaW1hcnkgZXhwcmVzc2lvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwOTA4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZWQgdGhlIGNv ZGUgdG8gZ2VuZXJhdGUgYW4gQVNUIG5vZGUgZm9yIGEgZnVuY3Rpb24gZXhwcmVzc2lvbiBmcm9t IHBhcnNlTWVtYmVyRXhwcmVzc2lvbgorICAgICAgICB0byBwYXJzZVByaW1hcnlFeHByZXNzaW9u IHRvIG1hdGNoIHRoZSBFUzYgc3BlY2lmaWNhdGlvbiB0ZXJtaW5vbG9neToKKyAgICAgICAgaHR0 cHM6Ly9wZW9wbGUubW96aWxsYS5vcmcvfmpvcmVuZG9yZmYvZXM2LWRyYWZ0Lmh0bWwjc2VjLXBy aW1hcnktZXhwcmVzc2lvbgorCisgICAgICAgIFRoZXJlIHNob3VsZCBiZSBubyBiZWhhdmlvciBj aGFuZ2UgZnJvbSB0aGlzIGNoYW5nZSBzaW5jZSBwYXJzZVByaW1hcnlFeHByZXNzaW9uIGlzIG9u bHkKKyAgICAgICAgY2FsbGVkIGluIHBhcnNlTWVtYmVyRXhwcmVzc2lvbiBvdGhlciB0aGFuIHRo ZSBmYWN0IGZhaWxJZlN0YWNrT3ZlcmZsb3coKSBpcyBjYWxsZWQuCisKKyAgICAgICAgKiBwYXJz ZXIvUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6UGFyc2VyPExleGVyVHlwZT46OnBhcnNlUHJp bWFyeUV4cHJlc3Npb24pOgorICAgICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VN ZW1iZXJFeHByZXNzaW9uKToKKwogMjAxNS0wMS0yNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4 ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFtTVkcgLT4gT1RGIENvbnZlcnRlcl0g RmxpcCB0aGUgc3dpdGNoIG9mZiBvbiBpT1MKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9w YXJzZXIvUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFy c2VyL1BhcnNlci5jcHAJKHJldmlzaW9uIDE3OTE0OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9wYXJzZXIvUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAyNyw2ICsyMDI3LDE1IEBA IHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZUV4cHJlc3MKIHsKICAgICBmYWlsSWZT dGFja092ZXJmbG93KCk7CiAgICAgc3dpdGNoIChtX3Rva2VuLm1fdHlwZSkgeworICAgIGNhc2Ug RlVOQ1RJT046IHsKKyAgICAgICAgSlNUb2tlbkxvY2F0aW9uIGxvY2F0aW9uKHRva2VuTG9jYXRp b24oKSk7CisgICAgICAgIHVuc2lnbmVkIGZ1bmN0aW9uS2V5d29yZFN0YXJ0ID0gdG9rZW5TdGFy dCgpOworICAgICAgICBuZXh0KCk7CisgICAgICAgIFBhcnNlckZ1bmN0aW9uSW5mbzxUcmVlQnVp bGRlcj4gaW5mbzsKKyAgICAgICAgaW5mby5uYW1lID0gJm1fdm0tPnByb3BlcnR5TmFtZXMtPm51 bGxJZGVudGlmaWVyOworICAgICAgICBmYWlsSWZGYWxzZSgocGFyc2VGdW5jdGlvbkluZm8oY29u dGV4dCwgRnVuY3Rpb25Ob1JlcXVpcmVtZW50cywgRnVuY3Rpb25Nb2RlLCBmYWxzZSwgaW5mbykp LCAiQ2Fubm90IHBhcnNlIGZ1bmN0aW9uIGV4cHJlc3Npb24iKTsKKyAgICAgICAgcmV0dXJuIGNv bnRleHQuY3JlYXRlRnVuY3Rpb25FeHByKGxvY2F0aW9uLCBpbmZvLCBmdW5jdGlvbktleXdvcmRT dGFydCk7CisgICAgfQogICAgIGNhc2UgT1BFTkJSQUNFOgogICAgICAgICBpZiAoc3RyaWN0TW9k ZSgpKQogICAgICAgICAgICAgcmV0dXJuIHBhcnNlU3RyaWN0T2JqZWN0TGl0ZXJhbChjb250ZXh0 KTsKQEAgLTIxNjMsMTYgKzIxNzIsNyBAQCB0ZW1wbGF0ZSA8Y2xhc3MgVHJlZUJ1aWxkZXI+IFRy ZWVFeHByZXNzCiAgICAgICAgIG5ld0NvdW50Kys7CiAgICAgfQogCi0gICAgaWYgKG1hdGNoKEZV TkNUSU9OKSkgewotICAgICAgICB1bnNpZ25lZCBmdW5jdGlvbktleXdvcmRTdGFydCA9IHRva2Vu U3RhcnQoKTsKLSAgICAgICAgbG9jYXRpb24gPSB0b2tlbkxvY2F0aW9uKCk7Ci0gICAgICAgIG5l eHQoKTsKLSAgICAgICAgUGFyc2VyRnVuY3Rpb25JbmZvPFRyZWVCdWlsZGVyPiBpbmZvOwotICAg ICAgICBpbmZvLm5hbWUgPSAmbV92bS0+cHJvcGVydHlOYW1lcy0+bnVsbElkZW50aWZpZXI7Ci0g ICAgICAgIGZhaWxJZkZhbHNlKChwYXJzZUZ1bmN0aW9uSW5mbyhjb250ZXh0LCBGdW5jdGlvbk5v UmVxdWlyZW1lbnRzLCBGdW5jdGlvbk1vZGUsIGZhbHNlLCBpbmZvKSksICJDYW5ub3QgcGFyc2Ug ZnVuY3Rpb24gZXhwcmVzc2lvbiIpOwotICAgICAgICBiYXNlID0gY29udGV4dC5jcmVhdGVGdW5j dGlvbkV4cHIobG9jYXRpb24sIGluZm8sIGZ1bmN0aW9uS2V5d29yZFN0YXJ0KTsKLSAgICB9IGVs c2UKLSAgICAgICAgYmFzZSA9IHBhcnNlUHJpbWFyeUV4cHJlc3Npb24oY29udGV4dCk7CisgICAg YmFzZSA9IHBhcnNlUHJpbWFyeUV4cHJlc3Npb24oY29udGV4dCk7CiAgICAgCiAgICAgZmFpbElm RmFsc2UoYmFzZSwgIkNhbm5vdCBwYXJzZSBiYXNlIGV4cHJlc3Npb24iKTsKICAgICB3aGlsZSAo dHJ1ZSkgewo=